From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47B16C71136 for ; Tue, 17 Jun 2025 15:43:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9B9D6B0089; Tue, 17 Jun 2025 11:43:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BFE906B0099; Tue, 17 Jun 2025 11:43:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AEDB56B009A; Tue, 17 Jun 2025 11:43:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9FA7A6B0089 for ; Tue, 17 Jun 2025 11:43:55 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 76DE41A05AA for ; Tue, 17 Jun 2025 15:43:55 +0000 (UTC) X-FDA: 83565313230.08.C212986 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 30D6714000A for ; Tue, 17 Jun 2025 15:43:53 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="e/sfzd9X"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750175033; a=rsa-sha256; cv=none; b=xfcO5f58miTcvJWejVK4DxWnZyXcTXLELtIPgQR/AxI3EidYvFzfHtxvZO5fJLJWYkWcnH m9ENhigufP+db76GSLRz52Zn57TwAFxao+NIJ3/WPRDyPGnhYogkK+ysmkPyzn45OF+1VT 6TMcFnidbqSYoUAAsdkXDGtgl0A3Df0= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="e/sfzd9X"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750175033; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t4hXdfl2BxaEs0JquHL/H5jXrrSdl8LRqFfGRUF6aUs=; b=jhzKqIlYo4NExTNavf0nXS7mQqrAsQAEYAUwqp3SNoUjic00HzAz+AYqMPN8oz54EaUhne Ff+M4sETgmRxSVf5vBJaTqELUHIyUlTGwdYx+FSlFoi8gLxE96JbLR30fB0Uck2NFpUC8g CW3A9WMcwOx3gGXzwewClC7fbhM29Ws= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750175032; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t4hXdfl2BxaEs0JquHL/H5jXrrSdl8LRqFfGRUF6aUs=; b=e/sfzd9Xi4A69fq9EJ8AstiRmgVgewVPdlpvS+wVjTpMPO+k8gBBEqQEzBGRniVN1t7eBn gyFX8+FpiK5H3OYCvzf6WoOVVrpAj1eCZjF5dVvU64euto00AktoEhQZjz3E1lxSSNijLy sag35NkI0TaH4zdvUcD/3WQn5h2lCok= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-34-yvmlm51BOJGGGV8c2cgwJQ-1; Tue, 17 Jun 2025 11:43:51 -0400 X-MC-Unique: yvmlm51BOJGGGV8c2cgwJQ-1 X-Mimecast-MFC-AGG-ID: yvmlm51BOJGGGV8c2cgwJQ_1750175030 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a503f28b09so526899f8f.0 for ; Tue, 17 Jun 2025 08:43:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750175030; x=1750779830; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t4hXdfl2BxaEs0JquHL/H5jXrrSdl8LRqFfGRUF6aUs=; b=No5rJQPiAGKH9eqes++zXIt9VliDBR5gaj27qHeCea3G3oGieXK1AC/xbFedA+56+T 3nFkjHHuWy4XFBSL4v1zddbIxrjDDdiIHWfeHb9kSwl4qAcdcmr2U+5XlmZbRA4jWoAB frBziVfm3PQe01xIHuOPvp+jIyZkdV2EGNXVyxZ6ryUqmmfjwr1hqfXPjbI6jcQXmu24 dkyK+8/W+fP3B5ZAqkM61Tg2kTvUw2GumV+mPr0ZDjBe1vYUSYCutrC60bFPSlR3Zexp iLvCiben3EneH8CMDsAVshOOzwFf016VCo4gXIM/p0s1N3sOplsjQeqMV93CRcrGQPTk kmFw== X-Forwarded-Encrypted: i=1; AJvYcCWZ35rwnL6jpxmE+hT7i6mhiRU6v6TNjrntG5XeUMMJv8zTSSpXFRh4ko/dH5To3F2NHWpbe394Bg==@kvack.org X-Gm-Message-State: AOJu0YwyeikhuX6mSnIHZ8Qy88/COXyMAxvEZT1gf8xvIwTosqkj2nGD Yb4w3AWNc/+KTgaQ+incf9UKg4uDlB0SViUXybrOqUsm51kb+OYrz8/Vst8ACTk8WqnNS6LdQ1j Uvd9+j3LrONxHrSQCZKYLUBSVUoGaD425O2/bRrFfAyfx1wmFqc4k X-Gm-Gg: ASbGncuEK3Q+w5EghKD1LPScZCIxco0kZ/ChffsQCin8gb+RvUso5Kw3jL14yesN4C2 nn+bFKuKiavwh/aUcs/SCSHnws5Ko8+qRvnEkQyVyLTAG0OvMSdsDbB9Hzg7HlTAo2neDEFI/0B HGz1gSuArwFlLvGXCNw6bDaWlW1H0ERWALa2JSyB9zL1SPWXnr9qEZPn21C104MVOX9xBUeFkYp 5ZNqY2DupfcifzXmG8gCUZMAbWRTF7sNsVgTQoyExI6DPME+19KD9xClus6q7ravN0C/6VQYoMi 8jV6ZyKDk7xBLXQ7T+z+s+/5/rIpYJL7xxT0t7hu2/pMyzwFVLEmnRj5HpYzkdpL0g6dbQnciZZ PdHj3nQ== X-Received: by 2002:a05:6000:1884:b0:3a4:eb7a:2ccb with SMTP id ffacd0b85a97d-3a56d821e4dmr12961332f8f.16.1750175029948; Tue, 17 Jun 2025 08:43:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFcoD8JqLOB4EjbN+k5qD0zJS7SAB63dB1ZbzMQjH6b78ztWbJgN3nPYj9/mZ7cyKIKJjAtyA== X-Received: by 2002:a05:6000:1884:b0:3a4:eb7a:2ccb with SMTP id ffacd0b85a97d-3a56d821e4dmr12961278f8f.16.1750175029492; Tue, 17 Jun 2025 08:43:49 -0700 (PDT) Received: from localhost (p200300d82f3107003851c66ab6b93490.dip0.t-ipconnect.de. [2003:d8:2f31:700:3851:c66a:b6b9:3490]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a568a54a36sm14542075f8f.15.2025.06.17.08.43.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Jun 2025 08:43:49 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, David Hildenbrand , Andrew Morton , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Alistair Popple , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , Zi Yan , Baolin Wang , Lorenzo Stoakes , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato Subject: [PATCH RFC 01/14] mm/memory: drop highest_memmap_pfn sanity check in vm_normal_page() Date: Tue, 17 Jun 2025 17:43:32 +0200 Message-ID: <20250617154345.2494405-2-david@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250617154345.2494405-1-david@redhat.com> References: <20250617154345.2494405-1-david@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: LmsW069wYpQP-jmY3uaEm2Vc8EsJlIslFUftjCTXKh4_1750175030 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 30D6714000A X-Stat-Signature: p756135wh8x4omwo953dg1zszcauxa9g X-Rspam-User: X-HE-Tag: 1750175033-816987 X-HE-Meta: U2FsdGVkX1/cYk0bzMmrg0St6+vzEa/tjelcWMLwCyM6EOHGfMNuApBNmkJ8xqpb2O8Ct9iUuVycAGZaaVPxg38JEGklITBT66ZKaQIIWQgy+nPYJs+mVo3oZCML4y9bAQYIoBudi2jQ9W83JuoEmgn2Mzd+Gb4G1BMCejvnpOCHdiBLITzmp7/u4t1Egp0pT7sL3tKMaRq6KVREgQbDkOaqqoE5AUfasmxjlJbVSmAKbOaNew/iv/hYJZsMunbnN/3mB++/gx6HOnVNqMIuS0alLLLKcDZyNfGht3DTswZKgsvddl+vTWgU6rlJGBcV8ju9qN0JJLG7ewPBXtIgaL/v6A3jsY6YSyFYkT+VNJAGZi12ayS3ke/5YUt39fO27oRCNLQIT+Xiwfh0G4+wa7hqWj9uC1hLcA7UnRsROsXckQ4uKJFFzg76F7QOmqixnUUhjrF/arqTkGCa4Ae1S1NclC2FL+GcJEvglP/Jyy92MYUwO1XEb6z6o2I4O6XX5tH1zD5ye2YzxKm3+Bk9kAVZlYF6sTZplK7Uctg/raMQBrxpzdY9tMF2k3nio8XPdrGxQrhedzOLyDQA2xrVH4jwYOH0t3dOJhymNh6UDMqnjmnb+ISwJQRjro7nJvQ7fbT3WJwrb123yuxWa6KuORyYRg1/vqbBZswsmD+td0tRnJEYBuCuhVVi8sMqXgcbCHtxNw0c7sekHpMXbJfx9WRJRqBn70EXtLLlJkpuV8BNh0pI4WSjfv39OELvD++EV47gkuPDUIEfOBp7LEZTlvxQsPQfpUNg4LrBP/sE87a6KKf9SsI8AcP2c/E8fQ/Butq1ct0ey0A3eQsstwnCUrgH+eLsP4BCQkxdfYvCbuBHlMF4XSltLpmXAV1fbtz11U68cm5t4RzMGV0hbj8ymL+ojkPietprB8tBg3ZFKLMtkCgyjJ2ta+9VL8awhosZLx9AR7CpjV/62dd21/F VpXBZiQ3 Zne2usIkWBOnz6L7UB+YB5km6O9RvfRKTkAJPZMGzxq2HTriRxHpEXTZ2nkTTZZXqxyJm2mSlQkrpIa/e+3NvahkZWxzbnm6th5UN20RFvNzbBl9SQH5zkXCN06W59c9QMx514Nf80ZmNKvHF5wqQBgH7tD6xiwSTkPuORicmfy3qp+1UvguUMfRiT4fkbuSCU2ihDm07P059UF0poXMvZUmLAp8iFMHbNbQLVaU9BgqcLoaJI8tQUnhjXBkpK064kEpRYJyWsS0wCcsjYN49nDno0gcRU168uqE/04YNTvDA2jkv1c2rsztEKeKKxbOyGiZPjb6bMHJzwYwL0FuDLFEBQ/cGQzgZmaNpV1YxSvceul8wW5a5A+y+u9cdVsQIUz9cQY3MBIrjYxYZqMFG4zwrBmhDa9hK+Tt2a8Wxa/RdqeyWOND+s2XLrVZWwCJot31VKrLf3EKc6RZAHeZhShDv3bZS9FOCE7I0x0zPm/pSv8dN/2V5TvMJVEcez0XhyyufzHtky7wBGmYOF033afeEXc+28+ar/0cQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In 2009, we converted a VM_BUG_ON(!pfn_valid(pfn)) to the current highest_memmap_pfn sanity check in commit 22b31eec63e5 ("badpage: vm_normal_page use print_bad_pte"), because highest_memmap_pfn was readily available. Nowadays, this is the last remaining highest_memmap_pfn user, and this sanity check is not really triggering ... frequently. Let's convert it to VM_WARN_ON_ONCE(!pfn_valid(pfn)), so we can simplify and get rid of highest_memmap_pfn. Checking for pfn_to_online_page() might be even better, but it would not handle ZONE_DEVICE properly. Do the same in vm_normal_page_pmd(), where we don't even report a problem at all ... What might be better in the future is having a runtime option like page-table-check to enable such checks dynamically on-demand. Something for the future. Signed-off-by: David Hildenbrand --- mm/memory.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/mm/memory.c b/mm/memory.c index 0163d127cece9..188b84ebf479a 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -590,7 +590,7 @@ struct page *vm_normal_page(struct vm_area_struct *vma, unsigned long addr, if (IS_ENABLED(CONFIG_ARCH_HAS_PTE_SPECIAL)) { if (likely(!pte_special(pte))) - goto check_pfn; + goto out; if (vma->vm_ops && vma->vm_ops->find_special_page) return vma->vm_ops->find_special_page(vma, addr); if (vma->vm_flags & (VM_PFNMAP | VM_MIXEDMAP)) @@ -608,9 +608,6 @@ struct page *vm_normal_page(struct vm_area_struct *vma, unsigned long addr, if (vma->vm_flags & VM_MIXEDMAP) { if (!pfn_valid(pfn)) return NULL; - if (is_zero_pfn(pfn)) - return NULL; - goto out; } else { unsigned long off; off = (addr - vma->vm_start) >> PAGE_SHIFT; @@ -624,17 +621,12 @@ struct page *vm_normal_page(struct vm_area_struct *vma, unsigned long addr, if (is_zero_pfn(pfn)) return NULL; -check_pfn: - if (unlikely(pfn > highest_memmap_pfn)) { - print_bad_pte(vma, addr, pte, NULL); - return NULL; - } - /* * NOTE! We still have PageReserved() pages in the page tables. * eg. VDSO mappings can cause them to exist. */ out: + VM_WARN_ON_ONCE(!pfn_valid(pfn)); VM_WARN_ON_ONCE(is_zero_pfn(pfn)); return pfn_to_page(pfn); } @@ -676,14 +668,13 @@ struct page *vm_normal_page_pmd(struct vm_area_struct *vma, unsigned long addr, if (is_huge_zero_pmd(pmd)) return NULL; - if (unlikely(pfn > highest_memmap_pfn)) - return NULL; /* * NOTE! We still have PageReserved() pages in the page tables. * eg. VDSO mappings can cause them to exist. */ out: + VM_WARN_ON_ONCE(!pfn_valid(pfn)); return pfn_to_page(pfn); } -- 2.49.0