From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23E0BC71136 for ; Tue, 17 Jun 2025 13:42:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D0356B007B; Tue, 17 Jun 2025 09:42:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A7C66B0088; Tue, 17 Jun 2025 09:42:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E5416B0092; Tue, 17 Jun 2025 09:42:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6D9C76B007B for ; Tue, 17 Jun 2025 09:42:56 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1BB9A1A02DD for ; Tue, 17 Jun 2025 13:42:56 +0000 (UTC) X-FDA: 83565008352.26.54DD778 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) by imf11.hostedemail.com (Postfix) with ESMTP id 182534000B for ; Tue, 17 Jun 2025 13:42:53 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=EPdAuBQR; dmarc=none; spf=pass (imf11.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.219.52 as permitted sender) smtp.mailfrom=jgg@ziepe.ca ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750167774; a=rsa-sha256; cv=none; b=XTGOtdgnZh2rH3UqfSCbfnsTfooDYF7rG8jDkAuoUCsE+LWTcOT9/fWX1W4DZzZ4mCOrme y5ZtaqyA3OLJCZ/Hk+L2f5D/0VsRDdx/m3+0rEllfGwN51zE7V9QdKL4YBwSE3VCafrzke JCy3mThBt/CjA5VNsB6LPz+n/VzHHZo= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=EPdAuBQR; dmarc=none; spf=pass (imf11.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.219.52 as permitted sender) smtp.mailfrom=jgg@ziepe.ca ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750167774; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FxBrg9yjhh0CNTc60c5POeHRluMG4w5cQfO2cpUAxgw=; b=D1oMhzqKOWDIfp9qH8b/tzy0aJWru5ovbOWNRlrOcf/m2vY8i94/3AK3QSQSaVcfp5Sqvz jUdoGE3GGsvvZB+7hTAYGDVRhVTTRArsjWcDMTCqccmuJdJ5s0cWpwBlQwuV50SaO+U2a0 o4FMoZgo/UnMRUn5153QOV8SV7+i3x0= Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-6fafdd322d3so61098776d6.3 for ; Tue, 17 Jun 2025 06:42:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1750167773; x=1750772573; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FxBrg9yjhh0CNTc60c5POeHRluMG4w5cQfO2cpUAxgw=; b=EPdAuBQRbYORGGzyAG+rc4FxivAmnGGQ2zc/KsymjKBzZGrie3MNjjkaSlqKgChVbx 7MRZOMMyZw8wnNo13FplJtPywwjRBwk+UqgClvMZP0CwvgwsLUpgM2IDnKaKlkrL5C/+ FtoNQbPVsOp3Ek5vWY0sFbzpJ5M2kLYGa0d+STZMHaVOThRXQuYiEbb1yQCiWlNv3K3j TS/Mgk+DW1oQ+kY5JJWrFSRVjv8VewFshqmE0meAsZR7SeUYCo24zl7RSKkizsCB9Tn3 gj/swGMsZcdc7+jV5HruCGCpg5c+t/4m8NndXg2PcabMU1jt7O6PohNbI7Z3XZCHNvC5 Uc1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750167773; x=1750772573; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FxBrg9yjhh0CNTc60c5POeHRluMG4w5cQfO2cpUAxgw=; b=D+lPo85zmpLyDYbmd4r8CiQpyWCn5K+KVBtLMOBudq1Zr9dDi4TRnAi++mnsJmdPOp gnhZyoRaUKjqaaONXVfbvwl+CiXLUu/gRVWnR8J+APIK+2cmQCQIhTaMgbU78m6/qB3x SdnxCsEgsjgRFWxSXsVbPkmKPrYGrIcM1vWTp8ITiO0YXGGyJ+N3Ml7iYIs4wqpdy1GV 9bpWp5z4+5AVop3AX9ZiaoSYDtG6ALEMfTbCrkVqkpx/9uQE/fOE1jv5EHdl3mcoD92R 4r6rglKrGVRAcBZUa+J9nZpj+PTls2Lc5ObHWDRfAKB7cb3cJBoYe40Wx0pV/DUi6tCI +TvQ== X-Forwarded-Encrypted: i=1; AJvYcCVqm9m3KUlW0lRfzgysxmNaH71nCG40Q+pcVTGtO4UieJD84m5O1Ai3wCu4q2lt5RvEgK+wC1FV5g==@kvack.org X-Gm-Message-State: AOJu0YzyTaRGySXt9GjzemvHp4A2iAHrBH/0MdRGAfwA4QmoTECXx1Sb klpvrdJd3bRAp7TofbDbOSVLfQw2tCV7UuU3kr2waWNyDg1238e9KQotHO1Syhyb008= X-Gm-Gg: ASbGncscEtnUqoZflD5a5o6xiAkvnrRbs6bDCFoRksh9Qpvf0WM3utWUSW9/iTWue3r ZC+13IMxE7AaGSqcfno9gOBRRMj2FcSDZ5tSNVUMp6TpUT/Ri0bZhx+soXKnrqQacJYeYYQcyAj 25MTjFwi1Rh55R53FORXmix5yUV5Bz/B2DRFPyvKE4Cu9R+DPm3GuAXvC+E420u67b/lMb7wM8A MBcRR2UcWtfINWyvuH7gT9nsq5118F4JFxiLQvyqGsFceO4AMDK60LkIqlnUya18QMKhWy35KG+ NI+C+A7eZL0T4UkxCdc/sPUvjZxYjzXgCtM9XC/tB5LWL1o/LuvhNunNZb8QyxI0i1ROnyzirAc R/Ges5FBhSud3T2wPjBOdiDW/FX9b85txdJWMUw== X-Google-Smtp-Source: AGHT+IFEZ8nthWy5jI6l0U78X3cHgEw8q6a0mxGxgcwvH61XQjN0X9TnLrxMyQsbjOJQTgPXejMaNw== X-Received: by 2002:a05:6214:252b:b0:6fa:cdc9:8b02 with SMTP id 6a1803df08f44-6fb477430a7mr207174626d6.16.1750167773087; Tue, 17 Jun 2025 06:42:53 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-167-56-70.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.167.56.70]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fb57a66df2sm18569776d6.27.2025.06.17.06.42.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 06:42:52 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1uRWaR-00000006Usp-3gz8; Tue, 17 Jun 2025 10:42:51 -0300 Date: Tue, 17 Jun 2025 10:42:51 -0300 From: Jason Gunthorpe To: lizhe.67@bytedance.com Cc: alex.williamson@redhat.com, akpm@linux-foundation.org, david@redhat.com, peterx@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v4 2/3] gup: introduce unpin_user_folio_dirty_locked() Message-ID: <20250617134251.GA1376515@ziepe.ca> References: <20250617041821.85555-1-lizhe.67@bytedance.com> <20250617041821.85555-3-lizhe.67@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250617041821.85555-3-lizhe.67@bytedance.com> X-Rspam-User: X-Rspamd-Queue-Id: 182534000B X-Rspamd-Server: rspam02 X-Stat-Signature: 4imqamfp16iresx8tm6bykirs5sbnq5o X-HE-Tag: 1750167773-386756 X-HE-Meta: U2FsdGVkX18vrwCNg6p0LJ6qS31higkEyLWqJZqPi5h6KmefLWCRBiPIrk61ujDBJtXp/sWJ7XRDNo/ktpSJ2ospxLxsAVSTjzHZiVMVaRkepmQ/yS+5pIq7pkK2daXedeNHwK+g3gA9Huizf1xV9RhWd9GbqoAvp3fu2Tvfn/Dzjs9Iru0w73DWJJI7V41Lbuccx5QVbifZOehQoMEQbgBQv8pvRjRTREIGZwUSZPJ5ct86RIl0qYkBYyXOy613Qs/YbKxhaz+sDhzj76hw+KLnLTgyYSHm4Ioa7/ExWF9c2kjsOtIN3nTjZKXpKZD7EVP37Hq6WCXMz4FX0fMh7sFFx+l45oc/Wc4MbozCTm8MQ0PUWdCQ1d1mxWcbB7yhtFuZeZ+V8g+defQ5jzZScLW22DIRZqB/Nyn921KR1lsfOS+QO4WRDJDK2q8CaDDTGEwmbbT9CkA4/T64tyldCiaR9vVGcPu31CoB2cOvxe2T6Br3IDxyQTAEdI0XsPxhVtZmG77Ecps4NmWwngb4A50UxmDE4oAngDJSsREHRkgZdCoNYQ1crziKd3Z05KA8MyLa8JQ/9GYDusQ+BpxwvBewFcBaY4a0ah5EBsJWQR4n6baf/eu63wfYHRAc99d9ALvg8cAjk5u8UIiYObHuLKV4Xdl6WSwFSn1Sf5C6xp7LV8eYilab3EcC9wfA/PdiUrbp0QoW5llk+Kab+/K4niRnX/b0PsaZawNMFAt7Mq610QuYYpWUtUpik3d0B1Z+chLEpTodfRdSJp1J65wZjl5wvA587BOK7HzfQM78n3Q3BZr+vZFrGx8h3ugevDg9SoRcbn92tgteVXaI9lS3S7ixbXRf5plWt4teDOY4EO8nx2dk5hgxjJJc8vlDiLqMjR/2o4/dXpNm/CoF92pGIa0KzXUtiBzRYO37S9lEHcJNdJ4lVtfOR15ghx3imfcNzt2zHC+i0U9351HZw50 E6MeMpMg 0nD7sTujl3+Zv2JtV1y0Z62jBfDbvkkhpDhyuXStunNjfgA7X1QruzdRNueclpm+7FlPXWxy0sinNiae90+4grFC4/2Vf8VvqiL3iEoxHLWsY/Z/NZ1ABJweMUORPk8HQuATPtjefKHWlp4/JQO1T8SiVai9EsQMi05g1EBfGlFxE3lntIoHxVBwp3rZ+vhHMpcJ/IqsWqtBE8Kpo5/9wZLCsCHmyxWYiy31dwGM5vPmOAjEpxGjR6qeP2y7gvAbMssMnPfFuAdqnUvmjukgISz3Ko++0ZJSTCe3B3PunuO+Mq943AqmhvX1/ytmKFWJOKq4RCxkia2GaFXoHiczDE3M69gCyMw9r1ORl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 17, 2025 at 12:18:20PM +0800, lizhe.67@bytedance.com wrote: > @@ -360,12 +360,7 @@ void unpin_user_page_range_dirty_lock(struct page *page, unsigned long npages, > > for (i = 0; i < npages; i += nr) { > folio = gup_folio_range_next(page, npages, i, &nr); > - if (make_dirty && !folio_test_dirty(folio)) { > - folio_lock(folio); > - folio_mark_dirty(folio); > - folio_unlock(folio); > - } > - gup_put_folio(folio, nr, FOLL_PIN); > + unpin_user_folio_dirty_locked(folio, nr, make_dirty); > } I don't think we should call an exported function here - this is a fast path for rdma and iommfd, I don't want to see it degrade to save three duplicated lines :\ Make the new function an inline? Duplicate the lines? Jason