linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: lizhe.67@bytedance.com
To: alex.williamson@redhat.com, akpm@linux-foundation.org,
	david@redhat.com, peterx@redhat.com
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, lizhe.67@bytedance.com
Subject: [PATCH v4 1/3] vfio/type1: batch vfio_find_vpfn() in function vfio_unpin_pages_remote()
Date: Tue, 17 Jun 2025 12:18:19 +0800	[thread overview]
Message-ID: <20250617041821.85555-2-lizhe.67@bytedance.com> (raw)
In-Reply-To: <20250617041821.85555-1-lizhe.67@bytedance.com>

From: Li Zhe <lizhe.67@bytedance.com>

This patch is based on patch 'vfio/type1: optimize
vfio_pin_pages_remote() for large folios'[1].

The function vpfn_pages() can help us determine the number of vpfn
nodes on the vpfn rb tree within a specified range. This allows us
to avoid searching for each vpfn individually in the function
vfio_unpin_pages_remote(). This patch batches the vfio_find_vpfn()
calls in function vfio_unpin_pages_remote().

[1]: https://lore.kernel.org/all/20250529064947.38433-1-lizhe.67@bytedance.com/

Signed-off-by: Li Zhe <lizhe.67@bytedance.com>
---
 drivers/vfio/vfio_iommu_type1.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c
index 28ee4b8d39ae..e952bf8bdfab 100644
--- a/drivers/vfio/vfio_iommu_type1.c
+++ b/drivers/vfio/vfio_iommu_type1.c
@@ -805,16 +805,12 @@ static long vfio_unpin_pages_remote(struct vfio_dma *dma, dma_addr_t iova,
 				    unsigned long pfn, unsigned long npage,
 				    bool do_accounting)
 {
-	long unlocked = 0, locked = 0;
+	long unlocked = 0, locked = vpfn_pages(dma, iova, npage);
 	long i;
 
-	for (i = 0; i < npage; i++, iova += PAGE_SIZE) {
-		if (put_pfn(pfn++, dma->prot)) {
+	for (i = 0; i < npage; i++)
+		if (put_pfn(pfn++, dma->prot))
 			unlocked++;
-			if (vfio_find_vpfn(dma, iova))
-				locked++;
-		}
-	}
 
 	if (do_accounting)
 		vfio_lock_acct(dma, locked - unlocked, true);
-- 
2.20.1



  reply	other threads:[~2025-06-17  4:18 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-17  4:18 [PATCH v4 0/3] optimize vfio_unpin_pages_remote() for large folio lizhe.67
2025-06-17  4:18 ` lizhe.67 [this message]
2025-06-17  4:18 ` [PATCH v4 2/3] gup: introduce unpin_user_folio_dirty_locked() lizhe.67
2025-06-17  7:35   ` David Hildenbrand
2025-06-17 13:42   ` Jason Gunthorpe
2025-06-17 13:45     ` David Hildenbrand
2025-06-17 13:58       ` David Hildenbrand
2025-06-17 14:04         ` David Hildenbrand
2025-06-17 15:22           ` Jason Gunthorpe
2025-06-18  6:28             ` lizhe.67
2025-06-18  8:20               ` David Hildenbrand
2025-06-18 11:36               ` Jason Gunthorpe
2025-06-18 11:40                 ` David Hildenbrand
2025-06-18 11:42                   ` David Hildenbrand
2025-06-18 11:46                     ` Jason Gunthorpe
2025-06-18 11:52                       ` David Hildenbrand
2025-06-18 11:56                         ` Jason Gunthorpe
2025-06-18 12:19                           ` lizhe.67
2025-06-18 13:23                             ` Jason Gunthorpe
2025-06-19  9:05                               ` lizhe.67
2025-06-19 12:35                                 ` Jason Gunthorpe
2025-06-19 12:49                                   ` lizhe.67
2025-06-17  4:18 ` [PATCH v4 3/3] vfio/type1: optimize vfio_unpin_pages_remote() for large folio lizhe.67
2025-06-17  7:43   ` David Hildenbrand
2025-06-17  9:21     ` [PATCH v4 2/3] gup: introduce unpin_user_folio_dirty_locked() lizhe.67
2025-06-17  9:27       ` David Hildenbrand
2025-06-17  9:47         ` [PATCH v4 3/3] vfio/type1: optimize vfio_unpin_pages_remote() for large folio lizhe.67
2025-06-17  9:49           ` David Hildenbrand
2025-06-17 12:42             ` lizhe.67
2025-06-17 13:47               ` David Hildenbrand
2025-06-18  6:11                 ` lizhe.67
2025-06-18  7:22                   ` lizhe.67
2025-06-18  8:54                   ` David Hildenbrand
2025-06-18  9:39                     ` lizhe.67

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250617041821.85555-2-lizhe.67@bytedance.com \
    --to=lizhe.67@bytedance.com \
    --cc=akpm@linux-foundation.org \
    --cc=alex.williamson@redhat.com \
    --cc=david@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=peterx@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox