From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9A02C71136 for ; Tue, 17 Jun 2025 11:44:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47CB26B0092; Tue, 17 Jun 2025 07:44:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F7A16B0089; Tue, 17 Jun 2025 07:44:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BF9A6B008A; Tue, 17 Jun 2025 07:44:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1505F6B0092 for ; Tue, 17 Jun 2025 07:44:07 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B33851A00E0 for ; Tue, 17 Jun 2025 11:44:06 +0000 (UTC) X-FDA: 83564708892.11.94C873C Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf07.hostedemail.com (Postfix) with ESMTP id A747140002; Tue, 17 Jun 2025 11:44:04 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=pglRVmSg; spf=pass (imf07.hostedemail.com: domain of brauner@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750160645; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XaXveEeH10NyqmsZskThZ30oS/IooNFOsjao3u+MPWU=; b=Am+RJbdeVNQILxFqf8NihYw4p57yk2Bd7ql6FSbm7Oftau9b8lhALunN4iGv2sR8xV2ZeL Zi1GsWgtUFtfKwM6REVN2frY1Z+yTJvbh5zc9igypaM5D4QcJnQq5rVixkfZap5VYBqu+c +YqAc0anoNRsJ0JSeDVU7sRDi/KjRcU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750160645; a=rsa-sha256; cv=none; b=LA4yvJJf2AsvI3v4b4IPTuHlW4aaPWrhygrmiLg5qiM9clcE71pzK/S/okJuEw92ej56v7 UN93hJJXzXIT9Nyu+ExIWmhyRaSqGqTa2CCzaUD/I6SF/EobXniKgT2F42FG7HkBpHfl8l p4XP2mBC8phdL2aVbQqFctlsXT343hw= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=pglRVmSg; spf=pass (imf07.hostedemail.com: domain of brauner@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 77600A5000E; Tue, 17 Jun 2025 11:44:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CBABEC4CEE3; Tue, 17 Jun 2025 11:43:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750160643; bh=L4F/xAE2aK6xDa/QOHjQNfrbZ+ldwQ/xxyXW1QOlMqY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pglRVmSgsr6zVPCbLUxJit1HENECqtF+VKUELSm7DDvJTAXtRKCT9IonBR+vy/Pv+ 0KOSaKv4o78/UPxS/8WAJnS8XTOzb25DdQPvidNigl04+KbSBnUNdwYpWyPtjwUao2 KVjU1eod47I9hfmAqu1HXs5NNkpj9ZmoKBDj9iEbYW+Iu4/Wq9ZnQvd/24RiYcCxU6 ehoC5iKuDLDPBM85gO0tJ3zg29crJnqV/BFPF36D01IwNlhquecGAcdQBOYi0SfMgr iTlE7wC7JprLm5uHeq/OcqpnX3tE4351ouMdsYgL/8w6omsW5EvX+9RqdO82rtRfny Z7wz58Ln84EiQ== Date: Tue, 17 Jun 2025 13:43:36 +0200 From: Christian Brauner To: Matthew Wilcox Cc: Lorenzo Stoakes , Andrew Morton , "Liam R . Howlett" , Jens Axboe , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , David Howells , Marc Dionne , Alexander Viro , Jan Kara , Benjamin LaHaise , Miklos Szeredi , Amir Goldstein , Kent Overstreet , "Tigran A . Aivazian" , Kees Cook , Chris Mason , Josef Bacik , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Namjae Jeon , Sungjong Seo , Yuezhang Mo , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Viacheslav Dubeyko , John Paul Adrian Glaubitz , Yangtao Li , Richard Weinberger , Anton Ivanov , Johannes Berg , Mikulas Patocka , David Woodhouse , Dave Kleikamp , Trond Myklebust , Anna Schumaker , Ryusuke Konishi , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Bob Copeland , Mike Marshall , Martin Brandenburg , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Zhihao Cheng , Hans de Goede , Carlos Maiolino , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Dan Williams , Vlastimil Babka , Jann Horn , Pedro Falcato , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-aio@kvack.org, linux-unionfs@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev Subject: Re: [PATCH 04/10] fs/dax: make it possible to check dev dax support without a VMA Message-ID: <20250617-sehgewohnheiten-getagt-47e1ee917d4f@brauner> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: A747140002 X-Stat-Signature: 7jhkbyr3uofucakdukudwa6djort979c X-HE-Tag: 1750160644-679641 X-HE-Meta: U2FsdGVkX1/JdQTs92b/XoNd0MMD75lGxL3BQtAWyFStAgmnQdffSQOF31ftuihWSApAVRk4CBSNjkn4sGDXx9lFR2dnqQ6MX3UuXPdlWWSr94ydxWMD30xsBCX+hI+3mFIR3QgPcL72fH7ieRiM37JEBpJ61ZnCHHBqJtQuH9gJEQ2kdBdz0LXgjh9rT/rkK6oC5lo4Rk4L7HzEpqz/CzICzTRoEDAF9e5BrPtDFHOfGvv7iOpnwNPL+XAb/ZxjK5S24O0EediHkCC5vzWmEbeHgfnRGfKru9fp7c5LN29ltfAUWIRQaL9IjEkHwkokMWp0ZaTID5qINzhDGnVCwXtayRfYwsGXGdIEFI7pBM9wQEjXgYIFx2oxFf5Hau/i6Ffuj8Mkp7g8UfFoaFN6zJplf2Na4YncCNMbB6zcJl+N8ol9/b8/emL3W64C3Koe8s4POeeozMBrIapw+6ukxVi5c9Pn3WdxPZxx179VVAG5Czs0x+s4e8qcRKIVYrdXtFVnOLjyOHyg6P4I4CNjBFoNOYG6IX+XPnTnh3VR6zxomfRrxleCsk+ms6Z1w9csX6fUF0G9+ARCrddBygB7LFssfkvi3DpuGz2dbhvp6Vtin8YYemgAGls4zw5/TCnYsphXYahp7/syiQYHCbmbFUuDhj/Mxm/2vv5TC0uzQl0KbY+iX3QwgW2KliIrrteeXGVcIV5b/sOidATDygYsY+tAISRmojRhquFLZvw/PO+JZRk1pZ8WbN61sMDf7JrPzxqa0pBftQHFqtDQuwUxPT+bacn67hdc4ei6jUeOOxubyiplZ7q1mbj/Q1DTEmJSjcdQEA7BvVrA/aLP73ePE+tRRCRYnYZKH8JOVB5HJnBQe4mzl4Nsilyb7nkhXVR279m55EPdSX2nf7R3Vlf912LgyqbBuf5zO4bi1Whr8pq5SuLI7qDI/FvnT/Ahr4Oy7zepvDp3RvUtvJWdHEg zREzG8xm aO+zuRp2b4IghZByGgj0pz4B27J83xoF1AU6fUdkFOhjvstxAJ7kGCFWN7U4j97+qOlJEkf2JCS+Qb4BxnuR2WVStPKH2C0UJs5XcSXPWJDrcaqQNWXW1PQpWwD4R++UCXtkG2UFHSA+1i0UtmTWoVweD2efynckFM/YnDJgIWRHPQ4VLsAyZtJoJ4ZS63ZxbAySCwK+BlJRgS1bYjCGf2jbWRlvxMxOZsOmIGmdmbPrUjqvH+LwaBQAsgjr8Z4wfPfZfetPVyeKalNoYs+AM+ZNF5KnyRKxLeThAKm/bH8Io+WiGRAOnfn1SPu5hDWqTJrg096sFs5Dj2IexqUZq8G3X3NCd1kAYFh1ljkNG87kkW++L0UbfmBG7WRw6kq7AKd9rNQCVfzHdLfGcmN1sII9qPA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 16, 2025 at 09:26:54PM +0100, Matthew Wilcox wrote: > On Mon, Jun 16, 2025 at 08:33:23PM +0100, Lorenzo Stoakes wrote: > > fs/ext4/file.c | 2 +- > > fs/xfs/xfs_file.c | 3 ++- > > Both of these already have the inode from the file ... > > > +static inline bool daxdev_mapping_supported(vm_flags_t vm_flags, > > + struct file *file, > > + struct dax_device *dax_dev) > > { > > - if (!(vma->vm_flags & VM_SYNC)) > > + if (!(vm_flags & VM_SYNC)) > > return true; > > - if (!IS_DAX(file_inode(vma->vm_file))) > > + if (!IS_DAX(file_inode(file))) > > return false; > > return dax_synchronous(dax_dev); > > ... and the only thing this function uses from the file is the inode. > So maybe pass in the inode rather than the file? Agreed. I've converted this to take const struct inode *.