From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40590C71136 for ; Tue, 17 Jun 2025 12:00:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D66416B009A; Tue, 17 Jun 2025 08:00:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3D986B009B; Tue, 17 Jun 2025 08:00:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2C416B009C; Tue, 17 Jun 2025 08:00:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B3AB46B009A for ; Tue, 17 Jun 2025 08:00:17 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 311E11003F8 for ; Tue, 17 Jun 2025 12:00:17 +0000 (UTC) X-FDA: 83564749674.09.8EE6E1A Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf24.hostedemail.com (Postfix) with ESMTP id 7E494180003; Tue, 17 Jun 2025 12:00:14 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cbm6eSpO; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf24.hostedemail.com: domain of brauner@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750161615; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VadYNfxPDS9mWpWiEQHS/5/7snz8zXTvd9oaZpSDKWQ=; b=L38antGRFAYj7QRlzKxEWP4IQzv+MaH/zsB+Q9WjcK85WwA8Y0Qw2mRHBx5ZNP+gnNuqBe AuwXZZ9tyH1usQs7gR48X1NXXkEwVroUnmzfxA2B7RoXV+2auAh0bYgZiKI4jZPMHr3clR lw+a4sGq3vJmX3b1Icqc7b+epK1mCns= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750161615; a=rsa-sha256; cv=none; b=M5DJ0qVWamtLImO8XCh+F+Xfn2yboVbUVfNujwexh3zU9GQzUnnr7WrwSZ6k0N/n+SNiIp Oo2EjBJokUIl49aDEYLjj8sFoxnWr/cV992zujqBL1xmAu2IzZkGDiSBcuyjOPvFJCeYZg 9LVALrMyxYRii/gdn2V9RvoC9TyL6Yk= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cbm6eSpO; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf24.hostedemail.com: domain of brauner@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=brauner@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 4F92D49D8F; Tue, 17 Jun 2025 12:00:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F729C4CEE3; Tue, 17 Jun 2025 11:59:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750161613; bh=d7N8Br27sigUm6RwJ6QKDyuMIfLKb482gs0GJECdYqY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cbm6eSpOXnYTKVf24fD5wSecYeYAtaJSPLtzA/cg7YuA4PJRPYSNZqoHGrOB9vedO xE+Kw4QDbA/4jdsP7oXbPhVrMP5XKHSj57b+LizHRuDadEPqGBM+ZxF2QhTJG4KKld niMYuWEWwMHm5apCVpkqg1uA/sm57a3OJs6XP47Q03JuvcLdBMJ4BZLJME8mGFpquF OAV54y1YNZFqwgygvgnolLyQkxdfAP1bT54VMRT4yd/LwvYOK0H78h2s/9FU+jHgJZ /1P5yb/ScvLTgMkRASvu83CdtUFgXaGEFmmqSgC4JGFIOk41SmtzQEJEUL45wKXKIE copUCuL9W6X/w== From: Christian Brauner To: Lorenzo Stoakes Cc: Christian Brauner , "Liam R . Howlett" , Jens Axboe , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , David Howells , Marc Dionne , Alexander Viro , Jan Kara , Benjamin LaHaise , Miklos Szeredi , Amir Goldstein , Kent Overstreet , "Tigran A . Aivazian" , Kees Cook , Chris Mason , Josef Bacik , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Namjae Jeon , Sungjong Seo , Yuezhang Mo , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Viacheslav Dubeyko , John Paul Adrian Glaubitz , Yangtao Li , Richard Weinberger , Anton Ivanov , Johannes Berg , Mikulas Patocka , David Woodhouse , Dave Kleikamp , Trond Myklebust , Anna Schumaker , Ryusuke Konishi , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Bob Copeland , Mike Marshall , Martin Brandenburg , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Zhihao Cheng , Hans de Goede , Carlos Maiolino , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Dan Williams , Matthew Wilcox , Vlastimil Babka , Jann Horn , Pedro Falcato , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-aio@kvack.org, linux-unionfs@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev, Andrew Morton Subject: Re: [PATCH 00/10] convert the majority of file systems to mmap_prepare Date: Tue, 17 Jun 2025 13:58:21 +0200 Message-ID: <20250617-neugliederung-erarbeiten-58c2ad93db83@brauner> X-Mailer: git-send-email 2.47.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2454; i=brauner@kernel.org; h=from:subject:message-id; bh=d7N8Br27sigUm6RwJ6QKDyuMIfLKb482gs0GJECdYqY=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMWQERqz1Wd3by3g/duuF6rmP/N/MPRV+t8Tf5qpaV67t4 jKOJ7rXO0pZGMS4GGTFFFkc2k3C5ZbzVGw2ytSAmcPKBDKEgYtTACaysIiRYfKb1+w2vf8O/mdg vPFO8PHqRzML+F0vTZYp4bqm1fwkeyXDP4PuJqblPl9UmcRtf/n65jge6ap97PLc+43T4+kid/k fMgMA X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit X-Stat-Signature: 34srhyb1tka4hft9th7oxqkijuhq8ft3 X-Rspamd-Queue-Id: 7E494180003 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1750161614-102074 X-HE-Meta: U2FsdGVkX1+iBuL0+WJRlyvUHsY/Py/YucYL/QflZMGtlJH6Y/K31h5Ekrw8EyLreIkcFK7jlE1uLHwOTE+o6cZ4y/xQNPQ4mY2XkfbesoJGydNN17+jCwfBhG1e9nuUBOeAWhul99LsfRKVNZmrzpbe2nJFjtMPpNGwWL/mEWi46RVnfUZ+L3GF+beGQakxUVJ3CfmwLqsa8TP6C9JLDeMha4S4QvczXgL1P5+auHg38ygVfnGjzCOdAmXNZU1zXkaEE+UCZ2rr0BjVeYDQQ2F7Zg5iTOsBWenFeYIs2N9wf4fQ8Ni/dgE0xxMOuVUVRZogDvRHgpvoJy27GU4hHya6bWF9SQIwTlRiijROvluraRe/6HgNwmtrTPkLtPQx3qVArtkxiipPQL5IZVnrIfiyuDv6JKbwHKwBwULHBHzRtm94wc5qMYbq4mwAUTv9biK7tFCBCDgjM58/ggNoXt7y+nicoTPKrXHXZLDCEgo9evpHuFOy8ivobEWMMC9FO1+MXDyKSbwY/bmTVadPvqNgT8DLr8YGu+Jw9ElSEpDazYwPLt0dDw9h7/0lAf3aWmabiJ5iC80ZL2g41IjfI4YXic2QtnLOsqJQJLJNS/n3eg+q8aPw3PFDTF0hE96ZCe/n5WrTLo9PbyU4I7wS6z/wMErFSGqtcep1M8BYmt/vrv8C5o64z3fR8CUfn7ALEKHIJLEhAX/Dx3YjXfMH0W1f0uURWtoIZ2aIatnmQLJAoLnUmQrr5m9DaB3u6UjGxy12gRvmsA0Ys27DbIl7hWosHFCthVymWQxl53O4WNoXKa9uzhqHCUy3wqCCLeum1iOc/HvQV6bbf35X4K6so1d3IvIazhbEcjQaY4g1hkXcGxshPA0TCUr0q0BgT6hAbywZUAnH2vlWi/Xx0vtynbRPapa/+6ETFtjnmgfBjxRFEdlWo/R3gLsEEbJ8CUcNpXcR9QQiHMC64jCQsw+ hnK1wMvS QX1yK7uErWWF/7B01Mf1b+0Lwd9Sodoc99zLO/J/1Mb0ynJqvh3FZNzc1DWHFO+8jkbgUOtp6Wrglk6uflEWjig+218e4snXMhwdC/hbDNqrG62PfVwZqHDkYIdEJKVgrxh6cSJCsWl3ii+eMim61G2d7KH0g1wwS8zDraCxzim0cah5c5srCW2xlSO3kRnR3fLNbgChoDvQKqe2UUUiXwH/qnl/RFQq5DJvt8Gzv1Fc7uG2MLN0WR0EZ17mZ0zYlCQUdOR7oLEJxXQAuP1b3xMEf8FIAZ8CnAVd/ZyE+7QWFnuJUmuRP79XQkLYNbwTb5iM0wHNSFIM7s4t7i/OMEGd9qw/3Yo3XThijjXCMYvqt5XAIEulcCZyWm8p3MdzwnEyXTeuqNalNsAqJGwuLnr+4DDudTBV0Vzb/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 16 Jun 2025 20:33:19 +0100, Lorenzo Stoakes wrote: > REVIEWER'S NOTES > ================ > > I am basing this on the mm-new branch in Andrew's tree, so let me know if I > should rebase anything here. Given the mm bits touched I did think perhaps > we should take it through the mm tree, however it may be more sensible to > take it through an fs tree - let me know! > > [...] This looks good. I fixed up the minor review comments. Looking forward to further cleanups in this area. --- Applied to the vfs-6.17.mmap_prepare branch of the vfs/vfs.git tree. Patches in the vfs-6.17.mmap_prepare branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs-6.17.mmap_prepare [01/10] mm: rename call_mmap/mmap_prepare to vfs_mmap/mmap_prepare https://git.kernel.org/vfs/vfs/c/20ca475d9860 [02/10] mm/nommu: use file_has_valid_mmap_hooks() helper https://git.kernel.org/vfs/vfs/c/c6900f227f89 [03/10] fs: consistently use file_has_valid_mmap_hooks() helper https://git.kernel.org/vfs/vfs/c/b013ed403197 [04/10] fs/dax: make it possible to check dev dax support without a VMA https://git.kernel.org/vfs/vfs/c/0335f6afd348 [05/10] fs/ext4: transition from deprecated .mmap hook to .mmap_prepare https://git.kernel.org/vfs/vfs/c/8c90ae8fe5e3 [06/10] fs/xfs: transition from deprecated .mmap hook to .mmap_prepare https://git.kernel.org/vfs/vfs/c/6528d29b46d8 [07/10] mm/filemap: introduce generic_file_*_mmap_prepare() helpers https://git.kernel.org/vfs/vfs/c/5b44297bcfa4 [08/10] fs: convert simple use of generic_file_*_mmap() to .mmap_prepare() https://git.kernel.org/vfs/vfs/c/951ea2f4844c [09/10] fs: convert most other generic_file_*mmap() users to .mmap_prepare() https://git.kernel.org/vfs/vfs/c/a5ee9a82981d [10/10] fs: replace mmap hook with .mmap_prepare for simple mappings https://git.kernel.org/vfs/vfs/c/a1e5b36c4034