From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD20DC71136 for ; Tue, 17 Jun 2025 11:48:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 36E636B0093; Tue, 17 Jun 2025 07:48:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C79A6B0089; Tue, 17 Jun 2025 07:48:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 18F006B0095; Tue, 17 Jun 2025 07:48:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 00FFF6B0093 for ; Tue, 17 Jun 2025 07:48:34 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A78371CBB83 for ; Tue, 17 Jun 2025 11:48:34 +0000 (UTC) X-FDA: 83564720148.04.5EB222F Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf18.hostedemail.com (Postfix) with ESMTP id 3DD281C000C; Tue, 17 Jun 2025 11:48:32 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=i76Wd947; spf=pass (imf18.hostedemail.com: domain of brauner@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750160912; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lIpP5iOY84H59tRkmuJOo9CYvchrtq9t6gV5oxKPio4=; b=D75XQxuQP3nJ8fZwXxc33GT5vpdnz0YalpE8t+swOpqWcsCe/dQaW/iavDwt7gve2wRUMU 8mvTttf1xuAtjXFZKmnn83cO3jNyEoyLJDaiL1NJ8/Hal3kadnP4IeUkcj1s4cC+as1YAW KGN/SfZN4YopRkAoc7c3/1pZDuScZi4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750160912; a=rsa-sha256; cv=none; b=IMtulW4dzMMgGYKt5iOy7/OqOtANGqQT5OA4c6Bg1OBaX9kQSGxtQaqJfyfiK/5j5UIJre DHUrqmVQHZnusOw36lKrNAzK1srrxgYMyLtOzUtkK/tthHNJxlFV9yFEXKS0JjLd0cjLdJ EHqize0RFyy0ZXgEMUjHmNOK0Nhw+lY= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=i76Wd947; spf=pass (imf18.hostedemail.com: domain of brauner@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id E682744DD6; Tue, 17 Jun 2025 11:48:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40C6FC4CEE3; Tue, 17 Jun 2025 11:48:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750160910; bh=Vnr3kmvDQPz8s5uZNmSkWKP9XPj/+f6PNSLS1Tx/MzQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i76Wd947DS4XwAcDpAS8fpuf+Ela4lfUx5B4Zl+sE1WJ8kzwgrCbFciE3rigUUS/6 wkwvrTbKDnBSYG4C5HYytRyvy7B3ZkCeJ/5F35ij31zEXxn65NXesNNhKSYHlLq/2D R33NY8eYZWteN9O+9G//EUF0UQxUiz+Y2C7gC+ejd2PqldQ355joR8oksRp/9Bu+B9 HCJ+eqE2ygFdOjJuUuFVDO+rKmgk2g66UaZmVaAWhJlsobI+L+ldnr5kvasHnLLQtL 3ZDhNpWvRvvYFALgNe61XXKpKO8zT2d+3DmY+NeMp1GFEAHy45cWCYw7RMgE+f8kCe WOUfPvP6PlRuw== Date: Tue, 17 Jun 2025 13:48:04 +0200 From: Christian Brauner To: Jan Kara Cc: Lorenzo Stoakes , Christoph Hellwig , Andrew Morton , "Liam R . Howlett" , Jens Axboe , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , David Howells , Marc Dionne , Alexander Viro , Benjamin LaHaise , Miklos Szeredi , Amir Goldstein , Kent Overstreet , "Tigran A . Aivazian" , Kees Cook , Chris Mason , Josef Bacik , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Namjae Jeon , Sungjong Seo , Yuezhang Mo , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Viacheslav Dubeyko , John Paul Adrian Glaubitz , Yangtao Li , Richard Weinberger , Anton Ivanov , Johannes Berg , Mikulas Patocka , David Woodhouse , Dave Kleikamp , Trond Myklebust , Anna Schumaker , Ryusuke Konishi , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Bob Copeland , Mike Marshall , Martin Brandenburg , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Zhihao Cheng , Hans de Goede , Carlos Maiolino , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Dan Williams , Matthew Wilcox , Vlastimil Babka , Jann Horn , Pedro Falcato , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-aio@kvack.org, linux-unionfs@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev Subject: Re: [PATCH 03/10] fs: consistently use file_has_valid_mmap_hooks() helper Message-ID: <20250617-mitstreiter-bewahren-455b96bd1d50@brauner> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 3DD281C000C X-Stat-Signature: ootmb7miha5udo5ariey179u81spsud7 X-Rspamd-Server: rspam04 X-HE-Tag: 1750160912-946694 X-HE-Meta: U2FsdGVkX18WYaQKdyu0GzrMKcBPqkunpj6c8fqHTt4571HMqrNHPPOLCnwm139bJRSRlcXuIuiCWda2MZIzBh3bv9eZ1Q6vKH6NtlR14/mAZXxiHht5TLLmaGCCPt9+nTO358jCYSJmPw1VARtgk5E2Lgal8rxraUTPfrntwGSC3ReBvEo8XSf2AHzJ/O0Nfv3h/sAIxj8JzorpV/l6UDnG7hEkhsQOgLxoaMLuM4YVFG1IpKfULqv+JzqfcaXh856TaD4/gRpXW3OKlvJookc0MRlBcrBi5Y172gaG9z7mvpAbV+wRRrMdCR7dt0iDrYi5EJExqmtGSk31xVwYftriv2Z7UtzeWbwN7zZRSvxYQr3ennrt0JvBI1UMEpko6JgoW2C1Rhh3M6Z/DVMdKMAfNFcr3dbxrSx2N74UAPwIkicIjYr4kGACjHD5MA+S8MbA4XcgmFnvDqkvgmX7UeBoxOSeRnBLY5pfEOalHieiBgcghle7y+5UWUYUYh608i/ltJK5rsuIYRX668yAslJUTXswhLXDB9UC/ZRyVvt/Bt7RvLgL1BMIC1uWYvOnRvE92Smlaa4ZzkZdknbGmDZnx1uhHl12iqmMyAU5G4KywIr1SpmrTWHPlYtMf1f/Adc1ce218Eu/E+fKqb525ffWNjTeGW9JNPcZ8SrcnoMjTmMs/+XuM9B9np/tVjlR8xMvqzq9WYnEECF3guXKKfYhLeZTWgH2g91B3dis1BSKsqJia12AN0wgeSleZWgs0lrxTlLxPvwDzbfAcdhLXPbTGQzmpziIRBi/qYvCdPJi1LNuDUtqwg3nQX89GCfKG79s9LD8FF9afhSjWSvnb95ju8x7oGeUEwurs4slyca5uCVaF4/NmaEqSFzsNIMub0IoA21WO6Tu7yZEh36jMFWRdkwVTJedyeHg7cBjdVvKBwfQ/qQ/ekTrBRwnvvUNkL2+W4oFwDLGHLOn0vQ uXnnWb8q GGQP7ZIMfegQC8ZN4aJbkIvixrA58ySNVr7M2Tu/lfdXEHrjeETL8DKLrTyDukonB+cZ6/hfEsQdn55JQCyp+zMRlHzFgYyWJncnBOckNfU6hzeLaoPHma7Y4/zS7McD56OIuvPA1gg3mysxHsXusZywuch5zRNTQRUci6/Yptvi4XPJHBTcIxFCz6Yc5mkcewu79FykZwEmucIrmPqMtjqOEDO6x0RRMdZb7VZZM3/8vfXxmJ4IqzjGD9P9y+ZzHO4TANYDMS+3p5brFapD/EpEDIg7WR8NClRzJo2P2sFaQ7PF/jfdBz+zJTC5WEceozo6ws/gHqLClOXZwuxgbcBGKizwR9JA+UV2qaGhXlcjCm6GK3+1l9p70TjAMtXq4NHc7zmcP/AniTrUg++L5m3Xx4/yglVLiMV8J4MbJeOBGJRg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 17, 2025 at 12:08:13PM +0200, Jan Kara wrote: > On Tue 17-06-25 06:25:34, Lorenzo Stoakes wrote: > > On Mon, Jun 16, 2025 at 10:11:28PM -0700, Christoph Hellwig wrote: > > > On Mon, Jun 16, 2025 at 08:33:22PM +0100, Lorenzo Stoakes wrote: > > > > Since commit c84bf6dd2b83 ("mm: introduce new .mmap_prepare() file > > > > callback"), the f_op->mmap() hook has been deprecated in favour of > > > > f_op->mmap_prepare(). > > > > > > > > Additionally, commit bb666b7c2707 ("mm: add mmap_prepare() compatibility > > > > layer for nested file systems") permits the use of the .mmap_prepare() hook > > > > even in nested filesystems like overlayfs. > > > > > > > > There are a number of places where we check only for f_op->mmap - this is > > > > incorrect now mmap_prepare exists, so update all of these to use the > > > > general helper file_has_valid_mmap_hooks(). > > > > > > > > Most notably, this updates the elf logic to allow for the ability to > > > > execute binaries on filesystems which have the .mmap_prepare hook, but > > > > additionally we update nested filesystems. > > > > > > Can you please give the function a better name before spreading it? > > > file operations aren't hooks by any classic definition. > > > > > > > can_mmap_file()? > > I like this name more as well :). With this patch looks good to me. Again a Fixed in-tree.