From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08EE2C71136 for ; Tue, 17 Jun 2025 11:46:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8696B6B008A; Tue, 17 Jun 2025 07:46:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8414B6B0093; Tue, 17 Jun 2025 07:46:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77E076B0095; Tue, 17 Jun 2025 07:46:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6B68E6B008A for ; Tue, 17 Jun 2025 07:46:07 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 395B0160110 for ; Tue, 17 Jun 2025 11:46:07 +0000 (UTC) X-FDA: 83564713974.28.206D063 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf30.hostedemail.com (Postfix) with ESMTP id CF5C08000F; Tue, 17 Jun 2025 11:46:04 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LKZAHZAC; spf=pass (imf30.hostedemail.com: domain of brauner@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750160765; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dJhc/xLFMoBcJaq1EUp+bwPxRKCz82LTkTE0hRnLfZw=; b=gFzlfU1b2jLOKLk84Vs64AIjMvDO+4/nx9b9b4aNtq61PH0ZanFWs0lVQnYzJNeG3KOh1N iUXZzb/NNiSU9O/pWMTfc7T+PrWSaCJ0ME3HWksPTnt95wHWY6mBlUY3Eys1yrcHp5ME1s 1Y9C7VbdRZpwtxKzArl9gakmIOG/SaU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750160765; a=rsa-sha256; cv=none; b=JSd4cKny/GbSysqhkGkzHfvHtgKRtF95Slj/tJE++VyAqwN6OPlTInXd/KpQnqQ6Ls1cYm vzkdu0cOywwifPaJspjX/PBpUfAlkFs6rWyF6k42004QHzMrvYABcW2ftgon0BMWNuykgm 57lSSVtXqFdPRIP0Vv24y4WtQcmXviU= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LKZAHZAC; spf=pass (imf30.hostedemail.com: domain of brauner@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 27AE1448BF; Tue, 17 Jun 2025 11:46:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E2A2C4CEE3; Tue, 17 Jun 2025 11:45:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750160763; bh=StMBYKo3IYdJvpDPP28DVy7nnfZ5iZVxiZzaq3OT7Gk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LKZAHZAC9vUoLxqJ9kPw7y11d1vccxwHwO+yliNT9fTET47uPMg0jRAi/9kqollS2 3j8hdqKrliDMUGiMhPw2i9dqvvInebMc6yA2lG7rgUpPGh/yxB0XWm17UXOqauVCc6 Sagcwo9PDm6boEPAX0mIsK8saf5hKwJj0gSqfvOJcC35Ur+DJm/pIWbzY5aT2H/9YC 9jut3Jn0eTCrVe+VIPmIgpnff0NScXFO+hEPUf2CI9uzx8gHglPFlh4VWh+b/JQt0q u82czCjtFdfG73DgONm2+NtA0s6Hq8jxAqKfQtbaaS8tUES6NzxY9nC8fYbzwdQBIB OrD8iaWSk5iyQ== Date: Tue, 17 Jun 2025 13:45:37 +0200 From: Christian Brauner To: Christoph Hellwig Cc: Lorenzo Stoakes , Andrew Morton , "Liam R . Howlett" , Jens Axboe , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , David Howells , Marc Dionne , Alexander Viro , Jan Kara , Benjamin LaHaise , Miklos Szeredi , Amir Goldstein , Kent Overstreet , "Tigran A . Aivazian" , Kees Cook , Chris Mason , Josef Bacik , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Namjae Jeon , Sungjong Seo , Yuezhang Mo , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Viacheslav Dubeyko , John Paul Adrian Glaubitz , Yangtao Li , Richard Weinberger , Anton Ivanov , Johannes Berg , Mikulas Patocka , David Woodhouse , Dave Kleikamp , Trond Myklebust , Anna Schumaker , Ryusuke Konishi , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Bob Copeland , Mike Marshall , Martin Brandenburg , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Zhihao Cheng , Hans de Goede , Carlos Maiolino , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Dan Williams , Matthew Wilcox , Vlastimil Babka , Jann Horn , Pedro Falcato , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-aio@kvack.org, linux-unionfs@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev Subject: Re: [PATCH 06/10] fs/xfs: transition from deprecated .mmap hook to .mmap_prepare Message-ID: <20250617-herdplatte-ringkampf-8e8b439e81f2@brauner> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: CF5C08000F X-Stat-Signature: go3c1ore8j7b89beja5r1x6scgaogo7b X-HE-Tag: 1750160764-462469 X-HE-Meta: U2FsdGVkX19IWpBxMosWhpG6TdNasaDKbRAmPOcVqo72gAX63aJJsZTlpRq6yYa3FubqYh34UG4UDokpmqz4/ZpXx1c0/bPtVEHJ91k/6u7BQjUZyIP4q6gtn6+tqjRffR7rdCSdWEqdosSfs5M71tR6A24CrQk7xNP/97NrxYOyVI+oyXIpN6F0oEapCU2BvoFnwbnSENthEYdmRkMCA8VIuorNzSUEdACh5nxFuYAzr0imsvMIhDPpCXkSgwfq4ldjTe4Cf0JvnKlnzOJPJKdbtSKVIHkk/sTDFlBkOfCRc+Jijp9VTHd/6VShln+q/Ea7/74gUGnBeWhUQE4C3tCfuhWRpjQfO0n5xHYkZf1nRaPtiLZW1o8xaTX51zmF+jYEAzP5gd/TWXwSal4EfyDJODHQkQ3jsMFzA1I5OA5hgVpa+/IEa2JxMpyxaBkEPTUfNXZjYNRLk54ORBpW0bU+6WyW00laHbFvbSdHe77jXrkjxk2RgE3mWdml2jdXSMNm2kteYoSrWHF8wzvujGO9NXyFHKa/yN0ysHGqqox3D8OSWLexLu4/OYzwDbsBfWxm4nOkgbDjJ1/U7YUbQd2tE4SCC6OwA3B5VXXACFtuYfOXchi81K8gYzru0+o+YNiLIR67IDU+oPEilmrIZbtQFLSDPR6sBBPOn/XoYVJqq66FEMLn1S86Q8Ordk1OOwNbg8MkK7OvdTsXRJLjbQSW6WNMINHcqdblrw0wEOQHzN0EzXhwryaN83G6ZASg0nngAKVwXr+KNxIVtt2r15/3sLyVM+RO52B5XlyvOQND25tJ2tu1u750mrkG7TJlofVsQBTZR0/D0sFdxQ2ilWzNDdANJxt5r6jGkP5aYjaYu/U+MdHXqTiN7gm2ug5Di8giLoPeALT8oMDSlkej9gkaCRRE1ibKBNPCH8o4qGKYEBaXYutqBUN3x0cPWjNx3baY3qENm3NS7DdNIoJ Ks2geyyy hRebgipSXlJEr704PI2rfIaOuAJniyDxyFbYufWDnwVzZnyxJhjrLY4Mz8ssptwRFnWF7FpuJWvo4trAgxT6DlJccJjZ5korATgQNTsXvB5+T1zck0NPWWsaY3lBNBIT+z3q9WrOw6u4/7w+PCGss8XbGfoAPRhwtPsZ5h0LeD1WReRtYUF7MTSTAMMlh5aKJ9CzfKyq0Sw+aD7bxt4Q3rBU9tPtgHh+k2Ph2IScGMcITgp7Bw7ld1F//m2Ork6jr7xZvdpptkW01YNLXNCWMAL+VKcUsYKxhTO8yrHC3e/LViBnRTDPFUh2Dflp4OmtWYRBoAC6U0W7OtNyWjhdiwGg26imrNiJ3+lwe3z4wkJ78nuyW9wEWPXQe3aXK6OXtEl+CX7b+LSyvqiwTTgEmqlCPNX1duGKXw7yj6+7pzHAyBTk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 16, 2025 at 10:08:03PM -0700, Christoph Hellwig wrote: > On Mon, Jun 16, 2025 at 08:33:25PM +0100, Lorenzo Stoakes wrote: > > STATIC int > > -xfs_file_mmap( > > - struct file *file, > > - struct vm_area_struct *vma) > > +xfs_file_mmap_prepare( > > + struct vm_area_desc *desc) > > Please stick to the existing alignment for the declarations. > > Otherwise this looks good. Fixed in-tree.