From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1DC7C71136 for ; Tue, 17 Jun 2025 01:38:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 304C86B007B; Mon, 16 Jun 2025 21:38:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 28F586B0088; Mon, 16 Jun 2025 21:38:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A5976B0089; Mon, 16 Jun 2025 21:38:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0746F6B007B for ; Mon, 16 Jun 2025 21:38:00 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 87520BF031 for ; Tue, 17 Jun 2025 01:37:59 +0000 (UTC) X-FDA: 83563181478.23.4E2D553 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf11.hostedemail.com (Postfix) with ESMTP id D397940005 for ; Tue, 17 Jun 2025 01:37:57 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=NXOhlO6Z; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750124277; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Buw6VaPpWlyI+Pu8u+fgp7RsJjPM5+sBi1u8oJ0tZSI=; b=ZISgrV3vsu1V4OAwif37xvqoyW9SOUTvWFUfTg/wh7tq+ny7trm9ODOV08htRrNONEsHr6 v16pOwAnptG3VzM+FJck4St/wKPXPRQR1hynPmrrKz9lJxbG3jgfQlXTkwJU34MHmmRMYh dD+/rVufDe7oJIjRh3i/gFVSBav6rjk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750124277; a=rsa-sha256; cv=none; b=QvKwn8BD32z1YliOiL+7ErR6CWfGYSnMxxlq2z+Tqni+l5BRISsgcBSRtqD49tc3SUbQmB WNKMxlPkr1jkpRFGKGPnfJAOcCpVbiXxVWrh8i43EWZkiz1j/SEYBVxY/lFFoEDsM38KSH o7iHhxHUOoeEbx9/3xATw2KGv3QYjW8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=NXOhlO6Z; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id D89B0A51FBF; Tue, 17 Jun 2025 01:37:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D93D2C4CEEA; Tue, 17 Jun 2025 01:37:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1750124276; bh=HzHh17AhtI00MRQ0FRmfvj3yZsKOrK/43wpwNt/3t24=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NXOhlO6Z8cAxxcUHr6pxmWeVcJTdZNwzpsOYoXcGAyRedqqndUEVgw1Vnz8Y+neXR ypgtGg+Vx7GyMcb3Tp1r6YHZaXiFmBPl8x7q1fL0eizRAQguv8IPii8/RFLj/B73Wq YiZdjarNSpkKfhsYxeE/+aEnQ4sFcM7dJaV4wlV4= Date: Mon, 16 Jun 2025 18:37:55 -0700 From: Andrew Morton To: Zi Yan Cc: linux-mm@kvack.org, David Hildenbrand , Johannes Weiner , Vlastimil Babka , Oscar Salvador , Baolin Wang , "Kirill A . Shutemov" , Mel Gorman , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Richard Chang , linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 0/6] Make MIGRATE_ISOLATE a standalone bit Message-Id: <20250616183755.16fbdd5e867752db14e321cc@linux-foundation.org> In-Reply-To: <20250616121019.1925851-1-ziy@nvidia.com> References: <20250616121019.1925851-1-ziy@nvidia.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: D397940005 X-Stat-Signature: uzdquj9whcmcgohztr8o68z4z769m8e1 X-HE-Tag: 1750124277-988403 X-HE-Meta: U2FsdGVkX1+YVsFtbBIRs3a9iyGgi5IAbdWKbzk1y0zwWvRIfI5H0Pr66NNqYFnlPtmngx+LoTkHQZL9SH9/yI1lrv/wTO2py7IyJucqqLuV0vQUQKdhpqAwSuJG2r4lMF0adlhBvae6AVwEXnIIk6j4nxESpuzCkk3THMDv8B1gE0XptsZI1UuOsGg1UKXK60tO9qyD1zSgcQlhctVzN1gLRKcKrW7I5t3fckcS7mTPytJficn6O+P2Eq+6G7sq1VrprtsVTol+iuM4D/Sf/mf0hhdIGNYoJI9ztiKeY6O7oVSdr3AZCEDO2H4uOomKNN+/oflfMkPOuWc984W1yyuqqM7jv0rJTsrQAkePAfFET5IoMoe/fl72JMlqQZg9plcIUfC+P429OnvsEi9nb5EWmISqz8r0x1lj8I99dxZJgR20z/th54LZC8vpsTcu4YmtjTh+iUaElqAibXQxCfz4Z2YJkAfQSz5SHGWl++cJbdC1uESSCEbVe1RUb6YYgn7AzGaGNS633joKsHjrk6o8G9iOvMihRrMYQwC0avBFtVb2kNAe8hBWRuqJ1lwxErU+FQOqwiKDSw3YaZTxgnFB7HkucmwI8oFi9siXVvZ8YvtgYa+lWwSwEeoxhtkaINWSKDP5BafGkCj/lAIWGKwwehXrjPyl6Nau7DbK4uPReCHvht/AMTK+GWFDmqrAiexvmrY7EdC12F3/W2Eq6X3HvgXew5ZDcxMQzrxtcl8p36vEoWVbCfkYNmH+5DrdRF2elvq0lpXlBNEfOihCoP/sBrSlaMc1SnwlAg9Cv43WWfDkZA7u8EBLL7cShOQWHaVpeFdoilxoH80LWs7Unwm1CHzlY8fotZvJFOfMwfl0N40PpqfbFA/yPOwHWtP41NTVAmvuJb8X0IG+CryUmr3ag5rLtgAOiffhRxPvtZOjLecT0hWhk134S8JgFOSTR56mIgQAJtyHJyrFB3J 5eaoHR+u GjeBDJ9SocM4Iryejr3lnvC1nah841PE37vvp91Aie0Nw6G9CbnfJb1jlfA/7QaF3z4R7tNuaT3IlFS0EJ6iuV3aKD0Tv+R9Wj9l6pxdlKn+P+7w7ryw/DXVk2rlGMTCow+dBRyDiqStx9wuyZBvnFYSLhrVkyJIeDPTuacqGpaTVLrIUp6x+l3HUnL/II5PajJDwJrC7rRLbOLkBRGFNQfD2XnvmJu0lf5pHygHHQ1IvRjGb6IAhO/pNgielPdEiyZavtRBMA3P17pqzKIbm5abQ4Cho2QM3xQlgM3Ct9y4gnVEPxg7+SGFn/bWHUc9/OQyu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 16 Jun 2025 08:10:13 -0400 Zi Yan wrote: > Hi all, > > This patchset moves MIGRATE_ISOLATE to a standalone bit to avoid > being overwritten during pageblock isolation process. Currently, > MIGRATE_ISOLATE is part of enum migratetype (in include/linux/mmzone.h), > thus, setting a pageblock to MIGRATE_ISOLATE overwrites its original > migratetype. This causes pageblock migratetype loss during > alloc_contig_range() and memory offline, especially when the process > fails due to a failed pageblock isolation and the code tries to undo the > finished pageblock isolations. > > It is on top of mm-everything-2025-06-15-23-48. mm-new would be a better target. mm-new is not (yet) included in linux-next, hence it is not in mm-everything. I hit a few issues (x86_64 allmodconfig): In file included from ./include/linux/slab.h:16, from ./include/linux/irq.h:21, from ./include/linux/of_irq.h:7, from drivers/gpu/drm/msm/hdmi/hdmi.c:9: ./include/linux/gfp.h:428:25: error: expected identifier before '(' token 428 | #define ACR_NONE ((__force acr_flags_t)0) // ordinary allocation request | ^ drivers/gpu/drm/msm/generated/hdmi.xml.h:71:9: note: in expansion of macro 'ACR_NONE' 71 | ACR_NONE = 0, | ^~~~~~~~ And this was needed: kernel/kexec_handover.c uses set_pageblock_migratetype() --- a/include/linux/page-isolation.h~mm-page_isolation-remove-migratetype-from-move_freepages_block_isolate-fix +++ a/include/linux/page-isolation.h @@ -45,6 +45,8 @@ void __meminit init_pageblock_migratetyp enum migratetype migratetype, bool isolate); +void set_pageblock_migratetype(struct page *page, enum migratetype migratetype); + bool pageblock_isolate_and_move_free_pages(struct zone *zone, struct page *page); bool pageblock_unisolate_and_move_free_pages(struct zone *zone, struct page *page); --- a/mm/page_alloc.c~mm-page_isolation-remove-migratetype-from-move_freepages_block_isolate-fix +++ a/mm/page_alloc.c @@ -525,8 +525,7 @@ void clear_pfnblock_bit(const struct pag * @page: The page within the block of interest * @migratetype: migratetype to set */ -static void set_pageblock_migratetype(struct page *page, - enum migratetype migratetype) +void set_pageblock_migratetype(struct page *page, enum migratetype migratetype) { if (unlikely(page_group_by_mobility_disabled && migratetype < MIGRATE_PCPTYPES)) _