From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6D9DC71136 for ; Tue, 17 Jun 2025 00:26:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4794C6B007B; Mon, 16 Jun 2025 20:26:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 42A146B0088; Mon, 16 Jun 2025 20:26:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3408E6B0089; Mon, 16 Jun 2025 20:26:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2607D6B007B for ; Mon, 16 Jun 2025 20:26:22 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7BE7D5EEB0 for ; Tue, 17 Jun 2025 00:26:21 +0000 (UTC) X-FDA: 83563000962.24.7631140 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf03.hostedemail.com (Postfix) with ESMTP id D469B20005 for ; Tue, 17 Jun 2025 00:26:19 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=eUJjYtNr; dmarc=none; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750119979; a=rsa-sha256; cv=none; b=m30mLai5WucWbtMxts4iZ05NMgDRdjGQeNiGHWiEYTX9w3AbkjsBcbbZh8T4VgH0qHY1YS Ax4jisF6RslzunbaN1ddA4b7Rdg6AbphzN/tmXreyioB/USAEdtxoWiDK7+JNV0Ed/3YMA /4ip04wGpkGqMyCJ/zkMri1qkooF0O4= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=eUJjYtNr; dmarc=none; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750119979; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n2MGmT/lfQRGCYiV1SLAJx57YEeU6XbFxQeWQfPsOy0=; b=34jSyOOqSc/EWqtf2upGAb6XVoTKXUdaTD+oSx4bLjZ0SyPbAIoLYc6et8k8L8YU3PwHJX XNNnb5VXHOAl06BVqdF3I7lWNP4ewmCEGpt6rnBtqnq3fHkfC/mOYEe3ZCpG3KQp2tESag CnY9SvOSgbF+H8YFsWhiI3e0A53W64s= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 26DD0629DF; Tue, 17 Jun 2025 00:26:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E0C6C4CEED; Tue, 17 Jun 2025 00:26:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1750119978; bh=1dNJ+Ka9TAbVHyjR2CGsnLlmTs2kKI7Ua3GjWXy7N04=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=eUJjYtNrlIBLqlVTJPk1mF/8PxhL3dnyjjgMetEL0b1iJhpvSaz4fDhoBdhuWDCXv F+HoxcdRNNdsUibp3ZyVi1+dg5Syv3skVvg7xTm2AQvwMOXtInY+yREkkxJ7Wlq2XV xR/OXyVVMPAAX7LBcmRuI0EM1sByMfKc4be/8YlA= Date: Mon, 16 Jun 2025 17:26:18 -0700 From: Andrew Morton To: Ujwal Kundur Cc: shuah@kernel.org, peterx@redhat.com, jackmanb@google.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v5 1/1] selftests/mm/uffd: Refactor non-composite global vars into struct Message-Id: <20250616172618.0609127a8b1e406d4c228d24@linux-foundation.org> In-Reply-To: <20250616100406.2853-1-ujwal.kundur@gmail.com> References: <20250501163827.2598-1-ujwal.kundur@gmail.com> <20250616100406.2853-1-ujwal.kundur@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Stat-Signature: arbfz7w6997hyf3gqfprby4p8sddo44o X-Rspamd-Queue-Id: D469B20005 X-Rspam-User: X-HE-Tag: 1750119979-66715 X-HE-Meta: U2FsdGVkX1/+tDr7zYd7L+uRMDGEYt2CLejVJO7pmjzSUY+Cl12utw/lP+axzimW9vD0zihEtsUUK41PARr5RnZAYfJf9I7OYSbpZAHaUImsjiZkISd7688fxZtXw5trT+eCPwLUoWLKv2YgFdGxpI4qGabMqBTKW4NbNQM6nMm5/tyF8aeOvCDJVlhfDnUZMLT25DY06V1sMdgiNUtyYAOE3HYN4OuNhi36t3VMPESUDtvX7sEVL1N1n/gpApczVWVJBgFqV+Jsmjkg/ohZVxkIH4ZBOERA7UyzIlHbKz5OJQTa0lMsCJfbEV0EY788dfI/LWSRIbrzB4Fk3TVYya61kpzcqWh37hfKYWSMmYNXSDiolr8YK/PU3zZkIoGiL41NNBxGx7X24/hUiAIKdYMHGsvSYXDY6JmbcWKudewuW2btgiIaiBewvdsMTu3UkYNXIawYwnveNkc3T0rYlr6sR9/iJmpEQshk23Hd1jliloU31cvkz8+192N2WdQdxcZgvFz0LHDg0++ZISSP1RTlJbjiblfnTR2mYzhG2Ya9hyykqrbnKaGoTw2avoIz6yfJxWw+PEHFVv4it+CrJsL544SWVfLAFwmVSazelkqiCZfm4hMWJISlMze+U/wiMoqxoTWXyEGCXRjlL0hSa0yY9Xw/Of9wzVe6Yt+GPuVux6D24H+2ALCve1BhBEmvtyfeICp4nopnzdGjA7nYxJaNILRM+MKZooIWgG8be53oFaO8Z/L0l/0d1/8IijmkaoN6pSe5yoxpkkd/ljw6qGno9Jk4/EclZPU0k4HbajuxY0SEh1SqRT6kvVjsu3KDeQ4RuIULGdGwFGmkEJllq7PtX6yyIRbapvgXL/3X5lnX1QggPCB0qeLfZrS4U1Tlr44gmEvkWV8FZf6RKZDtPHaewqcffTGjqazYXyHXh5dWIB8EylCmPDIuaHc3QGUQ2F6VM3QdiMZOsLWfE8J YOE/ulfp wWm0IgWV3B4RKVIX4LG2Q5rklrQE/XeFpUgyH7I6fNXMcfPtJ6Zj2zjOyXi74T/wd1DlU5k0q1KAAbM5OXupToemTDciuB0byPdXxCe+LV5dmaH419k06tEiKIU10pdZnbmkrNhlLUGdrlTp7HdXk6gMHAEfj/JzYzzzM+4I2PedpdPafd5j3rn6xL7ZR66IkzGvU5mYQiB6v17FOrPwfIWMpAAgWkqOFron3+ZiseqTBI97TFUOEoHl0A2DQnHC2/yA1PeKpOcNtBdMSdSSMn/PmaKUBz08+1GMmTFHqmSnm8zOU64IW8uynQ59SnYdYTKMqr59JWMZrUqbzcMgFIsMatQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 16 Jun 2025 15:34:06 +0530 Ujwal Kundur wrote: > Refactor macros and non-composite global variable definitions into a > struct that is defined at the start of a test and is passed around > instead of relying on global vars. Well I guess that's nicer. > 5 files changed, 616 insertions(+), 542 deletions(-) It needs to be! Thanks, I'll queue it for testing while Peter thinks about it :)