From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFCA6C71155 for ; Mon, 16 Jun 2025 16:07:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B7B46B009F; Mon, 16 Jun 2025 12:07:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 341086B00A0; Mon, 16 Jun 2025 12:07:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2301B6B00A1; Mon, 16 Jun 2025 12:07:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 109036B009F for ; Mon, 16 Jun 2025 12:07:25 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CE9DF16081E for ; Mon, 16 Jun 2025 16:07:24 +0000 (UTC) X-FDA: 83561743608.29.16845D7 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf29.hostedemail.com (Postfix) with ESMTP id 880CE12000F for ; Mon, 16 Jun 2025 16:07:22 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="j8XE/fBO"; spf=pass (imf29.hostedemail.com: domain of aboorvad@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=aboorvad@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750090042; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nH9dt8z0VyAEMb1ZczxG+YsmobDeOns6AKcYFv+gtvU=; b=k9h34K9tgXh8Om9bc6wBQNWfXQFMyYaKWdjvruDM/oqB2kla0xLWx9FbrA1G41JYg2vc5y ekRJVZdZXtgrr7sKSTo0gUnauLYukbjnnQ58qXii75fRl/hra29SMRbhLTcGun/uYMc8SQ SMdsThTQCcH93Uj9lQirbsGZWxoQXRk= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="j8XE/fBO"; spf=pass (imf29.hostedemail.com: domain of aboorvad@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=aboorvad@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750090042; a=rsa-sha256; cv=none; b=LbdSe7luvd76ZlhLmPVkFnRGP7ywNWdjZNQglqCoi5S6PRgGaLfscbLk42hoKRlBbQ9iif bUzLu+DSojpg6spLLLVJzjztXtMYpZ6OjYvyAc7iI4Yb1t/ShJzBJkJUCzpC4u66EZkKK1 lwWaJTPRW5uNXkNd9u/zZgHijGekFHg= Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55GCW689017455; Mon, 16 Jun 2025 16:07:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=nH9dt8z0VyAEMb1Zc zxG+YsmobDeOns6AKcYFv+gtvU=; b=j8XE/fBOXpk7jw+yqg8i3YBFb2XWl+hxC +E65t/IXuliJbfjb6wW8YGLdNizLNPBFjLkZin+N9b1/OHp5jzZhlclJxJZ7890p W6U4SEtv0DJz+cIhdBbXB6Vs0WH+5l6CFxdHstoFr2rlzlXFs1rIbbMZSiIsbLxW JQtgBijzy1hCoKTkS1DMXlvtbqqkduDHTLDAHv1V2PU1OLVIyM/HP2lraPhHJaqX 767c52iTb7+vxAk2IH7E7uKgbnc3Hyio4exX84aFC3b4FkguDLaJu1ycJhcku0+o PCIH+8Bbxejsi1SKq61v4VqC1D+p46YgZWKpUiHva2EdR4fyPnFyQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4794qp1x1d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Jun 2025 16:07:17 +0000 (GMT) Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 55GG0BYJ023302; Mon, 16 Jun 2025 16:07:16 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4794qp1x18-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Jun 2025 16:07:16 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 55GEWnwk014115; Mon, 16 Jun 2025 16:07:15 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 479p426hfn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Jun 2025 16:07:15 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 55GG7Csq51249434 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Jun 2025 16:07:12 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 09DF920040; Mon, 16 Jun 2025 16:07:12 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5306E2004B; Mon, 16 Jun 2025 16:07:06 +0000 (GMT) Received: from li-c18b6acc-24ee-11b2-a85c-81492619bda1.ibm.com.com (unknown [9.43.33.110]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 16 Jun 2025 16:07:06 +0000 (GMT) From: Aboorva Devarajan To: akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, shuah@kernel.org, pfalcato@suse.de, david@redhat.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, donettom@linux.ibm.com, ritesh.list@gmail.com, aboorvad@linux.ibm.com Subject: [PATCH 5/6] selftests/mm: Fix child process exit codes in KSM tests Date: Mon, 16 Jun 2025 21:36:31 +0530 Message-ID: <20250616160632.35250-6-aboorvad@linux.ibm.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250616160632.35250-1-aboorvad@linux.ibm.com> References: <20250616160632.35250-1-aboorvad@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: BPObgMJtaOVtje-umRyDLgbspwMrVjKs X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjE2MDEwMiBTYWx0ZWRfX6nTrU1NLvTfU 9FjQwT09hi5sewxcscv1y89bMcsvFk/j0JjTaG9sOUlhAtzy/RYw3L0BfUiVWkjQQ3hwdUa4fuU AAhw7zqzqvc4dgNAf8kNaoRuPez4HlDM1OX7icV6eZfX3rAyhnaIcIKVYOic+688JKVGuez0St0 iFfoQiCw+EvflimcUrNEP5UQB3rnEN+yVu2A8k1c4fRgmzE0p/DQDItZ1V6fdv1fW9d3OhkQ8Ps sxsy8rxl4c6bjEhRlVb9rrOMResD07P4cOXBXdNipJVLJRMqPbKvI2g0WdtIJsQtBZsHHdBP2QL jVfvzzzkmWh4D+HS1Wcn/rnzdrwQ/1ioOfG3+CoL91QhHDFoAuSz+Yprj5d0vLSNImKuvHb5joc SeAgkJLEK5qVCZ/POddfguTYTG2QaaH0GPC35CG8x5IdC5IjPDvtyFqpY/X9Kvg+7fcCz6hI X-Authority-Analysis: v=2.4 cv=NYfm13D4 c=1 sm=1 tr=0 ts=68504135 cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=6IFa9wvqVegA:10 a=VnNF1IyMAAAA:8 a=103AOF-ep-hNQpW6YsQA:9 X-Proofpoint-ORIG-GUID: 84_LTdBoX5QKoTcTK_OS2now3pT3bfQg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-16_08,2025-06-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 mlxscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 priorityscore=1501 malwarescore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506160102 X-Rspamd-Queue-Id: 880CE12000F X-Rspamd-Server: rspam07 X-Stat-Signature: a5c9j59s9mr6ua69f35w4oa58jefsens X-Rspam-User: X-HE-Tag: 1750090042-766145 X-HE-Meta: U2FsdGVkX18c5HizaD6MpXdcgg1mSeBiAHf4GSaY/HDqs/muKDvYuNDXRbHx5SOLSDr+8exfOceE+HI1Eu2GneflOhEqPtOyzrw+y+s/Rvh+x9pTpeMCh821YRv22tygNHoDV78ND82TUFDeAJmLIJD5uI47jmFgip+tVWXoeluJZK8/9jPBzjZSenMxXZjyephM/vjRqVTiDYKarJiWIPeq8YhqB7cuNNxSrPonTGGKAjidnkFt/RcFQbhdKjRJVbO/1yia4+2sVEeu1kDGoQ2BSDSyDVnLI4YfVpNFFdlSQzAB8oaSnfRwrH8Imvc8iB41fpg9NlyM5maypTQzwz0GWI/xXqevDXVbcvGGrtCTYrvwIzRPebEddMLDdt9xPhcK48cKYah4mS7myDwiYMef1rOyJeNDpH/Yi62pQCP1nI+FWedgiuQXQZnpzcoPjVPOzL1m2lbXj5Y8i0a4N8Eg5NVSHFxTCV3rk8S9RKl8yhxCEI5NiszT/dbyx/Hra1Tp+ViOZZL46ZVY3Kcp53EJwDFlUs+KR24XM20BzY3kDD6/FRAK0Us7ndPmNZE7XC0x89nLLW4+SwvBkljjBJFH/GJ6k4N5ci3RirJkYJFfPPxiY5UhoqlVkouh9O3pQN9DddFI1nwyJUlbbI8sWd1MgFxitWm+8NRJ/Klf3o0eEnVFb+gU9NCHgApVqUooRVyz9AktQlHTCBOR9Hc/Z5Ku9JbphG7U/gc59IMor4ZI+30ugXCSP/OWhayThVslbZWyhaCiYMmNUMpzdhwvAHU3/wM6wUOQ0oJurUvU0aBq/9PpsZp06HvM1CEk3BxPPI6hJta9+oHpUwV2UTpoWBPtJjqSTCilyycgXr43Kp0a1g72zSnNnfQoBwAGUNmDx4qcytTkqLpfOrTGXc/Yi+8JRHhmInmoEA2PzcsiL+tvKM03cvWQnGO6v2XI22z2GXla14X3YkteaHV7P2+ 4+T/kE46 7/kqA881rONNS9r8aSCUOvJoHLonU8YhMkxvoK+yBzoNbI+Lelh+ENM2ZbZn2Z/bHkytXaip1yujCg9ydoYviyzfy2NIrDcDo+OqkJyHeoVjLklVLGqeojLQ7Ah9VEIF9BjuyJA6TObBT/1I8HnRZq+Jm2Vv9f2DiFtAdcfe9o6E/EfjFmq9KFyYz04DPGIIBhXswDfG1pN442hLbED4SvSMqTHBmldYdKGoOLavGffAs5tdPq2RFk3fvX6Tya4eCqlZLC76JvZnVSiW6hEh6yUu/w7FfkLlRGr3vDSUlgfwk81CSlb4TKgpLGBXpBINvqneaBwPTNffbdDb1mqljg8b6aswNKZSQzS8CPyb//bzgJ4k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In the KSM functional tests, test_child_ksm() returned negative values to indicate errors. However, when passed to exit(), these were interpreted as large unsigned values (eg, -2 became 254), leading to incorrect handling in the parent process. As a result, some tests appeared to be skipped or silently failed. This patch changes test_child_ksm() to return positive error codes (1, 2, 3) and updates test_child_ksm_err() to interpret them correctly. This ensures the parent accurately detects and reports child process failures. Before patch: - [RUN] test_unmerge ok 1 Pages were unmerged ... - [RUN] test_prctl_fork - No pages got merged - [RUN] test_prctl_fork_exec ok 7 PR_SET_MEMORY_MERGE value is inherited ... Bail out! 1 out of 8 tests failed - Planned tests != run tests (9 != 8) - Totals: pass:7 fail:1 xfail:0 xpass:0 skip:0 error:0 After patch: - [RUN] test_unmerge ok 1 Pages were unmerged ... - [RUN] test_prctl_fork - No pages got merged not ok 7 Merge in child failed - [RUN] test_prctl_fork_exec ok 8 PR_SET_MEMORY_MERGE value is inherited ... Bail out! 2 out of 9 tests failed - Totals: pass:7 fail:2 xfail:0 xpass:0 skip:0 error:0 Signed-off-by: Aboorva Devarajan --- tools/testing/selftests/mm/ksm_functional_tests.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/testing/selftests/mm/ksm_functional_tests.c b/tools/testing/selftests/mm/ksm_functional_tests.c index 6ea50272a0ba..230c21c72f3e 100644 --- a/tools/testing/selftests/mm/ksm_functional_tests.c +++ b/tools/testing/selftests/mm/ksm_functional_tests.c @@ -488,14 +488,14 @@ static int test_child_ksm(void) /* Test if KSM is enabled for the process. */ if (prctl(PR_GET_MEMORY_MERGE, 0, 0, 0, 0) != 1) - return -1; + return 1; /* Test if merge could really happen. */ map = __mmap_and_merge_range(0xcf, size, PROT_READ | PROT_WRITE, KSM_MERGE_NONE); if (map == MAP_MERGE_FAIL) - return -2; + return 2; else if (map == MAP_MERGE_SKIP) - return -3; + return 3; ksm_unmerge(); munmap(map, size); @@ -504,11 +504,11 @@ static int test_child_ksm(void) static void test_child_ksm_err(int status) { - if (status == -1) + if (status == 1) ksft_test_result_fail("unexpected PR_GET_MEMORY_MERGE result in child\n"); - else if (status == -2) + else if (status == 2) ksft_test_result_fail("Merge in child failed\n"); - else if (status == -3) + else if (status == 3) ksft_test_result_skip("Merge in child skipped\n"); } -- 2.43.5