From: Aboorva Devarajan <aboorvad@linux.ibm.com>
To: akpm@linux-foundation.org, Liam.Howlett@oracle.com,
lorenzo.stoakes@oracle.com, shuah@kernel.org, pfalcato@suse.de,
david@redhat.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com,
npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com,
baohua@kernel.org
Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, donettom@linux.ibm.com,
ritesh.list@gmail.com, aboorvad@linux.ibm.com
Subject: [PATCH 5/6] selftests/mm: Fix child process exit codes in KSM tests
Date: Mon, 16 Jun 2025 21:36:31 +0530 [thread overview]
Message-ID: <20250616160632.35250-6-aboorvad@linux.ibm.com> (raw)
In-Reply-To: <20250616160632.35250-1-aboorvad@linux.ibm.com>
In the KSM functional tests, test_child_ksm() returned negative values
to indicate errors. However, when passed to exit(), these were
interpreted as large unsigned values (eg, -2 became 254), leading to
incorrect handling in the parent process. As a result, some tests
appeared to be skipped or silently failed.
This patch changes test_child_ksm() to return positive error codes
(1, 2, 3) and updates test_child_ksm_err() to interpret them correctly.
This ensures the parent accurately detects and reports child process
failures.
Before patch:
- [RUN] test_unmerge
ok 1 Pages were unmerged
...
- [RUN] test_prctl_fork
- No pages got merged
- [RUN] test_prctl_fork_exec
ok 7 PR_SET_MEMORY_MERGE value is inherited
...
Bail out! 1 out of 8 tests failed
- Planned tests != run tests (9 != 8)
- Totals: pass:7 fail:1 xfail:0 xpass:0 skip:0 error:0
After patch:
- [RUN] test_unmerge
ok 1 Pages were unmerged
...
- [RUN] test_prctl_fork
- No pages got merged
not ok 7 Merge in child failed
- [RUN] test_prctl_fork_exec
ok 8 PR_SET_MEMORY_MERGE value is inherited
...
Bail out! 2 out of 9 tests failed
- Totals: pass:7 fail:2 xfail:0 xpass:0 skip:0 error:0
Signed-off-by: Aboorva Devarajan <aboorvad@linux.ibm.com>
---
tools/testing/selftests/mm/ksm_functional_tests.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tools/testing/selftests/mm/ksm_functional_tests.c b/tools/testing/selftests/mm/ksm_functional_tests.c
index 6ea50272a0ba..230c21c72f3e 100644
--- a/tools/testing/selftests/mm/ksm_functional_tests.c
+++ b/tools/testing/selftests/mm/ksm_functional_tests.c
@@ -488,14 +488,14 @@ static int test_child_ksm(void)
/* Test if KSM is enabled for the process. */
if (prctl(PR_GET_MEMORY_MERGE, 0, 0, 0, 0) != 1)
- return -1;
+ return 1;
/* Test if merge could really happen. */
map = __mmap_and_merge_range(0xcf, size, PROT_READ | PROT_WRITE, KSM_MERGE_NONE);
if (map == MAP_MERGE_FAIL)
- return -2;
+ return 2;
else if (map == MAP_MERGE_SKIP)
- return -3;
+ return 3;
ksm_unmerge();
munmap(map, size);
@@ -504,11 +504,11 @@ static int test_child_ksm(void)
static void test_child_ksm_err(int status)
{
- if (status == -1)
+ if (status == 1)
ksft_test_result_fail("unexpected PR_GET_MEMORY_MERGE result in child\n");
- else if (status == -2)
+ else if (status == 2)
ksft_test_result_fail("Merge in child failed\n");
- else if (status == -3)
+ else if (status == 3)
ksft_test_result_skip("Merge in child skipped\n");
}
--
2.43.5
next prev parent reply other threads:[~2025-06-16 16:07 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 16:06 [PATCH 0/6] selftests/mm: Fix false positives and skip unsupported tests Aboorva Devarajan
2025-06-16 16:06 ` [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues Aboorva Devarajan
2025-06-16 16:27 ` Dev Jain
2025-06-18 10:06 ` Donet Tom
2025-06-18 10:35 ` Dev Jain
2025-06-18 11:22 ` Lorenzo Stoakes
2025-06-18 11:28 ` Dev Jain
2025-06-18 11:37 ` Lorenzo Stoakes
2025-06-18 11:45 ` Dev Jain
2025-06-18 11:57 ` Lorenzo Stoakes
2025-06-18 11:59 ` Lorenzo Stoakes
2025-06-18 13:58 ` Dev Jain
2025-06-18 14:07 ` Lorenzo Stoakes
2025-06-18 14:17 ` Dev Jain
2025-06-18 14:35 ` Lorenzo Stoakes
2025-06-18 14:43 ` Dev Jain
2025-06-19 8:23 ` Donet Tom
2025-06-19 9:02 ` Dev Jain
2025-06-19 15:31 ` Donet Tom
2025-06-19 16:14 ` Dev Jain
2025-06-20 14:45 ` Dev Jain
2025-06-21 17:55 ` Donet Tom
2025-06-23 4:53 ` Dev Jain
2025-06-23 4:55 ` Dev Jain
2025-06-23 17:32 ` Donet Tom
2025-06-24 6:15 ` Dev Jain
2025-06-25 9:36 ` Donet Tom
2025-06-25 10:45 ` Dev Jain
2025-06-25 12:52 ` Dev Jain
2025-06-25 17:17 ` Donet Tom
2025-06-26 3:57 ` Dev Jain
2025-06-26 5:42 ` Donet Tom
2025-06-26 5:55 ` Dev Jain
2025-06-26 6:35 ` Dev Jain
2025-06-26 6:52 ` Donet Tom
2025-06-18 11:50 ` Lorenzo Stoakes
2025-06-16 16:06 ` [PATCH 2/6] selftest/mm: Fix ksm_funtional_test failures Aboorva Devarajan
2025-06-16 17:04 ` Liam R. Howlett
2025-06-17 15:10 ` donettom
2025-06-16 16:06 ` [PATCH 3/6] selftests/mm : fix test_prctl_fork_exec failure Aboorva Devarajan
2025-06-16 16:28 ` Dev Jain
2025-06-17 15:04 ` donettom
2025-06-16 16:06 ` [PATCH 4/6] mm/selftests: Fix split_huge_page_test failure on systems with 64KB page size Aboorva Devarajan
2025-06-16 16:06 ` Aboorva Devarajan [this message]
2025-06-16 16:06 ` [PATCH 6/6] selftests/mm: Mark thuge-gen as skipped if shmmax is too small or no 1G pages Aboorva Devarajan
2025-06-16 16:11 ` [PATCH 0/6] selftests/mm: Fix false positives and skip unsupported tests Lorenzo Stoakes
2025-06-17 7:53 ` Aboorva Devarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250616160632.35250-6-aboorvad@linux.ibm.com \
--to=aboorvad@linux.ibm.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=dev.jain@arm.com \
--cc=donettom@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=npache@redhat.com \
--cc=pfalcato@suse.de \
--cc=ritesh.list@gmail.com \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox