From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9CF9C71155 for ; Mon, 16 Jun 2025 16:07:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4EF6D6B0096; Mon, 16 Jun 2025 12:07:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 451D96B0098; Mon, 16 Jun 2025 12:07:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 319B66B0099; Mon, 16 Jun 2025 12:07:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1E6DF6B0096 for ; Mon, 16 Jun 2025 12:07:01 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B444A1407EB for ; Mon, 16 Jun 2025 16:07:00 +0000 (UTC) X-FDA: 83561742600.25.FC8BD82 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf08.hostedemail.com (Postfix) with ESMTP id 66B8516000E for ; Mon, 16 Jun 2025 16:06:58 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=mKrFUSEX; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf08.hostedemail.com: domain of aboorvad@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=aboorvad@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750090018; a=rsa-sha256; cv=none; b=S6xTCmkNNQa0/t1biBNS0jvYdMDb/kNvPiWDpG3wA06u23LKAieItj7wOJrGzezSm2vPsi Uh2Rq/TcvMyxqyMKk9aOVjX/IwsrLUDIcrX9SefokEH+uJE7NaBKeZiltN61PRzLf7Ieos AjRH41sijukQnSAqZSO22LYn94PBTQM= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=mKrFUSEX; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf08.hostedemail.com: domain of aboorvad@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=aboorvad@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750090018; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gnb8gT4f9/b+H6cn3hiFT7Ob32zrk4dZrwq1ZTZHFkU=; b=cs8tHUTpCPdbQvUza6wrH68oymWKEK8gFLCMYuUnzVZ8HuS1sFObwHpA5q7614GPBVxh1b oQYmFPeQ4SWyYW3p/GHyxZhahW4Tgkz874MRuhoZD1iCuT6vMZ43YsJd6YMdH7iz2cNdsy bh9+05NDKjGBtrORf1eJUnRRDU31DsM= Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55G84HVG014238; Mon, 16 Jun 2025 16:06:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=gnb8gT4f9/b+H6cn3 hiFT7Ob32zrk4dZrwq1ZTZHFkU=; b=mKrFUSEXI4g/5YlUynL6xARLlxvoHpDpr GcuyRmQnKjgO2YosAvoUrfXqMQ9QtJGYxmOjrdOKoCtp5IzrA9d0hiqnwUU1kYI9 /zZUpGnm7JiK4nfswyNEoI99msAjwisqmPlT9Tvydvjf8zOd3AQchPVwTeh4HQAM rfW4eSBKOcOS12pAQOz1ewT5537raGy3ZXmVEWw52vfnCQY46ahFMhSCzYML91ok C4c/cLQo+gpeE3RZYVBSDrNFpmxr4wl4Yks2ND59rC9V6LScM4Ux9hqlrRrgfkbJ zQP0Y4yyBUOBqg0je1geY1Ug1aGPxd5tNki6iO3ZW8LTt0apMQt+A== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 478ygn2vrw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Jun 2025 16:06:51 +0000 (GMT) Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 55GFumVA020812; Mon, 16 Jun 2025 16:06:50 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 478ygn2vrr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Jun 2025 16:06:50 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 55GEXo5r014278; Mon, 16 Jun 2025 16:06:50 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 479p426he5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Jun 2025 16:06:49 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 55GG6kEI55640444 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Jun 2025 16:06:46 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5DD7020043; Mon, 16 Jun 2025 16:06:46 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A8EDD20040; Mon, 16 Jun 2025 16:06:40 +0000 (GMT) Received: from li-c18b6acc-24ee-11b2-a85c-81492619bda1.ibm.com.com (unknown [9.43.33.110]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 16 Jun 2025 16:06:40 +0000 (GMT) From: Aboorva Devarajan To: akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, shuah@kernel.org, pfalcato@suse.de, david@redhat.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, donettom@linux.ibm.com, ritesh.list@gmail.com, aboorvad@linux.ibm.com Subject: [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues. Date: Mon, 16 Jun 2025 21:36:27 +0530 Message-ID: <20250616160632.35250-2-aboorvad@linux.ibm.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250616160632.35250-1-aboorvad@linux.ibm.com> References: <20250616160632.35250-1-aboorvad@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjE2MDEwMiBTYWx0ZWRfX7L2TRUDsmRl/ /89I6QgAP3J0o6JXB66T3RtTOFDbAb7PH743/bnWGmFK+hkjXgTEZnMAYnGS914Gf36OgiaQpLy VvKE05H7HeNBHfc71cGGuxpzgQuevp59Hnvt7UldyUBc8ooeVxOoudSrJymltjeS6MdIP8vL9Mc 9lyivoEGcoC2s3zNUiXIThEZPNFhy+1BdGokk8vd0mpMVD12vq+ADQnL+BgEXWSlro6lHlWStQy LRJkUq3QnC+XeYXt83TvxYwXnlvX3KR8XR8Fq6O1W6daMG8Re5SIYryLjMTONI0Scea+AGpYXIM D/u+04szly/omVCtF+1Kp0xdefQPO4QnleDCuVbRlGppOLlFoq6V5ei/of/0yi0YgP+jITp/Bjz 1pjUXN6m6suo7COlrs//rDc3kgf4EcQ0IKWaublSwfZ6UrOJamcX9074Hk4vX7IV2DStmci6 X-Authority-Analysis: v=2.4 cv=fYSty1QF c=1 sm=1 tr=0 ts=6850411b cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=6IFa9wvqVegA:10 a=VnNF1IyMAAAA:8 a=0_35Z4S1ohBUcDDc-C8A:9 X-Proofpoint-ORIG-GUID: guKlIXlpthdCmbceel_anr-JnwHYfwfF X-Proofpoint-GUID: R_JBOrA5584VdThZW0qVwm_HUw4E4Mtb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-16_08,2025-06-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 spamscore=0 mlxlogscore=999 lowpriorityscore=0 adultscore=0 mlxscore=0 impostorscore=0 bulkscore=0 phishscore=0 clxscore=1011 priorityscore=1501 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506160102 X-Rspamd-Server: rspam01 X-Stat-Signature: sxph6owdegn391i4beqjof613dixxbip X-Rspamd-Queue-Id: 66B8516000E X-Rspam-User: X-HE-Tag: 1750090018-394329 X-HE-Meta: U2FsdGVkX19YBmcFwA23IQHzYX1ZN7YljIlK6MkHk63+BR6GTYS8L04WU2TTUWjyiQY/uwdxbJwb0HpONRm2xmWyeEEy04EQQjnTNVflzb92RlFhghtDH+AnRv+lJIvj1e1YJDIBMqGs1T4Wj/Rcy9/y3N3DKgdJlWk0/oC3A66oS2Bd30J0RDd0y1VYEo7ZNHkCgWPkldtX5CXKUv8LQX47hfzQvfeyHFcUppGVJL+oB47dgsVXBz+9KPiB7+N0bKQmdnJWZEx0a1pKWfkFiZjdS97OAszQr9w/FY/uBsbyWK8iDxjxFMXZiWjy2IjavAgwDjNiKRlzJaClxuEAeXgIiJgJEbUuthpeMZIzkENjp5gjpe3eKinu7ih9sJUVkimrJerTcugtJzKiui652ITuXbZdHRyiHxavnaAR2Sc4KJ5L+a0LD3IUYk8psDl51I7/JxqsMnmqLnLJWjpQ9BUxNTxB/J20WIPJmRrAFHhPuXHWgzWhHSXKC2kLWQEROg1mJko67NiqTCzUJfrSkm0DSZFHBka2QXqPjolV+tHk+rWe78Q2WyVRV6HCMu0oojf21pDr7Bw5oTz7plKzboWHzGLO2uFw2mMwAafIdhOdXzr28EYxLSQl39IrdKczmiLWRvOKJHOV6KOgpnmbXoo1X3pSg5oYYo9j4PAHf44IhegwO/YdJa4Ux2an70kRgqdanXFTiu14wzgz6cUfGxiG/OldUWjjkiuw0wm8PnHEX/NUU5wVLEsUHc2oqTgfsO0W89BI0VF74OxEVwcexyMdbjI/D5crqZ6s6kiz7ezpQojq0XUsweU0McIEGSLEXMj5X3Xyld9AVvnRUu4nOk08SmheuNPGNn8dvML/3YqW8GIGYfj7WMfa59foeJ5spEOlqLilsIPKf/fIy+k+kXVruFhBn7yvIjbNJyyM1KVjpJ2tjycRI694jmQqzE0rXRLVJPMZ9m6tYgSy4nq 9N+w52st dvlSRDcLYCYnuZt7ysVxmL+jPEJo38mRotHVPTUM7ljMyxwmbUxVJ6yOs8Xtju+fJ0OfDYg2zwG4UcdoZYm5s6PYjwQxgSZ5v22cBh3wq8oUF+gu+fGK+d7HxWDQD3ThX4IiCzSAUukQyiqtw4rpmvjVo8HJNU1TvksoNMRJEro/QtpGTr0H7lW1EBVjkmjhf1lYLhIQJV4+iaCbrHUPy4ygib0E2SSdnWETP8mkpYmuiW4dFi3HDxjr8+Kz4dSUIiVUfyeoEN0tbO6yzvjLeVpFqBrZCZNr+n3VefIjiv/uqOslO0Edow7Eglf1cHxlKXLPGXtmJVPdJJBX6z85CV7QXNSrvwn3OlGth4PVaRRqzG94i6WlS7igRfv4woSBqWyH+X0+tBpK/ONfgURfQqOXoll4zCYHFy1yZteLcXVSa5OVxX/XPq9NLMF7Igj/Izik7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Donet Tom In this patch, we are fixing three issues in the virtual_address_range test. 1. validate_addr() checks if the allocated address is within the range. In the current implementation, if addr is greater than HIGH_ADDR_MARK, the test fails. However, addr will be greater than HIGH_ADDR_MARK if high_addr is set. Therefore, if high_addr is set, we should not check the (addr > HIGH_ADDR_MARK) condition. 2.In main(), the high address is stored in hptr, but for mark_range(), the address passed is ptr, not hptr. Fixed this by changing ptr[i] to hptr[i] in mark_range() function call. 3./proc/self/maps may not always have gaps smaller than MAP_CHUNK_SIZE. The gap between the first high address mapping and the previous mapping is not smaller than MAP_CHUNK_SIZE. $cat /proc/3713/maps 10000000-10010000 r-xp 00000000 fd:00 36140094 10010000-10020000 r--p 00000000 fd:00 36140094 10020000-10030000 rw-p 00010000 fd:00 36140094 4ee80000-4eeb0000 rw-p 00000000 00:00 0 578f0000-57c00000 rw-p 00000000 00:00 0 57c00000-7fff97c00000 r--p 00000000 00:00 0 7fff97c00000-7fff97e20000 r-xp 00000000 fd:00 33558923 7fff97e20000-7fff97e30000 r--p 00220000 fd:00 33558923 7fff97e30000-7fff97e40000 rw-p 00230000 fd:00 33558923 7fff97f40000-7fff98020000 r-xp 00000000 fd:00 33558924 7fff98020000-7fff98030000 r--p 000d0000 fd:00 33558924 7fff98030000-7fff98040000 rw-p 000e0000 fd:00 33558924 7fff98050000-7fff98090000 r--p 00000000 00:00 0 7fff98090000-7fff980a0000 r-xp 00000000 00:00 0 7fff980a0000-7fff980f0000 r-xp 00000000 fd:00 2634 7fff980f0000-7fff98100000 r--p 00040000 fd:00 2634 7fff98100000-7fff98110000 rw-p 00050000 fd:00 2634 7fffcf8a0000-7fffcf9b0000 rw-p 00000000 00:00 0 1000000000000-1000040000000 r--p 00000000 00:00 0 --> High Addr 2000000000000-2000040000000 r--p 00000000 00:00 0 4000000000000-4000040000000 r--p 00000000 00:00 0 8000000000000-8000040000000 r--p 00000000 00:00 0 e800098110000-fffff98110000 r--p 00000000 00:00 0 $ In this patch, the condition that checks for gaps smaller than MAP_CHUNK_SIZE has been removed. Fixes: d1d86ce28d0f ("selftests/mm: virtual_address_range: conform to TAP format output") Fixes: b2a79f62133a ("selftests/mm: virtual_address_range: unmap chunks after validation") Fixes: 010409649885 ("selftests/mm: confirm VA exhaustion without reliance on correctness of mmap()") Signed-off-by: Donet Tom Signed-off-by: Aboorva Devarajan --- tools/testing/selftests/mm/virtual_address_range.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/tools/testing/selftests/mm/virtual_address_range.c b/tools/testing/selftests/mm/virtual_address_range.c index b380e102b22f..606e601a8984 100644 --- a/tools/testing/selftests/mm/virtual_address_range.c +++ b/tools/testing/selftests/mm/virtual_address_range.c @@ -80,7 +80,7 @@ static void validate_addr(char *ptr, int high_addr) if (high_addr && addr < HIGH_ADDR_MARK) ksft_exit_fail_msg("Bad address %lx\n", addr); - if (addr > HIGH_ADDR_MARK) + if (!high_addr && addr > HIGH_ADDR_MARK) ksft_exit_fail_msg("Bad address %lx\n", addr); } @@ -117,7 +117,7 @@ static int validate_lower_address_hint(void) static int validate_complete_va_space(void) { - unsigned long start_addr, end_addr, prev_end_addr; + unsigned long start_addr, end_addr; char line[400]; char prot[6]; FILE *file; @@ -134,7 +134,6 @@ static int validate_complete_va_space(void) if (file == NULL) ksft_exit_fail_msg("cannot open /proc/self/maps\n"); - prev_end_addr = 0; while (fgets(line, sizeof(line), file)) { const char *vma_name = NULL; int vma_name_start = 0; @@ -151,12 +150,6 @@ static int validate_complete_va_space(void) if (start_addr & (1UL << 63)) return 0; - /* /proc/self/maps must have gaps less than MAP_CHUNK_SIZE */ - if (start_addr - prev_end_addr >= MAP_CHUNK_SIZE) - return 1; - - prev_end_addr = end_addr; - if (prot[0] != 'r') continue; @@ -223,8 +216,7 @@ int main(int argc, char *argv[]) if (hptr[i] == MAP_FAILED) break; - - mark_range(ptr[i], MAP_CHUNK_SIZE); + mark_range(hptr[i], MAP_CHUNK_SIZE); validate_addr(hptr[i], 1); } hchunks = i; -- 2.43.5