From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99EDFC71155 for ; Mon, 16 Jun 2025 14:38:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D0EA6B008A; Mon, 16 Jun 2025 10:38:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A8336B00B8; Mon, 16 Jun 2025 10:38:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E5146B00BE; Mon, 16 Jun 2025 10:38:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2167F6B008A for ; Mon, 16 Jun 2025 10:38:11 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 036C6100B55 for ; Mon, 16 Jun 2025 14:38:10 +0000 (UTC) X-FDA: 83561518782.17.46D7FC1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id 3558F180007 for ; Mon, 16 Jun 2025 14:38:08 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=tdHsLx6i; spf=none (imf06.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750084689; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hhI/PPdrsCZfn56an+dU/qpyarTHRiW4AXw4sUGA6jQ=; b=xiM6wJ2tvu0RpRTLtkT+9iPoFKnoLEiBaT14BKUnK7L+VHVHppHKXNGV0+dKowKjw86ow/ xxFieDX+v6kOVP11kAEXC5KMr43gvB9Xx5sFjY7EAcXdOxm+5yL94oZiXkfpfFobBRS5Uc GWrburGytTUXxJbm3mQM+9PDZ+Vok8E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750084689; a=rsa-sha256; cv=none; b=nBXZRKLgN3KKTtDr59w1RFFKzp8aYw8Xg/lSJU7Q99L+nClt5CmOo6VJamHFPppPqdzFtt BnHaThd2s6cj26ztKoWmNu5gIIDAEYVFAfUXxZem5fympkup/nAwJ26ZGMRcAan4Z0envq s82MAcOJOC7A5vPf463iMrj72gNoc0E= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=tdHsLx6i; spf=none (imf06.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hhI/PPdrsCZfn56an+dU/qpyarTHRiW4AXw4sUGA6jQ=; b=tdHsLx6iYe1NyDwqwSSSWFgw5i qJHHTZRjffKbyioR1iSxbGu7PNvhKHmti48JaC1ggQaLyuWrWSB9QtXZO7nc+ad1vL0e5EvUvVaOk Dm3RfsmZoOs9D7j8HGRxoKZN+Uy9GBUm2h8sJm1PCAZDnLbqzgfhFZIskDEAU9PUMg4uUPbgLAKF8 09Jmrq9sYWaxAxN24JdFAeupsS630FmO0mxaU0VG52p9uWWlgxcN7KpTTvB2IdSPLkJN61gAw6hAN LG/tcGsUgQJlhA9Tqfc6Y/I1Wptv7FqaMiHIjIvfW/ZTL/hyrIs2JTkiV9nU0LxmGFEE+f8za0F9T GajdUQQA==; Received: from 2001-1c00-8d82-d000-266e-96ff-fe07-7dcc.cable.dynamic.v6.ziggo.nl ([2001:1c00:8d82:d000:266e:96ff:fe07:7dcc] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1uRAyH-0000000G3SR-3dxy; Mon, 16 Jun 2025 14:38:01 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 7C35030D551; Mon, 16 Jun 2025 16:38:00 +0200 (CEST) Date: Mon, 16 Jun 2025 16:38:00 +0200 From: Peter Zijlstra To: Dave Hansen Cc: Ankur Arora , linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, mjguzik@gmail.com, luto@kernel.org, acme@kernel.org, namhyung@kernel.org, tglx@linutronix.de, willy@infradead.org, jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com Subject: Re: [PATCH v4 10/13] x86/mm: Simplify clear_page_* Message-ID: <20250616143800.GE1613376@noisy.programming.kicks-ass.net> References: <20250616052223.723982-1-ankur.a.arora@oracle.com> <20250616052223.723982-11-ankur.a.arora@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 3558F180007 X-Stat-Signature: cufg9uaxhf7jrz864fsnhit5ymh9j963 X-HE-Tag: 1750084688-30005 X-HE-Meta: U2FsdGVkX1/+xkWAqbFrWsjLO9OcM1kWgRa1DF6nsqFn4khmt18CuqWp45fXA1B2n2OEyJoY/T9Dh4Kgyd+9hSzw3h/ha+cYSjRSz+QziaRBETE84/1Q2/p+VVUrocPhwaNT9h/U78YX79mX4SvubNAlsKgf85glLSf/MPHEm+iukUOG6IFK0BNhaZLxcMzfcR7p1Q2YC3xv0lqxtnfoM+oKDoFP/3FPaDNuzin2k8ujDhzx8rAu2Amn4GKHw7rgWXJPIS38gTLYWZSrwGM2ljfYHCBImMsMlqDUlyKv/KnoEWqiarbmZD78D+5ycqnOxOns5TFIaxZ7Tq3aP7380L62CUsN3r1BL59asbCExi5BmdrxyZEoSfEvmCXxonZD172iiSE0pqoPQNkTMyVmewsB0N6BfWw0Xxf4AZvw8MlCSI6Ue4leSwvEpnlytimCGqs01SGqMns1eDjUSvd/Pl+OG7hxAbUAubE6upd0iR1Q0twkOhdO7S9+q36hfF7SPHUdWQN+bTLB2aZrM5ZxlEQUsa/HiF4F9mmITDnuS7vivEkGULToT8qPVhTXBGXXQkLvXvBDYZZ69jB4sKPXwfrVTtiQ0JJXJQ94GTpFAK9d5vVnebHRxtSLcnpkT2aI5V8STOglP128Zlo5PUVskaBPujzEBHgh5/50zv6604YVXf0BpLSKsxM+gQMXlqz1XmTA2ZpSK496p/1bYAi3csK2uQTEzeJpTQyS4gAokZNAFUgUkeGjD4RB27sDYuf6/75MkGGQdZuuzNZt8c1fZRtds47NmEcjyOmGiDVbFdaP+YfrpJRTTC6AIYrVZOhCSiaFY4/lMPyiNcj8OH3KFbUCKwcH0KoyNT0Ky+AFROdag0X1xtamMGf+Qs8giL7chwbGW6b0OQAQjx31Xt2nZ4QqgvB/GtfHKRQSFFNOAfhvmGXSKwjbDvUMAG5hc8vlChbomEDUcbaiR0xW5zt a7xssagf CJVbJe1SGDWQHXczH68XMA7YftnYzBSL7031fdEWi1Tjv+ASjXoCb3M3RVhRLfP4Apv+m0nn19tpmD/3ulPjioRJXuEy/NpkNVuWXAOJicySnumIRn253RwAMhJ69FB9gLFk/xX39rn31EKnwxV7IET9/7GWWLPmgWkL6nfaJvjszEd7jnOTOYKCo2YLPxpgqrRt2J6Po0idqroNc6nuumSRUf15K4W+lfQTSRbNIghlP/YReUJkAAU4uq3eSPsUl/sw0TZ6LMye5tRo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 16, 2025 at 07:35:48AM -0700, Dave Hansen wrote: > On 6/15/25 22:22, Ankur Arora wrote: > > clear_page_rep() and clear_page_erms() are wrappers around "REP; STOS" > > variations. Inlining gets rid of the costly call/ret (for cases with > > speculative execution related mitigations.) > > Could you elaborate a bit on which "speculative execution related > mitigations" are so costly with these direct calls? Pretty much everything with RETHUNK set I would imagine.