From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DA2DC71155 for ; Mon, 16 Jun 2025 13:52:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4414C6B00C3; Mon, 16 Jun 2025 09:52:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F2046B00C4; Mon, 16 Jun 2025 09:52:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B9CB6B00C5; Mon, 16 Jun 2025 09:52:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1849C6B00C3 for ; Mon, 16 Jun 2025 09:52:50 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E85F9B9097 for ; Mon, 16 Jun 2025 13:52:49 +0000 (UTC) X-FDA: 83561404458.08.8D80426 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf26.hostedemail.com (Postfix) with ESMTP id BEC12140005 for ; Mon, 16 Jun 2025 13:52:47 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="uWPq5lR/"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=zicGrzhX; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="OMTLI/J+"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=CDZtJo7q; spf=pass (imf26.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750081968; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MMNHuzJzJyLgWzan34Wy5D6D68B1qu0nQ6rptGO5Izg=; b=CZktKOx5/P0eX/VRh1zs68bnBeYFaGr8eW7QGIED2KNHydo8E16G+1scRNEdz+Rn0gSYlo LlIOT4rFqVH9uZg7rpYxKRC0d/abKCK+IcujHAdfKaMOopWL8rStqyigU/zFGGpjFlIwhL BYZdH4ZzzjR7YgKj5mG77X+PgoCV95A= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="uWPq5lR/"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=zicGrzhX; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="OMTLI/J+"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=CDZtJo7q; spf=pass (imf26.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750081968; a=rsa-sha256; cv=none; b=I2UdzkDZY9N/p5YsFK2e85WXNCybcD6MjfLEvyFDeEYyy4zMf9pjPFYuWvzikLwx+/1gx/ hojie2iWNgQ6sA+BSub1fdTXGCiCp8DlrrLCwPhwzR/QtRoa6TQUEn5EKs3ovuy9Y2CWeU ndpJKz7HAUSv4h9ePBdgBn4CvtFR/4Y= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A085B1F795; Mon, 16 Jun 2025 13:52:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750081945; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MMNHuzJzJyLgWzan34Wy5D6D68B1qu0nQ6rptGO5Izg=; b=uWPq5lR/MqJgsqJ9Xy1C42kaxyPBOZexy5GaOuLHvV2ZITdZRuCB+yuVS2w2lebJsEXoQO pe9/d9cGp76ek9gNZ7epVBeBY/Fot5w+h2pdwyP8WsLyBpgzD6v2Jn/6zzX3pzdfCNJUbw wpO07FJ+l6VDMJWFFNTMte5icaR+8p8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750081945; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MMNHuzJzJyLgWzan34Wy5D6D68B1qu0nQ6rptGO5Izg=; b=zicGrzhXg35a5TMjMYSfxrwqsc4YBXuWRWqH4LeiQBuDPNh/SHRJwqutXBU0/5dFSbeLkC /cncPPPaJirN1XAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750081940; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MMNHuzJzJyLgWzan34Wy5D6D68B1qu0nQ6rptGO5Izg=; b=OMTLI/J+HvudeExzLCThCmv/z1Smeqcq6K2h19mA4GoZifmmjyYpFOfL+S8Nwhn5NM1BZw RVkQkRgRU82pkkgsWvLnMaqeIDG5WVbfTUdq6R2DJ8AU8i0eU8rg1WmuTQ8rWiwmkkwUPa 5k1CicByJs12LHZX+tv4j2Sa81QuJ/s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750081940; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MMNHuzJzJyLgWzan34Wy5D6D68B1qu0nQ6rptGO5Izg=; b=CDZtJo7qiCAidLzaZ+PMRDTJQ3kJdIx5Yq/TkvVNhbNLBpasjfMdVoPDhc06tbvN+q4BHf h/DZSOvUm4l/vFDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 85E8613AE1; Mon, 16 Jun 2025 13:52:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id QEUWHo0hUGhHLwAAD6G6ig (envelope-from ); Mon, 16 Jun 2025 13:52:13 +0000 From: Oscar Salvador To: Andrew Morton Cc: David Hildenbrand , Vlastimil Babka , Jonathan Cameron , Harry Yoo , Rakie Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oscar Salvador Subject: [PATCH v7 05/11] mm,memory-tiers: Use node-notifier instead of memory-notifier Date: Mon, 16 Jun 2025 15:51:48 +0200 Message-ID: <20250616135158.450136-6-osalvador@suse.de> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250616135158.450136-1-osalvador@suse.de> References: <20250616135158.450136-1-osalvador@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: BEC12140005 X-Stat-Signature: o7thaiei7zn7scju4474ugczogdo1oo6 X-Rspam-User: X-HE-Tag: 1750081967-198921 X-HE-Meta: U2FsdGVkX1/ud+7Lp3W2UszyUFbOMYTFWUlaWAbRViH//5QBbypQ9K0Kvgfbm7o8KaheiVJGXo+cp47eC5rwGVudGMPKU4lwcOrHEalhx1FJA+TM0R6q/2zZVtw43KLE0DLw8b8JO+cNaJqUDotBOHjGhMi5C1jigllVi/ca0YsMMwdZiLOYp7Ta66/sE2MfczLYv1S5NyzoKz4iwLBMaeul4oMfhK9gPWFlXfuziMkvyx0vY8A3o1gm9f6Kt4eYojerZH7l/j/X0pyE/n0oL1AQO1QEKp45K6nLCb++Jltb1Q9nQtioU2s2IY8NIMb68aJNMdcP1O9ef23SJidcnoOtfen9lRphi8BY9Jk2zj1JGCpe01c5B1rV136iqoamP/YHy23c2HfaYKTfJq6BDNX3C8IrqCIguxe+JEd5w66D6pzhWyFyR1FVaxcjbBlTTq+9oCMAlBt+p8yalafMMY68Xr5kp2cR888qu51kn8aWGVd6T8SIq/m6E3TZI6qCdYsekLvYUOGliJ8dPkAAn/iLIT1ZsxhGi3fDaVa7FKmjpdOUoSLGCnZJ5ldqMRSbtIIe4vY4TNBkY3QgcYYngnJz/UbUdjUf9Lp0rQJtiSWIsmkQMpTB+jreVKrUcDSubQMLUIWQwKGch5qhYmyEoRuSHoqF2KNPKGKWtn1bZshac5j8I8rehUZRulMnpRMTVGCQys0XQs+xRHd0cO2W38B3V44RqEooyLN/3IKM/X4nycBVdhE05q+yJuofKY4oa6rdSadOlrh/9Ua4i3KwV4afH4RocYobz/MUe8Kj9Hgrz31Q0oDqz3dzy6gN2Eb8noF2Ndz157063DN1d65rFVa1B8L/cnqzf265M7KcHym1PrU9D5pk990+oOFh5beeFjO5ydeJCmhKSfpBLC2jJBrLANVCKOCXiMo/CtTzs5NzyPbegrwJuvl/7eHB7hs7Ein08GNw9apWxMDJoYD 0VmeJGlO rXMVe5d+RP/7YpceR4sKUnGIWV5bitYdDRL9RjAkPFWkmpF314iTStV8RkcuUUjTz6xg0d00ztGbup+fcrXXu7WEvk1lpBeO+yM0KSi5KgotqjnOL91TbtImiwblGHDjLdneGgTwSQSaUOn4Smd4rMUZytNwio+/PmiVa2iVOri/mWY0qK6ATTK5KdyHuekXOYT2UAaJV8HuTGfgVtsw+sn/X4aIX7b9fp9UfAQ40l6sNf58aAbr9Hx1/mjaCqdSrwuqwLbxYhtbctaiKSNuuq4fBQvmxAA2wzDhsotjKU0CzWN/scqSOfI/XG6y9SpPvTJahYcys/8ueL1u7NgShBgJn3J+/cpt33gejbHhfhDwctSun4Rbn0aFvDrFw9Q2LAgpVnsDd3Akk8Cmp7L65Yp67Uw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: memory-tier is only concerned when a numa node changes its memory state, because it then needs to re-create the demotion list. So stop using the memory notifier and use the new numa node notifer instead. Signed-off-by: Oscar Salvador Reviewed-by: Jonathan Cameron Reviewed-by: Harry Yoo Reviewed-by: Vlastimil Babka Acked-by: David Hildenbrand --- mm/memory-tiers.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c index fc14fe53e9b7..0382b6942b8b 100644 --- a/mm/memory-tiers.c +++ b/mm/memory-tiers.c @@ -872,25 +872,18 @@ static int __meminit memtier_hotplug_callback(struct notifier_block *self, unsigned long action, void *_arg) { struct memory_tier *memtier; - struct memory_notify *arg = _arg; - - /* - * Only update the node migration order when a node is - * changing status, like online->offline. - */ - if (arg->status_change_nid < 0) - return notifier_from_errno(0); + struct node_notify *nn = _arg; switch (action) { - case MEM_OFFLINE: + case NODE_REMOVED_LAST_MEMORY: mutex_lock(&memory_tier_lock); - if (clear_node_memory_tier(arg->status_change_nid)) + if (clear_node_memory_tier(nn->nid)) establish_demotion_targets(); mutex_unlock(&memory_tier_lock); break; - case MEM_ONLINE: + case NODE_ADDED_FIRST_MEMORY: mutex_lock(&memory_tier_lock); - memtier = set_node_memory_tier(arg->status_change_nid); + memtier = set_node_memory_tier(nn->nid); if (!IS_ERR(memtier)) establish_demotion_targets(); mutex_unlock(&memory_tier_lock); @@ -929,7 +922,7 @@ static int __init memory_tier_init(void) nodes_and(default_dram_nodes, node_states[N_MEMORY], node_states[N_CPU]); - hotplug_memory_notifier(memtier_hotplug_callback, MEMTIER_HOTPLUG_PRI); + hotplug_node_notifier(memtier_hotplug_callback, MEMTIER_HOTPLUG_PRI); return 0; } subsys_initcall(memory_tier_init); -- 2.49.0