From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EB52C71135 for ; Mon, 16 Jun 2025 08:01:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 165E66B0093; Mon, 16 Jun 2025 04:01:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 11C106B0095; Mon, 16 Jun 2025 04:01:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F20266B0096; Mon, 16 Jun 2025 04:01:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DE2066B0093 for ; Mon, 16 Jun 2025 04:01:39 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A9375C0B10 for ; Mon, 16 Jun 2025 08:01:39 +0000 (UTC) X-FDA: 83560519518.10.2638ADE Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by imf06.hostedemail.com (Postfix) with ESMTP id A4F20180002 for ; Mon, 16 Jun 2025 08:01:37 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=e2eftkO0; spf=pass (imf06.hostedemail.com: domain of david.laight.linux@gmail.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=david.laight.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750060897; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8rjhe62crpddPisDTbWMw9CI5pB8pf5ptQA0xBtkwno=; b=NLmXtxENpkQemXuUHg/PEdwSRRZt0EsBPkl5R8X7FO3qq1e0RXF9PXQ+TORAGPtaR/6eur 3Kc7fxcwrqzCR7dvSkiCD8ErPVZ1pqIty60ZnnGE++b7hG9kVTJHVjl5a75xCSv0dDe6s8 fTlXxaF/1YGK9P0fM0WBDhA1U21d5yo= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=e2eftkO0; spf=pass (imf06.hostedemail.com: domain of david.laight.linux@gmail.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=david.laight.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750060897; a=rsa-sha256; cv=none; b=CAr6JNnRjvYxviPTRNHa5BksZBNsDlAe7yWy2TpC4QuQ1QAcOu1T/Mj5dM901p689F2A5X xzYpGbh9S/ReWL7Q0Vb53LjFgxOo/4EP1gMozUgKgJWPTetsba1O7dG0k5M3u8nhEnArzY /Yib6ZKWiO2VVXkdgECaZUPzpBh4zAs= Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-45310223677so34391845e9.0 for ; Mon, 16 Jun 2025 01:01:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750060896; x=1750665696; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=8rjhe62crpddPisDTbWMw9CI5pB8pf5ptQA0xBtkwno=; b=e2eftkO0z+gaFrSu5dqqqbKSzdvVuKq0KbXw2gGnTgDRLoGfdZlL5gWU0oUwWQa5Mc a7IEpFx5VaO3mYl3NbIWBX4wjhztBItDtoEma9lyFNUrBeKJLcJkhIPgC9mqKk3lHVN1 ulJMMJf88nLX5Oqhj8cGRfiOzqYQg1frHyvWXqxl7nLowaTLkLv2MM/grOx++Pu646/S LlvGkY/oxk4xpdpp/JmN0g+gDBeo24ikvNHDwvFq9PsHytAWDoy32d/6jhRXtgcxc6vX OD6PXDl+UYLkmijdnwk7O5wacrh/hvgxzSV3Oz9Vec6H/943VcbmDaElypkGZF3TmRqt 2ADA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750060896; x=1750665696; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8rjhe62crpddPisDTbWMw9CI5pB8pf5ptQA0xBtkwno=; b=QlZhJRrnNIj3jbPUaGS3EYBEpce/9ZoCK6TY6AnAtB1ohYAHgFRfWGZY2LIg5hMGiK 0Yfu9MLDeihdz2lc/AeR79Lw5Rh2+PCduCqT4a2+Z8uCGUWJ92MD5BCp+c1xNBzLI7FP KuRCEwImPrq8VA0hmTyDygeXqaUY0z/KqmQUE917tQifjc83xjc94OoZFOf3YhRKXujZ IUuLJqerLp1pkIqZehYrXn/hK7vaq3WmK2Cbx5kNgMV6fk7ujYXDv9p0SLq6Oll3SIeh PUnbqJpSpyewEzKFtXF32oXmjDsI0S8uezjLfug+htR47Mjo1c9vcWA/3DcL6PrDVb5g ddvg== X-Forwarded-Encrypted: i=1; AJvYcCV2IElsOVNoAtvO8wfm7nCXi9Hn59R5GGVmbe1F5GLINwDKqj5L6TBfuo7EkA7V8INMX3DUdJo+Hg==@kvack.org X-Gm-Message-State: AOJu0Yzes2KWnOqd6p6d4fda1l+7IWqdkMlzjNz0anR5tEw3w5zbTvNV dBYpyrR0uhG8TaICGZTYpUOXpg3NpTMLw+mz4Xd5sR5SzGSexLySrfFI X-Gm-Gg: ASbGncvIdy5/DJiXmGAiyTM3TOuVa0Oh5Byj2RlEtLk8LtE5F4x/hg+tYhp3VUUGZjF /vL0oorBJTqcCyeK+KqbhFaBSWwjBUHL/g/rIsKglCHTlrDK4bCKnddJVQivEpKQ833iS91QLbZ 7HTn+p0CKqfusyxTRzIiIJ/JrkbOgXuDlu+C9Zb/9ph0YMInQZiQD0jzWFCFNpcYfWcd0l+eDMK hWkOLtoy1tOoc7ipoIoB46Eu5Pd2y2rHLSXYDQjTF9UaaGjPaDv79Wq+ApFWx2vvijOPLZc+Z9G 1HoRteZAgEXZJ1kE8TBmd2VVrVLoCrz0QnyCnINDvTox2lJKRo8jbD27jcg8btzkiwJLv+2YvxP tAtwi8Hhmdqn17P2jhjwZlzA+ X-Google-Smtp-Source: AGHT+IFxUzw9tvO6IMyaRp5Ig3addvgyu6ghA4/maMlkhudC6AOZXyedgOso00+fPoolrpIVZvIyoQ== X-Received: by 2002:a05:600c:8509:b0:441:b19c:96fe with SMTP id 5b1f17b1804b1-4533caa3d54mr98453155e9.10.1750060895713; Mon, 16 Jun 2025 01:01:35 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568b62ba7sm10525383f8f.91.2025.06.16.01.01.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 01:01:35 -0700 (PDT) Date: Mon, 16 Jun 2025 09:01:34 +0100 From: David Laight To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, Andrew Morton , Alex Williamson , Zi Yan , Jason Gunthorpe , Alex Mastro , David Hildenbrand , Nico Pache Subject: Re: [PATCH 1/5] mm: Deduplicate mm_get_unmapped_area() Message-ID: <20250616090134.476427c0@pumpkin> In-Reply-To: <20250613134111.469884-2-peterx@redhat.com> References: <20250613134111.469884-1-peterx@redhat.com> <20250613134111.469884-2-peterx@redhat.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A4F20180002 X-Stat-Signature: bkyuotied8dier4wfx1rayon3ikxtnaa X-Rspam-User: X-HE-Tag: 1750060897-183984 X-HE-Meta: U2FsdGVkX18+jVN5CYuUK2nhrEF5qAJaGaDAcADF8JhPOUMli/DHf/zj7WlDuQ21Xr6E8RJlCdvRm5GJhZBkefV8ojqmbw6r0IP3/O5E4+1z/hKjzAwh/1F+VEiJtbWXgm4G9cC5RLnQ9VsWpEYOd85rSfILM2DGj2PVIFa8yrP6F+9R5NuSEHKmJIui34UQRFU2Jg5mCJy62gbqzq+piGoe+Elr/79TBvlm0xcI5adVNWWsJkOc9d+HAxVAJWj9UewLx3zovJqLnxUYwh79LdK2J2hLlooYPyagzZPaHspwNpYplkGaAFPRmo6n8H8GeJBtSQLp6zkpQCvnD/5Al/5CqARF/0fekp76mgrLRI1wJn9XE/Y8UyI1c54f2yva7CqgG1BGNSzZIdCg3iEKXmHeKL5UVxnUWMWX71fM2uRsP369GBh7ZCuE7YLy7Q9Az5WRSivylQ3WoqRlxbrkTJJAN/KRSw4WlJEyL64hrl4WOqJquDCnuFTfV+WnL4NvqxOq6Q4G5PDTx3GVeRi73u75cdd8Q3+wYG0MWwbzSjDVn+//rVyJULOgXaAtRobYEf47tlMx5MvnUSGy9nLij/Ol8RQSBZ5uF7q/gHxHM0T/lzZmrTBLwE8aXNo87fv/br3YlvUSmTjQ/GxToUdUkep/+KcDJAZESogNHSgCaMaoJ/OmnJ6H+wubgbbp2vf7q6apCZ3grc84PA1m+7cEvUXAIMbK8n5zrisrAhDuihiukGBuJI+fVhRcQnGmhZCTw4uaj8nDpBgx+s5ep7AUs0nHAgihClCydEId/9wX/Pv5mDomILdsGcpMxgDEfqHjtFrrZ2O6PxIL4WNdJB1UWyB+sg9ZJUTHbXSVSlJmfzgByAAWFFExoaedXZAdWT5dC5o3evGAMrc7ddXbg0+s4mo5Br4+olEACWJ0RROG9TLMa53wF6bk6MWscm+fr4xalH4EK837Efk707U7V+6 D8gyGUgt cqVn10Gofs8WF4PEVRPMrl/ozGLUjs6nVv5aRhtPUG0EnaSeh7JxwhPY3/zPurHeIW8hYdLoAzKHhJZoAl6rXpikBtdIHfvTa2QYEMRfwmIF+EvyeoeC+lI5mvuDtblG3MmjHsWeQSTejLZJYIn44MC9WY3O5dsLNsohSPem85sANzvNPIHcr4m7SL9YmV3YjeZ+vWOQLZhycoX9nlwuSMVeSHq7O0doSSRzTX6LQe083nmYGtb487moFo3MwJ8ysUGEYLfK0jLujBJwjxkfexyzYujAn3Z7hy9SC491MddIM9y/V1Ak9XeUsWksWh1fuij45cc/m+QyjqTG0jYc1OCCqaSink6CXC0+sxnkpmPw4uR5YuOWCvGed9JrcnS5PfqKhS661ts6wRgc77pUepObA7H5lfShryQlpiQHyfyOyqCAbSGaa4HiwV3WciRSSPD6a+XbOxTZ9YNpJKG9sANd/Gw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 13 Jun 2025 09:41:07 -0400 Peter Xu wrote: > Essentially it sets vm_flags==0 for mm_get_unmapped_area_vmflags(). Use > the helper instead to dedup the lines. Would it make more sense to make it an inline wrapper? Moving the EXPORT_SYMBOL to mm_get_unmapped_area_vmflags. David > > Signed-off-by: Peter Xu > --- > mm/mmap.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/mmap.c b/mm/mmap.c > index 09c563c95112..422f5b9d9660 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -871,9 +871,8 @@ mm_get_unmapped_area(struct mm_struct *mm, struct file *file, > unsigned long addr, unsigned long len, > unsigned long pgoff, unsigned long flags) > { > - if (test_bit(MMF_TOPDOWN, &mm->flags)) > - return arch_get_unmapped_area_topdown(file, addr, len, pgoff, flags, 0); > - return arch_get_unmapped_area(file, addr, len, pgoff, flags, 0); > + return mm_get_unmapped_area_vmflags(mm, file, addr, len, > + pgoff, flags, 0); > } > EXPORT_SYMBOL(mm_get_unmapped_area); >