From: Ankur Arora <ankur.a.arora@oracle.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org
Cc: akpm@linux-foundation.org, bp@alien8.de,
dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com,
mjguzik@gmail.com, luto@kernel.org, peterz@infradead.org,
acme@kernel.org, namhyung@kernel.org, tglx@linutronix.de,
willy@infradead.org, jon.grimm@amd.com, bharata@amd.com,
raghavendra.kt@amd.com, boris.ostrovsky@oracle.com,
konrad.wilk@oracle.com, ankur.a.arora@oracle.com
Subject: [PATCH v4 02/13] perf bench mem: Defer type munging of size to float
Date: Sun, 15 Jun 2025 22:22:12 -0700 [thread overview]
Message-ID: <20250616052223.723982-3-ankur.a.arora@oracle.com> (raw)
In-Reply-To: <20250616052223.723982-1-ankur.a.arora@oracle.com>
Do type conversion to double at the point of use.
Signed-off-by: Ankur Arora <ankur.a.arora@oracle.com>
---
tools/perf/bench/mem-functions.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/tools/perf/bench/mem-functions.c b/tools/perf/bench/mem-functions.c
index 8599ed96ee1f..b8f020379197 100644
--- a/tools/perf/bench/mem-functions.c
+++ b/tools/perf/bench/mem-functions.c
@@ -139,7 +139,7 @@ struct bench_mem_info {
bool alloc_src;
};
-static void __bench_mem_function(struct bench_mem_info *info, int r_idx, size_t size, double size_total)
+static void __bench_mem_function(struct bench_mem_info *info, int r_idx, size_t size, size_t size_total)
{
const struct function *r = &info->functions[r_idx];
double result_bps = 0.0;
@@ -165,18 +165,18 @@ static void __bench_mem_function(struct bench_mem_info *info, int r_idx, size_t
switch (bench_format) {
case BENCH_FORMAT_DEFAULT:
if (use_cycles) {
- printf(" %14lf cycles/byte\n", (double)rt.cycles/size_total);
+ printf(" %14lf cycles/byte\n", (double)rt.cycles/(double)size_total);
} else {
- result_bps = size_total/timeval2double(&rt.tv);
+ result_bps = (double)size_total/timeval2double(&rt.tv);
print_bps(result_bps);
}
break;
case BENCH_FORMAT_SIMPLE:
if (use_cycles) {
- printf("%lf\n", (double)rt.cycles/size_total);
+ printf("%lf\n", (double)rt.cycles/(double)size_total);
} else {
- result_bps = size_total/timeval2double(&rt.tv);
+ result_bps = (double)size_total/timeval2double(&rt.tv);
printf("%lf\n", result_bps);
}
break;
@@ -199,7 +199,7 @@ static int bench_mem_common(int argc, const char **argv, struct bench_mem_info *
{
int i;
size_t size;
- double size_total;
+ size_t size_total;
argc = parse_options(argc, argv, options, info->usage, 0);
@@ -212,7 +212,7 @@ static int bench_mem_common(int argc, const char **argv, struct bench_mem_info *
}
size = (size_t)perf_atoll((char *)size_str);
- size_total = (double)size * nr_loops;
+ size_total = (size_t)size * nr_loops;
if ((s64)size <= 0) {
fprintf(stderr, "Invalid size:%s\n", size_str);
--
2.31.1
next prev parent reply other threads:[~2025-06-16 5:23 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 5:22 [PATCH v4 00/13] x86/mm: Add multi-page clearing Ankur Arora
2025-06-16 5:22 ` [PATCH v4 01/13] perf bench mem: Remove repetition around time measurement Ankur Arora
2025-06-16 5:22 ` Ankur Arora [this message]
2025-06-16 5:22 ` [PATCH v4 03/13] perf bench mem: Move mem op parameters into a structure Ankur Arora
2025-06-16 5:22 ` [PATCH v4 04/13] perf bench mem: Pull out init/fini logic Ankur Arora
2025-06-16 5:22 ` [PATCH v4 05/13] perf bench mem: Switch from zalloc() to mmap() Ankur Arora
2025-06-16 5:22 ` [PATCH v4 06/13] perf bench mem: Allow mapping of hugepages Ankur Arora
2025-06-16 5:22 ` [PATCH v4 07/13] perf bench mem: Allow chunking on a memory region Ankur Arora
2025-06-16 5:22 ` [PATCH v4 08/13] perf bench mem: Refactor mem_options Ankur Arora
2025-06-16 5:22 ` [PATCH v4 09/13] perf bench mem: Add mmap() workloads Ankur Arora
2025-06-16 5:22 ` [PATCH v4 10/13] x86/mm: Simplify clear_page_* Ankur Arora
2025-06-16 14:35 ` Dave Hansen
2025-06-16 14:38 ` Peter Zijlstra
2025-06-16 18:18 ` Ankur Arora
2025-06-16 16:48 ` kernel test robot
2025-06-16 5:22 ` [PATCH v4 11/13] x86/clear_page: Introduce clear_pages() Ankur Arora
2025-06-16 5:22 ` [PATCH v4 12/13] mm: memory: allow arch override for folio_zero_user() Ankur Arora
2025-06-16 5:22 ` [PATCH v4 13/13] x86/folio_zero_user: Add multi-page clearing Ankur Arora
2025-06-16 11:39 ` kernel test robot
2025-06-16 14:44 ` Dave Hansen
2025-06-16 14:50 ` Peter Zijlstra
2025-06-16 15:03 ` Dave Hansen
2025-06-16 18:20 ` Ankur Arora
2025-06-16 14:58 ` Matthew Wilcox
2025-06-16 18:47 ` Ankur Arora
2025-06-19 23:51 ` Ankur Arora
2025-06-16 15:06 ` [PATCH v4 00/13] x86/mm: " Dave Hansen
2025-06-16 18:25 ` Ankur Arora
2025-06-16 18:30 ` Dave Hansen
2025-06-16 18:43 ` Ankur Arora
2025-07-04 8:15 ` Raghavendra K T
2025-07-07 21:02 ` Ankur Arora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250616052223.723982-3-ankur.a.arora@oracle.com \
--to=ankur.a.arora@oracle.com \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bharata@amd.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jon.grimm@amd.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=mjguzik@gmail.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=raghavendra.kt@amd.com \
--cc=tglx@linutronix.de \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox