From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FE3BC7115A for ; Sun, 15 Jun 2025 20:55:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A4246B0095; Sun, 15 Jun 2025 16:55:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 956166B0096; Sun, 15 Jun 2025 16:55:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F7226B0098; Sun, 15 Jun 2025 16:55:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 68B676B0095 for ; Sun, 15 Jun 2025 16:55:20 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 33BC1BFA2F for ; Sun, 15 Jun 2025 20:55:20 +0000 (UTC) X-FDA: 83558840400.22.3D3B81E Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) by imf28.hostedemail.com (Postfix) with ESMTP id 5AE9EC0008 for ; Sun, 15 Jun 2025 20:55:18 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QoY38ZSS; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of tamird@gmail.com designates 209.85.219.47 as permitted sender) smtp.mailfrom=tamird@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750020918; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BwuzOkwr2WXLbNIqZ4PjxHxYIhjL5EaV2fkU8tqfaYg=; b=LzpmCbAzVQSOeQ1oAzpttmHCoyHyoK5FjdjozfN9j/MHgVJLJH8IT1MyZNgrKsOEioFy2P 2+U82/y32O9qcQ8mhFmmogGh6A8qhfDP6ymF8h0ptb0EiqDhZOB+qts141eXNgZNdhjVIL VP/CdGo9UeEQfHn37TxocOvpq/qcGBs= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QoY38ZSS; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of tamird@gmail.com designates 209.85.219.47 as permitted sender) smtp.mailfrom=tamird@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750020918; a=rsa-sha256; cv=none; b=IE0oEyUwpLtxzHCM94Th33zw2F+0vSojFJO5JDKq1KTL3sg4GZrbHkdw773iq0ziOAy0GQ PYtw4/TgT0kWvQxfGW95ohxzBYbGRx+vkB9ga/57iKz1wNZp1wW5KzBbFBQ6EScEXdcKbG 9TaRDSWOpbWjW2U/gjgt0PpqRVAiC04= Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-6fb3bba0730so36734576d6.0 for ; Sun, 15 Jun 2025 13:55:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750020917; x=1750625717; darn=kvack.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=BwuzOkwr2WXLbNIqZ4PjxHxYIhjL5EaV2fkU8tqfaYg=; b=QoY38ZSSrZORXcbDNSuS27wd5ig2PLitbtUSoLhrdt6oaxz2Xx+mr9Lh/W6WAuIabc VPdpizcLsX0wWWsTIrDcvUS5V6FmQw1+aOrjteerU8Tsjqt8IzzSIDEUAplDbSoYGx3n XoD7A/vzv6Ykun37N9ODejmK7YbqZExlVxqtp58vZFoSXydkWkz8yHl6WY/cMj16q66A TMVnZGqySlOqsz54VX1SMxbSjdcLmmZhbpBn5wgEUT2iXP3pFXg8lTS/acDDumJRyS3e 2inQYHCiBKrlw0k7QMoPfJT+hnRFaKaL3rtlXPERrMkX2hzBTN/TvQNZ5hBn3TYsA4US /bwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750020917; x=1750625717; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BwuzOkwr2WXLbNIqZ4PjxHxYIhjL5EaV2fkU8tqfaYg=; b=MwM1Upa/tOacmXl+gMjUmYpWVuGMUF9+jKVJxeTr41wx7GKs/uZn+R4TO3QSBuRDeq UwEagMAs/Mp7d6kfCfRrk9UqYODRQH8m4kel+j3sXpUb2dQjOf02aJSyqrtX7PsdegU/ eAupz2fNZnv3CLss3it732qbg9P+HNLXnnlxUftAfk8ZS41YBfafSfgGbFldd2Ngztpf xyBaDWUsUTaUj+z1KOub0JQcI12VKsidzv+cVgv5AFD4Z9HaxoDA1DdBJTXKF0erTng/ h5UPlyjHf3UQquY+Cl/vuJaIchbLFbOCXYTvXMI/7S1NBZvu/uyc65Q9URDaRrY/cDYz SxJw== X-Forwarded-Encrypted: i=1; AJvYcCXLe3zTTowVWksbp5GtqFzi1sZAKmWjKBXKlnFrIbtu9ggPTsz1kZ8PPXZ9CxqM+ZUjRhq/qUUwgA==@kvack.org X-Gm-Message-State: AOJu0YwPe9+6SBFeH+hKfUQK125qvDCNf5Mm5yZCKFLWcExbRS4VB1Vd Dvnv2Sfy73/msw6V/B4vFbkWn5US7Lw5lomiAgQc9Xd4/0/dtniw0X7Vn2xDN8RS X-Gm-Gg: ASbGncs6OsyfmxAci99D3xUkw6mckow0dio1TfnV+8KVx+qRlNOSvCautQze4uA8zgv bHkmW8e2zG7K9WvAy/9bdDPpd8ITTMH1vtpy6YhtO6lYTYKFFLuSNUHg4ZkB6nlBUQYAgeNL0zi KLZmkoaOJ/k+Bj0jqIeZJHNy8cR5S7MLC8sOZ0GKJ2o+S/cEX4AsHuViM9V+AwpkfCqp8W+hmwy NHdcvrvcNNWHnJrT1GULALJLznFcgLiw5t9D6HwpVp7Rd1LrBZln18VPmJtzzT1GieJ6qhHl/73 bAhBzsMJ6rh7lTxvne3LzbglUkaW1AvJ7eNw1qc6Ns1zwanF5HDYbR48BgyH5L9zvio4Fg== X-Google-Smtp-Source: AGHT+IEgmK9+Bj58C8dqWwTYX0gZlBqZMRj5psT70nx4i2bPfqmKaepd9+hxp6sh8BMt38kvfV7yAg== X-Received: by 2002:a05:6214:76d:b0:6f8:c53f:48e with SMTP id 6a1803df08f44-6fb459eecb2mr143148166d6.0.1750020917091; Sun, 15 Jun 2025 13:55:17 -0700 (PDT) Received: from tamird-mac.local ([2600:4041:5be7:7c00:b0c6:92db:d807:21a6]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fb35c84148sm43468176d6.109.2025.06.15.13.55.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Jun 2025 13:55:16 -0700 (PDT) From: Tamir Duberstein Date: Sun, 15 Jun 2025 16:55:07 -0400 Subject: [PATCH v12 3/6] rust: enable `clippy::as_ptr_cast_mut` lint MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20250615-ptr-as-ptr-v12-3-f43b024581e8@gmail.com> References: <20250615-ptr-as-ptr-v12-0-f43b024581e8@gmail.com> In-Reply-To: <20250615-ptr-as-ptr-v12-0-f43b024581e8@gmail.com> To: Masahiro Yamada , Nathan Chancellor , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Bjorn Helgaas , Luis Chamberlain , Russ Weight , Rob Herring , Saravana Kannan , Abdiel Janulgue , Daniel Almeida , Robin Murphy , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , FUJITA Tomonori , Nicolas Schier , Frederic Weisbecker , Lyude Paul , Thomas Gleixner , Anna-Maria Behnsen , Benno Lossin , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , John Stultz , Stephen Boyd , Lorenzo Stoakes , "Liam R. Howlett" , Breno Leitao , Viresh Kumar , Nicolas Schier Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-pci@vger.kernel.org, linux-block@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org, nouveau@lists.freedesktop.org, Tamir Duberstein , Benno Lossin X-Mailer: b4 0.15-dev X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 5AE9EC0008 X-Stat-Signature: afsukqkk99uqgz9mghqgr7o7je8o15qx X-Rspam-User: X-HE-Tag: 1750020918-372655 X-HE-Meta: U2FsdGVkX1+9CnhAA9oR8UmlVFUJqcjAlLSU1iM55WNsBq6qQJ/RkwJCCkByljgLtXGqO/LkOWfKf+cE6B8h7KHo2CIOeN+/T/3/1Vctrn9Vkt7ogbeHtDrRDpWYhBMCg30TZGPMyrT3ndLCDobwF8VnENgghiS7CXxZWFALQlarimiN3P2O7nf7evR7NZfMSQoTVwoMEsLox4qxlvTSCeOlyiVjEZ94NT0l4raBnfhC2m0hBwFBBdGZAYdFf/rpkYM51sfg8WUbf2T0/0DMS5sonceYaHmiz+Ru7sMGY3DSx8U/26/iogqEDz41J36tgSitYOrQNm2pR3c8Nvjju3Ug3XgzqjI2odJqv+6pBMizzU8eVrg8bHKJJfYm3mL8V4eEtiFf3rQg54bQcYxe1JnFkaGOlRRRA6bYv8m4K1+8oamI2gU1D88v4pvTmHSWSBNuRdMmgGAEl40OhtK0Im8XDkhjGBrB8oSSJDbTigEYT9slxf5bbZcrslVe7+Kk0ziOTFI7zSHGkC0rLcIaHvfA/tBanIbmjGixUvnQh9kqtOwH/DJm3TgABBlNUINkN+Y5ttbJfQsbxfRqBT0oN3xy6M+i+sxU7yucAOfWl9S3w+tN61OeE6WzYiyy4lLADwsLhMFL78BO01GnA5rX5QqaNvQgMe26jcUqblMpfYzUpRDjHX/+K3qQnZdKYV3UjB29Fj4+RTi/x+I4aVggNR1cKRr+dWlWAMxHEMGzf+4f8JGzkkGNfYdAYlMyAVQlJGllhZeUB2DxfKq8pFzIAGBI2jpcn9JhKvT4+VNT4ZjYvkXrnbQl8ZrRp4Atakno+rENvLaHBsLdHwpY7FADMal9cKFwCGHJ8kV/HEjdigiv/Q88/aZAd8TLqYxRIuvU/+x9gAI8UVDHW9g6rFpMNYE9ogpzj6REYa1zVLEMTXTk64DEtKIL515xyajnaspGCI4yszcVKaAj9kFxLiw 3WFsn9cX JCJvmDLt0x47JLfCxMeZzJbZPB7sMHBIIw2nHOqxd802nDoDwBUTEspJssLpnr5O6C6KDAELUvX5PXKSIUHvbjJUdRH9jiEzm6BX7AVuP0zhj1n6qEQqXZhrBb7Yk3Hdrk6sKiPA/n857d/mvSkJxyGiKRqyKYTN8xWmb0I113zIaDk1qg2az+X4SJllJ+itlIyMfo6jFQ7kBVJ7+VCKrzMmalbBu/ihQEGGk8H6jFwXbaZgHSqW+EpY7tyTWwjpL54QGMF9lF8x7k5d5NrzWq7DRgRbWTX4qnqhlb7vB87DcDUPfe06bA4J6bH3Lj/BEi/LFsW71DDdoXZE2/9TDdIp4u7ndG12HpKcfTt5Sm4oje+LrG0Q0VQCv0JyBuCb0FdYuKbsQxa+AsFDK9i5/bT9R/YJMa9VusN7W30zofCyREWjhOQhiwNOntWa5oBGuemK7bt+XAKXww0172n3XOhH35WtFFcgLu8Diq4bcOXDpkkoWAGhJCzIYqNZm8B8+ysSRaMYGEWfyArJWF35Qxrqfw/P9VQx7yfeuQ7Man1SR1p90AJCmtkYDxv9VL3eau5IzKToL7GSUaaW6eGDrIzCbBmNLHKrmbkRlKGfBF6vYobiWyG7fYhsc5PXF1eRyAouQJ4sUCLiB/PM64w4ZenNBckve1MRLj4Q38f3sVvHuD4lrIJfMRmoMGcXWHfbkjU7how1LCvhA5FV9YAc/vpbftQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In Rust 1.66.0, Clippy introduced the `as_ptr_cast_mut` lint [1]: > Since `as_ptr` takes a `&self`, the pointer won’t have write > permissions unless interior mutability is used, making it unlikely > that having it as a mutable pointer is correct. There is only one affected callsite, and the change amounts to replacing `as _` with `.cast_mut().cast()`. This doesn't change the semantics, but is more descriptive of what's going on. Apply this change and enable the lint -- no functional change intended. Link: https://rust-lang.github.io/rust-clippy/master/index.html#as_ptr_cast_mut [1] Reviewed-by: Benno Lossin Reviewed-by: Boqun Feng Signed-off-by: Tamir Duberstein --- Makefile | 1 + rust/kernel/devres.rs | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 5eeddfbf5900..bb33023f87c3 100644 --- a/Makefile +++ b/Makefile @@ -479,6 +479,7 @@ export rust_common_flags := --edition=2021 \ -Wrust_2018_idioms \ -Wunreachable_pub \ -Wclippy::all \ + -Wclippy::as_ptr_cast_mut \ -Wclippy::ignored_unit_patterns \ -Wclippy::mut_mut \ -Wclippy::needless_bitwise_bool \ diff --git a/rust/kernel/devres.rs b/rust/kernel/devres.rs index e5475ff62da3..237182446db3 100644 --- a/rust/kernel/devres.rs +++ b/rust/kernel/devres.rs @@ -140,7 +140,7 @@ fn remove_action(this: &Arc) { bindings::devm_remove_action_nowarn( this.dev.as_raw(), Some(this.callback), - this.as_ptr() as _, + this.as_ptr().cast_mut().cast(), ) }; -- 2.49.0