From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E76ADC71135 for ; Sun, 15 Jun 2025 20:55:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC41B6B0093; Sun, 15 Jun 2025 16:55:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D4CCB6B0095; Sun, 15 Jun 2025 16:55:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C151D6B0096; Sun, 15 Jun 2025 16:55:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B09D86B0093 for ; Sun, 15 Jun 2025 16:55:18 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 447AE10258D for ; Sun, 15 Jun 2025 20:55:18 +0000 (UTC) X-FDA: 83558840316.07.512A62E Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf18.hostedemail.com (Postfix) with ESMTP id 5C3A41C0005 for ; Sun, 15 Jun 2025 20:55:16 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=m2CxyjDL; spf=pass (imf18.hostedemail.com: domain of tamird@gmail.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=tamird@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750020916; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3zUYH66sAi4M6SnRnDRUP9N7P8+78tvCpZpLM0hP8f0=; b=5ZNicV2D0ujRU/M+UcGZSJVxhj6ewPq2pUJN1/V4W11uTdzCOpLiNOlcieoWy8xOPqC2Ez LPaiGEC7qNS4Y9iZw3dSvd/d3h1pO82cHm6RgvF4m7dTm85sj8C4ViikG7Mv1EcDWGwOoT wnqcG8DPE4To1znTaZ89HQjERijjEvY= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=m2CxyjDL; spf=pass (imf18.hostedemail.com: domain of tamird@gmail.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=tamird@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750020916; a=rsa-sha256; cv=none; b=X1kbBz+nDJxqVN0QJZPu5a7umn3ZQnFkCDC+f2l+0g1I9ujgWXsmuplOksqBfZbKWHETxe pcY5kN/aG+Hk/dU7UzygT9UlpodzOcpvEkmLt7hDQ8fZF84OOS/Kum2q5EO/FsGxA4zWt1 1SCefmZ6Un8O+D+BNJwy0hTYIU11CXo= Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-4a58ebece05so41770591cf.1 for ; Sun, 15 Jun 2025 13:55:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750020915; x=1750625715; darn=kvack.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3zUYH66sAi4M6SnRnDRUP9N7P8+78tvCpZpLM0hP8f0=; b=m2CxyjDLZodZkpkz/H0ARGZN6bB9KeA8ZT+LKFdhtrusoVnRiwYwc1YezEQmp+2G2X nIAndO6PmV9bLPMMXn0j2OzyGGMcw8Zi7R0heYHuqnNJ61HSpKFElv+ue+u40GeQkXoC yVH9hMMga3JuXF4vXIBoNEJrWFaJhJOQThOYyPCacD8R84XuNGWZKMYboWcMGUEFR4e2 omsP4e2awhy5F3lGlrmulx/iOi5JmIjFUEln6D+auCzR9DySvCwvN6iPAIV1kUW2CQy5 sfaT0f1ezIWRBn38eL49iDS1O0IloOmkQlKdhRtlfjHc+TECecffrFf6yLzqFRWNOZj7 U7bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750020915; x=1750625715; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3zUYH66sAi4M6SnRnDRUP9N7P8+78tvCpZpLM0hP8f0=; b=U7dRyk+BzWr+HPSUG0cbEfWLEsuflwsFaEC+fGbBW/Ya69JnBLVtMW2d72RBaXUEaG yNPCE0n4xW8l7wthzh2YJotb+KnsqBdtRdJqe8NA9wfZTKtDV+ld2Cv7n65fFBrG1D+f v/2iugxNLWiVZh5dRQqflt2IV1tkLjxLaeuIZ5JubdATeicMLazmhsXFt6/EQ/6OntUK tx8uRgIZfXqSrg9YSAmcxh75OOd0baoSv5PjoVpPFebvlV2JzdPhL4dLyQqr4q46gBQY /QLJmapW3kbZC83H3qvRdbq/ZS/2QZISXAhEv4KxA35epsGOzk3dOIUmahGrD9bubE6c wdzw== X-Forwarded-Encrypted: i=1; AJvYcCV5tNnVcnztNoXhnvywRBtnRvOPvrgiYTZ3Y4694wQfFkgVvzmj0CQwurq1EhdQtsw9G2UJ+x3dPg==@kvack.org X-Gm-Message-State: AOJu0Ywep48fyKIV/xtyACIS0AjWZ5PHJATdW4JvInZMZwL6gVLN5IbC y0Tbp3JYJqENb12dxsaYLrcy7mMh3UAuyyVfex8CjFpEu1ugXNNK83CmRYVEyiqf X-Gm-Gg: ASbGncvD2e/UlDQbmmHABSjpM4TzMhMbknoLtdn0qQvMqJXqdoGFS2clsj8op/hA0u2 uFZQkkIiJj5fxsuDf8j0p9XUoEhKpXRn5Q6rLp5F7t8IS4ebKhN6fcJpfYJdbsoHtTpo1XkI6n7 HucVwYnDX+qGKXskZs1JNhdVsvlLlwqsceKOrwV6bkZ0XApY0Q6BMMWzGmRQi45eWmp5FIZO9iY 9DngOLUNhoZtPohW1NjOeQqb3jvvSg4NEaM7L3xlKoAFpt7gXegNWQliCXbCgJgW3I8uPiNMvAo MH6WFDq1tboz5qnh5eyoPljWIdSa+5egR6bczFvy7uBhZdkCDBr++TZVlPELYee7ePv2572ilfU gbxu0 X-Google-Smtp-Source: AGHT+IGnwG/F3pbc/I9CZO28hGaGlx5gnzKOmJ9C6eKZoLJoA9UqEbcNjyNDi/CwdRgtfZ3tf4DkZQ== X-Received: by 2002:ac8:5811:0:b0:4a7:189b:98ad with SMTP id d75a77b69052e-4a73c5338f4mr110296191cf.14.1750020914928; Sun, 15 Jun 2025 13:55:14 -0700 (PDT) Received: from tamird-mac.local ([2600:4041:5be7:7c00:b0c6:92db:d807:21a6]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fb35c84148sm43468176d6.109.2025.06.15.13.55.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Jun 2025 13:55:14 -0700 (PDT) From: Tamir Duberstein Date: Sun, 15 Jun 2025 16:55:06 -0400 Subject: [PATCH v12 2/6] rust: enable `clippy::ptr_cast_constness` lint MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250615-ptr-as-ptr-v12-2-f43b024581e8@gmail.com> References: <20250615-ptr-as-ptr-v12-0-f43b024581e8@gmail.com> In-Reply-To: <20250615-ptr-as-ptr-v12-0-f43b024581e8@gmail.com> To: Masahiro Yamada , Nathan Chancellor , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Bjorn Helgaas , Luis Chamberlain , Russ Weight , Rob Herring , Saravana Kannan , Abdiel Janulgue , Daniel Almeida , Robin Murphy , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , FUJITA Tomonori , Nicolas Schier , Frederic Weisbecker , Lyude Paul , Thomas Gleixner , Anna-Maria Behnsen , Benno Lossin , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , John Stultz , Stephen Boyd , Lorenzo Stoakes , "Liam R. Howlett" , Breno Leitao , Viresh Kumar , Nicolas Schier Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-pci@vger.kernel.org, linux-block@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org, nouveau@lists.freedesktop.org, Tamir Duberstein , Benno Lossin X-Mailer: b4 0.15-dev X-Rspamd-Queue-Id: 5C3A41C0005 X-Rspamd-Server: rspam03 X-Rspam-User: X-Stat-Signature: stp58aisjigemanqtykhffrndy9of7eb X-HE-Tag: 1750020916-554378 X-HE-Meta: U2FsdGVkX1+WRzXHM2QeESyoi3LliwcSMKWKeXZmfEdlF7mEMkszkaIOo3w3Tc5F13aXbYTtpAGyYIHZ3Y0tFSb6I4UbhOVY7Ve978RiTcEHLtC7wQ6X/FghIVEeva2Irk5fb2ueQGFmmMgy4fsf/BSqy5teyNlJo0csdVjLji4eC1UV6ZxGrlFdBfK/5AWxivWBtUWzHlTovi93zUBU/aRzKJje2PzujTHaRvwdwPsENllpX9CZOoUsUu/yvkbxoMSsQt9iwA248NxPr9UncVWY64opRZ9mC2A1qJSsGIwF72E6YheYT92+HouQ3A/1p3iLHWO0e0DvMx9ylinNBxAJxysOCdWTIHUZYY72RGUCrDL6jy9BmRnLhDDPLPpiBiwCgvQ6Bsqby4/AtBtY23rZ0ck8IhKC86uY5wDUgMeRCto25ZyguRXcKd9dprWx5rcdBFnc4v13FK4EDyG+AuSwJmEOcZiaH6JbtWIu3gSD0NuNix2cXKQazqWiriiTRG2U/8Drci8leaArBJtKxIZq9vNnlH/tLZ3lIYOlxDsQ7/i1GG5Ekj3u+syx+XjuvYDSPWZBYVXWeBIaWTVvfAebvCRv+l2jZYE8LYtTt6Nge5gyH+H6nyRNphHADLqMpvtTn/X/L5NV8mZxj7S9MELYq+VgKpRuxx587go0ZE4bIu/dBh5L6Db10OhGKbmfyNKyAu0rKcNSvp/XKCrLmY/mghVy9fgEj6kZ18/ix95mfgTdD1SMX7bSbrQ1NJFGZ1mOz0wimg/Hpu0JlXurizi3nocwk2PctUZsg5zUrRflnE+P0v56Om4tt1uSYbM9t9D/0CbRb7qY5yhTxxhfTt+TbkNz7jmbOW5Y6/tjeH5k9GzOvNYjQ5UfEVJVIHxECJzj1LTVsGaednNKWFOKN2AeVTKN0Rcx3KY7N3p5f5VUDiyrIG8fUdPwvNZymeP5IBiSgKqFNbaIU4NTvzO 6fn0tg8p aHV0vSezRXD38KwWB9WG+b30W2lY7nXJsK5HD8RlbGe9SQKy9mFa0Qi8VWmluETTuvy2GvRQtIw28gWUSJjeuTer51kjvyfu1YSgf6ET9rqauLVXSy7Gj2B29WTjgUtnvY+v/c5vKdxihFPNNWfC4+7Jtl5RyV+88l1k4PYBGZ90BPxAsoVE3bzFOtUIgmtijNru/5rvqs35Cdi2Iz/GHxLIf7UstgLtePhxgKHvtAJCsNtkiCeMv5roNY9oOehqkSi+nAMQeAq9nZf+XSm3RE0RfAXkxElqnr/kqfvkABWbyA6KXA2dfLh2dT9q8AG597u/zxdTK1QOfOUiT+35bunorGVVHMnw8jYZUVuru4qvuA6MJXbRw/wRDYIBqCJxCwqjlJJd+eyBuZSIRSVrCBAHWV33WF6Lvobrcm3XqfRibeFmlvHAXKeo/SsbwmFjKEOoqcwyZS1s3++PQ2PlxyRlfAKVWcZKEaqrmxcF7QMPMwBPcWhbvxDrRanxoH0oYl9AYVy5BjDYrtZZnhEbRCoK13zVipA7e5DhKNKlcRgmJAxHxgycySo7pTA+eMYGC5PL4k3TpOG3Xl+EZdXLMToz3BWzPw2ayTi4PY2QkROAgGE5BmyPa6uJOq3R5+FNIdsk4jpGxCMULNuKuYnm07NgzTc7A9l6XzyX/hE5I28UI3h7I737zRb4o2g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In Rust 1.72.0, Clippy introduced the `ptr_cast_constness` lint [1]: > Though `as` casts between raw pointers are not terrible, > `pointer::cast_mut` and `pointer::cast_const` are safer because they > cannot accidentally cast the pointer to another type. There are only 3 affected sites: - `*mut T as *const U as *mut U` becomes `(*mut T).cast()`. - `&self as *const Self as *mut Self` becomes `core::ptr::from_ref(self).cast_mut()`. - `*const T as *mut _` becommes `(*const T).cast_mut()`. Apply these changes and enable the lint -- no functional change intended. Link: https://rust-lang.github.io/rust-clippy/master/index.html#ptr_cast_constness [1] Reviewed-by: Benno Lossin Reviewed-by: Boqun Feng Signed-off-by: Tamir Duberstein --- Makefile | 1 + rust/kernel/block/mq/request.rs | 4 ++-- rust/kernel/drm/device.rs | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 21cc6e312ec9..5eeddfbf5900 100644 --- a/Makefile +++ b/Makefile @@ -485,6 +485,7 @@ export rust_common_flags := --edition=2021 \ -Aclippy::needless_lifetimes \ -Wclippy::no_mangle_with_rust_abi \ -Wclippy::ptr_as_ptr \ + -Wclippy::ptr_cast_constness \ -Wclippy::undocumented_unsafe_blocks \ -Wclippy::unnecessary_safety_comment \ -Wclippy::unnecessary_safety_doc \ diff --git a/rust/kernel/block/mq/request.rs b/rust/kernel/block/mq/request.rs index 4a5b7ec914ef..af5c9ac94f36 100644 --- a/rust/kernel/block/mq/request.rs +++ b/rust/kernel/block/mq/request.rs @@ -69,7 +69,7 @@ pub(crate) unsafe fn aref_from_raw(ptr: *mut bindings::request) -> ARef { // INVARIANT: By the safety requirements of this function, invariants are upheld. // SAFETY: By the safety requirement of this function, we own a // reference count that we can pass to `ARef`. - unsafe { ARef::from_raw(NonNull::new_unchecked(ptr as *const Self as *mut Self)) } + unsafe { ARef::from_raw(NonNull::new_unchecked(ptr.cast())) } } /// Notify the block layer that a request is going to be processed now. @@ -155,7 +155,7 @@ pub(crate) fn wrapper_ref(&self) -> &RequestDataWrapper { // the private data associated with this request is initialized and // valid. The existence of `&self` guarantees that the private data is // valid as a shared reference. - unsafe { Self::wrapper_ptr(self as *const Self as *mut Self).as_ref() } + unsafe { Self::wrapper_ptr(core::ptr::from_ref(self).cast_mut()).as_ref() } } } diff --git a/rust/kernel/drm/device.rs b/rust/kernel/drm/device.rs index 624d7a4c83ea..ef66deb7ce23 100644 --- a/rust/kernel/drm/device.rs +++ b/rust/kernel/drm/device.rs @@ -83,8 +83,8 @@ impl Device { major: T::INFO.major, minor: T::INFO.minor, patchlevel: T::INFO.patchlevel, - name: T::INFO.name.as_char_ptr() as *mut _, - desc: T::INFO.desc.as_char_ptr() as *mut _, + name: T::INFO.name.as_char_ptr().cast_mut(), + desc: T::INFO.desc.as_char_ptr().cast_mut(), driver_features: drm::driver::FEAT_GEM, ioctls: T::IOCTLS.as_ptr(), -- 2.49.0