From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCFADC71148 for ; Fri, 13 Jun 2025 14:17:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E8A76B0089; Fri, 13 Jun 2025 10:17:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 772236B008C; Fri, 13 Jun 2025 10:17:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63CAF6B0092; Fri, 13 Jun 2025 10:17:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 425FF6B0089 for ; Fri, 13 Jun 2025 10:17:55 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E5E741D6A7A for ; Fri, 13 Jun 2025 14:17:54 +0000 (UTC) X-FDA: 83550581268.11.9C6F884 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2076.outbound.protection.outlook.com [40.107.244.76]) by imf20.hostedemail.com (Postfix) with ESMTP id 294B31C000A for ; Fri, 13 Jun 2025 14:17:51 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=S4rbxxww; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf20.hostedemail.com: domain of jgg@nvidia.com designates 40.107.244.76 as permitted sender) smtp.mailfrom=jgg@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749824272; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jgzJOWzmRJvqH479gTFszeKWD+uz0cxLc5dh5Zglles=; b=0juFmk3nDZJ9rTkxuJ0V2nM9kB/y8pxrQa/oYRYiPsfSXqWHLnABLjyKl6yt3XKJe2S7A3 ZZGd9jL66beSWgWCaJort6M4b1AFHyuNrO1gxNVL52EdHo7G0B0VowAPqGt8fbMKn5m1UB YGCKJvAOdDjcrq8x+r4avFvWLxL3AXI= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1749824272; a=rsa-sha256; cv=pass; b=CrwWCw4yf+oCc97/NwBPD88oXOqeRmojzNtluB1QYdkRKsHUndhwA6A96U/Vpi1v1Qzw+E A5Vmeu2KhngUmzb5hvyWEdi9jUN5mYE6q/Z8C3eApEK0nBsXiksyFlxUHXYKRSMVegNsRB TwmFsNIR8cv69XK0eHbFT1x1NARaWv8= ARC-Authentication-Results: i=2; imf20.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=S4rbxxww; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf20.hostedemail.com: domain of jgg@nvidia.com designates 40.107.244.76 as permitted sender) smtp.mailfrom=jgg@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=H5WS0f10t1CMZ0L4q7eyKRKZLU9fJ3ZrzArnBO4qC4oMwiqxMeQmWAFhcf29mnrIA3ATENujQFdEUdv4kRD1M8D6nciA4rrh1DNX3+S8mnXldhe3aYXKjyRhQeKE2pqk/aHEbgPUqOhqk84iVnK6Y8LfYSqmgOwd+K2DJxqTXPxsdBSAzuZWlD+EZr8XG8gRQjw0IiJinmx50vD4fIg0KALAzYl0CwsfbQDOlo9FVPxqY44eKx3WKLj+xTmhebNJpUgLsteyVpDV1cTXXKXXOx1vtslwGqotoJ1H2/h+yNLGPrU2AmlL3PcIY7cYYBOfio6RBrJ/W0o5lJezpZjo4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jgzJOWzmRJvqH479gTFszeKWD+uz0cxLc5dh5Zglles=; b=C6n1uw8//vdP8kZcpkYJROU0WHaH0NBVfs5liSNnIl54QkOpjbe1GRlcmuHrRw0JJVDxHFLR80JKDOE7mMZT+iUiQyOX483+RgwVXCFEPNTNHYHlsZWDRvYTKoGjSoXJ2oMz9SQuTHrRHfr9dfMQQZzAg8zXe8+5KWa5ECkUyucdTGJnmwjTIbDSSnK6EVrNbz57jXOZ/PloKHlrYFCA0diH0i08+KDF2jERIqMrMskGIhoR5ae6NFRWbqsuwkLdlS89PtGAU/d6nlBAa/Xzt7Wwpiyw+0hIrQzxs4R63TboqbX+PbjIUY+bx55QoJMJBWolHOo9H9lEMh9t1hDIEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jgzJOWzmRJvqH479gTFszeKWD+uz0cxLc5dh5Zglles=; b=S4rbxxwwZV64Ido2V2/BDDIVsVbZqYNRglDSixrp7vWfBb8281MbcUyQlnDYU+HkKU3SzfATGZjGqVaCly6hTHZPdctQdlS+fsv8sQdjtUJWhfRkMElJVmCVqtDD6iKjJ6SMaYucWeQAePD0XfhdV9SHCppfzViVeoh89UF8jLdSmuoeAkmlcQ0jJK7O/FGPD47/fEqDMNB9J7AJsAc2LPrztMr5TJcR13jWMsrp25aiq34JLlkEecqpnCjMDXX6blabN0hqsbdJDol8v2SXOr2iasEdXfONW8VUPatGat//lZnZaOFJp/0PzC0gL8UW9YrVv2iH2966HwAVyFjdtg== Received: from CH3PR12MB8659.namprd12.prod.outlook.com (2603:10b6:610:17c::13) by SA1PR12MB7151.namprd12.prod.outlook.com (2603:10b6:806:2b1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.18; Fri, 13 Jun 2025 14:17:47 +0000 Received: from CH3PR12MB8659.namprd12.prod.outlook.com ([fe80::6eb6:7d37:7b4b:1732]) by CH3PR12MB8659.namprd12.prod.outlook.com ([fe80::6eb6:7d37:7b4b:1732%7]) with mapi id 15.20.8835.023; Fri, 13 Jun 2025 14:17:46 +0000 Date: Fri, 13 Jun 2025 11:17:45 -0300 From: Jason Gunthorpe To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, Andrew Morton , Alex Williamson , Zi Yan , Alex Mastro , David Hildenbrand , Nico Pache , Baolin Wang , Lorenzo Stoakes , "Liam R. Howlett" , Ryan Roberts , Dev Jain , Barry Song Subject: Re: [PATCH 3/5] mm: Rename __thp_get_unmapped_area to mm_get_unmapped_area_aligned Message-ID: <20250613141745.GJ1174925@nvidia.com> References: <20250613134111.469884-1-peterx@redhat.com> <20250613134111.469884-4-peterx@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250613134111.469884-4-peterx@redhat.com> X-ClientProxiedBy: YT4PR01CA0474.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:d6::28) To CH3PR12MB8659.namprd12.prod.outlook.com (2603:10b6:610:17c::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB8659:EE_|SA1PR12MB7151:EE_ X-MS-Office365-Filtering-Correlation-Id: a4ec40ae-be7b-4770-92a5-08ddaa8511f3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?/MA3rX6soXoRD9+wrRbqUQXv6KB/3XArM2LOihuhQwId4ANSL2QE9IHct0L5?= =?us-ascii?Q?uIXSwh8j/5UFbOmqmhVLNamYLcq1mzBtIa6k9XPK8ERmiF1wDp9M2nr9Xciv?= =?us-ascii?Q?pVvDe9L/V6V9G8grJMQvm7cHGoFFHdBpK4cerU+t3AjdoV9QZJsEBZHo1E+M?= =?us-ascii?Q?ZFLC7K90JxGPQY7nmW5GZikb0EcC2ixUw7spipBfBPvYkRcL/dsfl7bm1oNS?= =?us-ascii?Q?QTk1VAFH+06GyCUbVc+jq1aKjTOnRBeIEhWfBre47g99kFt09+Mxx3FQ9n0d?= =?us-ascii?Q?hhhdCwxRHBr+HFM5gwloTnAu80TxrKwvlqHmixY533Em5QBpWN4iyk19koTP?= =?us-ascii?Q?Z9doPRx5hh8DAP19j+6jpxak43n2QY5O4NfXe5hW23KMPD+Ljsi55w1P1tkY?= =?us-ascii?Q?z/90lOJyLIgA5IP3DuAxNpz/7UNp2Ffk8XRRfNaEPXJLLwTnVsmvPfTwMHvN?= =?us-ascii?Q?OsRvvXAxUVtVleS8xFWYdHeIqS3Mu9WD++wSPyzn1kbMiVipCkUXAYIuDZrc?= =?us-ascii?Q?0ThqF09D2BbVKpB0OLzSsTUt5eEqfO44qZk58DnTwhKvrRp5s2UJMp5id6w7?= =?us-ascii?Q?F8UICE3s7obeTXVuJ3mNDz40PPeWhDrMwFmuSQfvXp2G0+6QWAXmErCat0Pw?= =?us-ascii?Q?ECBpFR0VPUTaPmE6sHeH7JTelzOdE2pdJGwLy4abB6I/xMeclKo39Ay4AXOO?= =?us-ascii?Q?pImj3qyrzRJyCqQ/xX12WV6nfhShZarBphy4bOROkmLGYwqBF0Akgv3Q/KbE?= =?us-ascii?Q?8dE/8IEWi1dt1C1iv7MCpNeYTuGhG+AeoEeeIrrnD+/qkjhvkZJLK6Lm762s?= =?us-ascii?Q?kSjCoCSVdEJ6RaDhejw5u1tJ2ujNodZqP/e07ThUkZhhXTAMLlPORYvEO+lS?= =?us-ascii?Q?7rtZiEBEVVmY2gvwDtoYNzxuz738wNjKzxBotVqV1SRgQDO9RHXCqnOcfqtG?= =?us-ascii?Q?o723eMGDCrO/ZQC4p2tGpKr6pLTMxI7wqrAHsFXTFxqeJe04YrA/dbTEj3pK?= =?us-ascii?Q?A3Jb3jDZZtAa/yK9MrFNK22ey38vcySlLF3XW25I8emNeR9MxMOkM825DTUr?= =?us-ascii?Q?57NmRgdQcEcL/CrUEpfZP6A6MK7L671ZVlVKIyr5EUI9b1UHmBW66xmZpCSu?= =?us-ascii?Q?+11yEjUUmTeTQntfVQ/8P+8Q5mQLDQqeLCR0P0+R6uJBFreAnpJ6xoacKIZf?= =?us-ascii?Q?riBPE4FyuEnW8gDsIUqLBJZioAPUIwVvub/n29Cny2hUUxbZ6wX45Oa8+LuD?= =?us-ascii?Q?gEAKp+3jGl2ZR0NTik1CakhNpDxuUmknyTBh6XCaup3IoARjub3GQxIgEUNx?= =?us-ascii?Q?xNcY9CCsP7Z7CxQAh8P+gWnUeZosN67KNmK47wxG+ckW5gwXDgSBFxgP0wlN?= =?us-ascii?Q?/yW3FGab6KKgvgtXUOo88D6hIHZjC6mLnw007m7yZw38SPSdjr41QnicsLfJ?= =?us-ascii?Q?VBnS0ufslzI=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR12MB8659.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8sHdreQkYoIg4QcLyDyuINH88FLfYfsU4NaY3FIQ5f1AXtaXDgAcNuRrB4dE?= =?us-ascii?Q?Of4tfK1G+xLFVqeWI4vB314Y0pSjOZt/RfpGHX1XIQ72rw0IAk2ngQcZuy/4?= =?us-ascii?Q?F0g4T21LqCs/06l6tZAt+dy8pX2HDELdwwhYZg5A5ktXFm2POCofL/e85Dn6?= =?us-ascii?Q?LlVipT0XOt6UFe1rtyh+eBd6FD32AaYIl5wDknG3fP7/iSN15YglkwKyHM+V?= =?us-ascii?Q?p22mZMkkK/g+WTjWYmfuREm+9/qa/d8RA3LFisxl5GfODIicmD4r79WBw0KQ?= =?us-ascii?Q?0nb2ehk43BZTWAzaTEdihvarCuJWAIw9hFrjKCK80nKqGx+95IXYQrUPB8LX?= =?us-ascii?Q?+RsAThihV5pmGnpvCzzj8UABPBfFE6QXg0uqYskwj7BvEmzsoex2d0KkdcO2?= =?us-ascii?Q?vwoe1Sd0JQ1OeXADEE5xzqzbtTZT8WzbyTIxRnTyu6HzU1nmZ/q0S52JXUzg?= =?us-ascii?Q?QdYXXrj71I22xO0hf0AkZbDywWLQdQe2wu5yqPQe4n4LaxDQkYgKytk5Hazn?= =?us-ascii?Q?UyZFaehZEk4g4B6uy0hmemxNVvCRXHq0Rp+xc/k1hdmZhB/8CorvVvhaeFFR?= =?us-ascii?Q?uTQv/S7gWZdontrmP/BX5xFGtA9e7Rmx1kZoyj7WaoLXwXZ0j5cl7nvMzwpu?= =?us-ascii?Q?2cVwuIZ8kcu+3nY3ydHIfYONfQBOibq7m0ttjx4Or6kdnuUqxdnKUf7Os1uE?= =?us-ascii?Q?Vhs+hFSwSlnWjytjrxy7SvNRE9AjOFTmfCIdZPjwP00q0PHcLjIgLApq2GTQ?= =?us-ascii?Q?b2w3vhQekezdEat0JGxXGwzXX/rsZtxJ9OkLpGjor6Mbo98J3L/V75CV8bHh?= =?us-ascii?Q?xtQM3vSyme01HVvPtnOx0VrcyUSkeg20+UId8wy7XhjjnDjpYY47Kwd8FptI?= =?us-ascii?Q?0ENTYrW7XtgpYPVcmrJp41Dg1sbGCinL2agdbQNrJDf+tLqVyY0jDnhiwtlb?= =?us-ascii?Q?93e2Y9UxhotkiQ5drP4qR3V7yg9GLX9lAQRoe8CwLhyMxDOx/XBBm17KB+SQ?= =?us-ascii?Q?3uNJJPo2vBe66bDfowrWj+nqJ8D4M+vh9kb8fz9SP6LoaAY9hMzPghTsOp8P?= =?us-ascii?Q?FShv1vvKCVAZ55d74QNnJV/pXmXaAPoRnvKv5kS33FmVw/IceIZij1gXWjKD?= =?us-ascii?Q?4MhAGdZNXM+dMUGZHE9TIbQc71YCdJyjxGsYwJSoqa3TO/8ToYOoqn1nzdPR?= =?us-ascii?Q?FApzxGt5J3L3H/kAl1dK5DEn3GPHfYNWbWkDZhPXrZ4BLFqiiEddY4jC+KGb?= =?us-ascii?Q?uqEytUYs+5qUSD5xaNlSAXNWeS9m1F0Ay8/dL1f0zeYHZZpuj7+88t3cuF9l?= =?us-ascii?Q?921aMLdRL5vqmgdbq3TVQF3hPnmEakMVoXBYOYEzS1k0OfJ/Q/w+HtBY924e?= =?us-ascii?Q?RMBLceGcsjJExduTGbxHsOj17YTr0nN/JCjpI/JvAkNG3lWaE6D/aE8f0FIh?= =?us-ascii?Q?qIHTuR+h7cSVqrzR9egMqdcQIYRqJvD/moUGRhakBNhhcvV60Q7UWRuDrvuE?= =?us-ascii?Q?0RVr0ArOwCXB6q7PheK3rxLowa1T7Y8AgGOA9DMoYBhvPuj/MuZSVFtRmk/Q?= =?us-ascii?Q?LGNaI9y30rxmcmAmuM603W5U6VtXClmIlbup/81N?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: a4ec40ae-be7b-4770-92a5-08ddaa8511f3 X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8659.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2025 14:17:46.8297 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XjMBTRhVAAqY8NscSTAcqCMxpm2LdhzIzrrKs7CWM2Cf7mM7f75GiXWWvgGCi9YH X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7151 X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 294B31C000A X-Stat-Signature: fxdcfkxyg9ywm665r568ncjfudmwqxuf X-HE-Tag: 1749824271-702361 X-HE-Meta: U2FsdGVkX19NFG3o0nLVFvq9oqurJqqJfRCa4jijASaXlpTweJyckUr4VQD797M0ySvQaI1vmRHZb0+FUcQ6+SqpyrHmuOBJdXoUP91T04HPbydyxjm2ltUgLQaHi0RdV0vXc4p5Eha8ct6EEeEJmlmSQhEV0Q0AEo+HQ0yitIqGXmkQ7UVr/0X5/XIzCxT4bPYmiWQQvC+cKbeafNKv8DVeeWkqp/WtGkTTTapJNesGQQJEiz8JNDGTVGrtFobC01Dmh23eg8H4EJVScfI4/LCt/wv+EBgnDvHfy9zjB33aXxFvhvK+KrbKHbb6V5i1Mo6QL3qJTIB28PZmyL84hA/2+2Ly7eXdBSY/17dSFm83W27IcKuIPCxwjZ6xFhDk16SyeCrw+mRdKERkgJTSgCFJKfILEDB+MpjrrXXXw9+gfSFzpSHc0r+8HvxoNlUf6GA3YE4dSgLjfveuCU9qsRBZDZvaJuEwP3fvzVhXcnyoxV2ibA+htLmTIlSpL6q9N52GFNS33DBBG8O765j6WoaBrjsj/kQPnaVXXlz5ujomL7EYqx0z6dR7l6kJ52I1SUfXqIprHf7g3H1YVFSTOyOL2is8b/vY9fmzShibfaU4QTFrb50KOK5GkN5epYpA4K9wtu63IYdCW+a6cVRJyul6e3YTAksWsVx3OTuMktFtOogIB+m9ksv5yrSk7pZ3T9VtVD6cwvVbdidgre/11abmFC0ooGPG5UJ+eFtFTv6FtVFvm1yXX3L2PSeGTGI44h76PD6rTQg3E8Tv2v7E2Bs8b5FpOqQtA1QwPjA36AJ2glia5ToYMNn1+j56ltnINzaaGG2uL9nemyiX2eFIWgQ3DvTV170br+jHkU0T8N8fKXO7OfEQkIe/TsLYuDDnEbvvNEjfgeHohkItpUfTHPXiCE3fJInIqAiuxXyO8RZbwtfp5KXEpVnR6cVSKfoI82+LoDFo5zgvt2caD1T QbLoU294 opaJ2nopPnvgW1sajc14+DHgdJu1EwMwoPVzUOrXJr1SPQvk8aMxZE9HNCXhmw+Ha86CZMv/ckpn0joq5VkyW34LJhDnT2mbHfi0irkqfh7TZDW3JInrPt9PQ/Gfb8knCmdkKNgqsSRR6QRGZhmyYW9XVOsI6t+acn/TqUCyExIbpKBPS1rmtchItJ88O0II5QD0Tgsh4p91BtP+yT1CN/EczP4ZNua1J2xv/6vNqVKhdYI9o6pKRjKe7yEX1hM8Y9/2+CAhvekU9w/l/uRLuDHO59KIwe9IfPXI0Cnh/apPX+GqOApVZ/VEA20IKQSJ6DRSgrz41sBdilWH+eWMea7niG+LaZTIVTXM3uBPjycy5H/Yga+JLk1OS9v9ZH+FD5ZfngM9MTxUzdqZIMzy+tKDhWpZxKN08IbwVPJZHelHrsk4xNSpgQP5saqet5URzOAJWZixmUtAGDXkUNpYB1ojPX9NPRVf4Eumec1pZhhEt7DZYCIahAM1cSQZJr9TJ55oH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 13, 2025 at 09:41:09AM -0400, Peter Xu wrote: > @@ -1088,7 +1088,7 @@ static inline bool is_transparent_hugepage(const struct folio *folio) > folio_test_large_rmappable(folio); > } > > -static unsigned long __thp_get_unmapped_area(struct file *filp, > +unsigned long mm_get_unmapped_area_aligned(struct file *filp, > unsigned long addr, unsigned long len, > loff_t off, unsigned long flags, unsigned long size, > vm_flags_t vm_flags) Please add a kdoc for this since it is going to be exported.. I didn't intuitively guess how it works or why there are two length/size arguments. It seems to have an exciting return code as well. I suppose size is the alignment target? Maybe rename the parameter too? For the purposes of VFIO do we need to be careful about math overflow here: loff_t off_end = off + len; loff_t off_align = round_up(off, size); ? Jason