From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51B83C71136 for ; Fri, 13 Jun 2025 13:41:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2293B6B009A; Fri, 13 Jun 2025 09:41:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1BD3B6B009D; Fri, 13 Jun 2025 09:41:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0533F6B009C; Fri, 13 Jun 2025 09:41:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D3C5B6B009A for ; Fri, 13 Jun 2025 09:41:29 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8AC47C07B7 for ; Fri, 13 Jun 2025 13:41:29 +0000 (UTC) X-FDA: 83550489498.18.9A1827B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 5533D180011 for ; Fri, 13 Jun 2025 13:41:27 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MeHfT6zf; spf=pass (imf24.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749822087; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=srvKo/GW1EbJBPf9Cl0G9P4CrJB0MZAkcimCCvUCpgo=; b=uw2AV+OhM86VgRCcKd/mX8dr4LuSPEw2IASgtZe1SI2NwoYBYZ3zFsOkd+QoXd5+HoGh33 uaNYRxAt6bZHPk7YuQECa8yO6rAahGwlmryke5FZ0GmOKakMxgAZAOVxOHhfkj84JkxO/F GjWemwY4otJ1V4EUKLiMYaXpNMVayvg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MeHfT6zf; spf=pass (imf24.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749822087; a=rsa-sha256; cv=none; b=kKGX+VxUofv8D0lQ/fzw5mF0JG6/Hp00O+t9hu3HqfpEkRps29hHk9HAERRCPdKMDaUwTa c8ArzolttgWbCBopyZLa7Iet82gjf1Hd39/HUPFyamY5JtdM4OgEF/BN1kND34Gq83jAes GCN3lAjK/NTFoGlYmngKs8rQaJ6Wy4w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749822086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=srvKo/GW1EbJBPf9Cl0G9P4CrJB0MZAkcimCCvUCpgo=; b=MeHfT6zfnIOXS51Sx1RuZ2qnG8W3wb9lfRfphgc+f3/XQXNH6CJnhKwdexnrutdwQ6kAcF /h1PIqfI1v4rJdHsnQz5YEZp2EmdOb+umFMbGpjg8dIX7SJwOMB9ZAet0GysL5T50ppTEs 2BW7FnIjkqW5ZRZhX/kluAilqwGA5RE= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-453-vxB_GPRrO-avLvuDy6SMbg-1; Fri, 13 Jun 2025 09:41:23 -0400 X-MC-Unique: vxB_GPRrO-avLvuDy6SMbg-1 X-Mimecast-MFC-AGG-ID: vxB_GPRrO-avLvuDy6SMbg_1749822083 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7caee988153so372016385a.1 for ; Fri, 13 Jun 2025 06:41:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749822083; x=1750426883; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=srvKo/GW1EbJBPf9Cl0G9P4CrJB0MZAkcimCCvUCpgo=; b=ieQJRdLOqk4u5SepzWMAhLC6/zgmJ/GWtQHriDT34VlSzcOqjZ+3sKKH6OpY0yb83L Qxt61j5H+cqQaXIcH2x+s/wXsI2L08R+Sw9mXUSo0S8Etrf3mDqupWatPpmb01Jk0uvX 5kxwOUctwref+hycMY8Gsrv6uE9Hmpe7WMh6WoWuZN9kRFxJaWyEqxvQFvXPfEoNSvHJ 5Dl7zSFTfYbzgRCHJPEf9tHZm506Edd2SiFKsnXXAiELkrL9dOpJzg7DeZc7o3JPJ6m4 EZeeOEL6AO/DKHiRwzjulwu8U309LdVkHkSbBJ9Ot5v4jTp75vAeQsPszV30oZ0FsLEQ 0LVg== X-Forwarded-Encrypted: i=1; AJvYcCVUF1uH0Hh34bxpgFk6gmOle9Ve0ccWAlCV4rvgH2rESzlJpcmn+uapXpqMTKmfxWIEjW4kKkZM8Q==@kvack.org X-Gm-Message-State: AOJu0YwHRFxEom7xd0xjvzxzfeD6v2yfthTJsa3DqTPyVZDHCLc0DyPt FkgkgaaK72UDbjSt7QikyzpJtSsY4LkAY8YDTx+LuD3O/0K/YfXMQXn2K46uCBNCLhhY2jRt6o4 7MbudnnDofsdPfY0Ycm6Xj9RGxJfy/MOEjZm7mApJYWXLsoF+DUfo X-Gm-Gg: ASbGncvh8t0EKaJszSXQMNIGFrwI3sDHwc/VTYx2bPlvwX0fDZUFjBfOtC9r3/MIxWu QgTDFlPagvOsSBesMEWdEnjWddkxc8GfNzVdkkq50xtTGHjbkx3Uo0MHv8lmqZ8mbW9j30oMhuq riqE+BIalZ6smYHxgoByYrkm8BreRzb7rqNoG/B2aBxtPzPiKNoOO10A8lsfTZ0Yj51Hk2I0/aY ukPFdf8rANJlRWrKxHeygEQA2ept+65paVEVyYRx6W8K1Ts9OVqIGfjiVqE2R3WovhfhfOllTwG VBh8no4wK04= X-Received: by 2002:a05:620a:2627:b0:7cd:3f01:7c83 with SMTP id af79cd13be357-7d3bc44a1f9mr399252985a.39.1749822082994; Fri, 13 Jun 2025 06:41:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGy9xhb6Ir/WTjwOiKTV6R2xWTKghNAist5R7llcPyhmuhj1jELKcIWu8eGBTg4hcMRpO8q+w== X-Received: by 2002:a05:620a:2627:b0:7cd:3f01:7c83 with SMTP id af79cd13be357-7d3bc44a1f9mr399250685a.39.1749822082633; Fri, 13 Jun 2025 06:41:22 -0700 (PDT) Received: from x1.com ([85.131.185.92]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7d3b8ee3f72sm171519285a.94.2025.06.13.06.41.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jun 2025 06:41:21 -0700 (PDT) From: Peter Xu To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org Cc: Andrew Morton , Alex Williamson , Zi Yan , Jason Gunthorpe , Alex Mastro , David Hildenbrand , Nico Pache , peterx@redhat.com Subject: [PATCH 4/5] vfio: Introduce vfio_device_ops.get_unmapped_area hook Date: Fri, 13 Jun 2025 09:41:10 -0400 Message-ID: <20250613134111.469884-5-peterx@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250613134111.469884-1-peterx@redhat.com> References: <20250613134111.469884-1-peterx@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: z5xpUWfmSeC9sI8YXAWtn6PjWUTT1xDR2XVYbjWeR-g_1749822083 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Stat-Signature: msiwdsj8cmdfooad15j51gfqmp3nydxe X-Rspamd-Queue-Id: 5533D180011 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1749822087-566647 X-HE-Meta: U2FsdGVkX19mXbSAThnu0JBaBBjxbdJpeG541JcWXL/Lnz33o+kH7wajPXvHGqMp9UKW93bjqW1TDPxDfJq+bgwulM4LYQpU28MV81BYxEYjER28hP3C/ieI3KOZ06m6k7+FLXQdHq8x668+Qnl2ZjM80gZCFHrWv4bUOhUChSmeAOskH6ggGROvDGB8LH48D6Gr99BREATlDqIgp36wTCfUYJJzStfcXubtjA6UsCoEtG48MDq2qczTkFwCnBThguPSXz8hH5BduhTVBDDVYFNsZMkvceSvBCP2fK8INp0RufDD9gQtpmFqoy7+GcdpS68QwWmO2akRLy/JBW02EsDjqxZbj/PkMbxwmZAZgGOSUqGCCPDFnWffhm+TsW9ilJ99stYcZRAbodIiXgqxjsCn2e7xCAx0B9IviHWY6u8lUOrHfPHzhv26ADm18XnPDx+3U6Emnn52Vk7Q098w5/oR7yCQXdV2KduwAouQ/yg7lB99cfKPQqYw08mcSgl616HmgrFQHaR6Obz2bXQpFCD2NpJ5a40na2RU90ISDmPCj1y2YZB2VgqH31IEsmi4ywGRAtTU+Vsg0j+7JTzNNCOJAHmtYg4W91DThFUtHmmcAzs4bzY16njniAhMzoM6+cqrm2IS1QRwj90mOFgyMl6XBhVwQdy2ZC9dO8KjX3tueOpuNxaJMWq/aDLcAF6GhOPwHEXZWLapG4qEit2eUPe48JKipXfsfUaihEi9j9Dp6cqWHdHVg5t8K6vvi7a14W01GzE3ARSPtGgVlVaX4sa1sTfrnMfFT71jB2VLLPAlhi5OnIZ3CBSLDJ9JUzqLqNqkqXW6tzJ52byG4mBkRjSwXX8MNUu8pePG0pvwQHy06u33dIWzQgeFiMx5DzQt1Az5RD7RRsfASLAHEkDMj3gZjjVLI+ILz3wtRS+G6/P3k46LMa7joF8vDSnO+kRQh8VWV8fs3IXK+Mn8ZbT VHv0ITgv ju730rovs52KLESc+R3AFd1x2itC9FEqGyoN/YOeTMUYBcM9p1TAjCJkJxEu37hBI1pGZXAY7RKADuPK45mmazQXkZJTUcPuWhpdXIAnAZMqNNrS+wfHuw1iMpCzy6i2hgHr/OaQv8xKi3cARLri7FszYapEJf8mkR2QMASx3BOXdcUu+rnxpjkVZUZvCSNjNIcFJ2F8Hjebw12iosGT2BCZirq6rkV2z52Tx7zJCWEOSWpMN3t6osPWT6uh6Kr/mq5qFj3aCgu60whEckXjW0nQ6KB+As6QjeM3zaTPaSs6FJ37PYXA+fzgr/8paC9cZDP6TRG/NR8a02eXYRj8aCo4oTf1Ebbaizi6QQFIdoMCZMXzMKWG4rWukPJft79RLZRwMw/o+YYDe7WML9VMVYuMoEP3zXMHVlw0t X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Add a hook to vfio_device_ops to allow sub-modules provide virtual addresses for an mmap() request. Note that the fallback will be mm_get_unmapped_area(), which should maintain the old behavior of generic VA allocation (__get_unmapped_area). It's a bit unfortunate that is needed, as the current get_unmapped_area() file ops cannot support a retval which fallbacks to the default. So that is needed both here and whenever sub-module will opt-in with its own. Signed-off-by: Peter Xu --- drivers/vfio/vfio_main.c | 18 ++++++++++++++++++ include/linux/vfio.h | 7 +++++++ 2 files changed, 25 insertions(+) diff --git a/drivers/vfio/vfio_main.c b/drivers/vfio/vfio_main.c index 1fd261efc582..19db8e58d223 100644 --- a/drivers/vfio/vfio_main.c +++ b/drivers/vfio/vfio_main.c @@ -1354,6 +1354,23 @@ static int vfio_device_fops_mmap(struct file *filep, struct vm_area_struct *vma) return device->ops->mmap(device, vma); } +static unsigned long vfio_device_get_unmapped_area(struct file *file, + unsigned long addr, + unsigned long len, + unsigned long pgoff, + unsigned long flags) +{ + struct vfio_device_file *df = file->private_data; + struct vfio_device *device = df->device; + + if (!device->ops->get_unmapped_area) + return mm_get_unmapped_area(current->mm, file, addr, + len, pgoff, flags); + + return device->ops->get_unmapped_area(device, file, addr, len, + pgoff, flags); +} + const struct file_operations vfio_device_fops = { .owner = THIS_MODULE, .open = vfio_device_fops_cdev_open, @@ -1363,6 +1380,7 @@ const struct file_operations vfio_device_fops = { .unlocked_ioctl = vfio_device_fops_unl_ioctl, .compat_ioctl = compat_ptr_ioctl, .mmap = vfio_device_fops_mmap, + .get_unmapped_area = vfio_device_get_unmapped_area, }; static struct vfio_device *vfio_device_from_file(struct file *file) diff --git a/include/linux/vfio.h b/include/linux/vfio.h index 707b00772ce1..48fe71c61ed2 100644 --- a/include/linux/vfio.h +++ b/include/linux/vfio.h @@ -108,6 +108,7 @@ struct vfio_device { * @dma_unmap: Called when userspace unmaps IOVA from the container * this device is attached to. * @device_feature: Optional, fill in the VFIO_DEVICE_FEATURE ioctl + * @get_unmapped_area: Optional, provide virtual address hint for mmap() */ struct vfio_device_ops { char *name; @@ -135,6 +136,12 @@ struct vfio_device_ops { void (*dma_unmap)(struct vfio_device *vdev, u64 iova, u64 length); int (*device_feature)(struct vfio_device *device, u32 flags, void __user *arg, size_t argsz); + unsigned long (*get_unmapped_area)(struct vfio_device *device, + struct file *file, + unsigned long addr, + unsigned long len, + unsigned long pgoff, + unsigned long flags); }; #if IS_ENABLED(CONFIG_IOMMUFD) -- 2.49.0