From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74817C71148 for ; Fri, 13 Jun 2025 13:41:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C89286B0093; Fri, 13 Jun 2025 09:41:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF09E6B0095; Fri, 13 Jun 2025 09:41:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A161B6B0096; Fri, 13 Jun 2025 09:41:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 84CE86B0093 for ; Fri, 13 Jun 2025 09:41:22 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 14DD2100E4B for ; Fri, 13 Jun 2025 13:41:22 +0000 (UTC) X-FDA: 83550489204.22.EC2177B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id CFCCC180008 for ; Fri, 13 Jun 2025 13:41:19 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AOyrcaUT; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749822079; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z7W5IE9G9/u3/1BfK2SYpnNa28U9EpjOusASuWz1vAk=; b=av3nTn/Y/U3s+gckxrlEYPRPwOUSyCXFFMV3cDG5D/1yfz1K90WZCSIq0q5um0GzB67buU EVoYOlt8DKR354EjCRr77HEV08m525fFeLDZTPCNqQotdmGmaYgt0D6LHONizfCip8bDfN 8Csc/+HzREBDPy/JJWCNVMyeDODbNt4= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AOyrcaUT; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749822079; a=rsa-sha256; cv=none; b=FTU5FN1yAhZqov/mQGVbrEgGSreYVmrbsJ2u05Qa61uED05LoK5/dVerhF/I7etH6ta3Sf 860YbF/opsly4sJavcLuLU8d7lKfFpqeOJc4Q+iOZGPHGVaaEWarOEwPdDdtBJUuFPUFZx Tj5Re0EN0BUIz2ZxTMF6h7ZU0NLNWDY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749822079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z7W5IE9G9/u3/1BfK2SYpnNa28U9EpjOusASuWz1vAk=; b=AOyrcaUTc8SHm9pCR4ATfMoWxk2CN5kxSWqSo/zLXL9Owz9ruIkQ3XGVx/AVtlSyDMe5dm a1dS3UjFRzeu4SpZE5fodWoIx5SZmW98u3T0S2DEHXUBknPCV12wPjC74fgyYBIerNOM1Y wCTc8NmIrQ+OOg1UyaNLhVVNW3HqlPM= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-675-OqWXf2f1Mvepms-RN7D2RQ-1; Fri, 13 Jun 2025 09:41:18 -0400 X-MC-Unique: OqWXf2f1Mvepms-RN7D2RQ-1 X-Mimecast-MFC-AGG-ID: OqWXf2f1Mvepms-RN7D2RQ_1749822077 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7d097fd7b32so506870685a.2 for ; Fri, 13 Jun 2025 06:41:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749822077; x=1750426877; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z7W5IE9G9/u3/1BfK2SYpnNa28U9EpjOusASuWz1vAk=; b=TjawMCWt6Fk+NQStgnASLYCSCJPlLI3kwIfDcHTm9hZfM7ldC2m6Kv5tyXvUW4PBsE 7dcBOxNYMP24uSvj/xc2uBtie0J4ewdl54mKF8B+IF5A9OQfQ1bntRYqWdJ2+D4ZY4yb TF6XEGzdDmuR8c5gsgKdDTJNOqOh1Wp4vjLi13yfAoLGpwJkOtjO7wfY6cwwN08KRX+H p9DwatQcJo4+7SzcqeOlpIHjG8jiIOqqjB0S7arr8c9hR2ZJ/ckJzSDK3zKXwtYtqDoA bPf93TcFN6C2a2fxCx9VUdCq+sflFZaJoGkKrEDL7C3m0gF3FujnTbbimgY7ChMkhzUq TR8g== X-Forwarded-Encrypted: i=1; AJvYcCWObtg/GMg2FkvYCiBV6EVjuP7sWJvzg8qot1he9sO2L95jeDBIPcigh8RQ0rUDp/uB6w4E4nDICg==@kvack.org X-Gm-Message-State: AOJu0YyAw7V91C9+kXpYGAPLOnlwOggQSDVonZdYEaxxjfubMh8/hPAd XS3OA7EPnH92Mr8MXe+u0mXI397ik5S8ZiRnx4WL/DfoaUrVuDijc0fSuqgexUY01oF959NsmXq qucX5YXc6IITS/NO+BMuedPsFzWGonrq6caoB+Lha+X4UHRzsN01d X-Gm-Gg: ASbGncvgLOHX+vs+zZVVtZiYnktmvWlJQEg7Fe2EJYGZG2nLO5VC6LfSJqOH4pw7WzQ Yku09HMZ85r+Ep+qKLOWqv5y/HgSGeeEid/ik782lZRSG8ZC5oIwtyVuj1rLjEYY8bJhzJ72kge POAI1Gs7ZiGrdGIPOTXtAeVWckC9uIxLBPogOQW279ZnSB1i4OcHzSeMFKvyTLW0X+EUGMnibOP 1SO3KeeO+16vY29KRhf4K4gbWoGirbnLKq1UN6y/ayXUZAZJpEZ3giIRWeq7xujmsgGt8qiaTy2 uLruisWlCsI= X-Received: by 2002:a05:620a:3728:b0:7d3:914b:abe8 with SMTP id af79cd13be357-7d3bc4475a7mr706292585a.36.1749822077496; Fri, 13 Jun 2025 06:41:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFLW9momYNJwfmPgxDbKad4mtJlNzLyJURmiqrfzObWILrSALY5rlf3s+E58Q/NYKr9xf6MiQ== X-Received: by 2002:a05:620a:3728:b0:7d3:914b:abe8 with SMTP id af79cd13be357-7d3bc4475a7mr706288985a.36.1749822077027; Fri, 13 Jun 2025 06:41:17 -0700 (PDT) Received: from x1.com ([85.131.185.92]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7d3b8ee3f72sm171519285a.94.2025.06.13.06.41.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jun 2025 06:41:15 -0700 (PDT) From: Peter Xu To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org Cc: Andrew Morton , Alex Williamson , Zi Yan , Jason Gunthorpe , Alex Mastro , David Hildenbrand , Nico Pache , peterx@redhat.com Subject: [PATCH 1/5] mm: Deduplicate mm_get_unmapped_area() Date: Fri, 13 Jun 2025 09:41:07 -0400 Message-ID: <20250613134111.469884-2-peterx@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250613134111.469884-1-peterx@redhat.com> References: <20250613134111.469884-1-peterx@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: CNoqNCtDjFm-hS8NO-IeHNdwWp-KPRbhD-k_pgB_Cnk_1749822077 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: CFCCC180008 X-Stat-Signature: c7ky3tpxyixxqtaixotfmcdntozyjpwi X-Rspam-User: X-HE-Tag: 1749822079-777452 X-HE-Meta: U2FsdGVkX18AAJcbO+zjSLNhKjOeoUNUkzoD5QtphjQ+e3FEqPKZLyPGCZmpuLfMBeI9TTLPmay9aRBvQw7PLbaZXwYkUasGZfDjF0Vpc+dqRVE4OtU2Qi2v+sXjab2zYMSNEGSsuxwFWXqFvy2e6coWtSwprSUiCLDdu5FWKKVWIEicT8ynTMv+viLQ6tBFV1kUS0JhKA1h1aeeVR2HTVq+cSwSxNMVxjAEkeKZxWkTO78XJ83JEf1XqRWew4CbpZy9o30IMewrZy9iK4HoTz1CbclxuquRaYyosVesP/7E6/RmBqi5loM77x/ghFN4es3Zq9noVj+PGDikUZmU8Wa/IZeYdJB2jJzM78aMWDQqjzBrAij53yc0yh1iAGSD6yJ2Dl9Vs/1NU7k55GoROPJGgNW52OwOcmFHz5pcggst2ZU2DRWHgiDjJi1OtyjVykKOHccW+t7dN5xo8zK7vBvaow9Q/B+ZZV1KQ/gGsBhJ+oF0FLJaHhzPpUtG3NxiHo2OMovOmLiVjWe+G0IaJWZu3zImVupe4HEKslga5LDs7Zx+DGUrwbhC3gP/VuE/adPSQFZFRm5O2HnqnILYw8ksjQeiMTbKqvO3nCj32dyvD8xfggVSaJW82I2he/A+e+AKSKoTrAdJGscC04VTGt1+1ohUSRgtUJludRIyvOQrl0uZ6sYLgwyK0dymU3A4za3tv/CKuwqeCFL7w57jNzu6kWE3WzO6dIC+Fompck6Tv7+1ls8IwVfLLEYbJlh4Tlnzf9rMRmIXZcsXaleySoySFyMoOqRZlFaEU2KFgRmxZyjaqhddQ7WiOqnbbF1lQwtB/dfTu3Obh3mqNX9q2SzQXpH/kaa0P19Sq3JCw4mjvQp2ZE1MJkpGE32w5o5W8xBfrd1SMmly5bYAKLOdyiaQHGBWg1qZHxwbrFQv4uMF0X4j0NIJcqggu8ma3gR9P6h87vhLjGg34/1KLg2 oJt+vacY oxGqBf6Gf8UC/54KgXOHtITr0Zgjssx3pQR1SbyqwJWd4Kgd5C+pMYGypkqlR0AdPb8sWX8GxFLXBkJyprpWmbrmKRimcJnk3YrfbGGlLqznphVOm2w4J2bWrHDz5sJfxLlWR+NVi+y/lG2ZQpPNGXU4VEHQx4Q+YwiJQjfnSuuIMEH1DYIPYcp9sp7EoSHAwn2+Xr+VH+DVky/DmHIEjlRgYDGq/g/RMPFPaqaEi5LRsJjTpLJkRpML44np/TflXmi4wWMcX+HqviaiISncJdQD94nZfgydjMGbcjaBHTNc0KCCAcEDmnA7t4WgMmmo5Z2CzUJXFIxVzaU7P3cE0zxKG5lpGDT2KVoS7YHcmbVu06usyE9euD1XV8rLjMrPsu5hMMUEvZsJJg4bcy/IGyKrTDVCRFGy0G9qL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Essentially it sets vm_flags==0 for mm_get_unmapped_area_vmflags(). Use the helper instead to dedup the lines. Signed-off-by: Peter Xu --- mm/mmap.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/mm/mmap.c b/mm/mmap.c index 09c563c95112..422f5b9d9660 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -871,9 +871,8 @@ mm_get_unmapped_area(struct mm_struct *mm, struct file *file, unsigned long addr, unsigned long len, unsigned long pgoff, unsigned long flags) { - if (test_bit(MMF_TOPDOWN, &mm->flags)) - return arch_get_unmapped_area_topdown(file, addr, len, pgoff, flags, 0); - return arch_get_unmapped_area(file, addr, len, pgoff, flags, 0); + return mm_get_unmapped_area_vmflags(mm, file, addr, len, + pgoff, flags, 0); } EXPORT_SYMBOL(mm_get_unmapped_area); -- 2.49.0