From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E96A6C71135 for ; Fri, 13 Jun 2025 09:27:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 50AD56B0089; Fri, 13 Jun 2025 05:27:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B2446B0092; Fri, 13 Jun 2025 05:27:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 269B36B008A; Fri, 13 Jun 2025 05:27:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EF6096B007B for ; Fri, 13 Jun 2025 05:27:11 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7AE9FBF35D for ; Fri, 13 Jun 2025 09:27:11 +0000 (UTC) X-FDA: 83549848662.02.FE848EE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 1C62A4000B for ; Fri, 13 Jun 2025 09:27:08 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="SF4tNt/W"; spf=pass (imf17.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749806829; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=eA9hGBugFKNk6aXi/MtXxZpnAai7SGsOuKl0QrS3BOQ=; b=MgX/+xEHRWkppW4VWN2pt/s6cF9bYFJpDxfZxJWlSZuHHQoCefUf5sAL49+xEOhO0B//QU frIMNYWz86AjAfLp28SjytkXnL2rRwsngXT3PtV3RlmQ4TnxYJSSySve0/tHYJUkiLc+rl MYnQ+OVMwj6T4kQk1l3YVPCIms2R0ww= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749806829; a=rsa-sha256; cv=none; b=Qeeb2bg+bTZFS1DVg4PuIoPrQVMYQ69fXyZHfAzynWg46XFK1e2b2d2o6A/gHKju/hZnvH 3bMGfUskvvW1OA0n+UvrldNkYa2fHcNqk5lnq3SjhLSWOcELntsdolJj/sIabNRVmfoANA jBbNLbNoji45F6G2M4szH9VpMJGubJQ= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="SF4tNt/W"; spf=pass (imf17.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749806828; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eA9hGBugFKNk6aXi/MtXxZpnAai7SGsOuKl0QrS3BOQ=; b=SF4tNt/W+7uSySIR0vI2W3HDUJk3VwO5Eon0EY4v8THbTjqf3AcMKTNl4W6KacnQZURrA3 Y/ckQD6KrRg96T8PD/Qhtn0w41UZ53LfFJk2wEyJIzCHnK/nweHe3tKanfX7qNkMKuuRSO ArMAe38BCchItGH3W90Vs06bXEc8bHk= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-417-E0Uw4Ow9OLCr53I_rzQpQg-1; Fri, 13 Jun 2025 05:27:05 -0400 X-MC-Unique: E0Uw4Ow9OLCr53I_rzQpQg-1 X-Mimecast-MFC-AGG-ID: E0Uw4Ow9OLCr53I_rzQpQg_1749806824 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-450d9f96f61so16060845e9.1 for ; Fri, 13 Jun 2025 02:27:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749806824; x=1750411624; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eA9hGBugFKNk6aXi/MtXxZpnAai7SGsOuKl0QrS3BOQ=; b=Y8MRpqbX7BoAFK8UrZKaEYPqbp7By8hD5niEGrD4ZNWUfGJmXvtayLn0soEWeYfYj1 EQaZwxRZYaKGNGDPSjZxycbmxESLx3D/3dg2P6D3Z2ZSYsJZRwIOiop/bom98l5YK/+r ihCXWdLKwQA8Lpebjs0WtA+JL9GpXKXGlKEcXqC+6jRIf22MDLHLi2so1ER8PMQ11moe t086Rx6Q3wyVdCLuI9m7MvwZlTlcuKimVUD/ou6ubJ0sk07LGOs6dDZ6A8VXwCzAcLsh 43GB2YsJ5+daNKt/oNaBq41etWSVqMzPVqO+5jh36SK2LGeLlccSsoWWXvyWSbjs0xgO q/mA== X-Gm-Message-State: AOJu0YzusN9Mb0dnwpEaXJDBCfg8H/+smWLGgWkf8lGigOKFoS7LlM7c FxIjJm6UEzYdTyTdiPWIPNZtCX9vTCdPK9Z0EMIgAPU+6qukKTsGtChqTzAYG8hkfmxM2YjFj8/ LA5zhVtlIUHEF+iRk/ObL7PMvbh2A+M4MOfRx/njtG/R4fny39CV0 X-Gm-Gg: ASbGnctu2+Nv4cPnXYtuFomfF+TWrcWCNZP+lgcMmC38cuqqfxt5xUqvppX3R8YJzSO 9LDn4+y80RGb0ns8Oc39rVWWLlL4PUiBgQBjgFvQdw1FEPPO84Ffft1JyaFQYtw9LeJxys4M08X 9CoviDkRckPF2tf6U4ObYSsLV5yzdtBbiTo/qWGikmRe2GZSOpXBXMlfnyys8MBvy/RTWMSfq/H 3UsJha2Thws8IYHrvJRcmVNSrFw3e9ipn/Ua3EFn/0JxcrDGR3E8YLRKpj3xkaDxkUPhzAvhmsx PqTurHPvWXZMxAoQi9jKA12bejD9OwuJqv4h0edyXpPuQ4vBYcrMuzuihIGDP3eqdQJ9ChlK3Tt ufWvOM/Y= X-Received: by 2002:a05:600c:1c19:b0:442:e9eb:cba2 with SMTP id 5b1f17b1804b1-4533499edc7mr24668045e9.0.1749806824360; Fri, 13 Jun 2025 02:27:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGERaE8MR+6/dmyK3cZQ7xtwJhWFU3zCcnVAfTUdbkGjRrz6rE1iR9ahL+Nyc7gnKqK2+FRCw== X-Received: by 2002:a05:600c:1c19:b0:442:e9eb:cba2 with SMTP id 5b1f17b1804b1-4533499edc7mr24667655e9.0.1749806823907; Fri, 13 Jun 2025 02:27:03 -0700 (PDT) Received: from localhost (p200300d82f1a37002982b5f7a04e4cb4.dip0.t-ipconnect.de. [2003:d8:2f1a:3700:2982:b5f7:a04e:4cb4]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a568a73a7bsm1822993f8f.36.2025.06.13.02.27.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Jun 2025 02:27:03 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, David Hildenbrand , Andrew Morton , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Dan Williams , Oscar Salvador Subject: [PATCH v3 0/3] mm/huge_memory: vmf_insert_folio_*() and vmf_insert_pfn_pud() fixes Date: Fri, 13 Jun 2025 11:26:59 +0200 Message-ID: <20250613092702.1943533-1-david@redhat.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: bIV9FB-zzZnUdvjxXP4OvEVERJmF2fz-F0br6TgevBY_1749806824 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 1C62A4000B X-Stat-Signature: zcj8sh5c5tged68cx9bi81zttjt6izrc X-HE-Tag: 1749806828-585852 X-HE-Meta: U2FsdGVkX1/bVeGilNQCyuWZa9mawmoELq5/hP2+wdk6CzccPqIXkL/LgzVQ3s/2k+4RJZbaOiqNaENXXMiS6DJqhOOffAhiuotkwt58y/hHSZQct2F/RvKxSpW9GclxvQQiGkCEoQKRQlb6pJWRiorH5LU3Nf19JS99oHf08/zWUqomqhkFMS4tBs14O8qhnHBfg/iV3qj0WPJEWveC93tsIq6AnSUWD6pw7Dgh1FXTPnLth7ffox+3tT3g+yJHzlku+Wtgc5cRZsiOeK+4DySvrh8XpZr3UQ6qahqfd4Vb3J09EuguUQtQX/cEFRkwOhc9Ij7RFzYOccAv++thHNQUdCJjPIIyOQ11lw2kgL1/QfENrbbW6xtNHos7O3DK+j9KDG5R3tuwhXqkY/AAXqY+hp2P/QYxxNEPlChyQEUDwklUZ4fMhfstBpVUW5l17jaWbH5DX+F1ej8gTbsANc3vUvlMbX8CEi7LjAUpYgQO+MbBEqbeRe7620zSwbNcbRRS6W0TzEomMccFSxD3rhWZykOQKncST9zHSfIQ9Xe3hZSzpNfFQnCekkFRSD59jYe3nK4wth+Q2UCyEweo2b859IBALaAD59i2uv+GDeL9ZWc7JsUplXTMHHUTSEwmBuXsaewuXVwamozTtyf+yuxRq0fLwHjPdfSi6iHFQan0kH+C9/dKAClvESCDsFMAPvGRok1czZgfFhgyLjxXaGxDz+j5EtxMpuFI/6fTTHSd/QcHf1fbf2aysp5Cp/yMd2V+6Wcc1aBmvA2Ey38PSAcu2Y3fyH2C7dKNqaAHBsGxJpM1a9w7jolZNFZbP/sdIai6atU/7s9TbYK5d8oF+jtSTXnF/YVqLluntUx1Ocs13ksGMgHBF+lxYlkaLSJmfxXosLZY8UbUe2axfnooBNEB7eJKpomI2m/cWIeAC7r4P+oiuOtRW7PKxS0S3RI9UD8/UxkBqOw+gT+7Orp aQTVaP7R m2q3YVi4rWYdibpwd3ZPHrTsDJQvYcKgWUStcBPMhDXvA5/Bb7Ta8aBoiZMfIFwPl7mjn+tnaH8m1ZccK7dI9axpx9kofra9T7QSibB9mOo1JXW06muFcLJhnWoQLUJN4H/AurDX/w5GgW/AiWLdd5vw7N7Kd+VNUJQVkkjyDLca6rf/xwWlsRj60yQ8pJU8Jrm73hbLIgcT8wjj0OFDsjnvw6rNRyJZAgwg/xYAgzLQCqM/5DNb9Hfr6qyvquz54/CFlGV5y/2VzmVEr8CbXbp/0WX3Q6dtVN4JUu4E+RMSu6EHS2kEqoAayDBRCWr4EYLbS+sGPhUpr8aHZ0z9Rud+UXJSXI9Qs6tFrya3w1WTFfz4LK4VvnTDY3cAA1kZetNsWQJp+y3/0DJ+m9G0wptyIrQ9k6hBy/JLxUZlLw+MlAzatQCjSzruFy+zLIeJlyrzSVYNsoCU2A/JX8vhTPrNcpHujC5G9xQizA6KUUK7j2t745YVL3z5Y2avlOKzvu03+9LWPAu7SBHi2LTG4DOkcQaBDfMfcCfd4gEEafrroicqgPX0xTA4sAQS9JGSKI4/iBXVvuWGF6yrIf86tu0G8criG9l9/Cw/wKKOk/NY3UIj7cahOsr5RJWmRpjJuCg9mKDDclhIrxeMj5QSV+e2o7K2izYWFgqOmRhPXT+eDQ31tUIuOE3Py+dSdoPf80/9/Py9Es0VtcmyWaoJKHPhunyQwE7VF0vVvR5o3y06ZyFNAVXMnXAZukzYTFeEBBQhDFeVp/NX6hSrYBViYfB5PqnU2UwGQJ9HonozGU14bfm5rmUJZj6MIibqcaKNWZgo62by2Y6HUKHKTnThNxAcLOvP1z5mOvXiQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Based on mm/mm-unstable. While working on improving vm_normal_page() and friends, I stumbled over this issues: refcounted "normal" folios must not be marked using pmd_special() / pud_special(). Otherwise, we're effectively telling the system that these folios are no "normal", violating the rules we documented for vm_normal_page(). Fortunately, there are not many pmd_special()/pud_special() users yet. So far there doesn't seem to be serious damage. Tested using the ndctl tests ("ndctl:dax" suite). v2 -> v3: * Added tags (thanks for all the review!) * Smaller fixups (add empty lines) and patch description improvements v1 -> v2: * "mm/huge_memory: don't ignore queried cachemode in vmf_insert_pfn_pud()" -> Added after stumbling over that * Modified the other tests to reuse the existing function by passing a new struct * Renamed the patches to talk about "folios" instead of pages and adjusted the patch descriptions * Dropped RB/TB from Dan and Oscar due to the changes Cc: Andrew Morton Cc: Alistair Popple Cc: Lorenzo Stoakes Cc: "Liam R. Howlett" Cc: Vlastimil Babka Cc: Mike Rapoport Cc: Suren Baghdasaryan Cc: Michal Hocko Cc: Zi Yan Cc: Baolin Wang Cc: Nico Pache Cc: Ryan Roberts Cc: Dev Jain Cc: Dan Williams Cc: Oscar Salvador David Hildenbrand (3): mm/huge_memory: don't ignore queried cachemode in vmf_insert_pfn_pud() mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pmd() mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pud() include/linux/mm.h | 19 +++++++- mm/huge_memory.c | 112 ++++++++++++++++++++++++++++----------------- 2 files changed, 87 insertions(+), 44 deletions(-) -- 2.49.0