* [PATCH v2] selftests/mm: Add configs to fix testcase failure
@ 2025-06-13 3:49 Dev Jain
2025-06-13 6:08 ` Anshuman Khandual
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Dev Jain @ 2025-06-13 3:49 UTC (permalink / raw)
To: akpm, Liam.Howlett, lorenzo.stoakes, shuah, pfalcato
Cc: vbabka, jannh, pulehui, linux-mm, linux-kselftest, aishwarya.tcv,
broonie, ryan.roberts, donettom, Dev Jain
If CONFIG_UPROBES is not set, a merge subtest fails:
Failure log:
7151 12:46:54.627936 # # # RUN merge.handle_uprobe_upon_merged_vma ...
7152 12:46:54.639014 # # f /sys/bus/event_source/devices/uprobe/type
7153 12:46:54.639306 # # fopen: No such file or directory
7154 12:46:54.650451 # # # merge.c:473:handle_uprobe_upon_merged_vma:Expected read_sysfs("/sys/bus/event_source/devices/uprobe/type", &type) (1) == 0 (0)
7155 12:46:54.650730 # # # handle_uprobe_upon_merged_vma: Test terminated by assertion
7156 12:46:54.661750 # # # FAIL merge.handle_uprobe_upon_merged_vma
7157 12:46:54.662030 # # not ok 8 merge.handle_uprobe_upon_merged_vma
CONFIG_UPROBES is enabled by CONFIG_UPROBE_EVENTS, which gets enabled by
CONFIG_FTRACE. Therefore add these configs to selftests/mm/config so that
CI systems can include this config in the kernel build. To be completely
safe, add CONFIG_PROFILING too, to enable the dependency chain
PROFILING -> PERF_EVENTS -> UPROBE_EVENTS -> UPROBES.
Fixes: efe99fabeb11b ("selftests/mm: add test about uprobe pte be orphan during vma merge")
Reported-by: Aishwarya <aishwarya.tcv@arm.com>
Closes: https://lore.kernel.org/all/20250610103729.72440-1-aishwarya.tcv@arm.com/
Tested-by: Aishwarya TCV <aishwarya.tcv@arm.com>
Tested-by : Donet Tom <donettom@linux.ibm.com>
Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Signed-off-by: Dev Jain <dev.jain@arm.com>
---
v1->v2:
- Add CONFIG_UPROBES (Mark Brown)
- Add CONFIG_PROFILING (Lorenzo)
tools/testing/selftests/mm/config | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/testing/selftests/mm/config b/tools/testing/selftests/mm/config
index a28baa536332..deba93379c80 100644
--- a/tools/testing/selftests/mm/config
+++ b/tools/testing/selftests/mm/config
@@ -8,3 +8,6 @@ CONFIG_GUP_TEST=y
CONFIG_TRANSPARENT_HUGEPAGE=y
CONFIG_MEM_SOFT_DIRTY=y
CONFIG_ANON_VMA_NAME=y
+CONFIG_FTRACE=y
+CONFIG_PROFILING=y
+CONFIG_UPROBES=y
--
2.30.2
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] selftests/mm: Add configs to fix testcase failure
2025-06-13 3:49 [PATCH v2] selftests/mm: Add configs to fix testcase failure Dev Jain
@ 2025-06-13 6:08 ` Anshuman Khandual
2025-06-13 11:04 ` Mark Brown
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Anshuman Khandual @ 2025-06-13 6:08 UTC (permalink / raw)
To: Dev Jain, akpm, Liam.Howlett, lorenzo.stoakes, shuah, pfalcato
Cc: vbabka, jannh, pulehui, linux-mm, linux-kselftest, aishwarya.tcv,
broonie, ryan.roberts, donettom
On 13/06/25 9:19 AM, Dev Jain wrote:
> If CONFIG_UPROBES is not set, a merge subtest fails:
>
> Failure log:
>
> 7151 12:46:54.627936 # # # RUN merge.handle_uprobe_upon_merged_vma ...
> 7152 12:46:54.639014 # # f /sys/bus/event_source/devices/uprobe/type
> 7153 12:46:54.639306 # # fopen: No such file or directory
> 7154 12:46:54.650451 # # # merge.c:473:handle_uprobe_upon_merged_vma:Expected read_sysfs("/sys/bus/event_source/devices/uprobe/type", &type) (1) == 0 (0)
> 7155 12:46:54.650730 # # # handle_uprobe_upon_merged_vma: Test terminated by assertion
> 7156 12:46:54.661750 # # # FAIL merge.handle_uprobe_upon_merged_vma
> 7157 12:46:54.662030 # # not ok 8 merge.handle_uprobe_upon_merged_vma
>
> CONFIG_UPROBES is enabled by CONFIG_UPROBE_EVENTS, which gets enabled by
> CONFIG_FTRACE. Therefore add these configs to selftests/mm/config so that
> CI systems can include this config in the kernel build. To be completely
> safe, add CONFIG_PROFILING too, to enable the dependency chain
> PROFILING -> PERF_EVENTS -> UPROBE_EVENTS -> UPROBES.
>
> Fixes: efe99fabeb11b ("selftests/mm: add test about uprobe pte be orphan during vma merge")
> Reported-by: Aishwarya <aishwarya.tcv@arm.com>
> Closes: https://lore.kernel.org/all/20250610103729.72440-1-aishwarya.tcv@arm.com/
> Tested-by: Aishwarya TCV <aishwarya.tcv@arm.com>
> Tested-by : Donet Tom <donettom@linux.ibm.com>
> Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> Signed-off-by: Dev Jain <dev.jain@arm.com>
> ---
> v1->v2:
> - Add CONFIG_UPROBES (Mark Brown)
> - Add CONFIG_PROFILING (Lorenzo)
>
> tools/testing/selftests/mm/config | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/testing/selftests/mm/config b/tools/testing/selftests/mm/config
> index a28baa536332..deba93379c80 100644
> --- a/tools/testing/selftests/mm/config
> +++ b/tools/testing/selftests/mm/config
> @@ -8,3 +8,6 @@ CONFIG_GUP_TEST=y
> CONFIG_TRANSPARENT_HUGEPAGE=y
> CONFIG_MEM_SOFT_DIRTY=y
> CONFIG_ANON_VMA_NAME=y
> +CONFIG_FTRACE=y
> +CONFIG_PROFILING=y
> +CONFIG_UPROBES=y
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] selftests/mm: Add configs to fix testcase failure
2025-06-13 3:49 [PATCH v2] selftests/mm: Add configs to fix testcase failure Dev Jain
2025-06-13 6:08 ` Anshuman Khandual
@ 2025-06-13 11:04 ` Mark Brown
2025-06-13 11:08 ` Donet Tom
2025-06-13 11:47 ` Pedro Falcato
3 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2025-06-13 11:04 UTC (permalink / raw)
To: Dev Jain
Cc: akpm, Liam.Howlett, lorenzo.stoakes, shuah, pfalcato, vbabka,
jannh, pulehui, linux-mm, linux-kselftest, aishwarya.tcv,
ryan.roberts, donettom
[-- Attachment #1: Type: text/plain, Size: 183 bytes --]
On Fri, Jun 13, 2025 at 09:19:12AM +0530, Dev Jain wrote:
> If CONFIG_UPROBES is not set, a merge subtest fails:
>
> Failure log:
Reviewed-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] selftests/mm: Add configs to fix testcase failure
2025-06-13 3:49 [PATCH v2] selftests/mm: Add configs to fix testcase failure Dev Jain
2025-06-13 6:08 ` Anshuman Khandual
2025-06-13 11:04 ` Mark Brown
@ 2025-06-13 11:08 ` Donet Tom
2025-06-13 11:47 ` Pedro Falcato
3 siblings, 0 replies; 5+ messages in thread
From: Donet Tom @ 2025-06-13 11:08 UTC (permalink / raw)
To: Dev Jain, akpm, Liam.Howlett, lorenzo.stoakes, shuah, pfalcato
Cc: vbabka, jannh, pulehui, linux-mm, linux-kselftest, aishwarya.tcv,
broonie, ryan.roberts
On 6/13/25 9:19 AM, Dev Jain wrote:
> If CONFIG_UPROBES is not set, a merge subtest fails:
>
> Failure log:
>
> 7151 12:46:54.627936 # # # RUN merge.handle_uprobe_upon_merged_vma ...
> 7152 12:46:54.639014 # # f /sys/bus/event_source/devices/uprobe/type
> 7153 12:46:54.639306 # # fopen: No such file or directory
> 7154 12:46:54.650451 # # # merge.c:473:handle_uprobe_upon_merged_vma:Expected read_sysfs("/sys/bus/event_source/devices/uprobe/type", &type) (1) == 0 (0)
> 7155 12:46:54.650730 # # # handle_uprobe_upon_merged_vma: Test terminated by assertion
> 7156 12:46:54.661750 # # # FAIL merge.handle_uprobe_upon_merged_vma
> 7157 12:46:54.662030 # # not ok 8 merge.handle_uprobe_upon_merged_vma
>
> CONFIG_UPROBES is enabled by CONFIG_UPROBE_EVENTS, which gets enabled by
> CONFIG_FTRACE. Therefore add these configs to selftests/mm/config so that
> CI systems can include this config in the kernel build. To be completely
> safe, add CONFIG_PROFILING too, to enable the dependency chain
> PROFILING -> PERF_EVENTS -> UPROBE_EVENTS -> UPROBES.
>
> Fixes: efe99fabeb11b ("selftests/mm: add test about uprobe pte be orphan during vma merge")
> Reported-by: Aishwarya <aishwarya.tcv@arm.com>
> Closes: https://lore.kernel.org/all/20250610103729.72440-1-aishwarya.tcv@arm.com/
> Tested-by: Aishwarya TCV <aishwarya.tcv@arm.com>
> Tested-by : Donet Tom <donettom@linux.ibm.com>
> Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> Signed-off-by: Dev Jain <dev.jain@arm.com>
> ---
> v1->v2:
> - Add CONFIG_UPROBES (Mark Brown)
> - Add CONFIG_PROFILING (Lorenzo)
>
> tools/testing/selftests/mm/config | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/testing/selftests/mm/config b/tools/testing/selftests/mm/config
> index a28baa536332..deba93379c80 100644
> --- a/tools/testing/selftests/mm/config
> +++ b/tools/testing/selftests/mm/config
> @@ -8,3 +8,6 @@ CONFIG_GUP_TEST=y
> CONFIG_TRANSPARENT_HUGEPAGE=y
> CONFIG_MEM_SOFT_DIRTY=y
> CONFIG_ANON_VMA_NAME=y
> +CONFIG_FTRACE=y
> +CONFIG_PROFILING=y
> +CONFIG_UPROBES=y
This looks good to me.
Reviewed-by: Donet Tom <donettom@linux.ibm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] selftests/mm: Add configs to fix testcase failure
2025-06-13 3:49 [PATCH v2] selftests/mm: Add configs to fix testcase failure Dev Jain
` (2 preceding siblings ...)
2025-06-13 11:08 ` Donet Tom
@ 2025-06-13 11:47 ` Pedro Falcato
3 siblings, 0 replies; 5+ messages in thread
From: Pedro Falcato @ 2025-06-13 11:47 UTC (permalink / raw)
To: Dev Jain
Cc: akpm, Liam.Howlett, lorenzo.stoakes, shuah, vbabka, jannh,
pulehui, linux-mm, linux-kselftest, aishwarya.tcv, broonie,
ryan.roberts, donettom
On Fri, Jun 13, 2025 at 09:19:12AM +0530, Dev Jain wrote:
> If CONFIG_UPROBES is not set, a merge subtest fails:
>
> Failure log:
>
> 7151 12:46:54.627936 # # # RUN merge.handle_uprobe_upon_merged_vma ...
> 7152 12:46:54.639014 # # f /sys/bus/event_source/devices/uprobe/type
> 7153 12:46:54.639306 # # fopen: No such file or directory
> 7154 12:46:54.650451 # # # merge.c:473:handle_uprobe_upon_merged_vma:Expected read_sysfs("/sys/bus/event_source/devices/uprobe/type", &type) (1) == 0 (0)
> 7155 12:46:54.650730 # # # handle_uprobe_upon_merged_vma: Test terminated by assertion
> 7156 12:46:54.661750 # # # FAIL merge.handle_uprobe_upon_merged_vma
> 7157 12:46:54.662030 # # not ok 8 merge.handle_uprobe_upon_merged_vma
>
> CONFIG_UPROBES is enabled by CONFIG_UPROBE_EVENTS, which gets enabled by
> CONFIG_FTRACE. Therefore add these configs to selftests/mm/config so that
> CI systems can include this config in the kernel build. To be completely
> safe, add CONFIG_PROFILING too, to enable the dependency chain
> PROFILING -> PERF_EVENTS -> UPROBE_EVENTS -> UPROBES.
>
> Fixes: efe99fabeb11b ("selftests/mm: add test about uprobe pte be orphan during vma merge")
> Reported-by: Aishwarya <aishwarya.tcv@arm.com>
> Closes: https://lore.kernel.org/all/20250610103729.72440-1-aishwarya.tcv@arm.com/
> Tested-by: Aishwarya TCV <aishwarya.tcv@arm.com>
> Tested-by : Donet Tom <donettom@linux.ibm.com>
> Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> Signed-off-by: Dev Jain <dev.jain@arm.com>
Reviewed-by: Pedro Falcato <pfalcato@suse.de>
--
Pedro
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-06-13 11:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-13 3:49 [PATCH v2] selftests/mm: Add configs to fix testcase failure Dev Jain
2025-06-13 6:08 ` Anshuman Khandual
2025-06-13 11:04 ` Mark Brown
2025-06-13 11:08 ` Donet Tom
2025-06-13 11:47 ` Pedro Falcato
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox