From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D766C61DB2 for ; Fri, 13 Jun 2025 11:44:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F0B5F6B008A; Fri, 13 Jun 2025 07:44:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EBB796B008C; Fri, 13 Jun 2025 07:44:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF83A6B0092; Fri, 13 Jun 2025 07:44:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C21946B008A for ; Fri, 13 Jun 2025 07:44:49 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 49669140308 for ; Fri, 13 Jun 2025 11:44:49 +0000 (UTC) X-FDA: 83550195498.12.82BD4DF Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 730E91C000F for ; Fri, 13 Jun 2025 11:44:47 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=U5J4HV1n; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749815087; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=Jhn9WIEXEwpnvGbBjHf1KHjg4mIbW3zwtuo0oewZyfw=; b=HUHZIum2/+Oq0909to8IOrD1DytA5kmFYBPceFU/YX9TZX2YPrZTbJYOoDog6p72wDCu1B VwhN+KndG/Mo+dDcEIN+t2S7fvXkCjVGDt1BocvbKVg7PyNloKXpIsP5rOjI6fHgHBj1OF oqxgiQ3jpkWJndQttqmkxkpMDYqV2b8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749815087; a=rsa-sha256; cv=none; b=lsR3rr4XgM1ksFeek1REe1XBeY24N2vVEsjZQotlJWI6rj0jVGCl0pnVB6CXb1hlhj0bFT L5zmUNU+sV7O4MtVYIWQ50URRx/RxnwcqaG/UyS13F7TjGjANZscgEYfXCz4nEsM170Cxw mZ994MW2J3PX8EruFRUhbCocsEZ9qb4= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=U5J4HV1n; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9AB2E5C58EC; Fri, 13 Jun 2025 11:42:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93389C4CEE3; Fri, 13 Jun 2025 11:44:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749815085; bh=67C8SauhQy4UDCcOAF3lc1WX/+uxuBUuNm519MYFsJc=; h=From:Date:Subject:To:Cc:From; b=U5J4HV1ngFV03Nwvqb+pAc9sD31Mp9qvuZ+EGB52Y6jF/3OC7/HfsjDzu4k8i+Soe FvRsQ2iRGAN9oFXErAmU3anccqP0S7a6bGyg0Pl1fciAyaZrLdCjduIGlrMR3Grni1 xdUoHg5UJQSqLtaoKFyrhefka+A0FnGjaJeKFN/ssjB0I8ZePHTS9pS3wWYcBKv/hj itJAjs45025+JsvzDANFT5Rue+VygzqJz0kPG7thfQH70VvyA8U3Czj6btyfFqfTuL w0nDZq+GvPC6sRzi39c7ZW4JmxfF27YrpNk+8YqAOyZ3CXTGlzfrQnvAaL2nMFypxD JXr0I5HxGxfGA== From: Mark Brown Date: Fri, 13 Jun 2025 12:44:07 +0100 Subject: [PATCH] selftest/mm: Skip if fallocate() is unsupported in gup_longterm MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250613-selftest-mm-gup-longterm-fallocate-nfs-v1-1-758a104c175f@kernel.org> X-B4-Tracking: v=1; b=H4sIAAYPTGgC/x3NywrCMBBG4Vcps3YgCbaCryIuQv0nBnIpmViE0 nc3uPw25xykaBFK9+mghj1qrGXAXiZa374EcHwNkzNuNos1rEjSoZ1z5vDZONUSOlpm8SnV1Xd wEWVnIfN1cTeIoxHbGiR+/6PH8zx/0+23KngAAAA= X-Change-ID: 20250610-selftest-mm-gup-longterm-fallocate-nfs-21ef54627ef2 To: Andrew Morton , Shuah Khan , David Hildenbrand Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown X-Mailer: b4 0.15-dev-c25d1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1499; i=broonie@kernel.org; h=from:subject:message-id; bh=67C8SauhQy4UDCcOAF3lc1WX/+uxuBUuNm519MYFsJc=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBoTA8refSwnoxdJb+107nNprcOEDsjz4KiGYmcVQTM W1F/HCmJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCaEwPKwAKCRAk1otyXVSH0FtkB/ 4+8N5ND04NyqzZJemY5vFK3k75oeTztrRfRyyZ3JvwmcCNAyZZ/S2SYtMfxJCnFaRVBCCrLG3cS6oD zS7FYy6q384+Svt1Eu6qfqAFTZrRXA1Dt+fdXTTEsAcYZk5lzEYMhRn+Pkw5E29gEYcSJp/LVAw6zz 37lA18qLoghB7nm3ndxqQdW5Ip+DPFq1ZKSo5Gtm1NntVlVFb0KvEcYEOr1n2jTO3HIvEmDkVa9d+6 lj7pH6N8b3KQR/TaopssA/UlZovbnNeS6DH+1AaDd9szj+rW5yfQKQ83WoEQ8ozXn6/Bbs+v5aBP3+ zcDOiUi+Df9d7jjbqpT2NDIHX+F5ew X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 730E91C000F X-Stat-Signature: wp3ycg36i33myo57h9gg7iw3kfszu4f8 X-Rspam-User: X-HE-Tag: 1749815087-799380 X-HE-Meta: U2FsdGVkX19ry6rdmBITI2gOAuHitk+q+ge2gnPLN7KIfZabNBslxXDQluPBQ+Q2rgyI7g8KoYatXk/ez9l+myPDbq3FJQd9xO+CIOlP/bJDacMBQUyCAVmOE7Od0MHZK6v1OjIp9LECyUSzZPagUszXISOs8Hg0DSQ1/ZNxpLPxAIZR5uSkqmuWv2qlPEsgkbE5SVT7zmVDgbmQU/PpmyaEBmDExGGmLKLL5E71CgJeFn+zMvwHuG/mvNlc/m3GBqYBOoplDNFx/iPTwzow0BRA2WxpULiEyYi20IlEjZXpd8XSKFL4AxudeHs6h98Xq2e2GcfvAVmvu7gAFZpRT6GdmZiz5r6v0NBl481GRishyBJA+Sla0hsEpEyUyDOB768eOTJr7/P5fyM6noIvnwBD0p3ERbTP6GSjfyXE7sWv9RDycrbKDunfMjc25wcPkiS40mCs3SduvBOcvKPYxLUvumb0dfVKR18L/1bUdLAyPXd+MURqIm4a2f1f6syW3e3ZeV2FCP/6dz44WjnMmvdueFwvlb1JGEAxKzAJLhGNFheldfgaD5IiojhXSdaoVjbMQm4OJkvvERSyZXWxg2mRhGhrH/qCugcrKHbQC7UfLYmNq2sbKP6NFpBKCG2iesAmTTp7vUbwED4aQM20woqOV8wJ/ePXMthR1ac9zypQ4f+VM5najmS5uUrANmRZP03MhrNsTtC7bOrUxtkbIKH+DAEMj1eYEpPVt9Y9lHy+x1kxkmPv1ndCbfNPU6cci5d/yds+exreDE5e06RuBhUll2/swQ95lbHMJUMUBKPDGMIGIGYkzgnwc9pkB5mpEI5jug3VZqFfpsjMFdI3+udvl26NU8UrM+DIDxi2ZXOebw67MMpSyDkhY5cR1KodRBaI1fC5E/7sC4stxpAdkOBDo5phepZlk4MbW+PbJc39VA/eyGzdatYtGj0idQ5conPMLZ8Ysjg1T3fBPW4 b2k9SxzS tORbeXvrAZJaveHnQwJsbGKqNe51Vq3NSKXyexZevWvbXW5WpUIU8sY0ZPuQNcR5nL7EXtaVm6dc8b2L4nQyMTTOaNyWthED4eqpWdo/y1YpLt5S+MZyim4+tQSGit3M3cQgjwXgF3VTHJxZZ04pYws6VLKquMMBGigK4ZeI4I1ZX6QxvoO0pED/JB2TYpUhjx6q1L1vf6Nw9Cpmz80y+wY/NaIf5MDXsS2ljtXE/TppOhlFqqCLZlm1yqemWjNjn0swhPoNTszNqjaQJlmGlfOrMkd03rcgVj77J X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Currently gup_longterm assumes that filesystems support fallocate() and uses that to allocate space in files, however this is an optional feature and is in particular not implemented by NFSv3 which is commonly used in CI systems leading to spurious failures. Check for lack of support and report a skip instead for that case. Signed-off-by: Mark Brown --- tools/testing/selftests/mm/gup_longterm.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/gup_longterm.c b/tools/testing/selftests/mm/gup_longterm.c index 8a97ac5176a4..0e99494268ed 100644 --- a/tools/testing/selftests/mm/gup_longterm.c +++ b/tools/testing/selftests/mm/gup_longterm.c @@ -114,7 +114,15 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) } if (fallocate(fd, 0, 0, size)) { - if (size == pagesize) { + /* + * Some filesystems (eg, NFSv3) don't support + * fallocate(), report this as a skip rather than a + * test failure. + */ + if (errno == EOPNOTSUPP) { + ksft_print_msg("fallocate() not supported by filesystem\n"); + result = KSFT_SKIP; + } else if (size == pagesize) { ksft_print_msg("fallocate() failed (%s)\n", strerror(errno)); result = KSFT_FAIL; } else { --- base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494 change-id: 20250610-selftest-mm-gup-longterm-fallocate-nfs-21ef54627ef2 Best regards, -- Mark Brown