From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07B03C61CE8 for ; Thu, 12 Jun 2025 15:21:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5997F6B0089; Thu, 12 Jun 2025 11:21:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 570E26B008A; Thu, 12 Jun 2025 11:21:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 487C36B008C; Thu, 12 Jun 2025 11:21:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 297B06B0089 for ; Thu, 12 Jun 2025 11:21:10 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9DF375FBB2 for ; Thu, 12 Jun 2025 15:21:09 +0000 (UTC) X-FDA: 83547111858.27.FA9BA01 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf12.hostedemail.com (Postfix) with ESMTP id C024440015 for ; Thu, 12 Jun 2025 15:21:07 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=XaiYzB2A; spf=pass (imf12.hostedemail.com: domain of will@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749741667; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=drjDvrrw4mJFoILdSf7D8mtW8M84pvZBDvAYOC3Fxds=; b=RUL0zq0r3akClLZZC59T28eeSLy2fX3OZETs1mjnt7LshlULdJBr3nCH9sgQkuJPa5erGu w02KZ3OTujubMxvK8WZv2NGAKJBktG3dnvuruKTw8N4ZDpxW3TLQfbxDIkbT1IwRZ8/Udn gDc6I6Ye+zxIwazMj9TSA9wGLDqbN2g= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=XaiYzB2A; spf=pass (imf12.hostedemail.com: domain of will@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749741667; a=rsa-sha256; cv=none; b=foPfsluvi88gQNfCr9MmR3BAho80dDKg3iNg95343xkjzZ5YuOOhFVt9vFpLpAzaJx1O3Q AaEXYEEgJHyhWcPp0VG0AcUATGjTcTKTCjhqaaA5kwh5VTDiK5GgQdQi0fJsEuYa0J0GHu 0bY6Zq/D5aj8nzK3J32ruCazROvbOCA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 622CB44805; Thu, 12 Jun 2025 15:21:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89ACBC4CEEA; Thu, 12 Jun 2025 15:21:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749741666; bh=wshbG/vQ6UX9QKzvPFllw/wGW4HRGOaCAzXepA4wqWI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XaiYzB2Af7RXh0Twpx+T1OBL4I2ke8snzfvGviZYp+JvsI80bLXqv1VwQ7/bZvCAB jizLTAUq6IHMdMIAuO0x67PXluwMf2ftZJNMOparAc6c+UshciGzVnPEpDNw/sVwkR ZPBrUrcdppmPGKgeJQHc9UkW8StOvC7G/0cn8iK+2eVUWiLznnW74BA+2oAQ89O/Gy 2W0appmJNEt1/IrH8cz1kMuoc9pMa4Dl/JJPtYNlNMUDF4IZ+ek/ZgGGrjwzsj6Vzi ROXQfNq1C0bDEhqoDOPCn6t75lY9Th9OUowpOVsmqGOVfe00p/d12aL3fiTFh/yqgA fIK6za3tIWq5A== Date: Thu, 12 Jun 2025 16:20:59 +0100 From: Will Deacon To: Ryan Roberts Cc: Andrew Morton , Catalin Marinas , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , David Hildenbrand , Lorenzo Stoakes , Rik van Riel , "Liam R. Howlett" , Vlastimil Babka , Harry Yoo , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH v1] mm: Remove arch_flush_tlb_batched_pending() arch helper Message-ID: <20250612152058.GE12912@willie-the-truck> References: <20250609103132.447370-1-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250609103132.447370-1-ryan.roberts@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Stat-Signature: rmuuqwhknzc7kgjkwooz6xiz3ggjx1a8 X-Rspamd-Queue-Id: C024440015 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1749741667-719281 X-HE-Meta: U2FsdGVkX1+B40f9RUcA0FNu8aL5s9otuCw9I9R0wdK2OylN5UTnYkmGbz51NDqkGA/UaJFV4GSCWvXbM4sRxY4DeFvnsJvtdUIj7kLDiujtDRxEuJH9BPzDYRfLubV4qkrqQJuMcR0nnLJC2cvozHXxS27azcWwXYXkOWXcJ9TFDW9TbXxOoTqj7UkWgyNI9q99cKHliZskITLHMusL20L8UEgkQWAGbyEGZ+WRi6P/Pi/LkRmsRHIGzOMVrAulcDCp7o+5MOqfyKEAFUd60KAPEZ69yOtG4h5gKW828ht5akV3BybJ3/9RGLFbjPhsCpOcd+z2lfzmZ0UpawogwAHWrf4Y2fYXsrooaZcTbD7xU0BTXGv8FqEZLlrDqBU1Qa8iflOZJJJuw4yYTEMrz9CTPRBKGfASOAyokpuvjnG+1zwvYTRH7QMdSfHQzMQdVZ9bV79oaEJfn/CFqbGFA5ZuWWM2x06+Bs/WU7gdO8vEMSBW2+Wwvnr0+eZniuyG45S43lisrtRtW5n9hwRXSvJ4P3/raHhSC8eCBVxPrm8CGfQUg6w9WUL0L1UISTd7MPTdRRhOT35u5PPj+ivlDTgQXN9dYs6lGgau5jVliJt95AyQl3T65wa6e7qbBEueg2r3l8LxdS05uG28kp3aygXDjjnxKQkKpmZqEzfE0QiQFvmId/ejtuUz1Q/4x12M9J8E1XS35zcSHTVPjr/fb+FcDcidHfTrD/jDIbsF74pSWYXNr28HXeEynnXQiwUTBIrVKnpPz9yRxWCUj7ji1WuYnD8mc9aUL44RXtluUhNrgx2p05ZI4fxuDChCAhm/6CK1078DVnP5j5KnxJIzYH4glLLg+G+Gwqs6OMDqk3UhPUK/eo9OX442hEPFOypeAQF1vCeGLcIdbrQQ6DU8nACnn87csuj/OmXcEp6FhCYVjm8KOc+jCcGWweVoZB2tApTq7g7dX1HdAl3dAgw 77eZFMoA /sJ/bzc65TxDEb3N7xpokl0j4AdfqVN01863pu/sbPF+K3YLETnYjPpar0nX4NRDQm0VuHOx2RU6fU/jFB+4g4epqfEkHctKdLZzM8sSKTuSOChaTDyfTPQ/ifivf/t5VXAqBD0nOKjYtpq79fEiCGROw/HN+0I/UamEXnY4mCmHo7SLnOv43hs7QgWP53d1UdzWBORWl8DZt30uSRXtQa2/NL+Rx+sLQX4TocEmqbYUrZke80xOhKBFZxEszY8IF/wTSsHVtLnGuomOoD+qNWDhQ2WbLYNMNiXNpYVfwPdF6JE9VtXbkFLQdt3cWgNevym4OJMgyvExQgUBITTg9UF4jQFuwXIYsSJFK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 09, 2025 at 11:31:30AM +0100, Ryan Roberts wrote: > Since commit 4b634918384c ("arm64/mm: Close theoretical race where stale > TLB entry remains valid"), all arches that use tlbbatch for reclaim > (arm64, riscv, x86) implement arch_flush_tlb_batched_pending() with a > flush_tlb_mm(). > > So let's simplify by removing the unnecessary abstraction and doing the > flush_tlb_mm() directly in flush_tlb_batched_pending(). This effectively > reverts commit db6c1f6f236d ("mm/tlbbatch: introduce > arch_flush_tlb_batched_pending()"). > > Suggested-by: Will Deacon > Signed-off-by: Ryan Roberts > --- > arch/arm64/include/asm/tlbflush.h | 11 ----------- > arch/riscv/include/asm/tlbflush.h | 1 - > arch/riscv/mm/tlbflush.c | 5 ----- > arch/x86/include/asm/tlbflush.h | 5 ----- > mm/rmap.c | 2 +- > 5 files changed, 1 insertion(+), 23 deletions(-) Thank you, Ryan! Acked-by: Will Deacon I assume this will go via akpm rather than the arch tree? Will