From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28F1FC71136 for ; Thu, 12 Jun 2025 12:16:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A9A16B007B; Thu, 12 Jun 2025 08:16:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 85AA26B0088; Thu, 12 Jun 2025 08:16:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74C2D6B0093; Thu, 12 Jun 2025 08:16:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 51A2C6B007B for ; Thu, 12 Jun 2025 08:16:03 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E5BDA12147C for ; Thu, 12 Jun 2025 12:16:02 +0000 (UTC) X-FDA: 83546645364.09.27E03AE Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf29.hostedemail.com (Postfix) with ESMTP id 6D97612000A for ; Thu, 12 Jun 2025 12:16:00 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=ZRCoBG68; spf=pass (imf29.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749730560; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oWUl518ENhE+I//VZIwKOVmltiU0ODOamU9HtHFT4ko=; b=mHpn3t7d0jyKGcmYH/fBjK1/0VXj+5kKwnPc7ZM/SnwM9CwwJkb5bFZB+5nVweps9/5Yog 3kg6hql7DauupIX9SHNP0SM2mlwDXSlkec3O4o81xuRV09rN+AZNZdBPISdeV7xUfuIh07 myEMWSm9295ZicniP7nNyLjo/TcoY/8= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=ZRCoBG68; spf=pass (imf29.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749730560; a=rsa-sha256; cv=none; b=VqDZXFytA92YAs0huDMIi7nXO/yWY2usWIu1ADd0E1pQCXCLzQciVMCElOUH7ZMR2V9cXC kzdfywSer3HZMjl69fUVQKjstlmCzf1odaysxQ8O4/TqzJuqJg1LrN7yK7ca8b+AOjzVZx d5n1Euu5kPwjWwiTzahQulh6np0GDVU= Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55C8QlUb000795; Thu, 12 Jun 2025 12:15:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=oWUl518ENhE+I//VZIwKOVmltiU0OD OamU9HtHFT4ko=; b=ZRCoBG689NVVhqLKP7vze5DKf2BAnmXTflsjNIThBvGPlI uIEJjP7Oxdueu/uF/ilUISry/+blVmZrdj1lI4jwmIajuM02kQ5aDHC/waEHNGXE ZgjTahqs6XRKDwMwJjxn8qbmWyZetP6waqHk6dZiPSsact1WHPo/WMIeNovJYUhF lMl6tMhY4UP5duvOTtZ82rXt3LhhcnVlad71gbpqMG5o8t7tIK2j/YypwZQ7mEY4 8DMYXv1nYzmb6NVT530Uhx5rx1q5hjKlfdSEC58ezgD4lFfQUP+UxuejtKCvbLxX soIZ/o8ePAlbVKhv19rd4cllToF/i83nwTy1RSwg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4769wyy8wq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Jun 2025 12:15:54 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 55CCFCUT001664; Thu, 12 Jun 2025 12:15:53 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4769wyy8wk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Jun 2025 12:15:53 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 55CB5COG028110; Thu, 12 Jun 2025 12:15:52 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 47518mmhw8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Jun 2025 12:15:51 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 55CCFmwq52822512 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 Jun 2025 12:15:48 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0788E20043; Thu, 12 Jun 2025 12:15:48 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BBD7120040; Thu, 12 Jun 2025 12:15:46 +0000 (GMT) Received: from osiris (unknown [9.87.144.171]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTPS; Thu, 12 Jun 2025 12:15:46 +0000 (GMT) Date: Thu, 12 Jun 2025 14:15:45 +0200 From: Heiko Carstens To: Hao Ge Cc: Andrew Morton , Suren Baghdasaryan , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Richard Henderson , Matt Turner , Dennis Zhou , Tejun Heo , Christoph Lameter , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Kent Overstreet , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-s390@vger.kernel.org, Hao Ge Subject: Re: [PATCH 2/5] alpha: Modify the definition logic of WEAK_PER_CPU Message-ID: <20250612121545.10868G00-hca@linux.ibm.com> References: <4d78498def57e0df4c768ad9eb672cac68fb51dc.1749715979.git.gehao@kylinos.cn> <20250612112215.10868Da1-hca@linux.ibm.com> <496a782f-25f8-44c5-88dd-d2c56a585898@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <496a782f-25f8-44c5-88dd-d2c56a585898@linux.dev> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 5ECCCBaGq-b_DYDsiRkDmnLOEbpQwJim X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjEyMDA5MCBTYWx0ZWRfXxUECaCqM6x6t s7fRYZxCkwb+mfNdorKCrdr9h/2Kd4a8ptgDxMXlhfwJhlnf4o9fYI3szL9PEzFn1EKlYFBHcqP G30vWpgQIxhLvtBJNMBfpj8TIO0lqXNbcNzgvYYuEG1/3AmcfyzoBAijj/vGkQ1kRg7QhstqhO3 Q5o1etjsLGxmuaOTnSNxQn9GuOMbSKlYl5TeA9wrog8RdFr6+WfMn6kbHJHJG50gAH/1a0Fg1nE nbdiY39ZoeTcdD++XEWZcVQfurnvkixl3gxvBRhWHQGjfCDaRtCvXNbTExpYbE7OxmhYD03Tmag 1frXCKZ0FWX1VSlu+1XRb/XqvAmxiPVe+qrQQdKPtT08EDcHLOj3G8FOW8FFdgG9gbP5wq9DLDH 9kZfXuXfr1QTd7E+0m1yGiG7bLJNpRC+ec+YSs6AaHnYevnOAAgMqw6xtkL5+BZ43RjyNkv5 X-Authority-Analysis: v=2.4 cv=YKGfyQGx c=1 sm=1 tr=0 ts=684ac4fa cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=kj9zAlcOel0A:10 a=6IFa9wvqVegA:10 a=PvjgP0zBWn8W4tAsNlkA:9 a=CjuIK1q_8ugA:10 X-Proofpoint-GUID: uWhc6G93y2Cxo5Tu8uuCIUnZGVE0d5xZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-12_08,2025-06-10_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 malwarescore=0 bulkscore=0 priorityscore=1501 phishscore=0 mlxscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 mlxlogscore=621 suspectscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506120090 X-Stat-Signature: sb6mixitbesorkhuh8bz7f5hccwq5kyz X-Rspamd-Queue-Id: 6D97612000A X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1749730560-456167 X-HE-Meta: U2FsdGVkX1/fb87k8Bx2nANcNboyK/KxLaY1SLIk25FZTD9HSl6RXSFu7Wa79Nd/E27YUsvydXpBqxumKj41E+mu6vOkokMOn+QHVpNHonyFr4LIU62C1AW8bk3agRbUdOenhQAtPg6HxA+psdzGRZjEYrcCo34p0t4ZtIpF1k4rpv2NHpiq6oaUNsYOyXOGkenL6EdDBIRiB0iOM7c9JGiKYcMrCSIo2SaAomZFfdpQn44814RlqHFFc9cO7YiabyOvPo057CVHu+sgboMx1YaO4lR1UcJrnryRc2am0fqgEn1UTXu4A2MyEhSyKVX+UCbujl4hZ81IdtLFeS12WVeVxZt+1yUdUd8WGAxqoSqIl+1zXWKTZHVD/36oW3U5+sb+jseKJrE9c9HgOdZ9Xc6xleGvJgawgetqXSQ0tVrVLhtbm7/931Nbe6C2m/Egl2GHYFl9aeEtCvzOg8wizigWycA/+yNfsuGGW5K1RiZXV6S7NxNBh3COCyKwsxqBLXYHfo7N3I3tXvoMG4o1fBAQ+DvUvyVN0YJ3egm1xAFgdTNQLFUq8BWA5fwrXI2xRORs0WzTtQs6EE5hfm8IMHfsMXiy/sHIbHbLATsy6yVCEcKok8a5qOIRnrGQxcNnfScDjVID3+KEjuUqeKkbM8b80OMOJI10TAaTcwVJ8rKZw/dJmhyJ/0Bl8clvl16QfI7/uVUhIov6xR/YSJJEG+k8l7LYpxh4Xrr8BNK/T9ZbKWY1q5HNXM/fdf6mi6fBVyk+dz21XIa+R/CUgKPtXwFlAz1RDNcAnTwfv+2J/fw8nK+JXTnVlwDweSLSgsO+NVJIf9dOBDhi8+1N33WOtUNtkDRjcbgeNoftDEsw3XX0AkDV8JoU9ad7NB269fNr0gt0sSVhy3DJZpVidJRCestkHqxTc4W0nEjylL5t+HuJGkjhnp7ggBHicoPom8lzsT6g0XPFk6i9f1+m91b 83B8E57u 6xecAnOpLpjlPgOr25Et+huJcB/I0R4ltqic//DdxtjhmcT5UN0h6UHe6YVG5jIDuPodPFB8skFh98ZH3HdiLfoFchTypjocWyztHVPu5pAHtlng/BnMkvZbKEdXArPiBDOJfBgB1U8qEu2XpAQ6FBnncf6CpWvrlOYVm+D10S0kOBftJkec8ED7x2y88/dDJa9bKcZH1kuRwZKzmP1tXpGB6rkSF6ottkRW4RMyTfSlcWK2o0NNtQ4M6MzflA421PLLwn91DevnO73o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 12, 2025 at 08:06:25PM +0800, Hao Ge wrote: > > Furthermore this removes ARCH_NEEDS_WEAK_PER_CPU and defines > > MODULE_NEEDS_WEAK_PER_CPU while the common code conversion happens > > only with patch 4. Or in other words: if patches are split like this > > things break. > > > > Same is true for patch 3. Just merging patches 2-4 would be the > > easiest solution to this problem. > > I think this should be CC'd to the stable branch. Why should this go to stable? This is just a minor optimization. > I'm wondering if these need to be integrated into a single patch. > > I'm not sure. What do you think? stable or not: this series must be bisectable, which is currently not the case.