From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53126C61CE8 for ; Thu, 12 Jun 2025 10:51:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E9B776B0092; Thu, 12 Jun 2025 06:51:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E4BC26B0093; Thu, 12 Jun 2025 06:51:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3B2A6B0095; Thu, 12 Jun 2025 06:51:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B648C6B0092 for ; Thu, 12 Jun 2025 06:51:50 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 71A23121037 for ; Thu, 12 Jun 2025 10:51:50 +0000 (UTC) X-FDA: 83546433180.27.DC32EDA Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172]) by imf23.hostedemail.com (Postfix) with ESMTP id D770514000B for ; Thu, 12 Jun 2025 10:51:48 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=samsung.com (policy=none); spf=pass (imf23.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.172 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749725509; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lsTG9Law3p4/aJm9Zrapa6QwteUVIwe1U5idkUId8cs=; b=p6JXaZ+9y/DtRDkSYh0+mgI8vaQwHtBrDEbyz8K5X3MRxu7uyNMqEyoWfvSH/55xRWUjyZ c0wy+X6IwSxe2ynat6oV4RyDXE5CTYhcGSVRxY1Dv2dazZvH4EHH0BcN49qnNlPJ0OfV8k Y29lF1xkEaQBxEmns2TASCVTkgUiJ6A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749725509; a=rsa-sha256; cv=none; b=Vis+MI7dMZ6CDfDCwxBb5J3Kjq6GQqqv0Yi2VwWhknIWnSDV8WTrhMSQKZGp+ABwLZjh7R houKuExN0E7jWVRI+orGsuRC5+tcQDjAXp5hNanx1ABpQ7Nb3TjYLOOJyrUnEn5qKiBFro JEDzgRafEDWU/ZEtulCXVwsD+DXP9Xs= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=samsung.com (policy=none); spf=pass (imf23.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.172 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4bHzqP4ZBmz9ss0; Thu, 12 Jun 2025 12:51:45 +0200 (CEST) From: Pankaj Raghav To: Suren Baghdasaryan , Ryan Roberts , Mike Rapoport , Michal Hocko , Thomas Gleixner , Nico Pache , Dev Jain , Baolin Wang , Borislav Petkov , Ingo Molnar , "H . Peter Anvin" , Vlastimil Babka , Zi Yan , Dave Hansen , David Hildenbrand , Lorenzo Stoakes , Andrew Morton , "Liam R . Howlett" , Jens Axboe Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, x86@kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Darrick J . Wong" , mcgrof@kernel.org, gost.dev@samsung.com, kernel@pankajraghav.com, hch@lst.de, Pankaj Raghav Subject: [PATCH 5/5] block: use mm_huge_zero_folio in __blkdev_issue_zero_pages() Date: Thu, 12 Jun 2025 12:51:00 +0200 Message-ID: <20250612105100.59144-6-p.raghav@samsung.com> In-Reply-To: <20250612105100.59144-1-p.raghav@samsung.com> References: <20250612105100.59144-1-p.raghav@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: bup95ca67ksojth1oanu4iypc5jdjrwt X-Rspamd-Queue-Id: D770514000B X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1749725508-536110 X-HE-Meta: U2FsdGVkX18aC2Xoq0ThJDNIVUcqx2qe70CIUw3rP5txweFgmy4Ana/GVzjbeOSUscOOXEdi1FNPw4Ev2OPAQcS6JiWKSZqBlyCMi6Az68XVXMe/O+HfSJN6vhozSq3gRt+2wsA7xnwM18pQ3plX75Sgf0E6iUtUXNqgpo//SGIEex68OMsx0FixYAdl6tJqKTU6eJN0krIWpQVR6e2AdrmuxWrgRDG2NYI39zhLYpjZWzIGGvVt1AQI+xGQBf3hoRhCV/UTsiIPhsJcT/Ocu1rjcwoHGuXcWupOoWP60x2Au+lL8tsrhymD8SOCb0Ig5NZ6hIJEZMBSzhDBjNtAzhptZUKfbnXiu76PJ9Hb6LbpmwCN8553PymSr7Wm7pCiE4Eze+iaVURGnIYHu7V1z4PKPvZKpmAOHk2QAzYdxXQQvCcHK63v11KZKdvUOa8n41GdpRlRWjq2hw8VYO7GD5V0ozsGSQCJheRkQug9D5LSWJpjyztTn4qSw5qWP2W9V/Iiq9Yb+h8zjkdF1GssMaQhY8hGMve2ee1GIK83ib9cqYx4g4vjvpnZ78JvxPbVK3pV1xmOeM+hJ0tc2R3fBsMftYPP4usv3EvgN7mZXsqZBN4kQSQkV/X3Y/qetNDTdv/e0e/RaIM0LSEvW2VNg9chhooyEiV4Nkr9mpQyzdcWwlalHIcNeCkRT34mcXW5o3pVWW696Bo+El7f8QxDizkeMpEw+RcRdNvTEA0oghZXzpEeP6btAJw/miLThdV1l6emFQ3VdyL+zMEw1uFFkiqc7fE5oVkB5tU10qmb6y64occw9OTunIzHZIvV1z/UvCAZ+Js0PEmXHt+JM7xlpDb6DzssOmoV2cAkU/BzuoUuipQxipxzcFuIuOMpIGwdDyO7DFP8FskAKCGi9dckgf3QeTUK+vusqRnQTj24azgw+T/tVC9SlVkmtaEgXuROFR8NgeQwMkuE8FRwzFj 4BaIt6I5 Rr3NvID3zMqpzeWDZUsh2x3eyxuHbj8xpalFLNTDbZEyWlcA1tV5PEZJiFIgKxoRveKRgMANlUe46iE/nk36VfZFG1MGea3ORBw9DibHZ8Rx6RvoG060+fBwJkt88N7mDTPhnOHk2XT2m/icKgJ+t3qZqQkFBJ7YdloXsNkhl3kMZFGeHe+lJDcBZbK/+vdrlxKz9/yfj3TnWJMN88tkFhP5EnB84sDx5bZc02UDPfHqQipnbg+jEoqniI8dxNKMIq7wF2eK0s0rjmjmtyTrAbl7giZuyNeUn5UWjAuKugN6FOoVHbeaB3Mc0RmXPrtc8+xaN82OPmAbPJTtIAqHk3fuJR5L8D+HG02fB5GloWEw8ZApmi2OoKWke+dIDFnC4KUKXhRYDoBRr9E02w3aLIn4OiD9UdigYJIEItyMNxbYV1Xg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Use mm_get_static_huge_zero_folio() in __blkdev_issue_zero_pages(). On systems with CONFIG_STATIC_PMD_ZERO_PAGE enabled, we will end up sending larger bvecs instead of multiple small ones. Noticed a 4% increase in performance on a commercial NVMe SSD which does not support OP_WRITE_ZEROES. The device's MDTS was 128K. The performance gains might be bigger if the device supports bigger MDTS. Signed-off-by: Pankaj Raghav --- block/blk-lib.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/block/blk-lib.c b/block/blk-lib.c index 4c9f20a689f7..4ee219637a3f 100644 --- a/block/blk-lib.c +++ b/block/blk-lib.c @@ -196,6 +196,10 @@ static void __blkdev_issue_zero_pages(struct block_device *bdev, sector_t sector, sector_t nr_sects, gfp_t gfp_mask, struct bio **biop, unsigned int flags) { + struct folio *zero_folio; + + zero_folio = mm_get_static_huge_zero_folio(); + while (nr_sects) { unsigned int nr_vecs = __blkdev_sectors_to_bio_pages(nr_sects); struct bio *bio; @@ -208,15 +212,14 @@ static void __blkdev_issue_zero_pages(struct block_device *bdev, break; do { - unsigned int len, added; + unsigned int len; - len = min_t(sector_t, - PAGE_SIZE, nr_sects << SECTOR_SHIFT); - added = bio_add_page(bio, ZERO_PAGE(0), len, 0); - if (added < len) + len = min_t(sector_t, folio_size(zero_folio), + nr_sects << SECTOR_SHIFT); + if (!bio_add_folio(bio, zero_folio, len, 0)) break; - nr_sects -= added >> SECTOR_SHIFT; - sector += added >> SECTOR_SHIFT; + nr_sects -= len >> SECTOR_SHIFT; + sector += len >> SECTOR_SHIFT; } while (nr_sects); *biop = bio_chain_and_submit(*biop, bio); -- 2.49.0