From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 692A6C61CE8 for ; Thu, 12 Jun 2025 14:41:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E00376B0089; Thu, 12 Jun 2025 10:41:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD6EA6B0093; Thu, 12 Jun 2025 10:41:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC6356B0095; Thu, 12 Jun 2025 10:41:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B12D46B0089 for ; Thu, 12 Jun 2025 10:41:24 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 352AC1D7EA4 for ; Thu, 12 Jun 2025 14:41:24 +0000 (UTC) X-FDA: 83547011688.20.3B184B5 Received: from relay.hostedemail.com (unirelay04 [10.200.18.67]) by imf22.hostedemail.com (Postfix) with ESMTP id 6FAB7C0003 for ; Thu, 12 Jun 2025 14:41:22 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749739282; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t/5E9gtLu5HwZ9jZLJcBw1s1o182j39D9jlcyCa6zTQ=; b=V7XXQYkUDqVuT78QOn1apDCs7L4gH8zavq2b3sLvS3QmeObq+FAS0siZX4vNOuxoxmIFaQ E4F/7v9BHQSEjMI0CTRzjqgiKAFaGkth6I2UTXLjoMxgyEGcAjAaDXpfYPLFG7r8HjS0lZ SNRbUErHQ/eo9B6eOOGcrlPITwXmgGI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749739282; a=rsa-sha256; cv=none; b=DR4moOmMn9gF6tDyqaN4KeeeKGrtvbq2DMy9zxVvYK38dkKRrhGJctQZyTfCPXFmYt7N16 q/cTpgBrNs12mLMmY2sk7krOMbaX1X0AwwkliS3nRVZp9LlLpuhs9V8xqsv3Ide4x9V6F/ 07aiU/GTzuwu3by+gJmeuomb6vj1qGk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; none Received: from omf15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CEB5D1A1783; Thu, 12 Jun 2025 14:41:20 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: rostedt@goodmis.org) by omf15.hostedemail.com (Postfix) with ESMTPA id 74D8122; Thu, 12 Jun 2025 14:41:17 +0000 (UTC) Date: Thu, 12 Jun 2025 10:41:15 -0400 From: Steven Rostedt To: Dave Hansen Cc: LKML , Linux trace kernel , linux-mm@kvack.org, x86@kernel.org, Masami Hiramatsu , Mathieu Desnoyers , Dave Hansen , Andy Lutomirski , Thomas Gleixner , Peter Zijlstra , Andrew Morton , Lorenzo Stoakes , David Hildenbrand , Borislav Petkov Subject: Re: [PATCH] mm, x86/mm: Move creating the tlb_flush event back to x86 code Message-ID: <20250612104115.039a3817@batman.local.home> In-Reply-To: <2aec964c-ed7d-4e37-9649-cc0d20469142@intel.com> References: <20250612100313.3b9a8b80@batman.local.home> <2aec964c-ed7d-4e37-9649-cc0d20469142@intel.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX196er8TgFlcvZzFV7v1dZa9COTqpYsEhew= X-HE-Meta: U2FsdGVkX18wyPL2yuue7VL02ph12FgTwvegfaD4iTi35/VWqfSPLmLSGyNWfO2TO40aBJ4fT8UNWbBF5M5sSxew+Vv9NO8j4KZIoq0bByed8Fk7orVUocN2xfl2i3omDu2fDOwQB954fenIF65SwV5zmPVfre53F+YzfzeYzN4G1ZvNGWEQQtrhDf1uV4cvgNLOUMr5HnOVfzKGHoN2ym+0r53vP2dKCr4I/dCkFtOIg/MlaXGtA2QpYO1iHgF76TZ87v9qt4jfNvVTNtVf/5t7meV7cTL+1mcBe1Q/6rEdETi1BTP1ShfcYZx0yZ3SkCWuLWB+HAuxyv5Aml3PCLJZOgNZ0YYJ X-HE-Tag-Orig: 1749739277-873154 X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 6FAB7C0003 X-Stat-Signature: o84iwf5cnrp8jgcu4h1q7yfxc7b6dxzc X-HE-Tag: 1749739282-482338 X-HE-Meta: U2FsdGVkX191dEX2wDpkxsvIzldwxgetnnxu80oSTAesXt1XpVUeUp/0grc1VKlzftCer89aZlnOaYFOiTzrLnI9vH1Fs49RpKeYOfR3p3bBDTX19jti0dqEQjhY6UWfK0YCzccH+v1nYgzSwCNNVDhzOahl2e/okpyOZvnUdlYdCtRFj/+Kpl4NFS9lfdm+URQvQEATMcu1y8i0E4OsbNb1YZb048ttViMlHiugSHg3kSSnXLR87Qt1w2u0Q4wXmLJeimNjaYZ24Jo7h9qFV5QfbeDiosKsjcFTuM1/6ID56OIT6V2SLAKoFnp8aX2hg1lM6HzVjW9IwfMtTPhuw5N3jjYqWS6eNm9qMtmXTfXytLbzqz4W2MdSJaYYCJX4Dln8JU+RNmNyuIZgPf/Ui1xLWfQEHvmJIdbvIdaXtkhP3Vy3j2lVAQ9Ca3vMHOH+14PJGG5XBxHm5/+dZC5gQAqxPn+ZXbabyifryxKpozKRUadLAZOxbQ+WxQAfXE7Oek2YWhL47l7kj0w3c3GUc8Ky4fpcVf0tSQnhJPHPyNMcYxfnSOeW74NRbX3oIKJ9FuWesQBjv+HIPNJOmVNBDpvFcKHh0DsRtbPJa1bnHtJm8v0bMUh/qXdHGp0gPYKpf+5y8kjekkzxw3v1Nj7V3EBYJHj0KKRciwCEcZu1PzzDPU6eIBx4h4wvnSrUaV4dERhJ7/qvveepqxNGbrIjseZKsj8icy6joIPs6NpUucrGx83Ht3UN3O9LmMJ+wap7Z9YTwnZGDgt1b050SH5AmAULI/oAgEoGVS4IVtKnXQKqtI6lwDQWGGtoB6EGH3FDlnzaJcfVye2lWLhKcSFbYPYHgMNugEJQex0qCMMZlgcoBfGO6i6zR9fVRD6srzPychJ+vTrLZhPG/9MMDdyAmB2BvCcMeuZP3Na6GPqANhqsJc/VWyaCuE3PAVWXjwXw2g7qqgidnNNT4m39/L1 afQ1PSqw 3+cGB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 12 Jun 2025 07:06:47 -0700 Dave Hansen wrote: > On 6/12/25 07:03, Steven Rostedt wrote: > > Remove the events/tlb.h from mm/rmap.c and add the define > > CREATE_TRACE_POINTS back in the x86 code. > > > > Fixes: 4cc79b3303f22 ("mm/migration: add trace events for base page and HugeTLB migrations") > > Is this a big enough problem that it deserves a cc:stable@? That's questionable. Without this patch, some memory is simply wasted. So it matters how much you care about wasted memory? On memory tight systems it may make a difference. But it's just one trace event, which would free up around 5K of memory. I put in the fixes tag here because it was an obvious mistake that the header file wasn't removed from rmap.c when the call to the tracepoint was. Hmm, I think I put in the wrong fixes tag. I should probably be the other commit: Fixes: e73ad5ff2f76 ("mm, x86/mm: Make the batched unmap TLB flush API more generic") -- Steve