From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 354C2C61CE8 for ; Thu, 12 Jun 2025 05:37:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C4516B007B; Thu, 12 Jun 2025 01:37:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 96E176B0088; Thu, 12 Jun 2025 01:37:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85F286B0089; Thu, 12 Jun 2025 01:37:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 64C4A6B007B for ; Thu, 12 Jun 2025 01:37:56 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D0C9E1D56FC for ; Thu, 12 Jun 2025 05:37:55 +0000 (UTC) X-FDA: 83545642110.26.8E43950 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.2]) by imf16.hostedemail.com (Postfix) with ESMTP id 365F7180003 for ; Thu, 12 Jun 2025 05:37:52 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=163.com header.s=s110527 header.b=aN8ZsyEl; spf=pass (imf16.hostedemail.com: domain of 00107082@163.com designates 220.197.31.2 as permitted sender) smtp.mailfrom=00107082@163.com; dmarc=pass (policy=none) header.from=163.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749706674; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8uxIV25rvzc500OQYm7n7CRS3Jb65U/qpwbuXBGHpLw=; b=jLZ/dws0SPcS7WVac3gHGc8704P0rYbuVNH2jFB7QU4oay/Ru6duiIIg7j0Hjtgeaydz2v UMj4qCXVHtzfQ5zFocigsTKrQRF3RmaNEYnzyjvXkHlKImK4ZJOXDLnUJPRdB5uGb1K3lE NhSUurz3rA5Df0FcTQtixQy5XVfYy+k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749706674; a=rsa-sha256; cv=none; b=fEqc2aBwGecU1njMDL0CFJOmnWMsItlc9yjoMPEfWCz9VXHNRG7G3P5GHyO6zc1CXOJJ3e PctiRJP3dnBAdP45dSbvLTaa8wVU+TciPiyDEovao68yaTPpR0F2hYIO4nN+GYcgQdZ7+5 9lEEDw0ZQYoq0xCU65Pk4uDEa9TCvcE= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=163.com header.s=s110527 header.b=aN8ZsyEl; spf=pass (imf16.hostedemail.com: domain of 00107082@163.com designates 220.197.31.2 as permitted sender) smtp.mailfrom=00107082@163.com; dmarc=pass (policy=none) header.from=163.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=8u xIV25rvzc500OQYm7n7CRS3Jb65U/qpwbuXBGHpLw=; b=aN8ZsyElLBwfE4rdkV oDYF7HowdLbtdoIRzS2zsKZHoDRaIveTc01SoZPzLiIEI1Y/eKIDG9lL4psJx5Hk phhjiNe770/zQMOkMcQjWaecrW/Y0BDQOfiJuM2EFkGidOPFWF68C89FcuVpwy57 crAOEsgzxLWkiui9twZtZ4MRA= Received: from localhost.localdomain (unknown []) by gzsmtp2 (Coremail) with SMTP id PSgvCgB3lmVFZ0poG_P_CA--.31050S4; Thu, 12 Jun 2025 13:36:21 +0800 (CST) From: David Wang <00107082@163.com> To: cachen@purestorage.com Cc: akpm@linux-foundation.org, cl@gentwo.org, corbet@lwn.net, dennis@kernel.org, hannes@cmpxchg.org, harry.yoo@oracle.com, jackmanb@google.com, kent.overstreet@linux.dev, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, rientjes@google.com, roman.gushchin@linux.dev, surenb@google.com, tj@kernel.org, vbabka@suse.cz, yzhong@purestorage.com, ziy@nvidia.com Subject: Re: [PATCH] alloc_tag: add per-NUMA node stats Date: Thu, 12 Jun 2025 13:36:05 +0800 Message-Id: <20250612053605.5911-1-00107082@163.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20250610233053.973796-1-cachen@purestorage.com> References: <20250610233053.973796-1-cachen@purestorage.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:PSgvCgB3lmVFZ0poG_P_CA--.31050S4 X-Coremail-Antispam: 1Uf129KBjvJXoW7Zw1UKrW8Gry3WFy8GFWfZrb_yoW8tF18pF 4UKw1rWF4qqr1xCrn7J3WIga4ft3Z8CFWUJ3yaq34SvF1akryfZrZrKw45uF47CF40yF1U ZFWq9w17Z3W5ZaUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07UxCzNUUUUU= X-Originating-IP: [111.35.189.95] X-CM-SenderInfo: qqqrilqqysqiywtou0bp/1tbiqAhqqmhKX67XLgAAsK X-Rspam-User: X-Rspamd-Queue-Id: 365F7180003 X-Stat-Signature: au315j71zr3hy6t76b7om54cwrkc8uwj X-Rspamd-Server: rspam04 X-HE-Tag: 1749706672-48149 X-HE-Meta: U2FsdGVkX1/jhwKoh8FSVqaUPFuePoCo5jac0FT6BS2t3bOMjwCxp6y2YMsD2yjHdGlvlnyQ122wbPssEV0NxDTo2TVh+zCvCC9dax95OresSNFO2WhWPP/IpYIH959rVqraFMyzei5JNKqJ/HbjyHMk23sXQjJAl1VZeD/zmWozyeqJmiL+rLW6U/11fDt8kXb/xXoUmABlmkjlENkJAMxT8KNLYWajpzIiDkDrSfHJVbmcYe3lkhCm4PK00vf6ZgiqyaPLs0k919d3v6Ui42o5j927L2zbUjOLhsLWyuOzbLcmWV0R4zoqf04tceoXvUOXsO14SGm6Gq5uvXe7rsUUvl4ITi3rrDKjpA+kZnQsXmdxFJg1N6GU4ZIrBtyR1k4YX8kr8YNk0jp24s9hOx2dCUuUjJNMIA+gTi9cDBtV9Xo0K2Nie9am1aYL0ROctZSxWALVnr3lT6Zhtps/O5a8yFvgsyqL8TiEeSiI+SjlFOJnI1JarXDbV5CvS0CghcF5kX+F2KqEMYboxNKAMZWAY8OrllhxVdgj064GOukp+LZXZ0cFebW4hhcgJFvLYkQdz+zzt+ZBZggAuw2REoAtXjf7xa1ILoUSEtBRSUjCqjKy+9NTojUwjy2lB80YLI1VMLCh9lRi8Mk7DhviNByivvuZTxUFAdSOJ8AoL5tUACXnPBG5ISult+edd3iyM+kh1YJkOuwyEpApIMy9AgjoQzQsILM/AxC4RHqy2BTMQ28H+jDigKre8fprGo0HimluUBWczNzmMjEUbE2N5292g7D+qiR3calH2xf/ojFCbOjeHblaeiXQbcs4CI3wcJV3k+QUGwFZspjiajBD6NCMgm5k90jizvuWKE/LlIw9xQXATxVy0/qVAbmWkNLL2p/fmzuBZ1bzmsUHaDx/f8BJFjRK2mrmcr3WqRvhdRQpXY0RoTwdrCZf8AuE/Ef0vOtFKPffKg3dVMEjVJw iTX23Kjg 0RjYMRtchHafUS+kRhXWFcM+G0vc9zu8L9js4N5CRslHco50wEfWA0VK3ObvQdwdaLr29ZvJZxXrcz1eWGESJ8iP25a8oJE2LBtaXZOkTWONCOWljzUn0oF1Vz3PB5M6s+xiL5JXXKALkQAMtd0ADHXlf0et37jaHzKAdLNoMsm9824YnboW4DrwOyr/RRdOc9I+dtZZTyPX7x1tgiF6GS0PwdPQaIeAGTVJbXyxMGOz6sumqnmSes91HhFzU24RoWrsDWhal4qHCVmwdL9n5W/fbyt+q0DVywrFsQ//LvRpLnbQ874+bmr6OFED2zbhmZ5ugGJtabjM8oXmSXao05Pk16K1R7cyaklcnez3sTbIQD+e7vA5WxiRt6wqvatEshdTfKbs+57OOtib5/6xicNk2V0UsdBhJM7FE+vNgGk1YnjlUu/ZvNyz3aqF4i5XXUShyjKcWX3VIGYJRTtLDEIuT5CvX3E1nY95XLFPqSvSqwY1nnLY++K5A1CLMVw017dMsMs3N47oCa/D+QaJiI2H/Yw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Tue, 10 Jun 2025 17:30:53 -0600 Casey Chen wrote: > Add support for tracking per-NUMA node statistics in /proc/allocinfo. > Previously, each alloc_tag had a single set of counters (bytes and > calls), aggregated across all CPUs. With this change, each CPU can > maintain separate counters for each NUMA node, allowing finer-grained > memory allocation profiling. > > This feature is controlled by the new > CONFIG_MEM_ALLOC_PROFILING_PER_NUMA_STATS option: > > * When enabled (=y), the output includes per-node statistics following > the total bytes/calls: > > > ... > 315456 9858 mm/dmapool.c:338 func:pool_alloc_page > nid0 94912 2966 > nid1 220544 6892 > 7680 60 mm/dmapool.c:254 func:dma_pool_create > nid0 4224 33 > nid1 3456 27 > > * When disabled (=n), the output remains unchanged: > > ... > 315456 9858 mm/dmapool.c:338 func:pool_alloc_page > 7680 60 mm/dmapool.c:254 func:dma_pool_create > > To minimize memory overhead, per-NUMA stats counters are dynamically > allocated using the percpu allocator. PERCPU_DYNAMIC_RESERVE has been > increased to ensure sufficient space for in-kernel alloc_tag counters. > > For in-kernel alloc_tag instances, pcpu_alloc_noprof() is used to > allocate counters. These allocations are excluded from the profiling > statistics themselves. Considering NUMA balance, I have two questions: 1. Do we need the granularity of calling sites? We need that granularity to identify a possible memory leak, or somewhere we can optimize its memory usage. But for NUMA unbalance, the calling site would mostly be *innocent*, the clue normally lies in the cpu making memory allocation, memory interface, etc... The point is, when NUMA unbalance happened, can it be fixed by adjusting the calling sites? Isn't enough to be used as key for numa stats analysis? Any example explaining why you need the information of calling sites and how the information of calling site help? 2. There are other factors affecting NUMA balance, cgroup usage, e.g... Could we collect those information at calling sites as well. Thanks David