From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD6F1C71136 for ; Wed, 11 Jun 2025 23:08:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C0F36B007B; Wed, 11 Jun 2025 19:08:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 472776B0088; Wed, 11 Jun 2025 19:08:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3895E6B0089; Wed, 11 Jun 2025 19:08:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1A3DD6B007B for ; Wed, 11 Jun 2025 19:08:09 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AD901141759 for ; Wed, 11 Jun 2025 23:08:08 +0000 (UTC) X-FDA: 83544659856.05.61CFF59 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf28.hostedemail.com (Postfix) with ESMTP id 0A350C0008 for ; Wed, 11 Jun 2025 23:08:06 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="SY/GHK89"; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749683287; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Hkv3Uyst+RZ5tPefqFDZxlDUMvZsWbdIFxQbWsN/pYM=; b=aMdYIqCM7X/6ESK5rUh2awU9F8LVu0Qhm9dDNoyRfIPfVuyfIzF0ZIR3Q5xvdEMdWucZ3K syM0LP5h3DWQUyC0EE9vh54Olcdd2CokBLaUhVPVeLFPW4hYL6xCJfpVgiDptsJUvG9917 k5F0s0YZmLqK9ilNidUB1gdyHhNOD3k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749683287; a=rsa-sha256; cv=none; b=vbleqO25IkIJY04ztNT5bY+SB/odoiyO/HK6ryPNYBqodQKpnlHtibJy7HyXe3hrvv6rmI efnC/pfy8Lj19D7j477ZEx89yjuvMFz2nV31mAg0GupmKJXwvPVxQQS37DB53fsVgKh8IT eCTXwHbjxjIfWkG1Nc8nGbPtN6ntSOU= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="SY/GHK89"; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 6A558A51B45; Wed, 11 Jun 2025 23:08:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71BFBC4CEE3; Wed, 11 Jun 2025 23:08:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1749683286; bh=iI0Kj0iMx9/gwAzrpZC4Q+nF6kk89nBYnME2MFD72CM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SY/GHK89FXr8Uvif53wRdWKd6NAI6EnUtId5643s2rBEq9cvqXxgWQ4xB8FRdXn1E LT8tcUNB3wmpUUkETQuY2Ps7PWhppAcPBiKkrnX3r8Pc0sUhov4SoH4OSozrWGelGR X6qAaCdLB/hHevrQvWx3YBJRepuxlNYn/cByC6ks= Date: Wed, 11 Jun 2025 16:08:04 -0700 From: Andrew Morton To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Dan Williams , Oscar Salvador Subject: Re: [PATCH v2 0/3] mm/huge_memory: vmf_insert_folio_*() and vmf_insert_pfn_pud() fixes Message-Id: <20250611160804.89bc8b8cb570101e51b522e4@linux-foundation.org> In-Reply-To: <20250611120654.545963-1-david@redhat.com> References: <20250611120654.545963-1-david@redhat.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 0A350C0008 X-Stat-Signature: pn69f4b1uq1nu9txhz3nyyf3axatpzz4 X-Rspamd-Server: rspam04 X-HE-Tag: 1749683286-556651 X-HE-Meta: U2FsdGVkX19fUfB7lEcctIQdx9V8Qg7liz/r+Ltf2UGCBYvRKeajiyp+0lwkna0lEG6Gy0MbShYyQETM2lHNLyzSUijYWIsRJOknruotof5q9BkFv5oSb0/3OfStPgbPtKeNP1s1Bpt78DMnCFVV3ogDOpjoHpgaIF+RYExAHAe1wxiMEbV5qAvtjbLQoTjz1x+aBacSBTtgxL0U3H5LY7SJx2qzPsPF5RU0tBgAeuAY8nkdiB3oYJJNi5kpEeinofOfd0RQFXwyaPUiMoq37Njwl069gEYTfiDtUCRh8W986lowlEmuv5Wizn5Z9UsXp3+xfliei03g3r572zbpmJb2iJfM9qQCHPaVWj/+NVK93FUbpkO6d9UT90lp7Hcmrg0i6R6K1O3mPTr5sWg0ZqTtZz9jfurq7WwZkysMTdw2nBIUZ1yucM+XUMUCQ54pdbeQl0pI8cDZDbq/AfMNsMTDBhbjjSxZGCN4hQRm2+GP6RPyo3zSas7gdhK8mLhDFA8797O8lA984A/NJIKTRJsOk8A65fZaJK4McJoA1HMOUT2GQF8vtFuiPQ5OWNW4EmcbedNgzKnP4rNtGxPGZxVwLYJK3g/Yo2tuhw5PVnR9+TkZt1ymZ6P3yjQKtEIG4t/nxeTGIf9nRRT58p7XijcZIiBAYzWnC+v0fQuhbNQZSeFRcEnWcvtkwBZBxUqvmW1/7/TeXgayglkEprZGDsDuLpWSkT5yr3Dt/4Polumwek5jz0pejtrLGZ9aYIhvQRgAKeu61e5usfU+zAaX+0Dmoikyn88Cx6DT6b2Z72e7s/FH0t/ZM1f8EY8/rH3ayk0XynBuE8DJwh6uhYVYyUjBnnukKHyF7BjXJ6+t9Wy0YMUUUFkSwakDTUOjRJiO3ChWNrtt67W4zYxSGtjYZqb0oLXklvTOjq6OJdSapKvt9KW4QXFmXbFbOndzh+8UNAPN31iDUdrDs7UyK1E kD9hMWju CjBxWu9ctNYMeVjZHmB4EW/7i0hIcty8aLeQ8IXyvsrVQgHo9PiLzeU8uyrl6SaW0HdisSjOHfNLIbUex26kB4eI11Pkykm67V+XMOKuAtkWDPFH6YrI/YG8rbKZci6q//deSgbsQpq1stROSgbz/BMqlYfCHorDGnzFQs/yrTw3DBPkCOjC1bypn2If03wCmAYT0SR7wk2tTnlNHt651dqYUcPHNRTiTNfGRXjMkjbTn5n1wrmq8Wqk+NaIk03oCDnNWLizfCiKiLQaLh/gPy5IvDRt9AEEjSTLfAmPudIJew4bo4ZTGG+4eUcHLclVz45eX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 11 Jun 2025 14:06:51 +0200 David Hildenbrand wrote: > While working on improving vm_normal_page() and friends, I stumbled > over this issues: refcounted "normal" pages must not be marked > using pmd_special() / pud_special(). Why is this? > > ... > > I spent too much time trying to get the ndctl tests mentioned by Dan > running (.config tweaks, memmap= setup, ... ), without getting them to > pass even without these patches. Some SKIP, some FAIL, some sometimes > suddenly SKIP on first invocation, ... instructions unclear or the tests > are shaky. This is how far I got: I won't include this in the [0/N] - it doesn't seem helpful for future readers of the patchset. I'll give the patchset a run in mm-new, but it feels like some more baking is needed? The [1/N] has cc:stable but there's nothing in there to explain this decision. How does the issues affect userspace?