From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48823C71133 for ; Wed, 11 Jun 2025 15:59:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4CC0C6B00B4; Wed, 11 Jun 2025 11:59:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A36E6B00B5; Wed, 11 Jun 2025 11:59:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 393306B00B6; Wed, 11 Jun 2025 11:59:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 14BDA6B00B4 for ; Wed, 11 Jun 2025 11:59:39 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 95D901A1041 for ; Wed, 11 Jun 2025 15:59:38 +0000 (UTC) X-FDA: 83543580036.11.30B6828 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id F3A91100008 for ; Wed, 11 Jun 2025 15:59:36 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=p9P+OhgA; dmarc=none; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749657577; a=rsa-sha256; cv=none; b=WB+KFXRBfzgcVzK4ZG1REcX3nxcbAkd2vvbCUCOfbX4k5kuRKTWh7N/iaCxzu7Tdteygwq 6p16x6vFBCGBQKzMbR7GiWpDEExe3HW8tHRdxKMy5L3pL4gZq3yj6qgJsSLJ8hJIbCBq7r zfG9HPLLi+2aIU+pwCNiZyoI0GOD9TY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=p9P+OhgA; dmarc=none; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749657577; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r6fZNOg8+28dtdyVEzZ0A1poUQN3OFJVLMV4uNt5pbk=; b=rZZFxlFHi7bKm8zDxJwN8XrNa+vodNXUct/jTzlIKe5lxEZdfpzg0Ha0QNUFjBTILJjiDy RkdmXTtEcbTLOeGBKzqwgTtYmQNkE8AQSqkmiFt8nvJOe2vlFLm3FsMsr08LrlGZPS51Tm VT1bAPGR8FgVD2e9X63hDrqZV0UCQko= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=r6fZNOg8+28dtdyVEzZ0A1poUQN3OFJVLMV4uNt5pbk=; b=p9P+OhgAMMfuwdVRe2fMAevDl+ yBo7VpE0OL2AuEsDXxFW1RhATVscWIStjsN13tLabM6qHP2P4WNz1BuKCtx/GGT1OGq6u320R1L6N BZ+Y5nqpHHfQXhUzYI2UFxRsI07WpoijeSRO26AWIhWYDCYeCFk/ZWhqeHaVwMci3ZxUEdd+e7COc SV3h4YRKj5agHr1Hnvc97OdBFw5Xkx99GWT/kH0TWOiGmE+gZVW7a2tzkqIl+VNYMMr67i0uMK+UO ZMc2JOmaShut3+I/DS1Znn5oqM4/xPfSZGr7ji7rI6Og/7xq9SD0mkn0HDD2aQW43Fif/smpEBFOT drvNagDw==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uPNrC-0000000Aoxd-1OZ7; Wed, 11 Jun 2025 15:59:18 +0000 From: "Matthew Wilcox (Oracle)" To: Vlastimil Babka Cc: "Matthew Wilcox (Oracle)" , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo , linux-mm@kvack.org Subject: [PATCH v2 03/11] slab: Add SL_partial flag Date: Wed, 11 Jun 2025 16:59:06 +0100 Message-ID: <20250611155916.2579160-4-willy@infradead.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250611155916.2579160-1-willy@infradead.org> References: <20250611155916.2579160-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam01 X-Stat-Signature: 3owhmowat1pc8a5gzsokenwye1oe33pp X-Rspamd-Queue-Id: F3A91100008 X-Rspam-User: X-HE-Tag: 1749657576-519175 X-HE-Meta: U2FsdGVkX19LjXH+kZVVcqXTWdOdVSJ8HtuLvkpaFEyYd/sbl/am3bJ9Uq1ocmwmOqxfAG0dF4aaFtxqBQ1YEgS0IYcZfexX5/USMWNblmcKgpq+08PFupqS8GsuqI6YPQXqhISXM3Hbz4irpVOjN/AFPvGzIQPW59xVnRXav3PP8UN09hGL+lxgO8eR2yuJdRaif7NRZKv74EKPix5jhAGSM1TMoHajulK/YftWSLdq3hzHMF4fJfEBi/Z1lRh1ISAMVantUOajTjXxphwSifl3KEjgDXsf0I/85iT0Q1dZmiVZnO8zP+WVDl08hW+itjfY3OEMdG3QlmmSk4TZLUbMyEUjb0KTG0a0xxrpvix5oZLFDHJHn5XDivT7zwuh7WWLMxNkXWwJA09gXS+q3gtXL27lp+Dnm3erulbIUDet+UaET2Fo0JYseuHYftIFn10sPCd4WwWG6I9YdL/7DXv5517B7gw7kNy7lbJLmTnJOT6DxJXbStU+9WMkM0UDeck5HM2OTKpnOd33SaWfRJ87Jh+NPO5CxqFTFWApa8zqJaeffc8GfzLZmAws6f8b/vyNgCdYjerzIY+awOID8zlrxqq7oSnVjj0ccX7DxLVTFM3xPQKRK+9S9gJzt3LCQnELv5VBAxSSwGhBfpQHUkxuzOPBVpi8GlMPP2zRTx1zbNLc4ciyE7EEfrICGfmb63XoA7WR9rjAWFytG3ZIW3Ru1b1kSZvR7jte58UnO/vcZkDtu//zrsuhL8CPNtPtNR39I9yQFGRbsvurqFkGgqfMWuQAy8IzRQn53CA5NUqmpgGeiWjt5rsHB66MLz1iZrgCnvS36V1FrG85h76PRIxUlmUF5FRIFbmh3s3oMoHdlvq8dVIAWwA+lxvbfCuiRiYKT+nBPWWh84sml6o5QRW8iCBsO4Wgu85ro9hzLaICvpVp0hNeyvhNzgRbHoJCUuRDGrsEa5L1NggmpR0 mjnZjeuk Qw0fqOTxKUczT4D1OSp7vf5nVlGo0W7w64cVGKrWyrr/+XbbXiwog5QnrBkw4f/9AlPK65xwqYGSYWdgPBiCdKbcGQv9S22gZhM6a2kGZSV6skQ+gWmg3ulXu4DkIh3RqRN+8VO8VLgA1IvcO8TFPBJivFG9Yvwhp9561pJSkewk9q+5GyB7dFn23bW46qBcqReRL7sbcK+Tyw0AfPBE5llqHMGdt3lFCmnKCCMy7C1NrHdf+c0R+xc94Nbtj6IN68X6TzINZ1r2RgCdEuxXjuBVTIARxyTu4n9ib3+XZhxyb23PpnS0K7ny9PA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Give slab its own name for this flag. Keep the PG_workingset alias information in one place. Signed-off-by: Matthew Wilcox (Oracle) Acked-by: Harry Yoo --- mm/slub.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index be44d7bd1f89..2bf1ad8a70ce 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -91,14 +91,14 @@ * The partially empty slabs cached on the CPU partial list are used * for performance reasons, which speeds up the allocation process. * These slabs are not frozen, but are also exempt from list management, - * by clearing the PG_workingset flag when moving out of the node + * by clearing the SL_partial flag when moving out of the node * partial list. Please see __slab_free() for more details. * * To sum up, the current scheme is: - * - node partial slab: PG_Workingset && !frozen - * - cpu partial slab: !PG_Workingset && !frozen - * - cpu slab: !PG_Workingset && frozen - * - full slab: !PG_Workingset && !frozen + * - node partial slab: SL_partial && !frozen + * - cpu partial slab: !SL_partial && !frozen + * - cpu slab: !SL_partial && frozen + * - full slab: !SL_partial && !frozen * * list_lock * @@ -186,6 +186,7 @@ /** * enum slab_flags - How the slab flags bits are used. * @SL_locked: Is locked with slab_lock() + * @SL_partial: On the per-node partial list * * The slab flags share space with the page flags but some bits have * different interpretations. The high bits are used for information @@ -193,6 +194,7 @@ */ enum slab_flags { SL_locked = PG_locked, + SL_partial = PG_workingset, /* Historical reasons for this bit */ }; /* @@ -2729,23 +2731,19 @@ static void discard_slab(struct kmem_cache *s, struct slab *slab) free_slab(s, slab); } -/* - * SLUB reuses PG_workingset bit to keep track of whether it's on - * the per-node partial list. - */ static inline bool slab_test_node_partial(const struct slab *slab) { - return folio_test_workingset(slab_folio(slab)); + return test_bit(SL_partial, &slab->flags); } static inline void slab_set_node_partial(struct slab *slab) { - set_bit(PG_workingset, folio_flags(slab_folio(slab), 0)); + set_bit(SL_partial, &slab->flags); } static inline void slab_clear_node_partial(struct slab *slab) { - clear_bit(PG_workingset, folio_flags(slab_folio(slab), 0)); + clear_bit(SL_partial, &slab->flags); } /* -- 2.47.2