From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F9C1C677C4 for ; Wed, 11 Jun 2025 13:34:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9AB226B00B2; Wed, 11 Jun 2025 09:34:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 95BD66B00B3; Wed, 11 Jun 2025 09:34:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8234F6B00B4; Wed, 11 Jun 2025 09:34:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 632476B00B2 for ; Wed, 11 Jun 2025 09:34:13 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1CE1EBE282 for ; Wed, 11 Jun 2025 13:34:13 +0000 (UTC) X-FDA: 83543213586.23.23BE379 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by imf22.hostedemail.com (Postfix) with ESMTP id 3CFA1C0004 for ; Wed, 11 Jun 2025 13:34:11 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=16jt9gsy; spf=pass (imf22.hostedemail.com: domain of 30YVJaAUKCEw7oppou22uzs.q20zw18B-00y9oqy.25u@flex--tabba.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=30YVJaAUKCEw7oppou22uzs.q20zw18B-00y9oqy.25u@flex--tabba.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749648851; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FJvbE/ShWBw64uN/gfxPQEGQRHHqSZqc097MOFM4eTw=; b=w7NWcgWF/wZQ+SyjCB9YNmZ5nxGCaUhnDCsvRh7eCeD0OW7vdZnMOmGEMAMlQdhqAcnbOP SDEFMtCZxxYgnlUBgQy8MCvBoazStLORMgh9d9TPh4jY1J7l69ntlCcoB3W6DSdUMRLhe1 9sb40zuaKg1sHrm51b9v55pGWumgSSI= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=16jt9gsy; spf=pass (imf22.hostedemail.com: domain of 30YVJaAUKCEw7oppou22uzs.q20zw18B-00y9oqy.25u@flex--tabba.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=30YVJaAUKCEw7oppou22uzs.q20zw18B-00y9oqy.25u@flex--tabba.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749648851; a=rsa-sha256; cv=none; b=vSLU+kP6SCSmyw4/x9EKYVNBWIYwv6klJHKJt3fT6N+Sb9ggZRIjtADRunPqLI6kj1nndA 3Pk28GDVgE0F2vdANl34QqMwYGKbiXdPqR/pJNSPjv6BBgkxNd14xE5tFY2wGSGDd8bwqA RXn/mteqQVwoE6nu1RcXaISujokxapw= Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-450d50eacafso37666585e9.3 for ; Wed, 11 Jun 2025 06:34:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1749648850; x=1750253650; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=FJvbE/ShWBw64uN/gfxPQEGQRHHqSZqc097MOFM4eTw=; b=16jt9gsyifeDwj+OSC1gNDI5szNcnCH43CPusKRZnN/90zG0qye5FoanPFGdd0FQZZ UljstB8SG4+Z6V6yBDTXzKr308G/wvQopdF6Jbn5t+jmrqzU9k1RHbb7qyf9jZ17eR3F 5u7lvXbV0xs3iZ5mpcXy1nsmAtGrLJQuMVwe0xQrI620s2hbf2rGBtOjNfn+t87LgEA3 WLZgdts466fTJ6+QJjZwLu2M3xbYHHFhircupjy64feW6yezr5MCO2LSeBO/7P3HJ7nk X9uHLHbV6zc/6dPVG8CKQ0gCsZXA7W/TQ6yLxzpYmx753oyz9Pk3KWOIZpa147PnhRyk P9ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749648850; x=1750253650; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FJvbE/ShWBw64uN/gfxPQEGQRHHqSZqc097MOFM4eTw=; b=bDRPJASCDvZTPuRFwGwyVhhUW9eVcAGkv4MK+DKzEDQkmNe+dKnZl3zeQ7ODNa2e4r Ykww+CU/+i78U9bVEqJLWE950hfAyHI1MYvW43GGrTEMoY3yZhXqsLcS0EFpo3PCYwbL x+/PP5EP3/+kcBYfIDvOpr2sM+41tb4zI6IcKNj/Aax9aOKmWVYF9l4zobAb2LBpGcBZ XfkFoR1LpDavsnbhbpX8KivI5HVmvwnRXgWYrImg0r5A3FEBT3Z1KAe7djifPpw4L/wE gHsUEfiTuQvinHTrxr+kUHhJX+pscFHLmLrDzmsHGsXzdC3UjaRUCGXft4pSvCuUiu+9 Uqmg== X-Forwarded-Encrypted: i=1; AJvYcCVduUvlHIO8BGeHZdF7UIpZ6REaioboi268NOA51CAKw/tC5Detg3tCaq+Th5nTq8ahz3id/El2sw==@kvack.org X-Gm-Message-State: AOJu0YwnO7sf8B2K+UASFS5rEE/9sm9kG3f4s0Nx+RtztfZnuf8FeYSO teSMKqVqRiwKb6L5RZP2TEZk3ESSdotQAE7diSLL7JLwrhaS/mNANWPcnFaEFEbsKI88WYXBWnE d6A== X-Google-Smtp-Source: AGHT+IHeu8YIl9sBvNyQ+lPC3i+DWieMJ5Ege0MJSOrRxbX1kzQSNvkrsiPuQZjK1BZWrhiZw4SOi05djw== X-Received: from wmbfa21.prod.google.com ([2002:a05:600c:5195:b0:43c:faa1:bb58]) (user=tabba job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3b2a:b0:451:df07:f437 with SMTP id 5b1f17b1804b1-453248dcd54mr32155365e9.30.1749648849873; Wed, 11 Jun 2025 06:34:09 -0700 (PDT) Date: Wed, 11 Jun 2025 14:33:30 +0100 In-Reply-To: <20250611133330.1514028-1-tabba@google.com> Mime-Version: 1.0 References: <20250611133330.1514028-1-tabba@google.com> X-Mailer: git-send-email 2.50.0.rc0.642.g800a2b2222-goog Message-ID: <20250611133330.1514028-19-tabba@google.com> Subject: [PATCH v12 18/18] KVM: selftests: guest_memfd mmap() test when mapping is allowed From: Fuad Tabba To: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com, tabba@google.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 3CFA1C0004 X-Rspamd-Server: rspam07 X-Stat-Signature: pgjnb7wwtanpsojtrscik6bwx36euk8h X-Rspam-User: X-HE-Tag: 1749648851-311529 X-HE-Meta: U2FsdGVkX18ltFzxVO3zZxbq/qEE77zCIkDnpSyQMvi7g7IYG7jOfVCcMt/A1/+pxuZ0lm45VnHeVB7aD6qh0HQ8CJstmsNd9I9kePKBh0hK73nV+kVIb/aCkTl0x/DLeHp2DKPDEC/21Mj/6h0080X/pqhmae+w93venRalIZ+FAqFnv5vdsp+J7ECyjma18AGR9jIwL2PG+Cpdv6uivladStuujn/SYZ42/21N6OIItQ+V9Ng7JkOxLqaA0MpVT6b2qqXIUgkN/dP0PCSZNlyfT6GarpRLh9UgCyXS1tZ6BlOrDAe0p8Uwwyxw6RDtQyKWGhTRCA2nxHh2KBofOnFpzJJgMeM01EX8D+sEeiBGuyRTnsjqb/M2ffEqWDbUtYSI87QfUCKm//YbO72cq/mTAB/D6bA+uuMjn55EsywPmmkxkOVAXj9X/xgYQ/mFr1EYNvpsP8alZIHdHPA4JZQBw+bNOTQf2Tcb8Dbb8pu3n1im3vF2nyODN985gkHT8JbrlwFqbdXedsrQ+HX3NKC5Mug/DVGFwQ5fInhrHm2ULc4iwUazcR2ohkO1xIPyeSPUNRsF64yeGo+g8ovPNt3f2Qi/3Qnz8v4pjzPwZhqjiXyxv2VpFNToFqYAFqf+qoMgr9mxYBvpx2i2MtzCKS4C9WNW4Cx841ASgU7mDW29IdGhEw86NpkY4eB/8pMP4eY48IjtziLn8PznRyzYRXG7W0nRXVS2pqF1jVDkorJ576lAc1MFtxRw67qmsH5JZSNVrQ6Np8vczlCKW5yu0ZNxsmiS/cc1dk3PgU6n6aXJXg/WuOiEGLlBD2w4wMXxvPtj4801DPAsW0d6YY9DRQax985m+1KGdmBvxvdiYRDHALStiV7rKn7idICxAsnud3uFQrNb+5nXSxirzZ8U6zgKJR+zQV6CGBxobDcFb8REkVyB0UAsZFGjqox1zDyuAIr33XFVJjdG45hOV0B SPx1Os0J AgJcNI28dMtjB7O9W8z4NLvd9h+k5ib0EWoPnHb1Ck3764TSILx//+KTlDHu4DzHl1LAqcyUaJXA0RAECyxkHQ8GK7vUJU3x8R9t6XY2fxPx040btx0P99xH894bIvOiMUCDaaLhrmYo42MZ2JXQdJlSemXyIyfWZljKwKuHQIZ6CUVLL5EzRWL6Eb5MVpbSMjvdaAeMl1C8Wds/CGri9VsOjdOXqgRZ98zGjTtVBEQDG90mHSEf0aRMOz2s62fupN9BMg1NR+7ZUxDlKCpt61BVbZlGY8CNTU7Oq9CL2tjbuITouiOxoDbHsGzYOsRFfVX9kN1sJ9Mg3++ECnSxw50vbK+TIi5VAhY3mGOs3TGlBLkTWgolsUy90Ul7dolEtbK4Lqj9fnY38xoMZ7bzYEKvTb5HnHTYHQ8YRWWVplGZsQTKxPvbKHme0pGqWYZDFZ3SaAzHtejYIZMBPUOBE4eLRoWXPDINuj3HSzqoOgpnia/kNMThrMInY7X+qVGItO5Blper3AoYWrr3MPT/f8DQFutxwwmY5Xu6NwyGeBCjmNoQOZw7/FIIHHxWAdZf2/pUr/YhWxIRlynh1kDvEoBqXRc1OQibNRv36qFLe6Fx9FU4QRR5SEJi9FaLkV1eEQdQjblIcz3Af9UNAbakUsZQDKez6nva2OfM2GsC9nb9CUI4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Expand the guest_memfd selftests to include testing mapping guest memory for VM types that support it. Reviewed-by: James Houghton Reviewed-by: Gavin Shan Co-developed-by: Ackerley Tng Signed-off-by: Ackerley Tng Signed-off-by: Fuad Tabba --- .../testing/selftests/kvm/guest_memfd_test.c | 201 ++++++++++++++++-- 1 file changed, 180 insertions(+), 21 deletions(-) diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c index 341ba616cf55..5da2ed6277ac 100644 --- a/tools/testing/selftests/kvm/guest_memfd_test.c +++ b/tools/testing/selftests/kvm/guest_memfd_test.c @@ -13,6 +13,8 @@ #include #include +#include +#include #include #include #include @@ -34,12 +36,83 @@ static void test_file_read_write(int fd) "pwrite on a guest_mem fd should fail"); } -static void test_mmap(int fd, size_t page_size) +static void test_mmap_supported(int fd, size_t page_size, size_t total_size) +{ + const char val = 0xaa; + char *mem; + size_t i; + int ret; + + mem = mmap(NULL, total_size, PROT_READ | PROT_WRITE, MAP_PRIVATE, fd, 0); + TEST_ASSERT(mem == MAP_FAILED, "Copy-on-write not allowed by guest_memfd."); + + mem = mmap(NULL, total_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); + TEST_ASSERT(mem != MAP_FAILED, "mmap() for shared guest memory should succeed."); + + memset(mem, val, total_size); + for (i = 0; i < total_size; i++) + TEST_ASSERT_EQ(READ_ONCE(mem[i]), val); + + ret = fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE, 0, + page_size); + TEST_ASSERT(!ret, "fallocate the first page should succeed."); + + for (i = 0; i < page_size; i++) + TEST_ASSERT_EQ(READ_ONCE(mem[i]), 0x00); + for (; i < total_size; i++) + TEST_ASSERT_EQ(READ_ONCE(mem[i]), val); + + memset(mem, val, page_size); + for (i = 0; i < total_size; i++) + TEST_ASSERT_EQ(READ_ONCE(mem[i]), val); + + ret = munmap(mem, total_size); + TEST_ASSERT(!ret, "munmap() should succeed."); +} + +static sigjmp_buf jmpbuf; +void fault_sigbus_handler(int signum) +{ + siglongjmp(jmpbuf, 1); +} + +static void test_fault_overflow(int fd, size_t page_size, size_t total_size) +{ + struct sigaction sa_old, sa_new = { + .sa_handler = fault_sigbus_handler, + }; + size_t map_size = total_size * 4; + const char val = 0xaa; + char *mem; + size_t i; + int ret; + + mem = mmap(NULL, map_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); + TEST_ASSERT(mem != MAP_FAILED, "mmap() for shared guest memory should succeed."); + + sigaction(SIGBUS, &sa_new, &sa_old); + if (sigsetjmp(jmpbuf, 1) == 0) { + memset(mem, 0xaa, map_size); + TEST_ASSERT(false, "memset() should have triggered SIGBUS."); + } + sigaction(SIGBUS, &sa_old, NULL); + + for (i = 0; i < total_size; i++) + TEST_ASSERT_EQ(READ_ONCE(mem[i]), val); + + ret = munmap(mem, map_size); + TEST_ASSERT(!ret, "munmap() should succeed."); +} + +static void test_mmap_not_supported(int fd, size_t page_size, size_t total_size) { char *mem; mem = mmap(NULL, page_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); TEST_ASSERT_EQ(mem, MAP_FAILED); + + mem = mmap(NULL, total_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); + TEST_ASSERT_EQ(mem, MAP_FAILED); } static void test_file_size(int fd, size_t page_size, size_t total_size) @@ -120,26 +193,19 @@ static void test_invalid_punch_hole(int fd, size_t page_size, size_t total_size) } } -static void test_create_guest_memfd_invalid(struct kvm_vm *vm) +static void test_create_guest_memfd_invalid_sizes(struct kvm_vm *vm, + uint64_t guest_memfd_flags, + size_t page_size) { - size_t page_size = getpagesize(); - uint64_t flag; size_t size; int fd; for (size = 1; size < page_size; size++) { - fd = __vm_create_guest_memfd(vm, size, 0); - TEST_ASSERT(fd == -1 && errno == EINVAL, + fd = __vm_create_guest_memfd(vm, size, guest_memfd_flags); + TEST_ASSERT(fd < 0 && errno == EINVAL, "guest_memfd() with non-page-aligned page size '0x%lx' should fail with EINVAL", size); } - - for (flag = BIT(0); flag; flag <<= 1) { - fd = __vm_create_guest_memfd(vm, page_size, flag); - TEST_ASSERT(fd == -1 && errno == EINVAL, - "guest_memfd() with flag '0x%lx' should fail with EINVAL", - flag); - } } static void test_create_guest_memfd_multiple(struct kvm_vm *vm) @@ -171,30 +237,123 @@ static void test_create_guest_memfd_multiple(struct kvm_vm *vm) close(fd1); } -int main(int argc, char *argv[]) +static bool check_vm_type(unsigned long vm_type) { - size_t page_size; + /* + * Not all architectures support KVM_CAP_VM_TYPES. However, those that + * support guest_memfd have that support for the default VM type. + */ + if (vm_type == VM_TYPE_DEFAULT) + return true; + + return kvm_check_cap(KVM_CAP_VM_TYPES) & BIT(vm_type); +} + +static void test_with_type(unsigned long vm_type, uint64_t guest_memfd_flags, + bool expect_mmap_allowed) +{ + struct kvm_vm *vm; size_t total_size; + size_t page_size; int fd; - struct kvm_vm *vm; - TEST_REQUIRE(kvm_has_cap(KVM_CAP_GUEST_MEMFD)); + if (!check_vm_type(vm_type)) + return; page_size = getpagesize(); total_size = page_size * 4; - vm = vm_create_barebones(); + vm = vm_create_barebones_type(vm_type); - test_create_guest_memfd_invalid(vm); test_create_guest_memfd_multiple(vm); + test_create_guest_memfd_invalid_sizes(vm, guest_memfd_flags, page_size); - fd = vm_create_guest_memfd(vm, total_size, 0); + fd = vm_create_guest_memfd(vm, total_size, guest_memfd_flags); test_file_read_write(fd); - test_mmap(fd, page_size); + + if (expect_mmap_allowed) { + test_mmap_supported(fd, page_size, total_size); + test_fault_overflow(fd, page_size, total_size); + + } else { + test_mmap_not_supported(fd, page_size, total_size); + } + test_file_size(fd, page_size, total_size); test_fallocate(fd, page_size, total_size); test_invalid_punch_hole(fd, page_size, total_size); close(fd); + kvm_vm_free(vm); +} + +static void test_vm_type_gmem_flag_validity(unsigned long vm_type, + uint64_t expected_valid_flags) +{ + size_t page_size = getpagesize(); + struct kvm_vm *vm; + uint64_t flag = 0; + int fd; + + if (!check_vm_type(vm_type)) + return; + + vm = vm_create_barebones_type(vm_type); + + for (flag = BIT(0); flag; flag <<= 1) { + fd = __vm_create_guest_memfd(vm, page_size, flag); + + if (flag & expected_valid_flags) { + TEST_ASSERT(fd >= 0, + "guest_memfd() with flag '0x%lx' should be valid", + flag); + close(fd); + } else { + TEST_ASSERT(fd < 0 && errno == EINVAL, + "guest_memfd() with flag '0x%lx' should fail with EINVAL", + flag); + } + } + + kvm_vm_free(vm); +} + +static void test_gmem_flag_validity(void) +{ + uint64_t non_coco_vm_valid_flags = 0; + + if (kvm_has_cap(KVM_CAP_GMEM_SHARED_MEM)) + non_coco_vm_valid_flags = GUEST_MEMFD_FLAG_SUPPORT_SHARED; + + test_vm_type_gmem_flag_validity(VM_TYPE_DEFAULT, non_coco_vm_valid_flags); + +#ifdef __x86_64__ + test_vm_type_gmem_flag_validity(KVM_X86_SW_PROTECTED_VM, non_coco_vm_valid_flags); + test_vm_type_gmem_flag_validity(KVM_X86_SEV_VM, 0); + test_vm_type_gmem_flag_validity(KVM_X86_SEV_ES_VM, 0); + test_vm_type_gmem_flag_validity(KVM_X86_SNP_VM, 0); + test_vm_type_gmem_flag_validity(KVM_X86_TDX_VM, 0); +#endif +} + +int main(int argc, char *argv[]) +{ + TEST_REQUIRE(kvm_has_cap(KVM_CAP_GUEST_MEMFD)); + + test_gmem_flag_validity(); + + test_with_type(VM_TYPE_DEFAULT, 0, false); + if (kvm_has_cap(KVM_CAP_GMEM_SHARED_MEM)) { + test_with_type(VM_TYPE_DEFAULT, GUEST_MEMFD_FLAG_SUPPORT_SHARED, + true); + } + +#ifdef __x86_64__ + test_with_type(KVM_X86_SW_PROTECTED_VM, 0, false); + if (kvm_has_cap(KVM_CAP_GMEM_SHARED_MEM)) { + test_with_type(KVM_X86_SW_PROTECTED_VM, + GUEST_MEMFD_FLAG_SUPPORT_SHARED, true); + } +#endif } -- 2.50.0.rc0.642.g800a2b2222-goog