From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 619E1C677C4 for ; Wed, 11 Jun 2025 07:50:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF03E6B0088; Wed, 11 Jun 2025 03:49:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA0126B0089; Wed, 11 Jun 2025 03:49:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB6F86B008A; Wed, 11 Jun 2025 03:49:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B0AB76B0088 for ; Wed, 11 Jun 2025 03:49:59 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5689A1006D7 for ; Wed, 11 Jun 2025 07:49:59 +0000 (UTC) X-FDA: 83542346118.01.A90F56D Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by imf03.hostedemail.com (Postfix) with ESMTP id 030E320003 for ; Wed, 11 Jun 2025 07:49:56 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf03.hostedemail.com: domain of tujinjiang@huawei.com designates 45.249.212.32 as permitted sender) smtp.mailfrom=tujinjiang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749628197; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=X073OXvi2n8TlIyqLXwIr2vQnBIBUiYaqvHBCgHFQtM=; b=u2MR+S/1aPxLxqHSLG3x58YpuaXcMwqa4lwlhI3LhsW81NxWUKKOzrDyQF/jMlij3aoCUc N2nERbeAtoK1LYiHuKJwwLsdUt6yBaLbabatCCYy8en0+Z+I/w431BLKxh2HOda8ZSMdHu mhZaEfRoOeCRi8VArGF8E6boTPmOmHI= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf03.hostedemail.com: domain of tujinjiang@huawei.com designates 45.249.212.32 as permitted sender) smtp.mailfrom=tujinjiang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749628197; a=rsa-sha256; cv=none; b=UsdQjex0AFS5ZiB+Br4FtSREnYwvNKZKODSWCIdzMVoVUyZ6LpIIfPZpOxrmnx3bPWkSR8 UTni48qKGafM0XggGegqoA1bIamblJMqHhshfR2AzMrmcEKrj+a/KJMH9vmY+n7y6JGNd2 1lIq4PSXnHSylU6po+gNCqIe+mhJm1w= Received: from mail.maildlp.com (unknown [172.19.88.163]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4bHHs041Ppz1vnHC; Wed, 11 Jun 2025 15:50:44 +0800 (CST) Received: from kwepemo200002.china.huawei.com (unknown [7.202.195.209]) by mail.maildlp.com (Postfix) with ESMTPS id F2508180044; Wed, 11 Jun 2025 15:49:51 +0800 (CST) Received: from huawei.com (10.175.124.71) by kwepemo200002.china.huawei.com (7.202.195.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 11 Jun 2025 15:49:51 +0800 From: Jinjiang Tu To: , , CC: , , Subject: [PATCH] mm/vmscan: fix hwpoisoned large folio handling in shrink_folio_list Date: Wed, 11 Jun 2025 15:46:43 +0800 Message-ID: <20250611074643.250837-1-tujinjiang@huawei.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.175.124.71] X-ClientProxiedBy: kwepems200001.china.huawei.com (7.221.188.67) To kwepemo200002.china.huawei.com (7.202.195.209) X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 030E320003 X-Stat-Signature: a1hpf9iruk8zm8gaq46oxhxneyi11a9g X-Rspam-User: X-HE-Tag: 1749628196-368188 X-HE-Meta: U2FsdGVkX19Dxu/YIKM/z2aZr704/qnrVyCbmNbTYJYfXi03XLhgoLYekWdulQ8R/Tys0QJwQElO28wliqC97SaAZEHnED5NA9ZHyoOljjRvzjNwdjTqAM+gAjQ/aai6YJEQExyb80UmfIki3gFs3wE4YWUkHrMmVhJ64dBkT3i8siozTJthGIXnTWCl4W3MK7EbJQU/29sIkdZzuYoUhf9M78WpTMr8bUizBpAGsJ0CreZhZhW22T97ZnF4safBR3WtIWZjiK31ebR9P9qGuqj8wv0nvZZEVz2sbz0RzW+cA2IUxLhNBW4EbOwl8sL9prTSccM44zr2kd9xBE1dJydpJr+83hozOkge95E1C8R4tQGfg2WVwUoYztOHD8amZIEtiFhVUfTqMQcFw79izWwkTOhCK/Yw4/wGSGqjndI/yuRwuHXD7jAwdQ0ucc15SlRvANnjs1rQglqWmHtMThAOUarbnRlQC5DFETMD5c03OIqvUlzPj8ciEoj/CgfK92SxjI8DMEEVb+g4kkpvhVXlyXBrS660lfCXnTP9683jCxcbUd1rJHOtoqVcF7H6GvJ7AjQqdAUX3VgjOlOWAfbTLR7W503ru3RWQtTHh+kzexmWma7YqymIBhRP1zcl8H2A3mOkOc6NOrJmyc8KYa2Gz6ChEUVl0AMtBpVPRjilMdjCRdAOJsTIBx2/94vkQwPqZQbECYiIvO+E4C7vAWGbb8C+cefOPUT2dE0nzHxaa/h/HLsXqmDcbOLcVaCGr6gQnDZ110sC/UFPmIFGzWAwipa+qpVlXzQkiZxg21j1g2bJd04edWk2ZV8yB6dl+W5cXmgNzr0cjZM2PXEL21iIuXIHHwBUCzD+cCWDU8NRHyr1KGtypP6OOSPKGXvuszwxQKn0g/34NL8wD1DPtanHvNFlIpIT29vVDhZF2Nvai8lfKjWsjHorNSOd1S08xJ3sZLWgk5FKOlgUhWe N8JEryse wuut/gmq9OAJVc+HXsPEe5Jqu6MIbm7A8YVQ7tNS4bBcwLiHUhJe+WE2RWkrp8W4ejHGnk4vdBoDbRM+Ir3YqkrNiixB5Q+HyGvKdHxAjy8ATtDYlExoxJrKhiBPhZWpw6gxj2cmo7hBENrI2fx6b1EA0VkXNF4/B+b74YJSN6rXWQTiFDZPHgTpzx5ZjdEJtf9PjC3IwpcbdMi0wZ0MoRStniP9q7EWT4417Opq0J2rqZDS+tCkrgLLlZ0X9PPwHvrr4IviK/WmqG0kWFImZBscUahRwAt3T3Ttn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In shrink_folio_list(), the hwpoisoned folio may be large folio, which can't be handled by unmap_poisoned_folio(). Since UCE is rare in real world, and race with reclaimation is more rare, just skipping the hwpoisoned large folio is enough. memory_failure() will handle it if the UCE is triggered again. Fixes: 1b0449544c64 ("mm/vmscan: don't try to reclaim hwpoison folio") Reported-by: syzbot+3b220254df55d8ca8a61@syzkaller.appspotmail.com Signed-off-by: Jinjiang Tu --- mm/vmscan.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/mm/vmscan.c b/mm/vmscan.c index b6f4db6c240f..3a4e8d7419ae 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1131,6 +1131,14 @@ static unsigned int shrink_folio_list(struct list_head *folio_list, goto keep; if (folio_contain_hwpoisoned_page(folio)) { + /* + * unmap_poisoned_folio() can't handle large + * folio, just skip it. memory_failure() will + * handle it if the UCE is triggered again. + */ + if (folio_test_large(folio)) + goto keep_locked; + unmap_poisoned_folio(folio, folio_pfn(folio), false); folio_unlock(folio); folio_put(folio); -- 2.43.0