From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD8BBC61DB2 for ; Wed, 11 Jun 2025 02:54:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 59B606B0088; Tue, 10 Jun 2025 22:54:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 54BE06B0089; Tue, 10 Jun 2025 22:54:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 462B96B008A; Tue, 10 Jun 2025 22:54:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 245456B0088 for ; Tue, 10 Jun 2025 22:54:43 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 958AD1D8471 for ; Wed, 11 Jun 2025 02:54:42 +0000 (UTC) X-FDA: 83541602004.06.7D65536 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf03.hostedemail.com (Postfix) with ESMTP id 96EBD20003 for ; Wed, 11 Jun 2025 02:54:40 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VZZMRG43; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749610480; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dJsYb9+gBNIBd/LiMHYhW8GoRnoSS8omC88I1y4WLrc=; b=Z8jNwcNJN3ChWgIE2YGhh4UvDD0CTVeOqXXA3yWYSvNEB4a9jWt7WQBzvQM7Vv0WGlfkR0 qZNbbO7F0X3rQgeSYAJVA0BoQ9oIwL/WEl+wAJmHktFhNdyVERMt7AsN8E2gUwtgadMXwB AJZMaqAVo1X/V5cC+iRcNmcGZKqM2Tc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VZZMRG43; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749610480; a=rsa-sha256; cv=none; b=nJOVF7cjPFT42+Gtu1PkGjuW3hWUqhmFukwvJrgmZ0SRj3UhB8NqY239sF0GoLwYeuTdyG T0IEMRVo03eh15aL5k2wtQSS3YNuaPYiq5y4e7x1bGAbcKyRL9J7n/8UiW4BhmefxGpSow EkT7QOMocHiCuH+jo9c1UqZDyG65ho8= Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-60700a745e5so9522910a12.3 for ; Tue, 10 Jun 2025 19:54:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749610479; x=1750215279; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=dJsYb9+gBNIBd/LiMHYhW8GoRnoSS8omC88I1y4WLrc=; b=VZZMRG43d7V5Cep/P0fP6c4BWg6rT9MCAR0idqjMYjMfGn8AoeR+yRtHtElRt4QJ5m arNA/Eu4zA5gU9sSz1fJYast3Y9sGKHfgjy6P+8Aj5nHgr1gZD2XxuwlftsCEbNyr8Ig T0mv4BzSkUKhCmKloBQS3SDvfDLl3eaGFsTV1ARL4+osUDKCwLnleqY9089PFACbTnRv B8LuIxg8aw+VPtbSjUS6VUH7UA08lY80eKeq6CR5+RkZFADbZnOZwO/gYT1zO03fiFkU HV8OJ8DWpuq1WzRIlJ6V6KZ5CicaupQk+d1Qw/NgHZ0eLmNltvD6YMksp/KYf0XG3cFs Z1vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749610479; x=1750215279; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dJsYb9+gBNIBd/LiMHYhW8GoRnoSS8omC88I1y4WLrc=; b=xKWDSDhAZx+2jAGZT+1zFkvHH77UN/k2PlN0Kss8Pz+nmAfmdMebTyvms9FKRRqYXn qQ1XMhqgRs0XLb5gAj/rzPQRyxgnmvxTWdSW9BUylmoVpMcQ0WEqwMYNUnL2BctavXbn hPtGyE7W1aBbKAx/HYSUtNyYIwqKVJtZYdJw1QICj/oWq+6UAcBPMK4SLDF48Y3DiQUl 28tM+G6SwRqUfl9sDDXPLk4YRV3aAPLFkGYyOoWp773dqW8SmUEcA5mGzlZat3G3Pmgn T6AGqYz99J4SvT01JP8X6qkK9TYpzJM47t/n1aS/GIV/SwAfOfS+p6AHExw7d5CuhD+M TOCQ== X-Forwarded-Encrypted: i=1; AJvYcCUFpxxB+kTbTC3y1aIOpoRc0gpHXvkGpEzDHw71AzQqXEx4bcAaXDMz/RWGdvSu6ccxWxIgtCeZXg==@kvack.org X-Gm-Message-State: AOJu0YwEvykJG1OM/BU+HKicj7Vhy7KOp0eC+q5yVG9XRHk86wRwYtnR HpRNcfZ4G6/vpY0IJlFfbuqtmanCBJWPV9g4+iDeeE1iCdGpt4xHpn+O X-Gm-Gg: ASbGncvDoCuiqb9ellFfb1Sq4BO0kyOozeZIEP9flYQAVnRH7eFqHw4GI7j9iN8qqTS IYpYbsj88xJ0K80GmdNDWHkvC1gN7/GQK1uFCb4bLHLLeAqTu8AvUW1IfpE2uir/OYf04zwTQ59 6XBXZ+yz7+Q7irqiqV16SlU2IX0RtbvTOiRglmREwAztYhKepaPNpGgAdeXgoa9uq4rjxkhigeJ 6w2eMQZ+32srZkTE9s5qgu+sRfF2RiJhdRc5EOoIaGFOFc6i2CULR9p0pODGorss3gcHMgSm9vD bcTZAzeyVVs2xKfHgiVcpjhF8gG5J/LYDM3p862+S2O66OnM8ZU6gcQIIYYZWw== X-Google-Smtp-Source: AGHT+IFhFrNRNtjtIW1qSjYp8eSGDE0a3XtZCLv1aEmdbvSMmcdVPyqfLYu/XyT++R7sG/lIoCipdw== X-Received: by 2002:a05:6402:270b:b0:607:1b7a:b989 with SMTP id 4fb4d7f45d1cf-60846aec68emr1290566a12.12.1749610478680; Tue, 10 Jun 2025 19:54:38 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6078a54da54sm5974775a12.6.2025.06.10.19.54.36 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Jun 2025 19:54:37 -0700 (PDT) Date: Wed, 11 Jun 2025 02:54:36 +0000 From: Wei Yang To: Andrew Morton Cc: Wei Yang , Liam.Howlett@oracle.com, willy@infradead.org, maple-tree@lists.infradead.org, linux-mm@kvack.org Subject: Re: [Patch v3 0/3] maple_tree: Fix the replacement of a root leaf node Message-ID: <20250611025436.wa37ileuswr5gleg@master> Reply-To: Wei Yang References: <20250611011253.19515-1-richard.weiyang@gmail.com> <20250610183727.5116056fe4cb7ccd36e93b9d@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250610183727.5116056fe4cb7ccd36e93b9d@linux-foundation.org> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 96EBD20003 X-Stat-Signature: x5xej818dgq5abqbryrb79quhi481wps X-Rspam-User: X-HE-Tag: 1749610480-434284 X-HE-Meta: U2FsdGVkX18uzK5v1on+lGSspAOsAA791smlfRmOdXgwD8aPxZAubVv2WxCRd5+yWi3FxZzr43l4t4Fx0iH4gz++NkJwjeW14qesEtvEEnHdx8ObfjKkjv1ebUhSw0pCUiaBp8EG28gnEauMXkiqGPDigix243c2MEW1gguNMWBNM7XamSL98ghp4YT8P+Ir9Jl/F/GVRpLlB4E77ZypmDkRZ/0cB6e5XHPPege+2WhWTilRqqEWSOdi8ruwbZ2GYhnNihF8RzQpimnGqTe2ymVJVHwJwpoiO7BzJGueDclZqwvXQSAQs1Op3IfknWkWrbOrbqa7+taxgswSH6OHm42b8urjnPVxoazcykvTC9g8rFs8I0Lpn3ID9mklp6rFLPGJDVRM5U2iIjrUQdQJ63T1ONRQFJ2nMQL+nyvSsSZ7CSHeYelMauCRWQg2YRVWzukstXAtocOI6FluXiov0wV3mUK0MmG/NQdl+UuZPxxCq+hDqc5E8RVWBlnoxfF2SlKmhBrxcP89T3eCSh0vV1Cd9haqek6QA4YbE4XvJEZcAA6b9QAlfDZTi8o4BybIXd8iDKxVr5kz04xoI+wkWQE5rXtIwIncD3m4zI1emRxOKq/xCNzgLFtgihN6cIEFvzu2CzdfNYxvfVdPAa/oGRWG4sWqt8RiSFXvw0/R04GwPBYVBDfls0fCHCb7TeRmsGR6yacBL6P92Yp+Ev8gIlOqNeT/a9BjTE7f94dVQAUDXVOEdpKpmk5cn6GHTUUlDsVilqlspCl4n4ghbRzznJFzT333bEis07ujINaODwVAX3Al6BFAR1nDKsifWeBzQGl/ieHu82akD8WYCU+xlnhOdJTVyKT2gHo6eNtRLS2vOx3BEDJJjskciXz8BfhgidEtZpKR1dYzqJ+Mg/1cVWSsaaMVDF+BoBXtvLKXuIkWaCQhSchrZ46AH6rEcn9E84ysqLEf8vvIc5m3Vz6 nCEoQieR 8U/PCXRFT3t/85GtDS3Q/wrWfFTrM4V/HkI/Qs9roiYVofYKgMNU0NQbyFBvAi0wM4EKzO9f/etZt03SFwU90E9ylFa/I9LXZbxqmoioHcMpE8w8F6Op8QT4C5RO4NXgnHe4MCKJeaLqxbdlK6bhTDRWhy3F0qLth324Myscr9rJy/+T3l7avRMhyctcdyqfjckwVddHLHaj8OSLglcAxViBeC5PWMP0PbRXa2w4rp/9aci6cRjVeeZdiH+xU1ZBg/1VDhnrT0O+9wDjk8DIURoticBh1MYoyzSaCvAgoyqVEBHimsM/lVl+7y+0R6Ao7Af4y+ZRCE9RwZioZdkAzGpcFV+Zsbbzh+heyGILg7oOa9kLHZM6UpOX5Zn+dxG9xBlJ2j1/GEat1oNEWY3bEaOJ+PWR3DpHdPEbjMVW1GeezIcORZxgGqMeFlzaY59iZ/TifIUx75rgiDu8HmcshB6NhgdV430AnSOsWeBo2aPwkg5XLBJ7R5TtwVH0o7yySGg9G75taXuleK6fx2j5w5f4oWN68aIn2KDXMyFBDNcwuGZKSg/65nga+w6htKXXRrXUhjmgVuxCwyA2c54KjEsXBBxo/arCzHYY9W9Odd7cZiQdgAoGdUsHpAs8loFH5SWqaHMF09gJWEuvANGvfobJdsHRR9goircf9ShGsm0RETtScFcQY37OhdnOoy2noVQJ/4QpRWDb2OopZcYuydL97wrxsgl4AcnV+obLmNdX5JzE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 10, 2025 at 06:37:27PM -0700, Andrew Morton wrote: >On Wed, 11 Jun 2025 01:12:50 +0000 Wei Yang wrote: > >> On destroy we should set each node dead. But current >> code miss this when the maple tree has only the root node. >> >> The reason is mt_destroy_walk() leverage mte_destroy_descend() to set >> node dead, but this is skipped since the only root node is a leaf. > >Thanks. You added cc:stable to two of the patches and that's great, >thanks for remembering. But the changelogs didn't tell us why you made >this choice. > >So, as always, please always describe the userspace-visible impact of a >bug when fixing that bug! Thanks for reminding. Do you prefer to have a new version with the description in changelog? -- Wei Yang Help you, Help me