From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15D29C71134 for ; Wed, 11 Jun 2025 10:23:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C90056B0098; Wed, 11 Jun 2025 06:23:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C18C86B0099; Wed, 11 Jun 2025 06:23:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B08206B009A; Wed, 11 Jun 2025 06:23:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 921466B0098 for ; Wed, 11 Jun 2025 06:23:50 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4DAAE807CB for ; Wed, 11 Jun 2025 10:23:50 +0000 (UTC) X-FDA: 83542733820.12.096ED8F Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by imf02.hostedemail.com (Postfix) with ESMTP id 556398000B for ; Wed, 11 Jun 2025 10:23:48 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IMpA9Zn8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of tamird@gmail.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=tamird@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749637428; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q9qhOcOtFQhfffMpoMualzwb4BvJ35IoO/XhbMyL5dA=; b=1U2+cTvxlq68vfd4FeonIqTAuSBqmt/19Zp/o1kv2fuiCtGH7fYdpjeBU2LPAvYJsJKPzt pnbcLMVGERxb+/2/gwaHUbidbJsFXPRaiEVvYdhp66v+bB2RSjh0nle7ihRPXj26xGxfdQ H/GPUa5DW8iLQqHhvvry5XV35nMvTQ4= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IMpA9Zn8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of tamird@gmail.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=tamird@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749637428; a=rsa-sha256; cv=none; b=WDStfr5ChEKh6Z6MbhfSr+N+nu7+EKAxL7mRSa+p6/vrCyogVimKTvNY9ho6V53x+Dfc78 M4KDiPAJzhJZpshM50iE2JMuXQSPsGnHBSsemt139d/pn1lO7JWL8BltJtv36gXfYfNut0 nML03f1tM7idZ0NV3Z8tTtQgOrE8CP8= Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-4a4bb155edeso79889701cf.2 for ; Wed, 11 Jun 2025 03:23:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749637427; x=1750242227; darn=kvack.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Q9qhOcOtFQhfffMpoMualzwb4BvJ35IoO/XhbMyL5dA=; b=IMpA9Zn80otV60yh3y10rg4FPfpOHQ17RSYJoyPt3BZK2CcJZcMf0Hf/IK7c+Qeqnq 7UDZRn4aYZqY+cZAFr6JeKQ2mpEVb7R3yRL1e5cWuU+1bvFMm8eIM5O72Pgt8oDSuuzX r4AEehNu5wibg7Nol9uvtd0os2yqIlxfhyZ3FcyKvFukwhiyflHfI+pbpTwGpphgdYtf j0xgLKap1AsaHpIu5YXMSxE2NvY0l6lhVPpZXyb4US3HfouOyH+glqH6aNWq89h8KIsw cGk6YPP0Lhm06fksOpgE77s5WEaZ3uScBbWyjR5RcIEldByGBvU/lami5wJ9LL8nnR6v XzzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749637427; x=1750242227; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q9qhOcOtFQhfffMpoMualzwb4BvJ35IoO/XhbMyL5dA=; b=kullSgJVV4y+S0XvlaJ80U5do3NaeYcjH8pSbqSWB8TMICTuD0o6llDNVFGNTRcZsV y2+NamMd5yOw9WMb9Zb3DdXyd08qIfsum1I3s708RVEPE0RFH8OKsm9iDHkn8uqk95Tm XM4mZXnWdmfuEnEgiWJxyeeROZUSGx8b0shyhFmwwxyRzg8URUP4w5XHVEZyiCIvBYDk Lfe+qHIHlm+J3f8GitnsJUhKSyPZvVqVpcHVE9r6TRu6YX8MCAO3zuNDoYC0XNaJdpFb KBH3eL7ZklqF6Gp8GEggPij9Zq42SMM6lvxs/nZ95Ri55ey18JvldwARakUgFvncbN98 PsbQ== X-Forwarded-Encrypted: i=1; AJvYcCWR7K5b2Mjva3TlWnvytjA4PHL9uB/e6GzpzemlJokLyS2J3FsuhamHDoslCb4wOcAgQyJxqH+eyg==@kvack.org X-Gm-Message-State: AOJu0YwvXzFXlYkuDDdped61QYpVnTWkeH+53mysJojmXZloip2Nw5XG FtcYkBzG2OPqSMuB23jrGKs0dBJtYZ0SiR22Y6eKEWxH8AmSmW9DgGD7 X-Gm-Gg: ASbGncvIYhpZSJ0PvL06UlbsRvGp5F9+PXPUcXTnxCTTvTboQ3lSKQpZOPcmgm+Z/E+ 7l4FmdfIWn/kCWUdSfGErhzu+2ijtnhxRCN2AakKhepaRSBWSUrGpmcm1G8TBYCXfHMj7H6oSYv iQV9mulhmZUMvNtRb6sjMY4oUDG0+9shlfXmrW1G8yzLQKP+ISJ7c9kMl8mvcEj1DpE5qEA3T1H GUKuTifxXySGgaTCBUMQHGiQ9e8/mxqcW0aJiCziL1Ssz0xJ6BOWyYPibwG+Tesao0jyWX2td43 wP3NkU6npo1/TwUUi9hlCkNrNn28a+Up/u0+0vDLG4fDc6ObPjRYk51pVxDk0XPAEOM= X-Google-Smtp-Source: AGHT+IEE+UdMzaOchvhdv2iTiBaMPk9Je4GKo5cGJfflzkUjSPeeVlANuY0LrkSRHqmvIwKc1ILAag== X-Received: by 2002:a05:622a:5c87:b0:4a1:3c6c:cda2 with SMTP id d75a77b69052e-4a713b9527fmr54652301cf.1.1749637427330; Wed, 11 Jun 2025 03:23:47 -0700 (PDT) Received: from 1.0.0.127.in-addr.arpa ([204.93.149.208]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a61114ff18sm85664341cf.6.2025.06.11.03.23.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 03:23:46 -0700 (PDT) From: Tamir Duberstein Date: Wed, 11 Jun 2025 06:23:29 -0400 Subject: [PATCH v11 5/6] rust: enable `clippy::cast_lossless` lint MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20250611-ptr-as-ptr-v11-5-ce5b41c6e9c6@gmail.com> References: <20250611-ptr-as-ptr-v11-0-ce5b41c6e9c6@gmail.com> In-Reply-To: <20250611-ptr-as-ptr-v11-0-ce5b41c6e9c6@gmail.com> To: Masahiro Yamada , Nathan Chancellor , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Bjorn Helgaas , Luis Chamberlain , Russ Weight , Rob Herring , Saravana Kannan , Abdiel Janulgue , Daniel Almeida , Robin Murphy , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , FUJITA Tomonori , Nicolas Schier , Frederic Weisbecker , Lyude Paul , Thomas Gleixner , Anna-Maria Behnsen , Benno Lossin , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , John Stultz , Stephen Boyd , Lorenzo Stoakes , "Liam R. Howlett" , Nicolas Schier Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-pci@vger.kernel.org, linux-block@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, linux-mm@kvack.org, Tamir Duberstein , Benno Lossin X-Mailer: b4 0.15-dev X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 556398000B X-Stat-Signature: thr8cyq5amtwk8ygom87j6o91fyjgppb X-Rspam-User: X-HE-Tag: 1749637428-490568 X-HE-Meta: U2FsdGVkX1/IZHmdAkjWI8QsqQ/2st9D5BryJcCV5zS7Bwf8+4bRP8Zy/ur42OgZCHuqIy2FPriwSCsUx5ImNfkZkmE5r2qQkRtvNswLzfU9ulOyROBisDhWn9phxjibcI5xp3dNwwe6AdDchDY6TNziqFzz2dDegOVMltPo/Au8VlLZQroc3f5tlYcNCJXxtYmdYfkxpzMnWJrke46yw4QkReYP5xB8exA53Xe0BbHJ9NhdQtbjWDqrqmd954jEU7j3MrEzeG1VOkIQ6rl7jIu7gR4clmOvN8/huHn2PF3CqK/3+3s9yqDX21wo2KoQgyRvwV2E+QEQQ3HAZhkhaGOH95w5HRYh791BdJF7QGTHNgCWVFhz6zDpPtRlux2HR5zpZ3TCmF2K1xdolKsE81bYT8cfKg+P6bU4tktMDdtgDBhJ5a0xugjSDzjEsa/IsyE6Jm5ZsbzFH2OEPvcO9cYDMwaBHU+s/yrNIVQYU2mcyZCsAzAfk5MZQOe3lYg2yUedTmJnvLvb6eyREJUb+abZyz85l6GpDzouvl7v5ak6iuih0k2PrjiN1/be3gwgCS5LjoaQlJLJ11ICsK6HCtU6AsY6MFyyh/D6fek/RzWcGNDsKb0YAYetGvsvl4mh8LKLIGpxvWyD+lx6wGvVUZGzfXO4iZMWQa0Wvj0ew3z9ds/ZlfyQg5XSCSSt3CfI1eLUCHJzCdH5fy+yfrM16ghot3RqTYmuJ1EudZJZaQ6ok+BEk6UZYzhRP7jSrbm5wVYRXhrukLcG1O24MKZ/oEG+gLNmGprE8u/HybqiDhA0T2Wm/mJEzAptiyyunFwlifZV0sekCOevfCGLfMuBIZh2sxFQBD+oUhuAc7ZjOFJksJ6UpsHYvYKx2+UOwBjs0qebYJK30TkcseXgQJJNPqiO1RVWF/HvOjUTRkUz+OHzOfNHt/SHk7ccOuo/QArdR5V8Z0BOto5P46XuaZ/ P8t96oT9 DvihMp8mDHnHY2qZEI6UzxbllSB/GXwVhx9uBmwR91p0YF2T1/qwX/FwqMMLC/Zdur1nmfWlNvlyti4EA5VPftazBqlqQ9srr7s/H5DDjZ8+VW3s8GR+8OQdMYUh12WpDu4iLAhsdeurkygEBUwbdG3RN7khez7k9WxZSI+PUGgIiky3my6hK3HjIpSMIXnqwTzT0RAUnlKCNvoecUIuv8roXn/JPw0UvoAy/NfQSji8lwymIXNqw9aEsxmIZ+rLlYYUjdySLshAtsYVWxZuzZ7pRJDbRdzsW3yC9Fra8+SezdT5AQGtyM7RSJoloEUN1EYd8OBWihDI7euDTFCgrdrnQPSERbi6PpuDx9EpxJWpOa8qcUPIIohpEkKvV2/lSFZ/K3dqmGNeLC02FrKuqRne57iesksWC+9VMpadZkja/ZPggz9C5Z3+7WzO6W8QOIeZScxwN0ZXFJbq5GNAZUOMmZiBeSdAnTnaeZ45qzAk2EAQDdP2jyWKJAFUizmTdWlzNZWI/mAC73mQDvdb8/QUu4+avwBYUf7pBlJr3Rh/vSv3crGuSOpHRWNGnZhCS6ljQhlzIX9GCYWdQ+0+ud9UmOI9OVYtCl0eTubfq8VTXo7k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Before Rust 1.29.0, Clippy introduced the `cast_lossless` lint [1]: > Rust’s `as` keyword will perform many kinds of conversions, including > silently lossy conversions. Conversion functions such as `i32::from` > will only perform lossless conversions. Using the conversion functions > prevents conversions from becoming silently lossy if the input types > ever change, and makes it clear for people reading the code that the > conversion is lossless. While this doesn't eliminate unchecked `as` conversions, it makes such conversions easier to scrutinize. It also has the slight benefit of removing a degree of freedom on which to bikeshed. Thus apply the changes and enable the lint -- no functional change intended. Link: https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [1] Suggested-by: Benno Lossin Link: https://lore.kernel.org/all/D8ORTXSUTKGL.1KOJAGBM8F8TN@proton.me/ Reviewed-by: Benno Lossin Reviewed-by: Boqun Feng Signed-off-by: Tamir Duberstein --- Makefile | 1 + drivers/gpu/drm/drm_panic_qr.rs | 4 ++-- rust/bindings/lib.rs | 1 + rust/kernel/net/phy.rs | 4 ++-- rust/uapi/lib.rs | 1 + 5 files changed, 7 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 0ba22c361de8..29cf39be14de 100644 --- a/Makefile +++ b/Makefile @@ -481,6 +481,7 @@ export rust_common_flags := --edition=2021 \ -Wclippy::all \ -Wclippy::as_ptr_cast_mut \ -Wclippy::as_underscore \ + -Wclippy::cast_lossless \ -Wclippy::ignored_unit_patterns \ -Wclippy::mut_mut \ -Wclippy::needless_bitwise_bool \ diff --git a/drivers/gpu/drm/drm_panic_qr.rs b/drivers/gpu/drm/drm_panic_qr.rs index dd55b1cb764d..6b59d19ab631 100644 --- a/drivers/gpu/drm/drm_panic_qr.rs +++ b/drivers/gpu/drm/drm_panic_qr.rs @@ -404,7 +404,7 @@ fn pop3(&mut self) -> Option<(u16, usize)> { let mut out = 0; let mut exp = 1; for i in 0..poplen { - out += self.decimals[self.len + i] as u16 * exp; + out += u16::from(self.decimals[self.len + i]) * exp; exp *= 10; } Some((out, NUM_CHARS_BITS[poplen])) @@ -425,7 +425,7 @@ fn next(&mut self) -> Option { match self.segment { Segment::Binary(data) => { if self.offset < data.len() { - let byte = data[self.offset] as u16; + let byte = u16::from(data[self.offset]); self.offset += 1; Some((byte, 8)) } else { diff --git a/rust/bindings/lib.rs b/rust/bindings/lib.rs index 81b6c7aa4916..7631c9f6708d 100644 --- a/rust/bindings/lib.rs +++ b/rust/bindings/lib.rs @@ -25,6 +25,7 @@ )] #[allow(dead_code)] +#[allow(clippy::cast_lossless)] #[allow(clippy::ptr_as_ptr)] #[allow(clippy::undocumented_unsafe_blocks)] #[cfg_attr(CONFIG_RUSTC_HAS_UNNECESSARY_TRANSMUTES, allow(unnecessary_transmutes))] diff --git a/rust/kernel/net/phy.rs b/rust/kernel/net/phy.rs index 32ea43ece646..65ac4d59ad77 100644 --- a/rust/kernel/net/phy.rs +++ b/rust/kernel/net/phy.rs @@ -142,7 +142,7 @@ pub fn is_autoneg_enabled(&self) -> bool { // SAFETY: The struct invariant ensures that we may access // this field without additional synchronization. let bit_field = unsafe { &(*self.0.get())._bitfield_1 }; - bit_field.get(13, 1) == bindings::AUTONEG_ENABLE as u64 + bit_field.get(13, 1) == u64::from(bindings::AUTONEG_ENABLE) } /// Gets the current auto-negotiation state. @@ -427,7 +427,7 @@ impl Adapter { // where we hold `phy_device->lock`, so the accessors on // `Device` are okay to call. let dev = unsafe { Device::from_raw(phydev) }; - T::match_phy_device(dev) as i32 + T::match_phy_device(dev).into() } /// # Safety diff --git a/rust/uapi/lib.rs b/rust/uapi/lib.rs index e79a1f49f055..08e68ebef606 100644 --- a/rust/uapi/lib.rs +++ b/rust/uapi/lib.rs @@ -14,6 +14,7 @@ #![cfg_attr(test, allow(unsafe_op_in_unsafe_fn))] #![allow( clippy::all, + clippy::cast_lossless, clippy::ptr_as_ptr, clippy::undocumented_unsafe_blocks, dead_code, -- 2.49.0