From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD552C71134 for ; Wed, 11 Jun 2025 10:23:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 367186B0093; Wed, 11 Jun 2025 06:23:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 340476B0095; Wed, 11 Jun 2025 06:23:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 208676B0096; Wed, 11 Jun 2025 06:23:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E34516B0093 for ; Wed, 11 Jun 2025 06:23:45 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9D83DBBB35 for ; Wed, 11 Jun 2025 10:23:45 +0000 (UTC) X-FDA: 83542733610.07.079D3C0 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by imf11.hostedemail.com (Postfix) with ESMTP id 9CA8340008 for ; Wed, 11 Jun 2025 10:23:43 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nPJqFvBI; spf=pass (imf11.hostedemail.com: domain of tamird@gmail.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=tamird@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749637423; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BwuzOkwr2WXLbNIqZ4PjxHxYIhjL5EaV2fkU8tqfaYg=; b=uujsqU5JsPt7nroKGQqs8GzD1Lu/EfmG6fO+cL7M7zwbQ98C66+7f3P3B2BeCdPunpbcRU yacx66OURj1eUeREm5DzRqEjnCzdm0wZh1eE1WxQgwn/d7F6C4RV8yYMK/2ceqkLXLddWA GsyFzGzME0lWyxA75hJIJAxs5Cf31o0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nPJqFvBI; spf=pass (imf11.hostedemail.com: domain of tamird@gmail.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=tamird@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749637423; a=rsa-sha256; cv=none; b=WTcIqHF1H7ys8ZJ9tPgQedcJKt1L25+xjlstMH7M7djtBD7ztxVoEZPOyo2wz8+E1CTog9 an6uhZ0xTdEZM7YfDRF9rue/RBIvwQrK6DcyTeOOVEG4mPM6nHiDdRr346cB43jTYB21K+ W/KwbfvHKYB/3FSkE5q0437Onff1crM= Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-4a43d2d5569so82690471cf.0 for ; Wed, 11 Jun 2025 03:23:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749637423; x=1750242223; darn=kvack.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=BwuzOkwr2WXLbNIqZ4PjxHxYIhjL5EaV2fkU8tqfaYg=; b=nPJqFvBI96B4FmDjDVuFXweQ73FMi4Xq0khNAtN7H/lQWFpRNnP59lJF7UWO3Tefot wWdi6631eIY6GBg8mjTF2nznNH4c+9moQNZYt82Y3nvH0K3V1VrZQ2f4zb/1flq1hBun iNGhoSETOIn+Ly3xoCaVi8rUk4TjNCLC67gig+Tpe6OWVV+VFnjsSS5IKje4XmdeF70w ybhZkZlSjGHDO2WaBYWsqevGTNaGaGwhNZi9dwYYsF540Azo2ogY4nC2dX23wjk0c+ix c/KIvrOfc5CDLPuYkxUErt90Nk21f0EkpFdNCEnair4nh+ckXoVZt8Hjy7pJzJ/g8GOS NTFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749637423; x=1750242223; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BwuzOkwr2WXLbNIqZ4PjxHxYIhjL5EaV2fkU8tqfaYg=; b=fgh6Atoy/j+6qWLtQzeWJpM/uk71c60UelUWss43R8kg7wV+PS3Upo8T2p8hYK/dA+ 8UEjdVD0dRsz+zvgTXFnVvJHSsl7snftjWUQVUGPck92VvZpYftGBgo1BK2zfty4CuUT Nldj4akFc/kwMjvIkSBnA79+S5oVJFY+3MLy4o5nv6xDEktNuSOGSdBFzn1F0yMvvV/z 9no7fq32t2WfprEW7JkeN+ipIPOBHvWe47y5jWiR2HFEPw0xoVpUVBiFGHn8j9pK5/Kd GkY9z3F+QCxDkOYCR8JwTCFa2W7Cx3La8IlBV+ECtJdbCvwcF5JT0schUhs4caOhbZyr cu4Q== X-Forwarded-Encrypted: i=1; AJvYcCUUbnpoY/jddvRvCXupG+bDTfUlvyrISBQRuUQKEjI/Tt07Srn5YzlPXF5LBiTwjGM5oSTjfkajJQ==@kvack.org X-Gm-Message-State: AOJu0Yw1ZkycknFt9sYvRkp7wHJ0AmIQWkLsZDSjvo0TrXE4mkcreRce GD5y2zN+/Hjq9wMUL+68TUpeCEtIuXXACEqE8nuyDHmnZBb78Cbv5tvE X-Gm-Gg: ASbGncuKWB8jMjoiO9KwnrpbLpB3tOsMFy8GnFQDKTbDNuT9csEyHeDpWfuC2lwkJ/2 Sge9Wd8Z9JrdQmTVSlh3MLP3D01hh/CUL10kHRsAkT4XzDR9+b/5UlM6w6JdsRNAXWylC1yfleI wR67zYgrItYzq/s2tXCLG8x3FFQQ5ojDgqo+ckZyWfud0WXhw7Zj43j3IKUb9VqO7HVdLvX+WZ4 232o6NP8Wn8fQdf+cOsY+2Vb1WDvLPuUXomMaZjIh39SUGoEmG7QqwccZ2R31NmnaO+dp0NUdqN hu41L5PpnR//4tjDUng2yMu/Jtx0atXF7dV/acOJfQGqC+Ic0yb4b92L3dtvL30el0ZtySAJPnf Qpg== X-Google-Smtp-Source: AGHT+IHtIidebIfTt2jkkrOO6cFXeDxcrBR6iqFW0QLdbmEyB32yNlITHUCKNzRDp0DfY2l6KJd6Hg== X-Received: by 2002:a05:622a:1b29:b0:4a6:f774:dec5 with SMTP id d75a77b69052e-4a714bd9ceemr41400951cf.31.1749637422582; Wed, 11 Jun 2025 03:23:42 -0700 (PDT) Received: from 1.0.0.127.in-addr.arpa ([204.93.149.208]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a61114ff18sm85664341cf.6.2025.06.11.03.23.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 03:23:42 -0700 (PDT) From: Tamir Duberstein Date: Wed, 11 Jun 2025 06:23:27 -0400 Subject: [PATCH v11 3/6] rust: enable `clippy::as_ptr_cast_mut` lint MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20250611-ptr-as-ptr-v11-3-ce5b41c6e9c6@gmail.com> References: <20250611-ptr-as-ptr-v11-0-ce5b41c6e9c6@gmail.com> In-Reply-To: <20250611-ptr-as-ptr-v11-0-ce5b41c6e9c6@gmail.com> To: Masahiro Yamada , Nathan Chancellor , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Bjorn Helgaas , Luis Chamberlain , Russ Weight , Rob Herring , Saravana Kannan , Abdiel Janulgue , Daniel Almeida , Robin Murphy , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , FUJITA Tomonori , Nicolas Schier , Frederic Weisbecker , Lyude Paul , Thomas Gleixner , Anna-Maria Behnsen , Benno Lossin , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , John Stultz , Stephen Boyd , Lorenzo Stoakes , "Liam R. Howlett" , Nicolas Schier Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-pci@vger.kernel.org, linux-block@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, linux-mm@kvack.org, Tamir Duberstein , Benno Lossin X-Mailer: b4 0.15-dev X-Rspamd-Queue-Id: 9CA8340008 X-Rspamd-Server: rspam03 X-Rspam-User: X-Stat-Signature: qsyq1a7fzfwgwjsn9uuksw3f884sehdr X-HE-Tag: 1749637423-52814 X-HE-Meta: U2FsdGVkX18s4g2+kN6MDFvJc3vThFA6rHpvpG1zvHPNo1xZLm74PBHLkaaapMYDSK91Dfe8ewCqlRCyFEeOpzuVcVGLrv3AIeU9AnrRl6w7To/pskq6KwN7aIRi3dvD9OgMe2Fp3kPDZAblZJ40nR5QdLf7xPYCZsbAWgrmY2bxvNd4GjuZlOfh6VYW5IdD4cSk/xNkgOY+d4WNiOIdFqQmN6I4pAevZgVgCtj7QOAih0JOvkD88IV7RAgf35PoLAyt8UZYvZxpvmgN3+8W/9nD8G1IK6eEXwxVFWKrJM9yllR1JEdPrAvhCmsYxSoqL+0RSiQFMG/uYcImvrHHNIkc+17ge0F+rHq0ArCQiHtcOpQNaJ3litWg3d0o0oLvNqWTZAEOLByvQMS7Rb2QzbjGc0uDMJaor+ahLbEOq4lTufOAhAVyO9SWzyvEobS/7nQpRXRx310RzChvULDfKtlu6gm7B4Jah0dPt+p+N2UbjxSmwDQZBXY5VtYFYAxlOMepM9TsdpOPa2gPyvi/3vBDZvhQzwKpqQzkkPSpDJ1BFPug1YaFOgq8NG0gkYjPyIIlqHFI1W7nSZygUn5+3GfjOeZpqc9nKDvqR9BsCECumL+XnHHzce+5CWt5sm80QEYeCIuOGzXb1bd6P0t4orlb2Xf+N9/vGeDVgk1xPJfiZaaW7o7ituwDHEyQodUzseUU3/2Z2lpKoAarjOA11h/pYyEt3mNKaFhbyx5LYj+aHjCtwcUQYfINjxs3BULbq3Ger3QoiZNWkqHMeCaIriQkSdzwtuhOgj+pA1TrJUFWwPfJZVZkERRBS1oNlq8ZZut0MwdUNreHu46BZzYOid+RBnk5hcW4OBIXfQ4W4Hjo5axwg9kxn7b752Hbfhz2udsGKqT2wHYiuYnqRz5Vr52EGad7+r+riUeC4gCak4YUmuXOnmReiEOtzaifFcE6e8yT1aVSaclGpxIV4Ys e6MfaOCH bkNb6bhNeV2PDPT02Z6PbwJwoei5m7I7w4UOmff2TyJPD5r9xTL65ZOZrLbEdketfBCL4eeK0ZF6fraDM3S3uUpNrkBj04jvO+72bxv1gwhvNs1txX95kgZC+PPl5TKvGrt2aLHkwnIKsyEo2u4dWGONg2QO2wND5BFPdzstNHe+mbnGlBu5NZ6xHTv3rdC2sbKLGrfMVfJq5OylRHOCjCrcHuxc8kP5n8G6BYkkqtk0UrBs0XF1h2gQNETecHPBUtp8WLyV+9u5kw2hFkLk/SdRp1sdS1yzpdFcZChTrhbYr1sxyHSzjkDKM3bXZPRTM+17PklubMis2SVgaHmqesCNu88ClZ9wO17BaZd4muvvMsLt08aPz+6ULwHgjq4jbh73gAQe5cPaOdsJPbluxebIvaZo5DsOPRHK6iAizbnC+4s7CWwH5aOSf1M1q+GAihs56XK3/PMWDG776xInsEysquP23Rx8VTfcNwoI/akXrfX+Mqu1ZGfPSgKSkoGvGU++4mzEk1MxTHGHx/CgAMZ+G+aFiQd2s4q+N+bpMYG+kdfFQPKs/dan8SdRVhecHjituULrT92p8qZ2gwpvx/txbvg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In Rust 1.66.0, Clippy introduced the `as_ptr_cast_mut` lint [1]: > Since `as_ptr` takes a `&self`, the pointer won’t have write > permissions unless interior mutability is used, making it unlikely > that having it as a mutable pointer is correct. There is only one affected callsite, and the change amounts to replacing `as _` with `.cast_mut().cast()`. This doesn't change the semantics, but is more descriptive of what's going on. Apply this change and enable the lint -- no functional change intended. Link: https://rust-lang.github.io/rust-clippy/master/index.html#as_ptr_cast_mut [1] Reviewed-by: Benno Lossin Reviewed-by: Boqun Feng Signed-off-by: Tamir Duberstein --- Makefile | 1 + rust/kernel/devres.rs | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 5eeddfbf5900..bb33023f87c3 100644 --- a/Makefile +++ b/Makefile @@ -479,6 +479,7 @@ export rust_common_flags := --edition=2021 \ -Wrust_2018_idioms \ -Wunreachable_pub \ -Wclippy::all \ + -Wclippy::as_ptr_cast_mut \ -Wclippy::ignored_unit_patterns \ -Wclippy::mut_mut \ -Wclippy::needless_bitwise_bool \ diff --git a/rust/kernel/devres.rs b/rust/kernel/devres.rs index e5475ff62da3..237182446db3 100644 --- a/rust/kernel/devres.rs +++ b/rust/kernel/devres.rs @@ -140,7 +140,7 @@ fn remove_action(this: &Arc) { bindings::devm_remove_action_nowarn( this.dev.as_raw(), Some(this.callback), - this.as_ptr() as _, + this.as_ptr().cast_mut().cast(), ) }; -- 2.49.0