From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8138C71135 for ; Wed, 11 Jun 2025 10:23:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA4CD6B008C; Wed, 11 Jun 2025 06:23:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B56D06B0092; Wed, 11 Jun 2025 06:23:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1E426B0093; Wed, 11 Jun 2025 06:23:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8158B6B008C for ; Wed, 11 Jun 2025 06:23:43 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3088E1A0836 for ; Wed, 11 Jun 2025 10:23:43 +0000 (UTC) X-FDA: 83542733526.07.B4DDE07 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf06.hostedemail.com (Postfix) with ESMTP id 46E93180009 for ; Wed, 11 Jun 2025 10:23:41 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kX+h08LM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of tamird@gmail.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=tamird@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749637421; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3zUYH66sAi4M6SnRnDRUP9N7P8+78tvCpZpLM0hP8f0=; b=QuYOifVBbFL937vstxGCUI7jviX8q5wnhJb8Z+B4iEATiVfT5l9OkIZRQEZMUcjGkKj6/F 6ZNyduXOKLnoTWnTQrx4lXErXZH8ZBghTeYGc8zekvgoam3cNRiTZK8vzq+VeXBfYWGqZi wJr/WzrMK9eyp7GbEmVTZmHF5TymuuU= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kX+h08LM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of tamird@gmail.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=tamird@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749637421; a=rsa-sha256; cv=none; b=bKQcPsqBPWhQm8zWL0dttmFHvXxg0SkXoqEb/KnRQWeUWtsQBuylLnmDekt6OSlyAhAEYV zIwt9H1ntnjPfcYIM2otgt3IoDGsP0WQD5aqNTVPsoqSgCsQAvMS/RMhtDklkYRwqkJi6h q9DDj3ECxmkAQYU6UP5VAP1QBPp+O7U= Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-4a58ba6c945so107299851cf.2 for ; Wed, 11 Jun 2025 03:23:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749637420; x=1750242220; darn=kvack.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3zUYH66sAi4M6SnRnDRUP9N7P8+78tvCpZpLM0hP8f0=; b=kX+h08LMdU9psGGs9Vt8G5vG66X8Bseb7xIFgLEcj0pSuXDQQgLCVmxI8y0aQNyiHK 0ZU0M6/tbU+Xhi2CUYV3A6vCqgYu3/UGXhhJT+XwKL/q9NZJDlq8k5JPIb5yXBPnW0Al pCUMwbv+9OBeXm1o1eHJaQGeVZo/I7xg4GBxaXwlvgwsgLXRed1qVZewV737l8g+PAof jSMFNVKbwJuzmPsvQBSOWLlc7aHxRiNcz+8A7UIJOOpDfV6Sqdpn8JP8yxbQQu6hnSJj Hdu7XMzCRn3Ub11/7Hc+r872+YMm95E08lZAPKf02WxvTTHXqdxJ2l2j/eN2dgdhaMvG uwtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749637420; x=1750242220; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3zUYH66sAi4M6SnRnDRUP9N7P8+78tvCpZpLM0hP8f0=; b=Dt935g4YP8JeecLa313jfOqhtjGMH73rsbDhg/f6Ap9xW9/q3NqROAZ3jYdvHFW15n Z7sT+Up2NshcVfOcUQyog9k+MAS57IegcSQpBrfpP3YO9Hi8VNnNe/nodgqXmPm9ouZW vKuMmzVR2PwX2bH8utoQOcWaIQ/60SbfuKbbl+przNE5wY/ZLEOps3OGzfuldRB8ziGZ 39730D7o1ohDb22fOViEfJ9kIndTVF3fiYBoeTPhhEMlZGVcNK9Wqa7+yAPKdfo3fX+z cSw3ooIL6Ys+H/8k0FcFCW9hpSJDoTt/39vSxpAQFhWvJ8QjHaBKrNauVGuM0h42HOfM LX/w== X-Forwarded-Encrypted: i=1; AJvYcCU96uaFNW8Q1x2ayWky4m9lgRl3qbTqmUK/HrBNiSE/61F4rvdk4Q75Nke2kfxxbCEKn/rHBhf8qw==@kvack.org X-Gm-Message-State: AOJu0YxeYUPntyf4bwSzO3OzZmCbp3rFzrlw0TQy/5EbgQqaHMTWuXV5 CL75KN7KqkTRLevcOi9HOsTy0Y/31D3tls/c6U23wTrYR3uFoCG1mX60 X-Gm-Gg: ASbGncu3+5s8+arWZTVCUwJwAbBNL6Wuo3rTNcTlQj6f8w/I9JpYTKEZLnaLrDHz5lG FV9LwVE8SISpnKbwQnt2YI0b8cwDmmCkSjLuyL6JO2H8y1wTdt6vfKMlEw4icPgJl7eUggtq+72 qFXzKHV/G54cK/nVqlkMjtU7JVt5HlUw0zKrLL9VWSQlfhvT3b2H9RRdjVhsCfiZrllorNbeNLy YDUYjMVoxrXZB0svsd+jhrCajpOixlXNjRBr8NaqyZgUb58BDFMOMmTwoD9AJDNEAXVHToB14ez WytouYQo9FB0i4NJQhMxx+GcFFTuyFS4DUULm4jPOf7uFm2uebKoMUE+lwH3D6uBS94= X-Google-Smtp-Source: AGHT+IGodjTiDzYzaYbdpnH5N4FiwK0k6INV5kLplUVd33gCvZuYk755vGupfng1qLMMcQ+unK6ODg== X-Received: by 2002:a05:622a:1929:b0:476:b7cf:4d42 with SMTP id d75a77b69052e-4a714c5a834mr32371381cf.27.1749637420294; Wed, 11 Jun 2025 03:23:40 -0700 (PDT) Received: from 1.0.0.127.in-addr.arpa ([204.93.149.208]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a61114ff18sm85664341cf.6.2025.06.11.03.23.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 03:23:39 -0700 (PDT) From: Tamir Duberstein Date: Wed, 11 Jun 2025 06:23:26 -0400 Subject: [PATCH v11 2/6] rust: enable `clippy::ptr_cast_constness` lint MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250611-ptr-as-ptr-v11-2-ce5b41c6e9c6@gmail.com> References: <20250611-ptr-as-ptr-v11-0-ce5b41c6e9c6@gmail.com> In-Reply-To: <20250611-ptr-as-ptr-v11-0-ce5b41c6e9c6@gmail.com> To: Masahiro Yamada , Nathan Chancellor , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Bjorn Helgaas , Luis Chamberlain , Russ Weight , Rob Herring , Saravana Kannan , Abdiel Janulgue , Daniel Almeida , Robin Murphy , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , FUJITA Tomonori , Nicolas Schier , Frederic Weisbecker , Lyude Paul , Thomas Gleixner , Anna-Maria Behnsen , Benno Lossin , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , John Stultz , Stephen Boyd , Lorenzo Stoakes , "Liam R. Howlett" , Nicolas Schier Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-pci@vger.kernel.org, linux-block@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, linux-mm@kvack.org, Tamir Duberstein , Benno Lossin X-Mailer: b4 0.15-dev X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 46E93180009 X-Stat-Signature: 9sfhitidgxungaobnx39kkhrau3deh8q X-Rspam-User: X-HE-Tag: 1749637421-663254 X-HE-Meta: U2FsdGVkX19FylnaZebStf131W4nsJlmhG+a3NABsNwhw6W+Qy5BvrRIMf+pSXPm+LC+xnpCzx5zEnPSxjHdOnqUyx2x71jp+GPGC73yWiEhkQ4IjXY+d2geEZBNuSHY3olRVlX068B4sjANrFGZLpA0HxyOipyVgwhkeoYG4q1BRrIUyGxcRDEQYbnl/378WVN6PbKCRpK5k40NjwOXucxeRXUaOBVSh1i5DpaaxOrTgF1Sh+I5ek9TbXg0yOXTLiLdNbSKweWivPJCTXbh2OzDoYicy8TIVscyadeZKYye1lwXusWkG7R/Iba8aGlE0oErVjx5S9/kkgGqO9SYwrMEiCFSK+7opAlRr9TATBkRHj0hNY/YE9Bhe2x+Trekc2p5TbRK3/V4axWIqVfaKcHFKGs4Gy0yW/f3Angrpkk+B7Jff7YQJZ23JtJtHgr/JRkACl9/9CHWPeMOj6xs8RdEIcm1dEok3hvSx+/lgMiQUZtf47w/ZlmcapUEuIc4vknzhRmR1fU4n045ySCZoYRhZiAsGlS/aLl+Utv1nb65S1sflEndFxLPyu49zVQxQmm2rPKAuUmSSD/i3kNdMyJzNfGv6j0dGGKpnMv/JW396meRSLnp+xRHM+ixphALU7p70e8nZC7MjQDZOpmkQk+z60B9fgfZUbD7Dqfv7GWMin0Zk4qMOv0UbI227F2MqiD+Xac8+Bp6LJ21Z/G0Wd785jIBL51Kdn1NS2oeyOQ4iPIsbfkdVYorn39Nc7yvM0wLDUhN5dHfjvOAN1F7rx+QQYpgRGy1vYtv3TrvZBZ/OPcH0354FeJMK6V06ghhAUHSfikmk3z/sfkECv7IWkK7RvTS9XNdas4zy1uPr2yE6XxWtqYVv5KVX+svJhdbFNmzbMR/op4z2tl10G3tHvSvH7+OgJHOFIh54PSXwf+54DgJLAQT8UjjqJnHYW5iIhpG923/J1YSmvtIssA CNe4B4Ij H1tUY50VjjVl6MHdVHr8mtc4Iwz8jWywC7T0NFR9iwGzphGabkE3cajHRCPzwS9xC48McJQApWcshyXCyNgc0y+hIhuVryAMGhBJSmtn6uwJt+pB543EV8oh1KEgpqiZPPifUEPPn1DfrmTe8AZL3ywzpZLN3PzvRGPmHz8aIaeHtr05BpX98rurWsHm45NS5SUd+lg9zRLqsplN2BjpvdTbS0KllfCAZ4fKsT64V2WLawoMtuBXFNvznKCg7ZLrVndpvE9noI/K934y+1uLBUEr7ZAfWp09HnumdbvmFTTgq1536qxXDqyenHh5fAamyNejfhsWpBhrZUAM0V5myolnyWGmb2ujywwz1gG+5QJqPEyt6+5+/KEJHSFf0S6vqASSkSrVyibnDg5ChglwyovHC5Kk0knU4Ng5dUps9R3TXNF4HoNzRv0BzNHCPYFDrXpCwH+ZokhZe52Qm4LzONcQ1FrYSWAHCg7hPWN3jfygv++gTvt/Jbjsn68NEodmMLI/M/XRPRUeM4V/HCTp9H8KsSDcTgD5qiSTAG4zCYbhkVHQ3JR2Gv+zrhg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In Rust 1.72.0, Clippy introduced the `ptr_cast_constness` lint [1]: > Though `as` casts between raw pointers are not terrible, > `pointer::cast_mut` and `pointer::cast_const` are safer because they > cannot accidentally cast the pointer to another type. There are only 3 affected sites: - `*mut T as *const U as *mut U` becomes `(*mut T).cast()`. - `&self as *const Self as *mut Self` becomes `core::ptr::from_ref(self).cast_mut()`. - `*const T as *mut _` becommes `(*const T).cast_mut()`. Apply these changes and enable the lint -- no functional change intended. Link: https://rust-lang.github.io/rust-clippy/master/index.html#ptr_cast_constness [1] Reviewed-by: Benno Lossin Reviewed-by: Boqun Feng Signed-off-by: Tamir Duberstein --- Makefile | 1 + rust/kernel/block/mq/request.rs | 4 ++-- rust/kernel/drm/device.rs | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 21cc6e312ec9..5eeddfbf5900 100644 --- a/Makefile +++ b/Makefile @@ -485,6 +485,7 @@ export rust_common_flags := --edition=2021 \ -Aclippy::needless_lifetimes \ -Wclippy::no_mangle_with_rust_abi \ -Wclippy::ptr_as_ptr \ + -Wclippy::ptr_cast_constness \ -Wclippy::undocumented_unsafe_blocks \ -Wclippy::unnecessary_safety_comment \ -Wclippy::unnecessary_safety_doc \ diff --git a/rust/kernel/block/mq/request.rs b/rust/kernel/block/mq/request.rs index 4a5b7ec914ef..af5c9ac94f36 100644 --- a/rust/kernel/block/mq/request.rs +++ b/rust/kernel/block/mq/request.rs @@ -69,7 +69,7 @@ pub(crate) unsafe fn aref_from_raw(ptr: *mut bindings::request) -> ARef { // INVARIANT: By the safety requirements of this function, invariants are upheld. // SAFETY: By the safety requirement of this function, we own a // reference count that we can pass to `ARef`. - unsafe { ARef::from_raw(NonNull::new_unchecked(ptr as *const Self as *mut Self)) } + unsafe { ARef::from_raw(NonNull::new_unchecked(ptr.cast())) } } /// Notify the block layer that a request is going to be processed now. @@ -155,7 +155,7 @@ pub(crate) fn wrapper_ref(&self) -> &RequestDataWrapper { // the private data associated with this request is initialized and // valid. The existence of `&self` guarantees that the private data is // valid as a shared reference. - unsafe { Self::wrapper_ptr(self as *const Self as *mut Self).as_ref() } + unsafe { Self::wrapper_ptr(core::ptr::from_ref(self).cast_mut()).as_ref() } } } diff --git a/rust/kernel/drm/device.rs b/rust/kernel/drm/device.rs index 624d7a4c83ea..ef66deb7ce23 100644 --- a/rust/kernel/drm/device.rs +++ b/rust/kernel/drm/device.rs @@ -83,8 +83,8 @@ impl Device { major: T::INFO.major, minor: T::INFO.minor, patchlevel: T::INFO.patchlevel, - name: T::INFO.name.as_char_ptr() as *mut _, - desc: T::INFO.desc.as_char_ptr() as *mut _, + name: T::INFO.name.as_char_ptr().cast_mut(), + desc: T::INFO.desc.as_char_ptr().cast_mut(), driver_features: drm::driver::FEAT_GEM, ioctls: T::IOCTLS.as_ptr(), -- 2.49.0