From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CD6BC61CE7 for ; Wed, 11 Jun 2025 09:57:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 94E1D6B0088; Wed, 11 Jun 2025 05:57:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FF046B0089; Wed, 11 Jun 2025 05:57:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 814476B008A; Wed, 11 Jun 2025 05:57:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 61F5C6B0088 for ; Wed, 11 Jun 2025 05:57:41 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CC6921A0774 for ; Wed, 11 Jun 2025 09:57:40 +0000 (UTC) X-FDA: 83542667880.17.0C8E02A Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf09.hostedemail.com (Postfix) with ESMTP id 3E587140009 for ; Wed, 11 Jun 2025 09:57:39 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="n/6FMBTw"; spf=pass (imf09.hostedemail.com: domain of brauner@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749635859; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wj1Sf7jZXzFpezv3SWCxLBwifYa4niBMpkYPMR5O4Iw=; b=fgdBAxSuYcIv2axTc5KrIckcIMVo1AJH19JK1Vk6XuD74z+XlhN/y3Wx/yw3xGUjNJWBJU GqMyKao8+JMUPor37OUuX5EMzDLbFETvv9VrArjzxPMFiNK+iJFrg9tmHhrWrmwFZjOAFd /OD1/AfwzU0KMV8AOT+vXCtkItgkb2s= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="n/6FMBTw"; spf=pass (imf09.hostedemail.com: domain of brauner@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749635859; a=rsa-sha256; cv=none; b=mvv3WpBDa7HgxoHGdzgHJR9koNsv4POcSzN36RV6m2za00D8lkI2RDxhMAsFU9pCE2jUxw QfigjU55IXuakZNxyo3jwYjUhKrhXCRW+FUxFafiFp/sX0NloX65p9YPt+brjRnYkoDcsO bWrYsnfDF6sfDdLGZMVCrLBIaPb8xXM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 90AFC629DC; Wed, 11 Jun 2025 09:57:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0735C4CEEE; Wed, 11 Jun 2025 09:57:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749635858; bh=e6TS5O+g2JwrZ8I2ZOF2aYAJsjX+AZS4VpHURqwjnLI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=n/6FMBTwIaQN2SRyM9vkcaCmosGcBtQJ+c5KUx2YCVnXFjDAKwf0hWKHhrni5xlbj dmklTuh3gfNT6cdQk/B4ISt7Gbtt+cfFSaFqiAGDp8HyX7WCSNCVQ+9ugGxnP8eCJU RB84oU9HHmsM/BCT0riqULfcimJiV4k55VpfsMyzIQtBTBIOQ6r0rATDg9sItv3kME lDhSusRlWoJCNI0V5+jLYHEcUpRwdl1seRedsQuzgP2OjF5L/g3RUkb1koXcnxHbbn J0HWHLacUxMOiUEiwjenshSVoafxRufNA8zPFF5Zme7COtU9+zqoGv9W/ABUjyGtGV 21Y3/bjAhoqwg== Date: Wed, 11 Jun 2025 11:57:32 +0200 From: Christian Brauner To: Ryan Roberts Cc: Andrew Morton , "Matthew Wilcox (Oracle)" , Alexander Viro , Jan Kara , David Hildenbrand , Dave Chinner , Catalin Marinas , Will Deacon , Kalesh Singh , Zi Yan , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v5 3/5] mm/readahead: Make space in struct file_ra_state Message-ID: <20250611-mitleid-ablief-1e7f1f03394d@brauner> References: <20250609092729.274960-1-ryan.roberts@arm.com> <20250609092729.274960-4-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250609092729.274960-4-ryan.roberts@arm.com> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3E587140009 X-Stat-Signature: uj61oa6ktw6dirbnppaofcqoqd5yrw5p X-Rspam-User: X-HE-Tag: 1749635859-76248 X-HE-Meta: U2FsdGVkX19lXUZDd8nkj07kQhVH3lxBuyIRs/UR6pR5o9y0gXdDd48L7TG6HdToxxUiJkKZiXR1htoxOT353Vgf1OhKZZlWocptRBUu6syXGLfnJQl4fgTl7RlFxGAPxGV70h/51kPO5oMu+2i9G4pLQq1GqN3zIoiKzxAmgD63vtnE8gHhbzBHyMH7ON6stBA6U1d55a6IkoHImkLbIoYQc9G7WN32/GnQqDHuTUfxm9KeiHzycI8YSVafi/2ersN/gcFNT46Ci0Z4y27/Wb72aEcp7fGfTkmlsszdgwh5GoRksDkLvPPJxtRchoTbHikbZdi8YMFIdBPk0uMdXJ+IJo4lE4eOJu/u4C8mBe4VBFzYPGqmWiTpaRZ+GBHGalp9rlOorEDHaN3ZjemqK7c+ABpqH4V2SgG0mNvt6mFG0PndFb0+Nwvk04Ce+IoOds6U/IUT/Jf1+s+0/FlBJkRj8J+AOK6U5C3R8sUD9oUqYokJwohZgFuaQzEXXSFQNIxGgZCGbVi3FrKVSWUBtS0uc2B9UOiCXaadNKGoPm2QERcibjMNo6HFHc+y87hd7WayLRWgyyAOduBkiDa5BMWq2JvHkssrspGA9F8Wy2ZnpHuNkG2UQPbB/2FOa+likaYEoYb7M1oHKYRsO+rzg1mxrDfM7cndcvEmksRo9lVHQLNFz9YwllwgAWGKDYstkl4+DXjxG3LoCFMyfrx3pQSlVcRqqlJXCNksdweP5n0b5FBeAp2EwZnxKY/o7vyEpKggqxXQFcSjCCuTi5WL2Z5S9bxXxdnd+YJig1k107pcAIOh7mENSDt+LoFeKkOn3dwTsFt+va4ZC5tSd4hWjJKniRoDv/TLNwZaYA1UlMn2cH3/VwUCqpaZGZ25isvEdK0rNwZcID+lotNz7eEBWcXQGuieV6+U9h7nz88Pnra5P9QIozuDfDWKr0QWozYpiEXOQ400gI6onyj3ZBX j7ektPMU VnDdUHcu6IAfPuEnJzlRiTGHwO9HQfDs6EnOwa8k+2boB3Uj+G8qsrCZBh7VgDuKkRsGdBqevHn2AC7RYrbnMpy09KHRrAJ4XONSZMJIzzAL6tw2N4omvjN+1+H9dWnYw+829qreQMtzW8K7iif7wWSZj5baFcfafrjjWVTmBXqsWKZ/ikI99ukKAZ6ikEkfS3SkiJISXaURSWEuWLI3sbxho+HGc7dKCXBizCRqCHTkZ+oOM2eAi/R9xGWAYBvwZ623Z6+Uihgjq2gtjyfCBy4nVGnNmWEfNZBshsR16f+fOvKSUojpKNwoWtVi2hMzDxLB8amnndA5wb2ZEpUAv1omwrL241SlvCLMfXeWWqDClyICP4XUl87z4z94QJmWif21Gkab6TIrK4RocMz1oapctUU9izmOyNO4KRtzYA+rtPj6ExbH1PVWxeA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 09, 2025 at 10:27:25AM +0100, Ryan Roberts wrote: > We need to be able to store the preferred folio order associated with a > readahead request in the struct file_ra_state so that we can more > accurately increase the order across subsequent readahead requests. But > struct file_ra_state is per-struct file, so we don't really want to > increase it's size. > > mmap_miss is currently 32 bits but it is only counted up to 10 * > MMAP_LOTSAMISS, which is currently defined as 1000. So 16 bits should be > plenty. Redefine it to unsigned short, making room for order as unsigned > short in follow up commit. > > Acked-by: David Hildenbrand > Reviewed-by: Jan Kara > Signed-off-by: Ryan Roberts > --- > include/linux/fs.h | 2 +- > mm/filemap.c | 11 ++++++----- > 2 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 05abdabe9db7..87e7d5790e43 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -1052,7 +1052,7 @@ struct file_ra_state { > unsigned int size; > unsigned int async_size; > unsigned int ra_pages; > - unsigned int mmap_miss; > + unsigned short mmap_miss; Thanks for not making struct file grow!