From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C81D8C61CE7 for ; Wed, 11 Jun 2025 03:55:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 65EF76B007B; Tue, 10 Jun 2025 23:55:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 60F176B0088; Tue, 10 Jun 2025 23:55:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FE4A6B0089; Tue, 10 Jun 2025 23:55:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3421F6B007B for ; Tue, 10 Jun 2025 23:55:43 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E3C04121B63 for ; Wed, 11 Jun 2025 03:55:42 +0000 (UTC) X-FDA: 83541755724.04.829775D Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf19.hostedemail.com (Postfix) with ESMTP id 4735F1A0002 for ; Wed, 11 Jun 2025 03:55:41 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=pjM6fM7H; dmarc=none; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749614141; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CtIFywc/aMCPDycZJaL/YvljQjKY/63gd8F5ioZcu98=; b=BuUcrRh1miub8lAZ5I4w8gazSPvAtobo+oL5JM38cyI1XoUYZam0piPifRFDRbiPFdqlEp Iyx++uYU84SDhDAJsCA9UCUtLNB7LomzfQePkFCutg8dy8w//33FYbkc2LQzl3TXBv8ZMs JKOPRIvwRoG6maQ4/vLpXi/nIorFZmU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749614141; a=rsa-sha256; cv=none; b=4ZAElWmHaOvwNXe/1Cx6x1X1Dco0iW0NhDMZPp0ykIBeuxawhXcw3aGs1UxUdNeFYDIDWs 4R5p7D9ZUvV4uw8BGEvk7ukZz31CGyePHzfdmDS/Pc0433wKDgL1/X9KSjAv1ZkIJwapgH INmkFxyjBvP/8HyfuNuBn0jqzFDO8Jg= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=pjM6fM7H; dmarc=none; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 7C5FDA51321; Wed, 11 Jun 2025 03:55:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03C41C4CEEE; Wed, 11 Jun 2025 03:55:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1749614140; bh=3DkIn2CHQwtzVGlOm8YRVl5fsACn+C50LTETij/hwgI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pjM6fM7HheIPVVLqFbAAqW88CHXpQePhDE65bwnlvMayl9l8g3U5znhwIa03UoyxK f18NvYgxzZIQpn/u5SJWq3+0ZYKcnpRdU0DnGzC0CwQBu1N6raethU/1BzBZUQMwKB pCm9OCF9AZlZELM7SRBYXquhvcIUFz2IEjmwgCXs= Date: Tue, 10 Jun 2025 20:55:39 -0700 From: Andrew Morton To: Wei Yang Cc: Liam.Howlett@oracle.com, willy@infradead.org, maple-tree@lists.infradead.org, linux-mm@kvack.org Subject: Re: [Patch v3 0/3] maple_tree: Fix the replacement of a root leaf node Message-Id: <20250610205539.75dc8db5fc245510228bcbf8@linux-foundation.org> In-Reply-To: <20250611025436.wa37ileuswr5gleg@master> References: <20250611011253.19515-1-richard.weiyang@gmail.com> <20250610183727.5116056fe4cb7ccd36e93b9d@linux-foundation.org> <20250611025436.wa37ileuswr5gleg@master> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 4735F1A0002 X-Stat-Signature: pcz574wy3n8c4gdu4b8diikzuj8hr8j6 X-Rspam-User: X-HE-Tag: 1749614141-651935 X-HE-Meta: U2FsdGVkX18PPT0LS01WisaXZJU4TWOD6qFF1Hr14XBFZ/NNkZUmwiQKzee1BKliL74xDDw5j7vZkpNGzbKHF3Z0ncbzUf09RQXZwoZzl8CoGnieMqJQUYZckzAN82mjbSabubsziBqG7BYjZfX5BPJOFLDITjAI2GrSoaA8WlBeax3rvKcQGIRQlaQk7m70n5YHP1aPyvZVeucXYmpuwjbqIBvtquk7s3Ee6hoKlveJXlptRHt8FW1U+9cDznHIdst7zlZq0QLGWNWNoVrg0ekOu6Gov4hSSv+hrwpw4NaAZDI36mHUYn+YKfRb/pBhKEAFq0Ae2DRNFMr4AOnDJTNInKCe/ZOt5kLe2xccf9QV9cySSeQnDCTykRkSOKDIRT8XFVF8PFJ7du1BSaj6VAwceWh3P0xPIWjLMPDgGSKdvdwAgE85a2mOGBeilVIeUpNGH2Q6KiwlzeXBEi6N7+7ZNO7GVmaidi6R8+X0YYUHjVsuk0sjPXJySLYY67iQ9ty5E2YezYccOXYZ0GUdb6H8O0Ie2lo8uilgP+Ptaq1lvchjM33Hxp2dA+WfMsoTERGJaDwaqzz2aN/rUJSHI+J2I/Vd+7uWsaDGQ7fZ3eCvjW5aL1Vkorn6r+oZEeFWpkOh81V4A2YZe80xAcVyWHqMXHCwp/hXEOEEjaeimQu9O8uJxeZqWB4t0wjSoVEK5H7fBgKa2SgvibVHm+s+W7HiDyxesdhljUDRwDHOVXcHWhOf7nvs6MRRlrFRykROveIe7Ep7MfmjU/UnF7dQkt7ubGy8FfhpVlUhQxD+pTxWYFRwf+BqQRY/Qf9ETmOTGCfajoPyHawd7rQqPnnE6OYkJ+l8gSycimDAzYSVqVWNxaFC/xTqXH/HEVOZ8WY0B2w1rKnrwqNaHHj5TJr8xmpqWApELMQmz2hW5P44xmGfv1wrPdnXTIwhTCMd9xYE4Vkdhm0LBF5/BT3m51u lk5ML5Nw CVTFw1zDVLkS7hMKuTrNg/DbUU4L/G/l8JA+FaM+d88kKFdTOQdvS/4LIFYMEcnBFdR5Sbveuo28ivTO3rE93fZRMYllZlJBFcJNxNF+3okULrTecqW97xGkdismRnoDoNh2jfvkQOK+H9KkkGGprk9bkvKn4wdUbpY4Nd3pVCrEIGEdj7JwxMlQSsNe8TdGabTV9z+/4+Yz0HM90SOIgNha9cLN+DZ19/LYmgqd7QeWfXN/AyxJvfTc+rIBgRgjglwHWXFX1K1+bG/EJEnw2NRQXiDj9DU5Dmc/Q2oi+QRde9Uuuo/5R91bw2DmpPRielpxXlneXzminViYLJ+1Isue7dwqyQbt6svefAo2TgREoATqqNJ1qXjObTmq998eF4YWvBBYhYyie9dY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 11 Jun 2025 02:54:36 +0000 Wei Yang wrote: > On Tue, Jun 10, 2025 at 06:37:27PM -0700, Andrew Morton wrote: > >On Wed, 11 Jun 2025 01:12:50 +0000 Wei Yang wrote: > > > >> On destroy we should set each node dead. But current > >> code miss this when the maple tree has only the root node. > >> > >> The reason is mt_destroy_walk() leverage mte_destroy_descend() to set > >> node dead, but this is skipped since the only root node is a leaf. > > > >Thanks. You added cc:stable to two of the patches and that's great, > >thanks for remembering. But the changelogs didn't tell us why you made > >this choice. > > > >So, as always, please always describe the userspace-visible impact of a > >bug when fixing that bug! > > Thanks for reminding. > > Do you prefer to have a new version with the description in changelog? No, that's fine - please just send it in reply to this email.