From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A969C677C4 for ; Wed, 11 Jun 2025 01:37:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0757A6B0095; Tue, 10 Jun 2025 21:37:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 026E56B0096; Tue, 10 Jun 2025 21:37:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E80CB6B0098; Tue, 10 Jun 2025 21:37:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CA7DB6B0095 for ; Tue, 10 Jun 2025 21:37:31 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 74FBF1A14D1 for ; Wed, 11 Jun 2025 01:37:31 +0000 (UTC) X-FDA: 83541407502.25.61C5F2F Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf19.hostedemail.com (Postfix) with ESMTP id CD1891A0002 for ; Wed, 11 Jun 2025 01:37:29 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=GNCgweSW; dmarc=none; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749605849; a=rsa-sha256; cv=none; b=rXFT0bQ0qS0GLmAxPL3rTwLx4F1lZKQYYLV4rL0lnQnVd8zDpvIYEsOHFOxSr/QFGFFK16 LLoZDETm1PzDzHINot7ubCqhWxIVUKHlYnOPx51vSoFAcFpVA/xOx3GMOKMQhJ1Vlc8bU5 2oY8Gys0zVmXfEqC7uZh7quVRDXDmhQ= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=GNCgweSW; dmarc=none; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749605849; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lQtsDVFpvMuVWqADrFIL5ATZ4WuD/zdIn2VzXFQGfEo=; b=zWJd0DqaUfNGT9Re0wGl32ATPjiBDQb1mpw2ORLQmdP6NlrCFSPknRJwMkJaWTyS5piPNk GzM7tBGpJspKWgQEVfsfJyIcmRYgzQzwXKF/ChexuCkmEYgCEPOcaN84caYwB6CZ37WkPa xAF0WkiEMpzmm1tVnPvYxvAVh/3EIhI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id E79AB60008; Wed, 11 Jun 2025 01:37:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E11DC4CEED; Wed, 11 Jun 2025 01:37:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1749605848; bh=6DAMgJxK60tw6+TlKK1ajGIhEFz2DfJJpwmKCfqTsCk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GNCgweSWFLwmgS6XrrBxjwNF2K2MAFz3HV+/SNAQKXqXb6arFQWdcvaJWmRRdOwCO EyX8JTOka6ETbxYi161m/DsIqdTDrh/7fLpFI80A+IdtWzeeyl6Ylib9vKlOT5PQX5 sT9zSIoA4HJjU0N+6HnOns8pHbWqotLlE6Mffugs= Date: Tue, 10 Jun 2025 18:37:27 -0700 From: Andrew Morton To: Wei Yang Cc: Liam.Howlett@oracle.com, willy@infradead.org, maple-tree@lists.infradead.org, linux-mm@kvack.org Subject: Re: [Patch v3 0/3] maple_tree: Fix the replacement of a root leaf node Message-Id: <20250610183727.5116056fe4cb7ccd36e93b9d@linux-foundation.org> In-Reply-To: <20250611011253.19515-1-richard.weiyang@gmail.com> References: <20250611011253.19515-1-richard.weiyang@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Stat-Signature: 541x6nxe3nxrcmsszwbfbww7jqp91ruu X-Rspamd-Queue-Id: CD1891A0002 X-Rspam-User: X-HE-Tag: 1749605849-492096 X-HE-Meta: U2FsdGVkX198YOj9wrG6zFSVFJZRjmOjuE/eJFZFERRxvEqLQvJlbuRIGZA0WjAZhgKKkmbgNs9BoUyM205AKjyt2tHtK7GIqu5hIG8xp5lks72lQRfOeMCS4jRYj2EWOKg41MlD6HBqZ0lTQ9/rbE4y6afh2t/jeuCY8mYth0pAy3wiYthuRvhnsnTEuph8YxJolbRuackHDUDmFFT7ut2BenR1+Rr82Mzb4chZKOy7DxxnqlwcSDTQR3MRQQe1Ui8avvf7ov1Zpl/pcItx7LQlmLckL7VfhYzXIXtYiB9WW0Tadi4vvHbbZAYDLJbPBXPdXmhVg/3BMuTzw+4gVmGLpjtCyeXhH1U3LuTVaNfYtWEnw4qpxAC2f5ybV46zVk/h+4PZunGDDH71Pjh1aCxq3XF/03rliDVLM9AH8mrZeGdD0VdyYOovyYzkEKQr6BSJHIjH5lZhhhG3Vv+M9qpWrFuzw2L4mz+rHc8LbvsqJENWpo2gXUGfUJ7mbxPszje6JYIvld1qk1Y8eh81LYWUO1VxwKL0j6wYzC4aFU5+DkONQLSrxXnOA/SbBp12SjuKgS8BVP878s6Xddn2sib+9MvABf2g67FYTc2okOneE/wgQ2cTjPzz1NCQx7taloNA4nLyjLxAO+3DGJsxgdC/Wp6dtXN/ZgAOudYfxvoNBoBeSZBMZb2ik7r18qSutcRRn1tswBnFmwNNfbxT/ZqVhVj1zuQAQrUu/SvPlUHlYXvR6Hc+NP4cRmWksUjFuAU5CSl0kpqjadj+xqyxpHqtFbqHt26VexolNxEPptO/hGSKhXeS98EKKNl5zC+STHHqtSivL2WubhyzAhxlbACFE/HrryuOBEyS42jhe3asVvL7G0BCEwtUyPKVDJ8BW9pxELXb2ArAkFDFxIweBnf44tQE76lGdzCDMRr/XIs50rDqV0vz1Vae8aOhCpjBI25wqYp+3Xlp1nT2s9W AdpFAoPp ZX3es9c4TkKI7auc4hXT0h2DC1ZYn0dRpIeaEBMFR/EAHNLTtZh1v6LcgKKGeVbYZ2jQ9N+P173GSCDR3kkNWHDy45+ZNB+OW3XpHAIwlzyMNAy8xN3lCMHSaIKyoLd3LGZ8k8VtAb9qs4u6QdbO7j5FCkgE8rU5AHafjZGTxG6MwLCBt3U6ydzMVs5MLEvV4A2M6GQx7KWtoe+BbByCPR6DrqB6U5xCsc7u/kFZuJ0rSCUMaAWX5yWB8CN72LdmyxjaXeRL0nY6Z6CTQGe1V3cKbLD6sQkpL5mR93XLMC9Gi4VmH6K00WM0VN4c8K/M8Ar7TwSl7ovNbQ7y3BeHUyG9/hcuxmdsJ4UbNq6abSgk62tNVAl5QPt7vcWlg19/w4QdIIInfsaVNBbc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 11 Jun 2025 01:12:50 +0000 Wei Yang wrote: > On destroy we should set each node dead. But current > code miss this when the maple tree has only the root node. > > The reason is mt_destroy_walk() leverage mte_destroy_descend() to set > node dead, but this is skipped since the only root node is a leaf. Thanks. You added cc:stable to two of the patches and that's great, thanks for remembering. But the changelogs didn't tell us why you made this choice. So, as always, please always describe the userspace-visible impact of a bug when fixing that bug!