From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C166AC5B543 for ; Tue, 10 Jun 2025 13:17:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 481DB6B0089; Tue, 10 Jun 2025 09:17:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 435026B008C; Tue, 10 Jun 2025 09:17:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 349266B0092; Tue, 10 Jun 2025 09:17:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 157F46B0089 for ; Tue, 10 Jun 2025 09:17:24 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B587A1A032F for ; Tue, 10 Jun 2025 13:17:23 +0000 (UTC) X-FDA: 83539542366.16.85DAB84 Received: from relay.hostedemail.com (unirelay04 [10.200.18.67]) by imf25.hostedemail.com (Postfix) with ESMTP id E9665A0011 for ; Tue, 10 Jun 2025 13:17:21 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749561441; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UWBqwLlGFJ9+QwVN64MWGTNQlllUYBAVKkqD+0YDSI0=; b=KzJffuYEZcPSijDyRoMDvggh0KmICQuqGe8+jxToVy8BWgZwfg+C6KItgIjJ+M6WM7bALZ BqllHg+1Ujt5ugwSyPDXwf5tZe68OlFyflogxn0QWboHMyJjzfJojgiRPDTQIuveC1LJSV tzq3dAqnHJNyvYovI9bWCNKpsj2f6uw= ARC-Authentication-Results: i=1; imf25.hostedemail.com; none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749561441; a=rsa-sha256; cv=none; b=UlLd/DvIHl/9vNP0oHB4JDViNEd8hmYwBVUumqWsYwrCXDKG840ovFrTxXmt9UyS4oUF94 qJZHoN/i6EFlmF2VU45/wXx2Hw7tnfqcKTF4Kx0LFMK4b2MTXbfoqquisyC4DsTn4H4qIP vNQbiztLE1BLQOQ8TnQ7ZMINmheBuhE= Received: from omf13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7CF0F1A030E; Tue, 10 Jun 2025 13:17:20 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: rostedt@goodmis.org) by omf13.hostedemail.com (Postfix) with ESMTPA id C2D5C2000E; Tue, 10 Jun 2025 13:17:17 +0000 (UTC) Date: Tue, 10 Jun 2025 09:18:47 -0400 From: Steven Rostedt To: "Masami Hiramatsu (Google)" Cc: LKML , Linux Trace Kernel , Mathieu Desnoyers , Mark Rutland , Andrew Morton , Lorenzo Stoakes , Caleb Sander Mateos , Peter Zijlstra , Ingo Molnar , Borislav Petkov , Thomas Gleixner , linux-mm@kvack.org Subject: Re: [RFC][PATCH] tracepoints: Add verifier that makes sure all defined tracepoints are used Message-ID: <20250610091847.3b2aab45@gandalf.local.home> In-Reply-To: <20250610145305.c925856f0201fb748c08b331@kernel.org> References: <20250529130138.544ffec4@gandalf.local.home> <20250610145305.c925856f0201fb748c08b331@kernel.org> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX1+aVSuBLrD9SxdYHA0aa0neCQue+qWn+mQ= X-HE-Meta: U2FsdGVkX1/BidFPX/u0H1GWobAiAn0PtNSDAOg4u4GzInF4/7tgJ6AvhBjrCtbCKnf59UH9ojK9a67ocP+Kl9SB50+0e8HylGpeYb7jomtRutHC8/Ykw47mhWnIYM8LxkkiPP2gO32iLgEfWFNkIWk5xo7wFj74MTnBl0fiP7Crxa3qh0BZLjB/lluadgJpKkzUeF0cIDA/UKemKZEgAIN8Q4RAxlPHQgzJVDK9da3tW/9mJnwwJ1xCi7js+HMTT4c2vhvH3i7BXvXdZP9PzU+LNMX0eXkOhsMnJcCZoFCYCiP7DV3luBjFu5aqIGqtZwfpgbxPkq/Bl5rUtuTzULnTFzJESBVk X-Rspamd-Queue-Id: E9665A0011 X-Stat-Signature: g4h5r3yqfsu98oa39zkmnic5hgkefdc4 X-Rspam-User: X-HE-Tag-Orig: 1749561437-404641 X-Rspamd-Server: rspam04 X-HE-Tag: 1749561441-703345 X-HE-Meta: U2FsdGVkX190OLbfCt6y2jsd+yz4NwD1yYQS1Jb40l/yKRh6eRn25b7ljBDn6lSUdY/Qxwp0EJiSIAyUtdNx9jAzn+0P6Fuo0KgmgSREO8jWbd0wCf9p3fUAAGdoRy5NSKoHUgXEsn1+JWSnD8X6KMhNa7DvVzR/JEm6Aov9+30Fj9nTz4q6dCXGi8v10yKGt1cilgTL4Dx5pfp/jd2NsvXGihEFQMbYNCL6BOD3/3N+DrtAX7yNmqa5Suo4gO+PRI158omK14kMiRSnxAsrgerDUkdgFZkiJ5ZtjDEZezZXEkRRj/HbHFeUzgoAaZI6DPlHZXT/g/EOLcbL//iSv4t3h4ofBpMMdyPhf+J/RGLMfI1Hl1axDZ8djJ6Kj3EYVnF3+MmIAmhV2bhzm4bAf/BGitYuVm/SU22whJzL+iXRQtcBbVvyZn1nGFojh/jXylpH+MFMuvabYx2KA0SfkiWEUyMd4y3OdwzaXrR296HEMUXcAgby4JoGozliUZYo/WYHAx0v5alk6g8HeUPDhgRRoIB+vpO5MF7S9Nqf0t2RqkzCYQ0UNpWy6cmAQ+fsm4o/HcSqhY2SXIzP2a+RvyjBmbFVJPh9Khhg0cmuCl7crUiZVXUjwmImge9L4/jsPpdW1xC9t9+y6UxHtrngcBcuesqbmfDhT5ToESdYZn3OLTrxhjaS5MgIRHv3YRx3s0Yb1sNEd1RwUsASc+gwpNKdm/XMETWgcFv1j0sgToqC85VToh9NBcZmaFUJgmgq62pauqdRqod8R7rMydo1au4FKKUyB4roaOhzt8SSverzWADEidcCzS1/E6Z3x7TUBzDmDTiPu40Ro9ZsBfYiuKQZAaTqpPb1e/5SQgOKq+RxMYIxg8BdSUOF1T3akE3QO6tuZvuSuS4Hx7LFtOs6zDs56iqHYSqOPl9VEIR7H8ug7yypUj5oAg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 10 Jun 2025 14:53:05 +0900 Masami Hiramatsu (Google) wrote: > > > > diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h > > index fa5f19b8d53a..600d8b51e315 100644 > > --- a/include/asm-generic/vmlinux.lds.h > > +++ b/include/asm-generic/vmlinux.lds.h > > @@ -708,6 +708,7 @@ defined(CONFIG_AUTOFDO_CLANG) || defined(CONFIG_PROPELLER_CLANG) > > MCOUNT_REC() \ > > *(.init.rodata .init.rodata.*) \ > > FTRACE_EVENTS() \ > > + BOUNDED_SECTION_BY(__tracepoint_check, ___tracepoint_check) \ > > nit: Shouldn't we also make this as TRACEPOINT_CHECKS() ? > > Others looks good to me. > > Reviewed-by: Masami Hiramatsu (Google) In my "build time check" it requires these to be there even if it's not used. It's how it determines if it's not used by seeing if this section is empty. So I need it not to be an option. -- Steve