From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44AC0C5B543 for ; Tue, 10 Jun 2025 08:38:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E9046B0092; Tue, 10 Jun 2025 04:38:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9998A6B0093; Tue, 10 Jun 2025 04:38:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8AFC36B0095; Tue, 10 Jun 2025 04:38:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6C83D6B0092 for ; Tue, 10 Jun 2025 04:38:14 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1519E81559 for ; Tue, 10 Jun 2025 08:38:14 +0000 (UTC) X-FDA: 83538838908.13.C363091 Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) by imf01.hostedemail.com (Postfix) with ESMTP id 4529E40003 for ; Tue, 10 Jun 2025 08:38:12 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=a8IAz6yb; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf01.hostedemail.com: domain of ye.liu@linux.dev designates 95.215.58.188 as permitted sender) smtp.mailfrom=ye.liu@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749544692; a=rsa-sha256; cv=none; b=5lzdsmMO+67Cx5qCcDj0jtL5DQe1LDBkDhulKHBV++2jYIloMToLMd8QuWPTARLF8arctc 4wSnndaff5SamP72QIF0p9TiJmdqgZn1BhEtqg+WHWrcoJau2kwfSi4SIWDXgI0y2Jw/VD x+OxzdVIe2+cJicDenTbEpqo6LrGDAA= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=a8IAz6yb; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf01.hostedemail.com: domain of ye.liu@linux.dev designates 95.215.58.188 as permitted sender) smtp.mailfrom=ye.liu@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749544692; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=q5HeugkHcjUwf4mk/XUNlpjUL6kKhDq/9U6Y9Vd4dl4=; b=UJPhaKJHhnZilbYi8MZU/LdQaESXrExLdrxsk7sNwAxXOIdMfLfSV/G60v/A0kosVRG1/w VLesX1vCwPe0KtygfvPVqaA3r5qXZot1pKAPzxI/qhku5Vhfz0BJjQncoLMqJh96xCB6B8 jo6+Yw5/UU1exfWqm9uKkaIa9ibkQrg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1749544688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=q5HeugkHcjUwf4mk/XUNlpjUL6kKhDq/9U6Y9Vd4dl4=; b=a8IAz6ybvG8uIiSxJDIUclktJubKEE4rGGhYGbGGM5R9No+9Cr1bGMQzp7hn39Zb32ck1f iwDxenlzf+k7MxolScB0OCodyDaTXE0kMqUt9ZjQ1kp9fgtv/bbJK1OAwkSw1xxftuN827 J3TUNEiyxSG4SiIp6Xw2lAdpIwP5lGg= From: Ye Liu To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ye Liu Subject: [PATCH v2] mm/memfd: Clarify error handling labels in memfd_create() Date: Tue, 10 Jun 2025 16:37:30 +0800 Message-Id: <20250610083730.527619-1-ye.liu@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4529E40003 X-Stat-Signature: dca747rysqb5my9ok313mhfp8h3yyxtm X-Rspam-User: X-HE-Tag: 1749544692-12785 X-HE-Meta: U2FsdGVkX19hI2rXKX6V+PDxblNXoyyoBqUexOkjInh3Hbl3QQ2iy5K2jffNwuQLwkY1AGA+IJoo8gS7v1vUeyN99YEeALGVCUyGGOT4Tk5i7iUAKwLwSDVaJcXc+OW2Zx6+zz9ZqbI9jMxYJEYrIbMIAPnI2KEFZ24pxgR6KazAMrl0sNGrYzqZZ+Z0WCktnNWkk8xcjmZxMwrAZNbjm4oE1aqSepoZvN7TVyPFt+CKGo6AoJJSXZVGniqfCitovgj4IiJ1M+TlyoaS66VkIK9lUAcRPzoi14Op63EzeOq97308vLa13Y3Yq6pHpwbprTZuyxu1HXanweUscSCEmRCgNrtJ1LsBOcW0VAagucxauSjwKcZpFEB0mglBf4gfUT+n/KcFy0iutDFjNxKZHhlW0cpZyqFjPs/gGT+QuS7GL0pPNB4sguCUUWjnhqMGEzTLycyHom+Yx1GXgBucFp+ng5jClHwpFqox3yIVT7SCT+hoqddOk88caR3l6qqSzx3g4iWQcGcuRrIFaaZ8FJPgWWDj7xtlp0h65KmLWWmPqBV8OOUMiHnOBreVwz9oJJf/tFEoGaHR7i/W14d2N64rMEcni2A+U/RLMOnRwKVEd8hdvbqFRVOSKLsDrQL03A4PQN7jak7GtkdYB11+TiLCjwycmM7/xhUfv/Tb2Ndhf4rB4X3p1pbTOOlx2fufdtiYVJdbNBNrqMVZcYLC1ZTjZYV/iu67MR/5LMNdZ0NAdrejlI/9Bej4sYluPyJYMmc50eUUU9PvMKWP0lXxfnibcf7UhzNM3RkK1UUwTfMsunIcb8ddrSElVNhoNXFolfpFXjCVkqLGWTkIOkJNYAc+ssEjiFs+UVOUBqN4r2Tnf1EXEfhsmy5Fx7oqiwk0J3mga6vRuKy5SDo3X4EZT7SqBK+aMND1pEQdxj4nt009in2ccGhTb6MDFL7FVz80qT0LMR68GzuvCNrjlJ+ ihR9P8NY LWCpIg4+R6Ip5QMFK/db97l5Aa1dL6DbADai7wt+5umbyjDP5Jy1xiK5u9LPRTPLwwS8E/TWZZ72rM64YUrOCOz2YrogRytueT98rCYM1CFhEkizhz1AD0otUw1LsaO5rdq3PZFIOCke9QEUAuzuDrvy3bAidekIS0qjjCpZLsfcD55BZaXCnkeLgGC1m3yxqmOzoFgqpvNOjgKOYFN3IUDTxo1BXelmEFewMAD3SMP6/Y53ZANmcmQlkbLh41wttY+Ipz4iM74QMWoR/n/dEKthe0A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Ye Liu err_name --> err_free_name (fd failure case) err_fd --> err_free_fd (file failure case) Signed-off-by: Ye Liu Changes in v2: - Rename Subject. - Use "err_free_name" and "err_free_fd". - Link to v1:https://lore.kernel.org/all/20250609031858.73415-1-ye.liu@linux.dev/ --- mm/memfd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mm/memfd.c b/mm/memfd.c index ab367e61553d..4fc98abe6627 100644 --- a/mm/memfd.c +++ b/mm/memfd.c @@ -475,22 +475,22 @@ SYSCALL_DEFINE2(memfd_create, fd = get_unused_fd_flags((flags & MFD_CLOEXEC) ? O_CLOEXEC : 0); if (fd < 0) { error = fd; - goto err_name; + goto err_free_name; } file = alloc_file(name, flags); if (IS_ERR(file)) { error = PTR_ERR(file); - goto err_fd; + goto err_free_fd; } fd_install(fd, file); kfree(name); return fd; -err_fd: +err_free_fd: put_unused_fd(fd); -err_name: +err_free_name: kfree(name); return error; } -- 2.25.1