From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B549DC5B543 for ; Tue, 10 Jun 2025 14:18:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3BE336B009A; Tue, 10 Jun 2025 10:18:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 36F346B009B; Tue, 10 Jun 2025 10:18:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2362F6B009C; Tue, 10 Jun 2025 10:18:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0352F6B009A for ; Tue, 10 Jun 2025 10:18:39 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8CC651A04EC for ; Tue, 10 Jun 2025 14:18:39 +0000 (UTC) X-FDA: 83539696758.29.677BD94 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf06.hostedemail.com (Postfix) with ESMTP id C52C6180007 for ; Tue, 10 Jun 2025 14:18:37 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fvEJkNA8; spf=pass (imf06.hostedemail.com: domain of broonie@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749565117; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u8Gsf35Qe21DLvTp8AmTr8WGJzE6MXE5nM4oa2p3Xl8=; b=GlgknQ3YwrjczwPLLjPU2FhyW/PA1e974BanfjXaXIs4O0oZ0XJyZOAj0nHIdAhNmn4Yq6 7TUCC1QoP2aXxDwehPY2MwSWJFuyibftPThGahItOeb472Liv3MVoQ3VmafslBTLE2fgcz oxyv8RVBkOehQzORo52TZKlc3s2GnZU= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fvEJkNA8; spf=pass (imf06.hostedemail.com: domain of broonie@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749565117; a=rsa-sha256; cv=none; b=yCcurutTiXUMmIMfOgM/3J7R5jsPVRLumXy/m7nMcHid3J1PgGFtwfuFPk5vou+HmncWIq ieufmIIYNiA0XEC7e+t9bSuCbNCa4Bg676IMw2UIhugQSwkOFR5z6eKqId4tmBe45xiyFF ZKcgKO92lN2und0ZHF2S8VBqQH7rJUw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 58CFC629FA; Tue, 10 Jun 2025 14:18:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D3A9FC4CEF1; Tue, 10 Jun 2025 14:18:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749565117; bh=XIqlvXcLhigaPQ9Uiztdzq4aV3ciRSHw6O22PqR8rDU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=fvEJkNA81zAL7NF8UKiSuwgNZEWLUkVEUY/DR1hVDBAwmDzKco7CtDda8YUlLICfT e8GvGMLPXC4h/lOwBep3rHrkxXer83eUT/HjAV33gvLE0SQN+ioXVCewGK3+sakL1W GgWXCdVGuZ1I29KVmkR/e8t71KSEVAvg5cG0BnP86cvQivSkfwEBbJvSTe/G90ZnVp U6Htk7qZ0Q50T+MXpdZvqoXC8P/IfZ9/G+izpnrYuP39rD849IemRZEaLWjUUX1495 /1PDbI3TChQCZzTA9HsGvrm9kjLUTAfDw5xVycdm7/wC0cYiSO1Abu6DGLsrk5pxqa d5g7+Odfj+mIQ== From: Mark Brown Date: Tue, 10 Jun 2025 15:13:57 +0100 Subject: [PATCH 4/4] selftests/mm: Add messages about test errors to the cow tests MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250610-selftest-mm-cow-tweaks-v1-4-43cd7457500f@kernel.org> References: <20250610-selftest-mm-cow-tweaks-v1-0-43cd7457500f@kernel.org> In-Reply-To: <20250610-selftest-mm-cow-tweaks-v1-0-43cd7457500f@kernel.org> To: Andrew Morton , Shuah Khan , David Hildenbrand Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown X-Mailer: b4 0.15-dev-c25d1 X-Developer-Signature: v=1; a=openpgp-sha256; l=3040; i=broonie@kernel.org; h=from:subject:message-id; bh=XIqlvXcLhigaPQ9Uiztdzq4aV3ciRSHw6O22PqR8rDU=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBoSD6z7nodlgS22VhRNHY97fp3ZLzuwRlu31UHzQwB gXw7IGCJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCaEg+swAKCRAk1otyXVSH0PuSB/ 9Gzkq/wcaXkrOxcFyL1WuVMFr8UsfjIpTwUaNEqszIp9AWmFw/DzRxjm33G41mFMQr1kRnUa0VtOqO aj1PB7cWiOLoalM2Z2ZwH7P0sa0Eqh0NI5kZ/4yiOpUDJVPnTuYtiw87wFWxKPn/Je0qO2sace67zh 8g4xKUoaU0Xi6lgPjnHDQjEEF9+US9M+nKjGzwJQmE7qw56NVvqbva0YpiaIKWvnXLFO32x8KRiwDN hJ+z5+qfe/bOTdsWuruJZM5sAEBHjCiAxleGAN/8dnoCXCIdfDXOPULSGQkdcAcjOtwjOcVMTMP5rL NmLXpU70IC61Cn+eVEiZj9gd48ZDu7 X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB X-Rspamd-Queue-Id: C52C6180007 X-Stat-Signature: ghkuch6bm34scsqunx5oojqni8bbm1mr X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1749565117-807501 X-HE-Meta: U2FsdGVkX19211Y+fkBJF2GHhYR5gX+Eg87JJ5e26mCMcMflcnFwalCt0wYeyGraAKrBpVARX2bh1JgqRT7akkItHZqUnHpU5m8UKZhrbmPhoH5Bphzb4uc4yoH7/F9zVMPlVbKu6TFJ3OQOzvdUwV7JW4+N+itkxs3eqyU211iX6PbdcpbQRF0YcG3X79A/U7cHSLJyvR6CebDG9HSZZPXAAA/x6/vvU8lqTKOknFCgDtaeqSsq4K+5SlADkkKS7XC7Gr3q9E3cUHQX1iSTrAzLq6Ik6qcZcjGTjYGm5pyYBqSRVsXK3MLfssmiMK/HdraNsUPsSUuaF8x/kl++uNGG9qg5bspxsMPmx+9RlfO8/qamgnVXYnVwKHH3VQ/z5qKSlWDROU6rzJQO4wjFjQUdeD9itvgu/WmgUn1sbNxuZ1p55UkvZacwV0TJSFwDI0iLN9+ad8OthdC4Ue7ZgJ48edMgG4CnoNaedwBGM1mLNOVy6qyqPCBlpQfZI+bwuFn5ysvnQvv+0Kzaw9tvvzPNvxhfySWumrqfAJjBdbKhVtNPd5lyx3dVtaNGJlf4/Vg8zOtNgDo69AgxEaazBZWdTNk2jUlMckeOEwoVRwIDeLjd6tR+kEvLm5PjlspjKVAY8s5rmLIhA6g2gvL5W0Jwysa6ZQeL45R8LzBXrhAXbEO0mG2hZ/rcR6mQfg8w+jtTHtLcn1csLccs5ZiUFRNAPDt2ID5t2t6HWCTSlPL7MVwTTZGWH75dcu242yLP6/x2npY+QbApGvljgEzUBoJJJ753/T3mJNw3H3wqTFy+765ULjIF5zEEN/CMVvU/54y9RxKdDR0OuG9v8zUIh17JIcoUKzA33ZIth/WEl3XqMPnbe1jBc65xfjUQ3xRwzOBZQegiwT5baNoiL3NbHqf5Zvty9X708obXNqIWVxczpQfvnkT/sg0UfZmvLrSo4hexvuRR2zeDqL0hM7d KmlyMOna 1Xxryf9Ush/dNtlWxYvkxpdP/kCegMJW8dYNI3UBd9t+8sc/PbNShRQou8gynOqxoWGyuk+3/qH9ZJbYp7L1dPfcOcXEINtxF01dxyBg0e63UtQfhOKSXS20IIh9Z4Leis0fj/YagBW565U2pCkh36UNXOBwNXpT7uuCgfb1Ab6HmHxYISoze/q7agg6uLyQ4v/oRnWK6GS891AI3417xWFbRZrcIIceoXzoMv4yXd2457Fa7dl99nI7rQeRLQkALPr2QcTPLweSHBFQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: It is not sufficiently clear what the individual tests in the cow test program are checking so add messages for the failure cases. Suggested-by: David Hildenbrand Signed-off-by: Mark Brown --- tools/testing/selftests/mm/cow.c | 28 ++++++++++++++++++++-------- 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/tools/testing/selftests/mm/cow.c b/tools/testing/selftests/mm/cow.c index 48fcf03aa4cd..29767e2afdd0 100644 --- a/tools/testing/selftests/mm/cow.c +++ b/tools/testing/selftests/mm/cow.c @@ -268,8 +268,10 @@ static void do_test_cow_in_parent(char *mem, size_t size, bool do_mprotect, * fail because (a) harder to fix and (b) nobody really cares. * Flag them as expected failure for now. */ + ksft_print_msg("Leak from parent into child\n"); log_test_result(KSFT_XFAIL); } else { + ksft_print_msg("Leak from parent into child\n"); log_test_result(KSFT_FAIL); } close_comm_pipes: @@ -397,8 +399,10 @@ static void do_test_vmsplice_in_parent(char *mem, size_t size, * fail because (a) harder to fix and (b) nobody really cares. * Flag them as expected failure for now. */ + ksft_print_msg("Leak from child into parent\n"); log_test_result(KSFT_XFAIL); } else { + ksft_print_msg("Leak from child into parent\n"); log_test_result(KSFT_FAIL); } close_pipe: @@ -570,10 +574,12 @@ static void do_test_iouring(char *mem, size_t size, bool use_fork) } /* Finally, check if we read what we expected. */ - if (!memcmp(mem, tmp, size)) + if (!memcmp(mem, tmp, size)) { log_test_result(KSFT_PASS); - else + } else { + ksft_print_msg("Longtom R/W pin is not reliable\n"); log_test_result(KSFT_FAIL); + } quit_child: if (use_fork) { @@ -725,10 +731,12 @@ static void do_test_ro_pin(char *mem, size_t size, enum ro_pin_test test, ksft_perror("PIN_LONGTERM_TEST_READ failed"); log_test_result(KSFT_FAIL); } else { - if (!memcmp(mem, tmp, size)) + if (!memcmp(mem, tmp, size)) { log_test_result(KSFT_PASS); - else + } else { + ksft_print_msg("Longterm R/O pin is not reliable\n"); log_test_result(KSFT_FAIL); + } } ret = ioctl(gup_fd, PIN_LONGTERM_TEST_STOP); @@ -1417,10 +1425,12 @@ static void do_test_anon_thp_collapse(char *mem, size_t size, else ret = -EINVAL; - if (!ret) + if (!ret) { log_test_result(KSFT_PASS); - else + } else { + ksft_print_msg("Leak from parent into child\n"); log_test_result(KSFT_FAIL); + } close_comm_pipes: close_comm_pipes(&comm_pipes); } @@ -1528,10 +1538,12 @@ static void test_cow(char *mem, const char *smem, size_t size) memset(mem, 0xff, size); /* See if we still read the old values via the other mapping. */ - if (!memcmp(smem, old, size)) + if (!memcmp(smem, old, size)) { log_test_result(KSFT_PASS); - else + } else { + ksft_print_msg("Other mapping modified\n"); log_test_result(KSFT_FAIL); + } free(old); } -- 2.39.5