From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58BC0C5B552 for ; Tue, 10 Jun 2025 00:26:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AEEFA6B0089; Mon, 9 Jun 2025 20:26:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ACA3C6B008C; Mon, 9 Jun 2025 20:26:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BBA56B0092; Mon, 9 Jun 2025 20:26:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7E0596B0089 for ; Mon, 9 Jun 2025 20:26:58 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E7D168065B for ; Tue, 10 Jun 2025 00:26:57 +0000 (UTC) X-FDA: 83537600874.09.3DE63E4 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf19.hostedemail.com (Postfix) with ESMTP id 4842D1A0014 for ; Tue, 10 Jun 2025 00:26:56 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=I45u+Thx; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749515216; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uU9uly8x8eFQK5wdpu6wo54ZpPNdhs+AZdtNJzB8xF4=; b=brPG8lpWrq1R2SPShisdq7bB0vt6d1BJPS+oZhNEu/fkjFTmRGre+pWFNzxlqGgVV3b3qA ryETEGfRaYmfOyiEELk9kZ82Tz0x9X1aU6L5X6ejGuMGreXd0FAYrPL2XabBfoKf8OSjaB QapGSLknKdf7eH3dyHx/Vv57SNGVL60= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=I45u+Thx; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749515216; a=rsa-sha256; cv=none; b=OA2ZZRsanjvMpMWRZkC2xl9vCM9BBLR221BmyhwH/q4gkRvaVRwaBLwpXR+xSXNI6MiWmM OvqcAGacPeYBZ0I6Vwh8ECmFzob7egBma95ja9oAEirV70Tdehh176+F5iIuY8ZTxic9Vh rlxcHrsui76MvYKhubb/MZjMSJtnQDQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 7F9C4A50CCE; Tue, 10 Jun 2025 00:26:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D002C4CEEB; Tue, 10 Jun 2025 00:26:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1749515215; bh=WKM7bYJF3RZYxDsLq3hlMwqpkAJAEZ2LKxzqn4OlM1M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=I45u+ThxW9/rG8sBGVzUpobXxqTPY0Dzhd1l64TQqS0LvYX2cOHgM7tJwbLpDjLVG aLyF1V/oHQathy1OE55iO6aTAWjgV21EeiXGy9RmFAT4W8ce/tBb5wggkDOrSgtkQk JKZdHHdbcKLlxW4DktzMO28sQ4gt2sJ+U7vY35R0= Date: Mon, 9 Jun 2025 17:26:54 -0700 From: Andrew Morton To: Ye Liu Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ye Liu Subject: Re: [PATCH] mm/memfd: Rename error labels for clarity Message-Id: <20250609172654.a99c06d8ad90a6a994545e5f@linux-foundation.org> In-Reply-To: <20250609031858.73415-1-ye.liu@linux.dev> References: <20250609031858.73415-1-ye.liu@linux.dev> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 4842D1A0014 X-Stat-Signature: w39farrp94gndrin7mfiyr77wob1s6fr X-Rspam-User: X-HE-Tag: 1749515216-189330 X-HE-Meta: U2FsdGVkX1+jYS7yYzYYgmuOUc9mDYrMd7yjdvHjfCrABVUSHevAFMqN8HA8O8EeZSw/3ez5zWNvrz6E/H0qzzh892a3vPQyJUtDi2kE42NHm6JCnA2UQkNI1YpuwLcRqXqb8oGELhQ8qsjfHj2pvuEiuH4g9iroQRDjqsJRYXDAZhLa7ldr8fyxf24ZnYocTMoPHUr4G1DBieGO6JDjdvSo+7DLEfPlV19FiAVnKiWLVpRFl13Dl6w+EMZcLo7ToPhWi2TI/1WkO1TP43fJSGReXTLcVDUi/9sXw9S9nEY9T3wKrohMtIhhKprH/yXVhBOM+4sVVPIrwBMMscQO+942P4E9FpNia6x3XiTAhIVRpUAsUvOEcvddLUTRH3hZk+6fdWSwISK8gV1GJlarQIsV0+EytKJ2nisYNSJNM7eD+/lDGGDG8AIU3Ljb5V+lKLrk+uyHQ8kftgdxex83G4cDa5FMQXMPdSr5fvcXW4wmkwL9ldf5/DAa4pct36H03pJml3T02mvAbowXB2c6LFKQBd7puVJusu13vqJfW4LKJjrkp+530oaHyc/goO55y3zSQx2rtdMQpnCgfYKxEXZUHSugnbW/1ugfQCPJUBj3IofK93mhDbBTsmbAGvQLqwkxb2oNy4jQf1O4LL4Wf2yDdyK+Dp2YIhnX0hvoLbXkUdtcRIqEHbIR8unUeCShksCZwG7h8bTHgkRjdLUYxeuJLi1jeLfm0zHlULwpTAhS1Hl7ncUk1dv+nMCRB9H3elhfivz4LqqOBHqvJYsU6fIztwdtOxnWHawqvS/6TZIW+goFtg5Qcabtumrb7KEyesZ6pLFmxw9eM255DEDObKLAey+rrRW4bZR/FLyukyM/nK/OxNDHB48rBvbOzsP/IyEjMvkI+gTvSyLETxJPz+XDtC+Vzd+7ZclMuzCx3AknOLYtoJ/ArOumHUW+I6683XLmr09nNXnB8x9dpyL gtPPoFGG oLx9+y0sGYaVkQbtW2/w10BURcbp9Xn33Cpq/fvN5rYlqU3/kJMVIpyGXeGcRZD14iBCih7UpN54bK8no4O2PbUp982gr/2t+CtvVLfKE1TcHLN6e3myKC/3Hikj4KN9s4sPGdkK6hsQ1+ABXDYh4ENl5Kiffz0qaESCLKwgnREHkUbAivtiuAjVTq07Stx8r8GGStthbXNfTjHDA1hbm3DnPboCVwz21VHbBORDzOaoixNsUitwt30rcvQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 9 Jun 2025 11:18:58 +0800 Ye Liu wrote: > From: Ye Liu > > err_name --> err_fd (fd failure case) > err_fd --> err_file (file failure case) > > ... > > --- a/mm/memfd.c > +++ b/mm/memfd.c > @@ -475,22 +475,22 @@ SYSCALL_DEFINE2(memfd_create, > fd = get_unused_fd_flags((flags & MFD_CLOEXEC) ? O_CLOEXEC : 0); > if (fd < 0) { > error = fd; > - goto err_name; > + goto err_fd; > } > > file = alloc_file(name, flags); > if (IS_ERR(file)) { > error = PTR_ERR(file); > - goto err_fd; > + goto err_file; > } > > fd_install(fd, file); > kfree(name); > return fd; > > -err_fd: > +err_file: > put_unused_fd(fd); > -err_name: > +err_fd: > kfree(name); > return error; > } Not really, but I see what you mean. "err_name" means "there was an error, so free the name". "err_fd" means "there was a problem with the fd". We tend to use the former convention. See grep err_free mm/*.c The memfd_create() code would be better if it used "err_free_name" and "err_free_fd" to remove this ambiguity. Someone who was feeling bored could go through grep "goto err_" mm/*.c and check that we use this convention uniformly ;)