From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E672C61DB2 for ; Mon, 9 Jun 2025 20:13:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 089B06B0092; Mon, 9 Jun 2025 16:13:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 060C96B0093; Mon, 9 Jun 2025 16:13:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE0816B0095; Mon, 9 Jun 2025 16:13:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D06A26B0092 for ; Mon, 9 Jun 2025 16:13:34 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7651814016B for ; Mon, 9 Jun 2025 20:13:34 +0000 (UTC) X-FDA: 83536962348.04.89931D0 Received: from relay.hostedemail.com (unirelay09 [10.200.18.72]) by imf17.hostedemail.com (Postfix) with ESMTP id B1CA14000C for ; Mon, 9 Jun 2025 20:13:32 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749500012; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RqIZmdiiB8Hn3MfP3Gtw/g5EdQJ1Nzyo770v35n67CI=; b=uTperEOSK0+LqGSCv7Egm5fLlYWZ+BpOKC5f4ZxdAD/lgla123m1tqRlgv5c3HbbCZKhul JSAU7TRKhHlCzSaRa9Rx+UI1B94QQa9fifracQfGS77th57Rfl8junmQagEYLx3WpkYiun DSboivtMJeBAMkHXyX7/IosynW5ce1o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749500012; a=rsa-sha256; cv=none; b=e4Tc6ftSz+ODo8H7ktzUGGwVxzbTV1Zi89AX8FvRY9C8ooXJQy3Mm8YA5k6lXb0NC7tVxf gvnvf04ZFWccQjwBvVclH0+rOcehCzq5GYJTh3NCrBgfKjInB33EYXuSWSnM6d+b4rmO0h LZiu0L4yfh+xZzoYVUBYikTlhT3QHSE= ARC-Authentication-Results: i=1; imf17.hostedemail.com; none Received: from omf19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0BB678022B; Mon, 9 Jun 2025 20:13:29 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: rostedt@goodmis.org) by omf19.hostedemail.com (Postfix) with ESMTPA id D6C1C20026; Mon, 9 Jun 2025 20:13:25 +0000 (UTC) Date: Mon, 9 Jun 2025 16:14:54 -0400 From: Steven Rostedt To: Matthew Wilcox Cc: Shivank Garg , mhiramat@kernel.org, oleg@redhat.com, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, kan.liang@linux.intel.com, david@redhat.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC] mm: use folio_expected_ref_count() helper for reference counting Message-ID: <20250609161454.27122eb4@gandalf.local.home> In-Reply-To: References: <20250609170806.447302-2-shivankg@amd.com> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX1/kJ8UB1vD94YuNV8XjvktY0cPUQseZ4mw= X-HE-Meta: U2FsdGVkX1/AbnxVbfcKCr7R6XcbF+NIATcgnSZMqeSoBZ8tgnjmm580xehAFo1U66DT7y1URDoJxSnyr8Qlf62mu6jBBImbCRwlr0MNscNf+Hj6CqxRMCN0GzwKttDu7pUlJJbLA7ZxWr+cix70+sg0E5OZQJ5ldrwLMducYMV4wYZ/lGCG/7ww17qqnxgB4h/HvU0WIAkKxsxnTNG67UynRvV8XJt3cdsNFB29lBpkqzdJZVLvHa5/TnK8N88Tz4XMIdnomHicXdG6pAwLWz+HMQxBuMC+jjpalt6eZjcc5orXSNT50Xy9/wLZZKKvq952wSzt65Y1rRZVwFxNoUAVyCsr7b5IMh8SsfcpbKIjAwUHwmNlXPhlMNO7hQ+c X-HE-Tag-Orig: 1749500005-938963 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B1CA14000C X-Stat-Signature: 7q8qiqkgba8zmq5gz9o7te7sybn8pt11 X-Rspam-User: X-HE-Tag: 1749500012-295921 X-HE-Meta: U2FsdGVkX1/JJ7hXSjqK/jB8ZfU5UXBuutq+8QSxO1siHrai7oEh+tTSGOBmxwTs/P5i8Z5VIMVRIssvphJQLh8lV6EDLM+T0jm/i8EaCbJ+DEwQ+Egh8NjSvibzbHBu3hebnDlcGF+xEf0CjMTiWTNJDUXyhWPbKjVLxtJWdtV2iD129kkGE16zkLSm+u3xEN8wQrqf8AZUjMohmOFepjKiQLNbjbiTFGb4z+DvzCuEShxVWvFAalOVjAB0kTsWKyLQnVCJC8WiFmAABg/8r8koO0rilzYCVSt6f5nBmYjwDN6BhKgJdSUSG9GOdbz8++c/It5wNzsU8jB45VbnVIA7UI+DDmhMiuqE0amCUFT/9r/i5bahbN7aU4Yqqxp9HhEdCheNOeN2frl0lgFF1d+m+WBN59XbizUboJGrsFDJw0zRFv/f5S+3k/FhbEYnbHD5dimXy4h2ZEJxxFdmqLpoiKI48SQllkUFBjClHp0iBiAhE1F8aYeWBQ24oWnywmgujuD6xj8KJEYE/MNrHv53j3dtArIivtfiFvDdFLTSuQnkeDrzMhWCQ1MYUPFp8JzNGovsPlVxSn0p1hhlqBDQyOOvRgQX0yOCFqTjyFatwcAm4z9HtF7Oar0u1ei1ZhPncFT/bWPYKFH8NGXAkpaNXocej+AmtFkIiUIz+Ce3OwSt1dMr7fG66ZiKRKngEUtC3z0m830opbP4cl+a3dE3soLfEdg7l+JwBdHCuFz1FbJDGTU4Uzno3nwKOaM7vymaoelZlya3Dwe21veBl28aw0xGC77KP7sGL62y5ewV5UDdV5GgrpQ+vtmfPHcESaJXRGgUsgqeDmIFpgbZsxuWKBPuDM03LrAZf8TbWS9qQtBPNekLVQj8lomXytW5yZEdAzM8wFPouAcey7reuUb6wEDSRb1lLXjN1SOGB93v9wSQ3LXobtLk6t3sPfzpEVDY9FmJH6N+khSIhDJ QgNcjE2u 6ZO9gqTy6e2LqzeivOyDI8aeqdeygC6rmhX1Hkl2935+US9c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 9 Jun 2025 20:51:00 +0100 Matthew Wilcox wrote: > On Mon, Jun 09, 2025 at 03:31:40PM -0400, Steven Rostedt wrote: > > > > > > On June 9, 2025 3:21:20 PM EDT, Matthew Wilcox wrote: > > >On Mon, Jun 09, 2025 at 05:08:07PM +0000, Shivank Garg wrote: > > >> Replace open-coded folio reference count calculations with the > > >> folio_expected_ref_count() helper to improve code maintainability > > >> and reduce duplication. > > > > > >If it needs this much additional commentary, perhaps it's not actually > > >clearer? > > > > I don't know. I tend to over explain as I rather make it totally > > obvious what is happening. I wouldn't say excessive commentary is > > necessarily a sign that it's not clearer. > > That was a Socratic question, not for you to answer. > > My opinion is that the extra commentary is obfuscatory and should be > removed. Ah, sorry, your response wasn't clear ;-) -- Steve