From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87415C61CE8 for ; Mon, 9 Jun 2025 19:34:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1ED6A6B0092; Mon, 9 Jun 2025 15:34:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 177696B0093; Mon, 9 Jun 2025 15:34:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 08DB16B0095; Mon, 9 Jun 2025 15:34:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DE4126B0092 for ; Mon, 9 Jun 2025 15:34:43 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7DB76160E17 for ; Mon, 9 Jun 2025 19:34:43 +0000 (UTC) X-FDA: 83536864446.17.334CB1C Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf19.hostedemail.com (Postfix) with ESMTP id C6DC91A0012 for ; Mon, 9 Jun 2025 19:34:41 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=NbrOqFX7; dmarc=none; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749497681; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hXHmaqserqQOzbvSsPg0RhmQ1kFi1RJeIwWTkWvoGP8=; b=o28aP4U5tStDDeTGkQDJ2xW0k6deVFvwqobRDEYjdhfqk8f8HrAAzQF/dNyhYcvEvQp8/X QyJlN8sTve1S9xYyTSC9NuPWqqca6nvgcXmHnx+LSR5wfCjDEs70Y81FNw3BlQtEADvoKL /3cGHtMVHcIev2Tq40B4G67u2s+Gwlw= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=NbrOqFX7; dmarc=none; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749497681; a=rsa-sha256; cv=none; b=e87Yyiec2y7tGBCrmE8rU0HPyXWNSiSpqkIQwaAhiqUmBX9HDf3MT7VrElgnU5I9XkpEfX VlKCvr2k+b4me+mrfEEQsnmndnmv4mDN19UwihyMpAZahlhSm9wfxhGWuNdSp9elZHHbkR dGjBdLrlBsNaYJPyZb4qlA7AXV1LoSs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 258DCA4D43C; Mon, 9 Jun 2025 19:34:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC293C4CEEB; Mon, 9 Jun 2025 19:34:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1749497680; bh=7UEVas++1sRIKJKDcqkdmIDpKIk/ySHCqO02kWbW8J8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NbrOqFX7sl+4WetUlJRyMPljlhwwEmvaZD7DNE+TXbBnyu7/yedJjn+vyFsK6nQGw 1BNFe3rdMuuIG5wn8zNX0pe7gKd7d7uSSWs1KmoSr9gkOuQ5/mNLPKFVv1dLRLjH7/ /2ez8/eZxaC5kKlj9cV0LttvAYVzwKHDIYMFMkbc= Date: Mon, 9 Jun 2025 12:34:40 -0700 From: Andrew Morton To: Linus Walleij Cc: Linux Memory Management List , Pasha Tatashin , Mateusz Guzik Subject: Re: Weird commit 8e02b1b7fcffcde7cc7d7749513ac1b0fbbfcf0a Message-Id: <20250609123440.c47297c078c9f8ea8f3ff0b0@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C6DC91A0012 X-Stat-Signature: fgyf5oph46x8rz7qtb653hdyxotxskdb X-Rspam-User: X-HE-Tag: 1749497681-951221 X-HE-Meta: U2FsdGVkX18MwW5zxGhSE6PVI6kWtUgLeEqjy4LfMIJgVBE2F0XsFC27HTjHYYGgMlnniQZCP/c9acWhwof3VpfW8kOyfPK8/f7UgUDQy66m8GdPqfvHoc0rxU7IQmFepOToXMXqflgIBu2aG17jgUnXhsJjRa07f7931aOkO9sEAfRYbsDFSG27FauN+AdnaymJuoyPAasEjdFZlCF82QrGUQtlTksYiQmKnRWZ192bmd+xOk6qcxiyAKPvZqBsw8xtdQECViBy9E5ZQeTmZSLkMWuuEHDSAwFcYjUeOTucsAgPqMNpKM3Uhm4zBMUh6U2zTzElGpfpaX0H9nL54oF0Aru0Pl0+b6monoFt/WCITewR+S3AxtPTQ4USRvEOmZRYZvnsdx1kknX8feWIgNwijZ2hdmOHIV1z+T+USIgAQmQLRbPEuL20WvLd2dRLRChyzbQuLZL++bqQORs1Hr1reeIp69xjoEYRPeNX9Nv+/ZC7OyX/eBSAACYZ95q1Lv0p/89OhU2jXv3oLQrenzImtdaUdZh9JJ1K7TGsnTIv7ews7m74Fwad+MrsBucLQBHFC/yd8x8nuEf0BO0OMEscjwy3mtxPoge/itYrRfzezkLhkAhfzKXql9qstidWiFxAlV/PsLPf9ez0sdQKdYYEI+K89Lmt9a3nTyOijTG1IdyWszIlXXGDBpqCT5VGM8BqR9gG3+N3AH3idyi11EnH7irqshBi7NzmyRiaNUXX1Pieb93Otj2V5vEBMXLf+9y2mw0bKxXno1DHHmL3ATHYxXWBNKsFHAW0GMgGVumnISeIH9ZHHGWgC/JzFJdcpt9G7Fan4STEu95grG+KujM5D5dnIwTNnaaJOdnDWrlhZGykJIHAzM8Ci16DCRkhCTVNjQ8Menke01NlTV/ukaEZYGds9XwGhT0JAMUNx0C++49e/xKz7GoJ81I17PCNqx3lp6pC0QdQ1Ubl94n Y2Y4CN6y JlJAxOC/J82V1F1trm+AR8+mOTsdnWiDZglvEF1GceEnHOChLhpc60EiEwPXwVE5TrU71DHFpraroqhw4gn/yWbAZr1Tqep5U5imTcvprvnJkq4pKBPJ3bXQEW7sfDVb+KycA+MyAmwbJTdJvPQO965eXGz1sZJdEqjjWZ4x4DznuuILBMaWSQCAAL6Ll2W6OHlCs0KlNqgTvDElbQ/RXXj0EsWXdjdz2U98aL1HYIDI8g0y+EgBW2+gq7qRaGe2Rca8Pay0a1eHOGHFMEc7Ns25hFeBzCzg0IjVaV1n3YuEK08v+7tX03bnrzWXoGYbpQSjJ6+aYmk0fsOo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 9 Jun 2025 10:35:08 +0200 Linus Walleij wrote: > Hi Andrew, > > when rebasing my trees on v6.16-rc1 I noticed that > commit 8e02b1b7fcffcde7cc7d7749513ac1b0fbbfcf0a > looks really weird, it looks nothing like what I submitted > and does something very different, so I'm puzzled! > > My commit looked like so: > https://lore.kernel.org/all/20250509-gfp-stack-v1-1-82f6f7efc210@linaro.org/T/#u > (Also linked in the commit itself.) > > Do you have some idea what happened here? > > The current commit looks like some odd version of a > revert with some funky indentation. I think it should > probably just be reverted and the actual commit put in > place instead, but the revert may have been for a reason. Thanks for noticing this. I must have really fat-fingered that. 8e02b1b7fcffcde7cc7d7749513ac1b0fbbfcf0a is s revert of Pasha's "fork: clean-up naming of vm_stack/vm_struct variables in vmap stacks code". I'll reapply Pasha's patch and your patch. Please check the result.