linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* Weird commit 8e02b1b7fcffcde7cc7d7749513ac1b0fbbfcf0a
@ 2025-06-09  8:35 Linus Walleij
  2025-06-09 19:34 ` Andrew Morton
  0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2025-06-09  8:35 UTC (permalink / raw)
  To: Andrew Morton, Linux Memory Management List, Pasha Tatashin,
	Mateusz Guzik

Hi Andrew,

when rebasing my trees on v6.16-rc1 I noticed that
commit 8e02b1b7fcffcde7cc7d7749513ac1b0fbbfcf0a
looks really weird, it looks nothing like what I submitted
and does something very different, so I'm puzzled!

My commit looked like so:
https://lore.kernel.org/all/20250509-gfp-stack-v1-1-82f6f7efc210@linaro.org/T/#u
(Also linked in the commit itself.)

Do you have some idea what happened here?

The current commit looks like some odd version of a
revert with some funky indentation. I think it should
probably just be reverted and the actual commit put in
place instead, but the revert may have been for a reason.

Yours,
Linus Walleij


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Weird commit 8e02b1b7fcffcde7cc7d7749513ac1b0fbbfcf0a
  2025-06-09  8:35 Weird commit 8e02b1b7fcffcde7cc7d7749513ac1b0fbbfcf0a Linus Walleij
@ 2025-06-09 19:34 ` Andrew Morton
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2025-06-09 19:34 UTC (permalink / raw)
  To: Linus Walleij; +Cc: Linux Memory Management List, Pasha Tatashin, Mateusz Guzik

On Mon, 9 Jun 2025 10:35:08 +0200 Linus Walleij <linus.walleij@linaro.org> wrote:

> Hi Andrew,
> 
> when rebasing my trees on v6.16-rc1 I noticed that
> commit 8e02b1b7fcffcde7cc7d7749513ac1b0fbbfcf0a
> looks really weird, it looks nothing like what I submitted
> and does something very different, so I'm puzzled!
> 
> My commit looked like so:
> https://lore.kernel.org/all/20250509-gfp-stack-v1-1-82f6f7efc210@linaro.org/T/#u
> (Also linked in the commit itself.)
> 
> Do you have some idea what happened here?
> 
> The current commit looks like some odd version of a
> revert with some funky indentation. I think it should
> probably just be reverted and the actual commit put in
> place instead, but the revert may have been for a reason.

Thanks for noticing this.  I must have really fat-fingered that.

8e02b1b7fcffcde7cc7d7749513ac1b0fbbfcf0a is s revert of Pasha's "fork:
clean-up naming of vm_stack/vm_struct variables in vmap stacks code".

I'll reapply Pasha's patch and your patch.  Please check the result.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-06-09 19:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-09  8:35 Weird commit 8e02b1b7fcffcde7cc7d7749513ac1b0fbbfcf0a Linus Walleij
2025-06-09 19:34 ` Andrew Morton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox