From: Andrew Morton <akpm@linux-foundation.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Linux Memory Management List <linux-mm@kvack.org>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
Mateusz Guzik <mjguzik@gmail.com>
Subject: Re: Weird commit 8e02b1b7fcffcde7cc7d7749513ac1b0fbbfcf0a
Date: Mon, 9 Jun 2025 12:34:40 -0700 [thread overview]
Message-ID: <20250609123440.c47297c078c9f8ea8f3ff0b0@linux-foundation.org> (raw)
In-Reply-To: <CACRpkdaBtyFXq1KX9LTVaAhPskXC8Fr_OqDELuZkj3g0Ag3HqA@mail.gmail.com>
On Mon, 9 Jun 2025 10:35:08 +0200 Linus Walleij <linus.walleij@linaro.org> wrote:
> Hi Andrew,
>
> when rebasing my trees on v6.16-rc1 I noticed that
> commit 8e02b1b7fcffcde7cc7d7749513ac1b0fbbfcf0a
> looks really weird, it looks nothing like what I submitted
> and does something very different, so I'm puzzled!
>
> My commit looked like so:
> https://lore.kernel.org/all/20250509-gfp-stack-v1-1-82f6f7efc210@linaro.org/T/#u
> (Also linked in the commit itself.)
>
> Do you have some idea what happened here?
>
> The current commit looks like some odd version of a
> revert with some funky indentation. I think it should
> probably just be reverted and the actual commit put in
> place instead, but the revert may have been for a reason.
Thanks for noticing this. I must have really fat-fingered that.
8e02b1b7fcffcde7cc7d7749513ac1b0fbbfcf0a is s revert of Pasha's "fork:
clean-up naming of vm_stack/vm_struct variables in vmap stacks code".
I'll reapply Pasha's patch and your patch. Please check the result.
prev parent reply other threads:[~2025-06-09 19:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 8:35 Linus Walleij
2025-06-09 19:34 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250609123440.c47297c078c9f8ea8f3ff0b0@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-mm@kvack.org \
--cc=mjguzik@gmail.com \
--cc=pasha.tatashin@soleen.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox