From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0E61C5B552 for ; Mon, 9 Jun 2025 10:55:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A43F6B0092; Mon, 9 Jun 2025 06:55:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 17BDF6B0093; Mon, 9 Jun 2025 06:55:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 091B56B0095; Mon, 9 Jun 2025 06:55:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DE70D6B0092 for ; Mon, 9 Jun 2025 06:55:27 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8921F121A2A for ; Mon, 9 Jun 2025 10:55:27 +0000 (UTC) X-FDA: 83535555894.06.46EC3AA Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by imf21.hostedemail.com (Postfix) with ESMTP id 8AF0F1C0007 for ; Mon, 9 Jun 2025 10:55:25 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lB9XIjuN; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749466525; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bSuwxTMiqoGY5WRirh9YqRM6jJaaP8lp+kq+VG0f4Z4=; b=X0NJShaRrOWNlvrJbxBUZxyKt8IdgVNG161HHmwbSlXa1DzOzhtsTCQbg5mTmZ7J10L3Vr pEA5SPNPf2X6O0eKAiPMH7Cg5ii3OBDStpqQpcsDLdvMaSpAPgHlArEdF9R6tzpSVU+TRM 5a3Y7uIbnnyXvMgtO8vwuFIjJGAGrXY= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lB9XIjuN; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749466525; a=rsa-sha256; cv=none; b=Gsgf3/x5e+mG4/0Z8RrcrXT0VEFXpnmDPksOM8jL0nfGLHhyNxip5lwCpQAUQaRMazRIkr 2H2ydmt7WbsFyJ1nPQb0qn8Tj3HemTD5rhM4IwbL5rFHh7WULfyGAz7P/v35gF6uK1JWuV Kz69JKRWR7IJyn6cYKPsj/P5CLKFES0= Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-73bf5aa95e7so3060171b3a.1 for ; Mon, 09 Jun 2025 03:55:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749466524; x=1750071324; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bSuwxTMiqoGY5WRirh9YqRM6jJaaP8lp+kq+VG0f4Z4=; b=lB9XIjuNCp+ac79WFXstlu7s6y7SfzN3o1B2DO1QWk6bLVtanYAc3pq3NhgL79y1ga y+c0XmlT3Go3VHtXpjmHif33D0iVulRiDhrQAFYtjwVvfwrjSm5RCLKOPNOQh9Ph1XcZ 52QqpfmsBMO8O0i9XHsxisBY9IoKfJk8WVOEETZnt2NwIiHeXOVzwTCebPNTGPOUCWLp KLR1mm3Z6YKqc7s7508yDa0yUYcENEKqkHD6nxt2grF1p2Vr/jMtG8/u9bqNzXhOh4s4 or4r1ND2pHPH4x1DzwNfTD1QZcVfx43GEAWJAi0T+gwy0qxTyGUjBYR2VYPHkteYmwP+ Cv3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749466524; x=1750071324; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bSuwxTMiqoGY5WRirh9YqRM6jJaaP8lp+kq+VG0f4Z4=; b=Q8eA5CM5Rjzzz+xqlwuRtQxncm547BSOfNArl7rWGfF6OieL99dIfqAfvy9oPQ+zsH 8CQNAzDnN1U8aLx1Komzi1KX3W86t9rO1ng+Ot8fbDzNuLpMZr3CyxnhdbwgF9+nAhTD RMWzlju0xDyZJ+1cFqn+lyGKjWHKS9iRColXfVEmODYfk1WjhnjmDYGOvpJ/YreXYuPs i4pqebeL5aHtluYOAzSQeKA2GvFMXhVSWxIpI5W+ALt0HDmqlZyjsBPxAAiJLhPZ+w0T iLlmP1sSamDWzu8J7T+95sL+gWsLLfEb+5AT66QhCUjVUInEVDkEOLBD7L+8e31LhTA7 +GRw== X-Forwarded-Encrypted: i=1; AJvYcCW+awuXM1fydxKeUTUnApbfwg49x+WT6hxzKfPSkxRMfjrynz1yh1icEoKabTOR3v2/jKNrYLfCCA==@kvack.org X-Gm-Message-State: AOJu0YwSQsa4aVvy9HlJ6zXLAQ8tHTUfWv1dB5/12r8yGjXvO7Ukcci6 DN38hGNfRAX8IRaz6SPgB4367ZP66Bv4tok7RYKkkboSqjghIPo3wTFa X-Gm-Gg: ASbGncukzE1/+KhkCc7HLbUf0exCLUqj+wIl/JSTuikBvjwDb6tpK8PuYK30eaZOuPu hsFHoxMChBe/R3sECjLOaX1Q+XdB4KBlyeaPYy+Yrz7zbqxztoo15VEzJVdLGElXRdDnVvm6Joq zYLCFBqPQ2K6ywverJgZPt/8TLsnmGrqpHZL+3hOeUXEc4tXpGaS84uXN9jFpDLCv+FqFSXQEKW 1p8idMn4d/Z0MKkMjtemVtivokMCJuLnPG8TThSR3FFsXSV9gufG8IQrXQ1zyIDnShTvnvBycOv YSdhIJrscwGL3pA8wG1YkC+r/RmYulWP1b2bCfOjApPKaqUpSq5sSpo2MlV/b99DI9bJKqnqDVH ckbu9HoAQ X-Google-Smtp-Source: AGHT+IE3/b0kxC3ol+meK8Ae5m7aPYsZcL+giGsuo+6NptvitOm2cWGvDKXxU3iwx1jrjcTh9jBprg== X-Received: by 2002:a05:6a21:2d8f:b0:1f3:33bf:6640 with SMTP id adf61e73a8af0-21ee25554a1mr19642640637.18.1749466524305; Mon, 09 Jun 2025 03:55:24 -0700 (PDT) Received: from Barrys-MBP.hub ([118.92.145.159]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7483318cc55sm4605114b3a.88.2025.06.09.03.55.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 09 Jun 2025 03:55:23 -0700 (PDT) From: Barry Song <21cnbao@gmail.com> To: lorenzo.stoakes@oracle.com, akpm@linux-foundation.org Cc: 21cnbao@gmail.com, Liam.Howlett@oracle.com, anshuman.khandual@arm.com, david@redhat.com, dev.jain@arm.com, jannh@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lokeshgidra@google.com, osalvador@suse.de, ryan.roberts@arm.com, surenb@google.com, v-songbaohua@oppo.com, vbabka@suse.cz, zhengtangquan@oppo.com Subject: Re: [PATCH v2] mm: madvise: use walk_page_range_vma() instead of walk_page_range() Date: Mon, 9 Jun 2025 22:55:13 +1200 Message-Id: <20250609105513.10901-1-21cnbao@gmail.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 8AF0F1C0007 X-Stat-Signature: pobydbmm6ruzmftwge7m7gdnjnrq773r X-Rspam-User: X-HE-Tag: 1749466525-380419 X-HE-Meta: U2FsdGVkX1915LSRRq9a0Kv+2acseErgGfNrDks9aiFtaHVjyqyGYgZM6CCFVHU4iCyBfwsjbP7fedfx46mS/v6S+EHFXMtZANWynlZy44huG8ubCJt2uPRQQUKqX/20HFqNv0RcifN8/jCeJzNbnD1SqEzeztboO1wQGipOnD2yVarB9+1xmWHOWkc5SFJoHxjMSvqk2eZqjPLnsQ73KD0koqGEV4hwZQWMh69OOJNDFd7VLzttmfyFTdfJcsyhEBJQlWWCIDxMSi/KEkaIlen4UtZzSc33ZcMBwsmpijwSdinzflJZuk6rQTWfk0zTbAZ6cfKZPEmcHiDyx3G38+shLYewug8k7UgLO8in4v11mB1vcXWDB+pQl1LIwx9OFxl6+NgyHS1/L8B6FG9Ttt3nc7vGNSXWrfedOEIZqUoq50E8yM8VfLF+/8k5fXKh2RfekYWRtaaoJ4AIOQzHrtm5r1FaIBHiviZIJi2udwPccBLyRjesvCaM+GmuaIzVXRDXeBB8ofB1yhzXgKijjf/SQQWFEEJmb31k7jfVGg7F/nSGu6Dh7wwHIqP820d8rVM2vFJq01mrcU2uWZu0qakQ4liMZvtleplzpqkCtjuzuWUdXcrwos+X/L+FBK0OE9pwAon+l2eivzehquBu0Zft0c+f+Zgf/s4hoS+8OFglzbeIJhO8KxAvdY6Vvf48oCC8026p1jAedrJ5OTEwsbBdn95TfXYDVOLbObDSpLDvLdQFbXwtdvy4/i/3VyD3lWoiZyB6GjdiEhZal+fNmfdjSi9+tkceHC9PJ1NtD9UWZcdXst1oKZW8hcy7usseTErAJFT2vXjhHmoyiBRPQpuC1bmF+Obk4caJ4qSslh9+F+IxOe3r9NBvDtXbYKn7o6zRavVxQWfw4/xelMPx4Mdj8h+kHINS6CxGOONjddoZGxuROuBK4jcRzgq3O/PVuCQwAPBhKTDRCEtRlSL vDL7oQ9J iVwqBNBsmWAvWtFHOkLxldiDlgTSDBiUuydPt3AYyh8znmBYr84jdf1vG71kJCynJRlbwt7x36VUkFUb2rs2OPZAAUsn/c5xMZJlF43xYdes7A/9+KtHWbYhcVZwbPe96AnXNXfjpvj0Kl08PNcOp37Qsod1s8M9XomRqxtUA6XqDyqhXx75ZIWm8QeA2Wz6bL5GjGS+QpOX2W9PF2JAGVZmtPhRlf6A28Y+HfTQw8TzA9Sl8/26TPomoi0XDQE3lz0k/fVOlopFy8gLDl4vsZX4vuaLYwDn/V5ewQQOV5gk/6nI1RHpCKEo6OecfHM++HJx0A0A7Bbq35FPRvvD1NohhtgX3czvl1gUx20JySxshVhrkU4C/hgPDhfcpsAZO0hPv1wQ3Py32nvpaAax3r3P0PMofVzEIFYFcry+scfrKznvBEYcoGtfXciRsC+B8SEF5uHKA8FXJFwHOZ5k/9TPgf5WSqQ1xdE1j7K51WQmZUrHD3JZmwSNlZcSF2k8yDzvt/MN3f4x73lLHVcoC+kbX4udWLPyhoIuD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > Yeah dear god I missed this oops! > > Yeah Barry - could you revert this change for the guard region bits please? So > this is intentional as we do not want anything non-mm to have access to > install_pte. All my fault! I wrote a multi-process/thread test to issue lots of madvise   calls, but it looks like I missed INSTALL_GUARD. Thanks, Ryan & Lorenzo! Does Andrew prefer to pick up the fix below, or   would it be better to send a new version? He’s handled fixes like this in   the past—happy to resend if needed. From: Barry Song Date: Mon, 9 Jun 2025 22:42:13 +1200 Subject: [PATCH] mm: madvise: revert the walk_page_range_vma change for MADV_GUARD_INSTALL Fix the broken MADV_GUARD_INSTALL reported by Ryan. # guard-regions.c:719:split_merge:Expected madvise(ptr, 10 * page_size, MADV_GUARD_INSTALL) (-1) == 0 (0) Reported-by: Ryan Roberts Closes: https://lore.kernel.org/linux-mm/671f8164-a90b-48d7-9446-359eb9493500@arm.com/ Signed-off-by: Barry Song --- mm/madvise.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/madvise.c b/mm/madvise.c index 8382614b71d1..381eedde8f6d 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -1141,7 +1141,7 @@ static long madvise_guard_install(struct vm_area_struct *vma, unsigned long nr_pages = 0; /* Returns < 0 on error, == 0 if success, > 0 if zap needed. */ - err = walk_page_range_vma(vma, start, end, + err = walk_page_range_mm(vma->vm_mm, start, end, &guard_install_walk_ops, &nr_pages); if (err < 0) return err; -- 2.39.3 (Apple Git-146)