From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80DADC61DB2 for ; Mon, 9 Jun 2025 09:22:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DCE96B00A4; Mon, 9 Jun 2025 05:22:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 18D746B00A6; Mon, 9 Jun 2025 05:22:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05B9B6B00A4; Mon, 9 Jun 2025 05:22:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D6CC76B00A4 for ; Mon, 9 Jun 2025 05:22:35 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7DED61214CB for ; Mon, 9 Jun 2025 09:22:35 +0000 (UTC) X-FDA: 83535321870.04.0C0E60D Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf26.hostedemail.com (Postfix) with ESMTP id 363CE140012 for ; Mon, 9 Jun 2025 09:22:33 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=dphPm5Ve; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=1jkqvrzD; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=dphPm5Ve; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=1jkqvrzD; spf=pass (imf26.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749460953; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=irK4Xm+Xq2AmoeMvzYUf2UTVfjZ7E7Dj7dx6W2eeCT8=; b=BL1RdCUbKFBiS0F/3R7k115VZ9HsPbIFfUKMWi0GH7BpSzUq1No2FquwP3wbfwec4P+YP9 4EDIB6ZIJvaIWWeyXsSTlddkfZ3BfjkSk/h7vS0JF/grm6Wa6t/iN+LVTv1Yxjh+r61uds 3obBk5OwpHX8j9byye+cnyX0dXV6GTw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=dphPm5Ve; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=1jkqvrzD; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=dphPm5Ve; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=1jkqvrzD; spf=pass (imf26.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749460953; a=rsa-sha256; cv=none; b=2wXPILOoy4gd5u9MeoU9nmINXOXUADBIzZ3jZEm0hHFW/EaNyqSECAO7Cv+QGTTpvM5geU aj9z9PAKHGJUIl8tOCvTYZNUYPyqIxaNvh7Gso46Oop6T7CyWF4eiFAdVsTx2KAkKBolRS tRdoBuKCp9oQxUp2OAs+p7RbStsKHrw= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id ABB35211A8; Mon, 9 Jun 2025 09:22:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749460924; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=irK4Xm+Xq2AmoeMvzYUf2UTVfjZ7E7Dj7dx6W2eeCT8=; b=dphPm5VeHY++2TNbYBnilhg6njbfqa6FHMqbgSg1xpdwBUf7yXnjbPBMp6c1JCyoCAu0O9 kILPQjcb0x/K9PpyJbvwMpTK5zdfVLklVKyChu3IJEM8SQVWURpiAcq/7ohs0sORb7eU3o 5oJcsKQEM2TA/UltSrbO4FrFS93ibhM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749460924; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=irK4Xm+Xq2AmoeMvzYUf2UTVfjZ7E7Dj7dx6W2eeCT8=; b=1jkqvrzDvuOglOaoFZSqYiU/nILIxh8DCvyJDChiMNgacWNTS+qlI924Pc0b+4SJyEdK6V oiHduuIG6MlByoAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749460924; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=irK4Xm+Xq2AmoeMvzYUf2UTVfjZ7E7Dj7dx6W2eeCT8=; b=dphPm5VeHY++2TNbYBnilhg6njbfqa6FHMqbgSg1xpdwBUf7yXnjbPBMp6c1JCyoCAu0O9 kILPQjcb0x/K9PpyJbvwMpTK5zdfVLklVKyChu3IJEM8SQVWURpiAcq/7ohs0sORb7eU3o 5oJcsKQEM2TA/UltSrbO4FrFS93ibhM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749460924; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=irK4Xm+Xq2AmoeMvzYUf2UTVfjZ7E7Dj7dx6W2eeCT8=; b=1jkqvrzDvuOglOaoFZSqYiU/nILIxh8DCvyJDChiMNgacWNTS+qlI924Pc0b+4SJyEdK6V oiHduuIG6MlByoAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 15E26137FE; Mon, 9 Jun 2025 09:22:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id +OW6ArynRmjJGAAAD6G6ig (envelope-from ); Mon, 09 Jun 2025 09:22:04 +0000 From: Oscar Salvador To: Andrew Morton Cc: David Hildenbrand , Vlastimil Babka , Jonathan Cameron , Harry Yoo , Rakie Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Joshua Hahn , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oscar Salvador Subject: [PATCH v6 06/10] drivers,cxl: Use node-notifier instead of memory-notifier Date: Mon, 9 Jun 2025 11:21:43 +0200 Message-ID: <20250609092149.312114-7-osalvador@suse.de> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250609092149.312114-1-osalvador@suse.de> References: <20250609092149.312114-1-osalvador@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspam-User: X-Stat-Signature: skewdfi57ihugr8g8tqssix7guuopr8x X-Rspamd-Queue-Id: 363CE140012 X-Rspamd-Server: rspam11 X-HE-Tag: 1749460952-441473 X-HE-Meta: U2FsdGVkX18kAZ9akAi3soDNEcdvgYnQS5wYOMoSgJaOTn9DuovJ9gQkKKY/vJ/Fe792pT6Ceand+/fjKCFO2zgiBcAgvqfGTX7Q9FTiN5kfEhwQi3BQHYQNYTANxU3yuZ08bJBGKZZ1b2RjUMcDq0FE66EczF0o34X4ud5JxwupkFKBfzJRzAU69+SjTvJUUcskN4nMoe2JmMak6a7MQ0Gx4+kukPygcmjX/zNlgGFuuP2+bTZHhRj95UbbLqrzpHvcyjPauCgmkPCoZxIK/mXzFnz3GXAEKS4ou92SZO99B0PJ1bK/h2yOSK+gmxNXUkCmFAkjoQNyjA0u1DGiiWRwTsEhrvQ5DSMoTcw/O0A1UEv5qj2puirJMYUbnn9IOxESO1XGKRv+2UQRMezgzNAcHav8DY2+UWuZCKWq3LuItNfB/uH0MmINBosMVfj+x5OmpgOl0S7svg5AE1QimkHJhWeTI8RbG4FIbH55/Xk3Z/VPeHNkZah2TfajFTFdl5+j2a8zxiOhAuDW2/2l+uDSxhiSwTDRiBEHexbaLTxA0EYYORV0SWlpo3iCPD2gDbJ2P6HrA5CPCVKMR7hdN2rwzBeY5GJ3wBf1s/0LOHzazyooYSJOsrWmAkN8R7DvLfCoWvqSQoyn9OlmaFrpvjWnptv3JXd7cVSiEasaUIm7VMfQ5JyKmdIa8/aL8CYeA55v2Zu3pk9Kcep7rubjL8E7AS1vR0xtpzbB+Eq65ZMi6xYAWo9jt21KYwruZbuWQNvg82EUdoDq/p6VOeI50cOs/FfofyhmRRoMFd4nugZ1e18zvgGL7CgAfDl+onqJUjprK3KUWYFkl5ORQj6m9iSktioPrNkLJJUlPBi8+P3nZY9hB83OnzSusnyapwLsDNDK+SKDdOjnW8claInkhXHHNYs6n8X028Fv+Ldw192QnuMQTyAsoPYtn0/+sdq4k6f6lY4zVP9RHLoMuFV S4wdVAPu mEAyWOmHG9n+Es1HlpyUjk67umhPpQk9hfxzbqWoK/+zBtWpplXR4mEG4AhOLpyNT/jq3lJijwgQodIS6PaYcTNQrX4/v9l5xzjnuoafp6zJrdzcTa8ab0wO4s4klTA7uFMF1bDtjBawGX9TDh04WSg3KmmfeCr/UlvI7V3atbfVnt8dVFupw3XOvjx26rDdOd7qTuwUMVskIFdUd+Utb8sBEaa60BPW51kYEq19hEcslbs+6wlgFAP70Yht5jXTi4XNscMf3762OWgCN6+nKPu6mGGF9dA8WZprxmPOijxjzniScnNBLWY/2yPQYwTSJfyKYlrLwzvoTxSC6zOAl338acPhpZhm+LYcYBtAEYfahB54Hy65IEYL/0Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: memory-tier is only concerned when a numa node changes its memory state, specifically when a numa node with memory comes into play for the first time, because it needs to get its performance attributes to build a proper demotion chain. So stop using the memory notifier and use the new numa node notifer instead. Signed-off-by: Oscar Salvador Reviewed-by: Jonathan Cameron Reviewed-by: Harry Yoo Reviewed-by: Vlastimil Babka --- drivers/cxl/core/region.c | 16 ++++++++-------- drivers/cxl/cxl.h | 4 ++-- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c index c3f4dc244df7..261e07302ca4 100644 --- a/drivers/cxl/core/region.c +++ b/drivers/cxl/core/region.c @@ -2432,12 +2432,12 @@ static int cxl_region_perf_attrs_callback(struct notifier_block *nb, unsigned long action, void *arg) { struct cxl_region *cxlr = container_of(nb, struct cxl_region, - memory_notifier); - struct memory_notify *mnb = arg; - int nid = mnb->status_change_nid; + node_notifier); + struct node_notify *nn = arg; + int nid = nn->nid; int region_nid; - if (nid == NUMA_NO_NODE || action != MEM_ONLINE) + if (action != NODE_ADDED_FIRST_MEMORY) return NOTIFY_DONE; /* @@ -3484,7 +3484,7 @@ static void shutdown_notifiers(void *_cxlr) { struct cxl_region *cxlr = _cxlr; - unregister_memory_notifier(&cxlr->memory_notifier); + unregister_node_notifier(&cxlr->node_notifier); unregister_mt_adistance_algorithm(&cxlr->adist_notifier); } @@ -3523,9 +3523,9 @@ static int cxl_region_probe(struct device *dev) if (rc) return rc; - cxlr->memory_notifier.notifier_call = cxl_region_perf_attrs_callback; - cxlr->memory_notifier.priority = CXL_CALLBACK_PRI; - register_memory_notifier(&cxlr->memory_notifier); + cxlr->node_notifier.notifier_call = cxl_region_perf_attrs_callback; + cxlr->node_notifier.priority = CXL_CALLBACK_PRI; + register_node_notifier(&cxlr->node_notifier); cxlr->adist_notifier.notifier_call = cxl_region_calculate_adistance; cxlr->adist_notifier.priority = 100; diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h index a9ab46eb0610..48ac02dee881 100644 --- a/drivers/cxl/cxl.h +++ b/drivers/cxl/cxl.h @@ -513,7 +513,7 @@ enum cxl_partition_mode { * @flags: Region state flags * @params: active + config params for the region * @coord: QoS access coordinates for the region - * @memory_notifier: notifier for setting the access coordinates to node + * @node_notifier: notifier for setting the access coordinates to node * @adist_notifier: notifier for calculating the abstract distance of node */ struct cxl_region { @@ -526,7 +526,7 @@ struct cxl_region { unsigned long flags; struct cxl_region_params params; struct access_coordinate coord[ACCESS_COORDINATE_MAX]; - struct notifier_block memory_notifier; + struct notifier_block node_notifier; struct notifier_block adist_notifier; }; -- 2.49.0